| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14610 (in support of unbreaking auto-update)
TEST=The .app's Contents/Resources folder should not contain the resources that
are moving to the .framework's Resources folder;
The .app's Contents/Resources folder should still contain app.icns,
document.icns, the helper .app, and a whole slew of .lprojs that only
contain InfoPlist.strings;
Make sure Breakpad still works in the browser, renderer, and other process
types.
Review URL: http://codereview.chromium.org/256062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shown in the background window.
BUG=23967
TEST=Open two windows with at least two tabs. Open one more window and go to
the NTP. Close the first two windows. Now click on the first link in the
Recently closed section. This reopens a window. Now move the mouse so you can
see the NTP again. There should be no tooltip for the Recently closed item
Review URL: http://codereview.chromium.org/263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dropped in the content area to load.
BUG=23517
TEST=dragging files, bookmarks, folders, text, etc to content area should behave correctly.
Review URL: http://codereview.chromium.org/267006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't get killed.
BUG=http://crbug.com/23919
TEST=The following command lines will now work and give no errors on 10.6:
python webkit/tools/layout_tests/layout_package/http_server.py --server start
python webkit/tools/layout_tests/layout_package/http_server.py --server stop
Review URL: http://codereview.chromium.org/257059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24000
Review URL: http://codereview.chromium.org/255101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hclam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUGS=none
TEST=unit tests continue to work.
Review URL: http://codereview.chromium.org/257063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Chrome.
TEST=Verify that Chrome Frame builds use the client name 'googlechromeframe' when talking to the safe browsing service.
Review URL: http://codereview.chromium.org/246090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused local variables.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23696
TBR=rafaelw
Review URL: http://codereview.chromium.org/270004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Put icons the "name" cell of KeywordEditor.
* Have KeywordEditorCocoaController be the observer of the table model, so that
it is properly notified of all model changes (esp. icons).
TEST=Open search engine editor, see icons.
Review URL: http://codereview.chromium.org/242020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24102
TEST=none
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/267005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23768,23961
TEST=DevToolsSanityTest.TestProfilerTab
Review URL: http://codereview.chromium.org/266005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open page with scrollbar, open and focus find bar. Hit fn-right, it should scroll to the end of the page. Hit fn-left, it should scroll back up.
Review URL: http://codereview.chromium.org/246084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/265008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
properties.BUG=23647
Review URL: http://codereview.chromium.org/262005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change contails the layout test expectation changes from http://codereview.chromium.org/248001 and http://codereview.chromium.org/251071 as the V8 update requires these.
This change also contains a change to compile against the changes IdleNotification API in the new V8 version.
BUG=none
TEST=none
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a toolbar instead of tabs.
- Make the window change size based on the content.
- Center the views to the widest of the subviews.
TEST=prefs window and all of the controls in it work.
BUG=20538
Review URL: http://codereview.chromium.org/242162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green linux layout bots
Review URL: http://codereview.chromium.org/269001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=23996
Review URL: http://codereview.chromium.org/242164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=17255
Review URL: http://codereview.chromium.org/266003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled newly added test for object cloning.
TEST=try servers
BUG=24063
Review URL: http://codereview.chromium.org/263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/251109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean to express the action.
R=ajwong
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/251103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/243115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
original issue: http://codereview.chromium.org/207062/
TBR=sky
Review URL: http://codereview.chromium.org/270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
me know. Here's the warning I was getting without this:
dereferencing type-punned pointer will break strict-aliasing rules
BUG=none
TEST=none
TBR=derat
Review URL: http://codereview.chromium.org/261005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make InfoBubble's constructor take positions relative to the browser
window's origin, rather than the absolute positions used by Views.
Otherwise, we run into issues when the browser window is being moved while
the bubble is created -- this is unlikely to happen for bookmark bubbles,
but when the first run bubble is created, the browser window may or may not
be in the final place that the window manager is going to put it. There
was previously a 200 ms delay before opening the bubble, but that approach
still fails sometimes when X is being forwarded over a network connection.
This change makes us update the bubble's position as we receive
ConfigureNotify events about its browser window.
TEST=checked that first-run and bookmark bubbles are placed correctly in openbox, KDE, metacity, fluxbox, and ion3
Review URL: http://codereview.chromium.org/256068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this many files).
BUG=none
TEST=none
TBR=pkasting
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=try servers
BUG=none
TBR=johnnyg
Review URL: http://codereview.chromium.org/266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.
Additionally, support is added for packaging extensions via ---pack-extension on linux and mac
Review URL: http://codereview.chromium.org/207062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
avoid the focus problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the crash the BookmarkModel is trying to notifying observers it's
going away and one of those observers has been deleted. This is during
first run import, so the only observer should be the importer.
This may be possible if someone prematurely exits the nested loop
started during first run so that the importerhost isn't done when the
profile is deleted.
BUG=16143
TEST=none
Review URL: http://codereview.chromium.org/242119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=22608
Review URL: http://codereview.chromium.org/262003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can shut down gracefully when many posix-based system halt or reboot while Chrome is open.
SIGTERM may come in on any thread, so the handler creates a Task object that wraps up a call to BrowserList::CloseAllBrowsers(true) and Posts it to the message loop of the UI thread. Thus, we both get out of the signal handler quickly and can deal with the signal on any thread.
BUG=23551
TEST=covered by BrowserTest.PosixSessionEnd
Review URL: http://codereview.chromium.org/255036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FilePath::StringType on linux is a std::string, while on Windows it is a
std::wstring. The old implementation assumed wstrings. Rework the class
to deal entirely with narrow strings (since wide-strings are not relevant
for this utility).
Note: This file is only used in some tools.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798,13907
TBR=jparent
Review URL: http://codereview.chromium.org/263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22922
TEST=Go to https://twitter.com, click the lock icon, see page info window.
Review URL: http://codereview.chromium.org/222020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also test_types/text_diff.py attempts to be smarter than the user by checking to see if the text results are a render tree output and, if not, writing them into the generic directories rather than the specified directory. Except, that code looks broken, too. I think it's probably best to just do what the user told it to do, so I've removed that path.
Thanks to senorblanco for finding the bug.
R=ojan@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/255068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so we can do basic UTF8/16/32 conversions without linking all of ICU.
Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using
these new functions. I will remove the Sys versions of these functions in a
later patch.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wasn't aware of it in my initial change that made us use
override-redirect windows for InfoBubbleGtk, but clicking on
the bookmark bubble's folder combobox steals InfoBubbleGtk's
pointer and keyboard grabs, resulting in the other widgets
in the window behaving as if they're inactive after the
combobox's popup is closed. This somewhat hacky change
makes us reinstall the bubble's grabs after the popup closes.
TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally
Review URL: http://codereview.chromium.org/260019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm still seeing some defunct processes, but not one for every tab, and they don't appear to be former renderer processes, so that's probably a separate bug.
BUG=23778
TEST=after closing a tab ps shows that the renderer is gone (not just defunct)
Review URL: http://codereview.chromium.org/242155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22608
Review URL: http://codereview.chromium.org/256084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well.
I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907
BUG=22836
TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes.
Review URL: http://codereview.chromium.org/255086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show.
BUG=23902
TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar.
Review URL: http://codereview.chromium.org/258038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object goes out of scope.
The control flow was as follows:
1. user initiates a save page command
2. user initiates a second save page command
3. tab contents creates a SavePackage, shows dialog
4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl
5. At this point two dialogs are visible.
6. User dismisses second dialog.
7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl.
8. Bad stuff.
BUG=23817
TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared.
Review URL: http://codereview.chromium.org/243117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/257074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28212 0039d316-1c4b-4281-b951-d872f2087c98
|