summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Updated layout test expectations for new failures.thestig@chromium.org2009-09-291-1/+3
| | | | | | | | BUG=21841,23306 TEST=none Review URL: http://codereview.chromium.org/245038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27455 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add valgrind suppression for bug 16584.thestig@chromium.org2009-09-291-0/+16
| | | | | | | | BUG=16584 TEST=none Review URL: http://codereview.chromium.org/251021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27454 0039d316-1c4b-4281-b951-d872f2087c98
* Change again the way we do ResolveNTFunctionPtrcpu@chromium.org2009-09-291-3/+7
| | | | | | | | | | | | - This version is different from last two TEST=chrome should start and you can browse BUG=11789 Review URL: http://codereview.chromium.org/246026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27453 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to r402 to pick up Coverity fix.mattm@chromium.org2009-09-291-1/+1
| | | | | | | | | | CID=82 BUG=none TEST=none Review URL: http://codereview.chromium.org/254010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized memory error reported by valgrind.suzhe@chromium.org2009-09-291-2/+11
| | | | | | | | | | | In order to make valgrind happy, this CL changes WebKeyboardEvent::isSystemKey and WebMouseWheelEvent::scrollByPage to int type to make sure the size of WebKeyboardEvent and WebMouseWheelEvent align to a factor of 4 bytes strictly. BUG=22857: Uninitialized memory sent via IPC from RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() TEST=Run chrome with valgrind and input something or scroll the mouse wheel in a web page, valgrind should not complain uninitialized memory anymore. Review URL: http://codereview.chromium.org/235038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27451 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check result of file_util::CopyFile.mattm@chromium.org2009-09-291-1/+1
| | | | | | | | | | CID=5099 BUG=none TEST=none Review URL: http://codereview.chromium.org/251023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27450 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPreferredTrySlaves() to presubmit scripts.thestig@chromium.org2009-09-293-0/+30
| | | | | | | | BUG=23071 TEST=none Review URL: http://codereview.chromium.org/251024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27449 0039d316-1c4b-4281-b951-d872f2087c98
* Update signatures for a few known crashes.huanr@chromium.org2009-09-291-3/+3
| | | | | | Review URL: http://codereview.chromium.org/249029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27448 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix for skinning translation bug.gman@google.com2009-09-293-10/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | We weren't binding the transform of the skin to the base so the transform was getting applied twice and also the math was wrong in skinning. This is the shortest change to make this work but it is arguably not the *correct* change. The correct change would be to make the import code create Skin separate from ParamArray and SkinEval so that you can use the same Skin data multiple times in the same scene. I don't know enough about collada to know if that's possible to setup in collada but the way the code is structured currently it seems to assume it is even though the code does support this correctly. That would take some work to fix and require samples and it seems unlikely people will run into that issue so this smaller fix seems good enough for now. Review URL: http://codereview.chromium.org/235046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test failues on linux/mac buildhclam@chromium.org2009-09-291-1/+1
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/235048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27446 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-2929-42/+516
| | | | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-2965-201/+265
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing some things that are failing in the linux o3d gyp build.bradnelson@google.com2009-09-292-1/+10
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/209025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27442 0039d316-1c4b-4281-b951-d872f2087c98
* The builders should build sync_unit_tests.nick@chromium.org2009-09-291-0/+1
| | | | | | Review URL: http://codereview.chromium.org/235044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27441 0039d316-1c4b-4281-b951-d872f2087c98
* Use the current frame's URL when initializing the extension framework for a ↵mpcomplete@chromium.org2009-09-291-5/+4
| | | | | | | | | | | | | frame. Previously we were using the toplevel frame's URL. BUG=22658 TEST=no Review URL: http://codereview.chromium.org/249026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27440 0039d316-1c4b-4281-b951-d872f2087c98
* Only write the image when writeImage is called. We don't write thetony@chromium.org2009-09-291-5/+2
| | | | | | | | | | | | | | | | other formats because when pasting, we want to make sure the image has priority. This method appears to only be called from the image context menu and when viewing an image only in a tab and using copy (ctrl+c or from the page menu). In both of these cases, if the user wants the URL, they can use the context menu "copy image url" to get the URL. BUG=21593 Review URL: http://codereview.chromium.org/254006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27439 0039d316-1c4b-4281-b951-d872f2087c98
* Directly add ExtensionShelfGtk to the widget hierarchy.tony@chromium.org2009-09-293-8/+6
| | | | | | | | | | | Just code cleanup. There's some more of this for the ExtensionShelfGtk::Toolstrip (adding removing the widgets from the hbox), but I kept that since the abstraction seems kind of useful. Review URL: http://codereview.chromium.org/242044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27438 0039d316-1c4b-4281-b951-d872f2087c98
* Enable a bunch of media layout testshclam@chromium.org2009-09-2954-429/+602
| | | | | | | | | | | | BUG=16779 TEST=layout tests After a long rewriting of media layout tests, we are able to enable them again. This change will leave us abotu 19 (out of 98) real failures. Review URL: http://codereview.chromium.org/249007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27437 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Cocoa does not like it when the close button is 15x15. Resize to ↵rohitrao@chromium.org2009-09-283-11/+11
| | | | | | | | | | 16x16 to prevent weird drawing artifacts. This CL does not actually modify the size of the close buttons in the app. BUG=http://crbug.com/22188 TEST=See test in bug. Verify for tabs, the infobar, and the download shelf. Review URL: http://codereview.chromium.org/243030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27436 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored event handler method bodies from widget_win.h tokbr@google.com2009-09-282-99/+203
| | | | | | | | | | | | widget_win.cc. This significantly reduces build times when modifying the code of these event handlers during debugging. BUG=http://code.google.com/p/chromium/issues/detail?id=23274 TEST=none Review URL: http://codereview.chromium.org/254003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27435 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r27137. Create renderers for ExtensionHosts one at a time to avoid ↵mpcomplete@chromium.org2009-09-288-14/+103
| | | | | | | | | | | | | | | blocking the UI. I added a process.Close() to the fast shutdown path for renderers. The problem was that we were trying to use an old terminated process handle. BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/243007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27434 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we leaked the decompressor state.mbelshe@google.com2009-09-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/243031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27433 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused pthread helpers. Looks like we don't use pthread_rw locks at all.chron@chromium.org2009-09-281-127/+0
| | | | | | | | | | This CL does not complete 19391, only removes the pthread dep. BUG=19391 Review URL: http://codereview.chromium.org/231005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27432 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing signed/unsigned mismatch warning showing up in gyp build.bradnelson@google.com2009-09-281-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=gman Review URL: http://codereview.chromium.org/248026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27431 0039d316-1c4b-4281-b951-d872f2087c98
* Diabolic hackery to work around differing NPAPI headers and definitions ↵apatrick@google.com2009-09-2815-23/+60
| | | | | | | | | | | between Chromium and O3D. TEST=none BUG=none Review URL: http://codereview.chromium.org/242042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27430 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.5 to 219.6laforge@chromium.org2009-09-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27429 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory_test to use the correct temporary user_data_dir_, so itsgk@chromium.org2009-09-281-6/+11
| | | | | | | | | | | reports valid memory stats for browser and {ws,vm}_final_{browser,total}. Add a sanitary assert for returned browser process id so the test will actually fail if it breaks again. BUG=none TEST=none Review URL: http://codereview.chromium.org/245030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27428 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale reference to ie_alt_tab. This went in by mistake.ananta@chromium.org2009-09-281-1/+1
| | | | | | | | TBR=slightlyoff Review URL: http://codereview.chromium.org/245031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27427 0039d316-1c4b-4281-b951-d872f2087c98
* sync i18n support for gaia_login.html and merge_and_sync.htmlMove resources ↵tim@chromium.org2009-09-286-89/+169
| | | | | | | | | | | | | in generated_resources.grd.Move the google logo depending of the order of words in the translation of "Google Account"Add support for rtl locales BUG=19896 TEST=Make sure the layout of gaia_login.html and merge_and_sync.html is correct in ltr and rtl Patch by Bruno Calvignac, http://codereview.chromium.org/195082. Review URL: http://codereview.chromium.org/244024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27426 0039d316-1c4b-4281-b951-d872f2087c98
* Fix how we calculate workarea size (_NET_WORKAREA gives width/height).tony@chromium.org2009-09-281-7/+8
| | | | | | | | | | | Fix how we calculate initial window size to be workarea - 20 for height and width. This matches Windows. BUG=23229 Review URL: http://codereview.chromium.org/254004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27425 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "+CC" to my watchlist email, and make the base watchlist only match thebrettw@chromium.org2009-09-281-5/+5
| | | | | | | | | | root base and not net/base, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/248023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27424 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable FindInPage automated ui test test.estade@chromium.org2009-09-284-12/+25
| | | | | | | | | BUG=none TEST=run it Review URL: http://codereview.chromium.org/243010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27423 0039d316-1c4b-4281-b951-d872f2087c98
* Use favicon for application shortcut icon.estade@chromium.org2009-09-287-18/+125
| | | | | | | | BUG=22528 Review URL: http://codereview.chromium.org/249023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-2845-382/+125
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side implementations of some FileSystem methods. This is needed to ↵jianli@chromium.org2009-09-285-1/+41
| | | | | | | | | | | complete the WebKit bug fix https://bugs.webkit.org/show_bug.cgi?id=29109. BUG=none TEST=none Review URL: http://codereview.chromium.org/209072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27420 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27407.senorblanco@chromium.org2009-09-281-5/+0
| | | | | | Review URL: http://codereview.chromium.org/249027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27419 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all member variables in the default constructor.jhawkins@chromium.org2009-09-281-4/+16
| | | | | | | | | CID=1423 BUG=none TEST=none Review URL: http://codereview.chromium.org/249024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dashboard history management to properly start from a blankojan@chromium.org2009-09-281-17/+14
| | | | | | | slate when converting the hash parameters to the currentState object. Review URL: http://codereview.chromium.org/242038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27417 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-2859-250/+188
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit revision 48796:48820levin@chromium.org2009-09-282-1/+7
| | | | | | | | | | | | Add some layout tests for me to investigate (likely just a rebaseline). BUG=None TEST=None TBR=senorblanco@chromium.org Review URL: http://codereview.chromium.org/251018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27415 0039d316-1c4b-4281-b951-d872f2087c98
* Add section about the Ruby script to the packaging page.kathyw@google.com2009-09-282-6/+43
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/244025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27414 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way the NonClientView handles forcing the native frame for ↵ben@chromium.org2009-09-2811-64/+82
| | | | | | | | | | | | | popups/app windows. Rather than carrying state in a force_native_frame_ member it uses a virtual method AlwaysUseNativeFrame analogous to AlwaysUseCustomFrame. This makes me a little happier. BUG=none TEST=On a vista capable system, test that when a theme is installed, popups and app frames are rendered with the native frame. Test that constrained windows (e.g. HTTP basic auth) are rendered with the custom frame. Without a theme installed, test that all windows have a native frame except constrained windows. With Vista Basic system setting, verify that all windows have a custom frame, including constrained windows. Review URL: http://codereview.chromium.org/200146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27413 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-2859-188/+250
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize ids_found_ in the constructor.jhawkins@chromium.org2009-09-281-1/+1
| | | | | | | | | CID=4622 BUG=none TEST=none Review URL: http://codereview.chromium.org/242040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27411 0039d316-1c4b-4281-b951-d872f2087c98
* Add some recent reliability crashes to known_crashes.txt.senorblanco@chromium.org2009-09-281-7/+16
| | | | | | | | | BUG=23278,23280,23281 TEST=Reliability bot a shade greener TBR=thestig Review URL: http://codereview.chromium.org/244026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27410 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove two unused member variables.jhawkins@chromium.org2009-09-281-3/+0
| | | | | | | | | CID=6087 BUG=none TEST=none Review URL: http://codereview.chromium.org/242039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27409 0039d316-1c4b-4281-b951-d872f2087c98
* We need to return S_FALSE in our IHttpSecurity::OnSecurityProblem ↵ananta@chromium.org2009-09-281-12/+20
| | | | | | | | | | | | | | | | | implementation for certificate errors to be displayed in IE6. This is because on IE6 the default IBindStatusCallback implementation in MSHTML implements the IWindowForBindingUI interface only thus resulting in the error dialog being displayed. We emulate this by returning S_FALSE in OnSecurityProblem for IE6. This should fix the IE6 issue reported in bug http://b/issue?id=2059540 Bug=2059540 Review URL: http://codereview.chromium.org/220041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27408 0039d316-1c4b-4281-b951-d872f2087c98
* If IE was navigated away to a different page when the ChromeFrame inspector ↵ananta@chromium.org2009-09-281-0/+5
| | | | | | | | | | | | | | | | | window was open it would crash the browser. The fix is to ensure that the inspector window is closed when the ExternalTabContainer window is uninitialized. This fixes bug http://code.google.com/p/chromium/issues/detail?id=22993 Bug=22993 Review URL: http://codereview.chromium.org/249005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27407 0039d316-1c4b-4281-b951-d872f2087c98
* Moving ContextualAction class to common/extensions and in the process ↵finnur@chromium.org2009-09-2819-134/+134
| | | | | | | | | | | | | renaming it ExtensionAction. No code change. BUG=None TEST=Page actions and browser actions should work as before (no change) Review URL: http://codereview.chromium.org/242035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27406 0039d316-1c4b-4281-b951-d872f2087c98
* Implement about:ipc dialog for Mac.jrg@chromium.org2009-09-2827-146/+3218
| | | | | | | | | Convert IPC logging trigger from x-process waitable event to a messages sent to all processes. Review URL: http://codereview.chromium.org/192070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27405 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 23:09:56 +0000