summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup:pkasting@chromium.org2011-02-0879-1276/+1125
| | | | | | | | | | | | | | | | | | | | | | * Change int to size_t in a few APIs. * Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates. * Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s. * Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly). * Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_. * De-inline a couple classes. * Make more functions private. * Add some consts. * Change DCHECK() to DCHECK_EQ() where possible. * Rename the delegates in plugin_observer.cc to have "Delegate" in the names. * Remove unnecessary qualifiers. * Simplify. * Misc. style issues, naming issues, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit from r77818 to r77879zmo@google.com2011-02-081-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=loislo Review URL: http://codereview.chromium.org/6424001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74083 0039d316-1c4b-4281-b951-d872f2087c98
* First crack at FileSystemURLRequestJob for handling filesystem: URLs.adamk@chromium.org2011-02-0820-0/+1223
| | | | | | | | Disabled behind a switch, "--enable-filesystem-url-scheme". Review URL: http://codereview.chromium.org/6262015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and enable JingleSessionTest.*. Disable these tests under TSan.sergeyu@chromium.org2011-02-087-62/+70
| | | | | | | | | BUG=70225 TEST=None Review URL: http://codereview.chromium.org/6246051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74080 0039d316-1c4b-4281-b951-d872f2087c98
* Don't update the instant results on the page due to omnibox popup changesestade@chromium.org2011-02-081-0/+4
| | | | | | | | | | | when the mouse button is down. BUG=71952 TEST=manual Review URL: http://codereview.chromium.org/6250201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74077 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix wheel scrolling for xinput2.sadrul@google.com2011-02-082-2/+22
| | | | | | | | | BUG=wheel scrolling doesn't work TEST=wheel scrolling scrolls the page when possible Review URL: http://codereview.chromium.org/6250195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74076 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile after the change to rework bounds methods.sadrul@google.com2011-02-084-4/+4
| | | | | | | | | BUG=72040 TEST=compiles with touch Review URL: http://codereview.chromium.org/6415001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74075 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move more layout constants to the views namespace.tfarina@chromium.org2011-02-0810-18/+27
| | | | | | | | | | | The other constants will be moved in future patches. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6250186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74074 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the pdf scrolling browser test to query the vertical offset instead ↵jam@chromium.org2011-02-081-1/+8
| | | | | | | | of comparing snapshots, since that can be flakey if the bot is slow. Review URL: http://codereview.chromium.org/6312203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74072 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented GPU process side flow control.apatrick@chromium.org2011-02-086-8/+75
| | | | | | | | | | | | Only one frame of GL calls are allowed to be pending presentation at a time. This reduced "jitter" for both ANGLE and GL. Also tuned client side flow control for minimal "jitter". Finally, I made the GPU scheduler prioritise command buffers directed at a window (i.e. the compositor's contexts) over those directed at offscreen targets. TEST=trybots, watch fish in WebGL Aquarium and see if they jitter with and without vsync lock enabled, scientific experiments on gman BUG=none Review URL: http://codereview.chromium.org/6250166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74071 0039d316-1c4b-4281-b951-d872f2087c98
* Add a tool to retrieve passing and failing WebKit revision numbers fromyuzo@chromium.org2011-02-081-0/+176
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | canaries. From each canary, - the last WebKit revision number for which all the tests have passed, - the last WebKit revision number for which the tests were run, and - the names of failing layout tests are retrieved and printed. This tool has proven useful to me in my WebKit gardener shift. Sample output from the tool: $ ./webkit/tools/layout_tests/canary-wk-revisions.py -h Usage: canary-wk-revisions.py [options] [builders] Options: -h, --help show this help message and exit -m MAX_BUILDS, --max_builds=MAX_BUILDS maximum number of builds to check for each builder $ ./webkit/tools/layout_tests/canary-wk-revisions.py Checking the last 10 builds for: "Webkit Win" "Webkit Mac10.5" "Webkit Linux **** Failing revisions ***** The last run was at r77559 on "Webkit Mac10.5" and the following tests faile fast/overflow/overflow-height-float-not-removed-crash.html **** Passing revisions ***** The last passing run was at r77587 on "Webkit Win" The last passing run was at r77548 on "Webkit Mac10.5" The last passing run was at r77587 on "Webkit Linux" Passing revision range: r77548 - r77587 BUG=none TEST=none Review URL: http://codereview.chromium.org/6340019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74069 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Add/update platform specific variations of settings window ↵csilv@chromium.org2011-02-081-4/+26
| | | | | | | | | | strings. BUG=64087 TEST=Verify correct banner text when display options are enabled on Mac/Win/Linux. Review URL: http://codereview.chromium.org/6334149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74068 0039d316-1c4b-4281-b951-d872f2087c98
* Fix about:gpu refreshing constantly.nduca@chromium.org2011-02-082-3/+10
| | | | | | | | | BUG=72093 TEST= Review URL: http://codereview.chromium.org/6413030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix thread-related PepperMessageFilter issuespiman@google.com2011-02-082-6/+5
| | | | | | | | | | | | | | | - Profile::GetRequestContext() needs to be called from the UI thread, i.e. from the PepperMessageFilter constructor. - MessageLoop::current() asserts on the worker thread (because accessing the LazyTls instance is invalid), so we can't actually check that we're on a worker thread. BUG=none TEST=with pepper flash Review URL: http://codereview.chromium.org/6246154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74066 0039d316-1c4b-4281-b951-d872f2087c98
* Make a DCHECK into a much more useful DCHECK_EQ in message_pump_win.cc.adamk@chromium.org2011-02-081-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6246155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74065 0039d316-1c4b-4281-b951-d872f2087c98
* Initializes TabContentsWrapper::delegate_ to NULL. Without this we getsky@chromium.org2011-02-082-1/+5
| | | | | | | | | | | crashes if the delegate isn't set (as witnessed in instant code). BUG=72219 TEST=see bug Review URL: http://codereview.chromium.org/6250205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74062 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Set default font to 13px.csilv@chromium.org2011-02-082-2/+2
| | | | | | | | BUG=54157 TEST=Verify dom-ui settings page no longer changes appearance with default font change. Review URL: http://codereview.chromium.org/6413024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74061 0039d316-1c4b-4281-b951-d872f2087c98
* More out-of-lining of test code, along with a bunch of GMOCK objects.erg@google.com2011-02-0832-216/+491
| | | | | | | | | | | Most notably, rename various mock_objects.h files in remoting/ because after deinlining, there were compile failures. This fixes Windows compiling because you can't have two implementation files with the same name in a project, even if they are in different directories. (The output from one compile will clobber the others!) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6250198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74059 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Prevent ChromeOS settings window title from being defined ↵csilv@chromium.org2011-02-081-1/+1
| | | | | | | | | | twice. BUG=none TEST=Verify that settings window is titled 'Settings' on ChromeOS. Review URL: http://codereview.chromium.org/6410131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74054 0039d316-1c4b-4281-b951-d872f2087c98
* Rework basic bounds methods on View to match new V2 API: ben@chromium.org2011-02-0892-376/+334
| | | | | | | | | | | | | | | | SetBounds(const gfx::Rect& rect) -> SetBoundsRect(); DidChangeBounds()->OnBoundsChanged() GetLocalBounds(false)->GetLocalBounds() GetLocalBounds(true)->GetContentsBounds() Moved GetBounds(), GetX(), and GetPosition into RTL section. http://crbug.com/72040 TEST=none Review URL: http://codereview.chromium.org/6410109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74052 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Remove position:fixed for navbar-container so that scrollingjhawkins@chromium.org2011-02-081-1/+0
| | | | | | | | | | | horiztonally does not push the contents of the page underneath the navbar. BUG=71689 TEST=none Review URL: http://codereview.chromium.org/6368149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74050 0039d316-1c4b-4281-b951-d872f2087c98
* Support XHR upload event notifications in Chromeframe. We don't get ↵ananta@chromium.org2011-02-082-0/+15
| | | | | | | | | | | | | | | | incremental progress notifications from IE indicating how much data was uploaded etc. We just fire one notification indicating that upload was completed when queried from Chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=70713 BUG=70713 TEST=As described in the bug Review URL: http://codereview.chromium.org/6246159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74049 0039d316-1c4b-4281-b951-d872f2087c98
* Verify only flash and pdf pluginsrohitbm@google.com2011-02-073-28/+16
| | | | | | Review URL: http://codereview.chromium.org/6368141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74048 0039d316-1c4b-4281-b951-d872f2087c98
* Moving psutil to third_party. This is first step for Media Performance test ↵nirnimesh@chromium.org2011-02-0743-0/+10564
| | | | | | | | project. Review URL: http://codereview.chromium.org/6246123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74047 0039d316-1c4b-4281-b951-d872f2087c98
* metrics: hash the path bytes directly for plugin filenameevan@chromium.org2011-02-071-2/+7
| | | | | | | | | | | | We use the hash of the plugin filename as a unique identifier for the plugin. On Windows, this new code produces the same hashes as before; on Mac/Linux, it saves extra conversions. BUG=69467 Review URL: http://codereview.chromium.org/6368110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74044 0039d316-1c4b-4281-b951-d872f2087c98
* Add ahendrickson@chromium.org to the OWNERS file.wtc@chromium.org2011-02-071-0/+1
| | | | | | | | | R=eroman,willchan BUG=none TEST=none Review URL: http://codereview.chromium.org/6286155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74042 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of WidgetExample to the source file.tfarina@chromium.org2011-02-073-150/+199
| | | | | | | | | BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6368122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74041 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74034 - Add histograms for prerendering to the renderer process. mmenke@chromium.org2011-02-074-83/+4
| | | | | | | | | | | | BUG=71160 TEST=none Review URL: http://codereview.chromium.org/6255015 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/6368145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74038 - roll to pickup validRectCoord change, and convexity fix in ↵jar@chromium.org2011-02-071-1/+1
| | | | | | | | | | | SkPath::reset/rewind, which fixes the bad-looking FPS dial in the fishtank Review URL: http://codereview.chromium.org/6246145 TBR=reed@google.com Review URL: http://codereview.chromium.org/6368143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74039 0039d316-1c4b-4281-b951-d872f2087c98
* roll to pickup validRectCoord change, and convexity fix in ↵reed@google.com2011-02-071-1/+1
| | | | | | | | SkPath::reset/rewind, which fixes the bad-looking FPS dial in the fishtank Review URL: http://codereview.chromium.org/6246145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74038 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix gl_context_egl header orderevan@chromium.org2011-02-071-7/+10
| | | | | | | | | | | | Chrome style is matching header first, then Chrome headers. We only need one reordering tweak to make this file compile. BUG=72233 Review URL: http://codereview.chromium.org/6312197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74037 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang warning WebClipboardImpl::writeData() fails to override ↵dcheng@chromium.org2011-02-072-2/+7
| | | | | | | | | | | WebClipboard::writeData BUG=72152 TEST=none Review URL: http://codereview.chromium.org/6413027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74036 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix z-order of notificationarv@chromium.org2011-02-071-2/+2
| | | | | | | | | | | | BUG=72224 TEST=Go to NTP Show Most Visited Blacklist an item The notification bar should not be covered by the Apps line Review URL: http://codereview.chromium.org/6413023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74035 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms for prerendering to the renderer process. mmenke@chromium.org2011-02-074-4/+83
| | | | | | | | | BUG=71160 TEST=none Review URL: http://codereview.chromium.org/6255015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74034 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix click issues with about: and file: most visited thumbnailsarv@chromium.org2011-02-071-2/+6
| | | | | | | | | | | | | | | | | The reason these were not working correctly was that the handler for file: and about: links was attached using capturing so the handler was always triggered. This changes the events to use bubbling instead. This allows other listeners to preventDefault before handleLinkClickOrMouseUp is reached. BUG=72213 TEST=On the NTP Show most visited and visit some about: or file: URL enough for it to show up. Try to blacklist or pin the item. We should not navigate to the URL. Review URL: http://codereview.chromium.org/6246146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test leak introduced by fix for crbug.com/70887asargent@chromium.org2011-02-072-15/+2
| | | | | | | | | | | | | It turns out that for this test, we don't actually need a request context getter spun up, so this skips doing that and avoids the need to properly run the IO thread's message loop to let it get cleaned up at shutdown. BUG=71909 TEST=The leak should no longer show up on memory bots Review URL: http://codereview.chromium.org/6286152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74031 0039d316-1c4b-4281-b951-d872f2087c98
* Roll clang to r125007thakis@chromium.org2011-02-072-5/+5
| | | | | | | | | | | | The static analysis-based part of -Wuninitialized moved back to -Wuninitialized-experimental, so turn on -Wuninitialized again. BUG=72205,71375 TEST=none Review URL: http://codereview.chromium.org/6312190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74030 0039d316-1c4b-4281-b951-d872f2087c98
* Make sync failure behavior in settings/personal consistent in Chrome and ↵stevenjb@google.com2011-02-071-6/+0
| | | | | | | | | | | | | ChromeOS. Removing some stale #if code to enable sync error messages when appropriate. BUG=chromium-os:11644 TEST=See issue and test sync settings page behavior, especially under error conditions. Review URL: http://codereview.chromium.org/6250200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74029 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderView not have to know about how PhishingClassifierDelegate.jam@chromium.org2011-02-0710-169/+170
| | | | | | Review URL: http://codereview.chromium.org/6250176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74028 0039d316-1c4b-4281-b951-d872f2087c98
* Delete accidental checkin of empty src/v2 directory.thestig@chromium.org2011-02-070-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74027 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webit from 77777 to 77818zmo@google.com2011-02-071-1/+1
| | | | | | | | | TEST=none BUG=none TBR=loislo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74026 0039d316-1c4b-4281-b951-d872f2087c98
* New test checks that theme install undo reverts to previous theme.tessamac@chromium.org2011-02-072-10/+33
| | | | | | | | | | | | | Test is for the code change in revision 70686 and to help ensure the bug 65967 doesn't reappear. (Also remove dependency on crx files.) BUG=65867 TEST=browser_tests and try bots Review URL: http://codereview.chromium.org/6269020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74024 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2011-02-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74023 0039d316-1c4b-4281-b951-d872f2087c98
* OSExchangeData: convert filename-related API to FilePathevan@chromium.org2011-02-077-31/+31
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/6368133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a warning found by Clang:rsesek@chromium.org2011-02-075-14/+11
| | | | | | | | | | | | | | chrome/browser/cookies_tree_model.h:497:16: error: 'CookiesTreeModel::AddObserver' hides overloaded virtual function [-Woverloaded-virtual] Same with RemoveObserver(). BUG=72149 TEST=Clang compiles Review URL: http://codereview.chromium.org/6368130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74021 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate locale change into text of tooltips of user pods.dilmah@chromium.org2011-02-075-2/+21
| | | | | | | | | | | Note: it is not visually apparent because text is not translated. BUG=chromium-os:11735 TEST=Manual Review URL: http://codereview.chromium.org/6246114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74020 0039d316-1c4b-4281-b951-d872f2087c98
* Require touchui==1 and chromeos==1 to build DOM login screenbryeung@chromium.org2011-02-0710-344/+17
| | | | | | | | | | | Patch from Ryan Harrison <rharrison@chromium.org> BUG=70954 TEST=manual Review URL: http://codereview.chromium.org/6350022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74019 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: 'Disable' the explanatory text for the 'Clear Auto-opening Settings'jhawkins@chromium.org2011-02-073-2/+13
| | | | | | | | | | | button on the UTH page when the button itself is disabled. BUG=71501 TEST=none Review URL: http://codereview.chromium.org/6410101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74018 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Clean up some drawing artifacts with the new unspoofable infobars.rsesek@chromium.org2011-02-071-9/+29
| | | | | | | | | BUG=none TEST=visual Review URL: http://codereview.chromium.org/6312191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74017 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for highlight background resources in windows task manager.atwilson@chromium.org2011-02-074-26/+93
| | | | | | | | | BUG=71490 TEST=Install extension with BG page, click "view background pages" see yellow resource. Review URL: http://codereview.chromium.org/6286147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74016 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 04:27:14 +0000