| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for page cycler regressions.
This reverts commit 7f33868ce04ed5679e8dd3e3d9ca57d47177cfbc / 40730
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/668152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView.
(in preparation for:
http://codereview.chromium.org/650180/show
)
TEST=chrome/browser/content_setting_image_model_unittest.cc
Review URL: http://codereview.chromium.org/660279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StorageArea::setItem.
TEST=none
BUG=37350
Review URL: http://codereview.chromium.org/669072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin,pfeldman
Review URL: http://codereview.chromium.org/668148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the world.
TEST=Start with --no-referrers, neither headers nor document.referrer should ever get set
BUG=none
Review URL: http://codereview.chromium.org/668065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35338
TEST=none
Review URL: http://codereview.chromium.org/660283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/668131
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/668139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that directory.
Review URL: http://codereview.chromium.org/669031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Sure would be nice if the trybots actually worked
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/668136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(note: I also forgot to check in the changes to
build_gles2_cmd_buffer.py from my last CL so
that's in here as well)
TEST=various unit tests
BUG=26101
Review URL: http://codereview.chromium.org/668131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This lets us use portage-based cross-compiled sysroots, that force the prefix to be an absolute path within the portage chroot.
In particular that lets us build the ARM sysroot using the Chrome OS build system.
Ubuntu-based sysroots already have prefix=/usr, so this is a no-op in that case.
Review URL: http://codereview.chromium.org/669139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
harness (WebKit/WebKitTools/Scripts/new-run-webkit-tests).
This also adds an old_run_webkit_tests for the moment for testing purposes.
I will remove this file when I obsolete everything under
webkit/tools/layout_tests/webkitpy.
BUG=23099
TEST=bots stay green
R=tony@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40679
Review URL: http://codereview.chromium.org/669037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fopen_s() won't let you open a file that is open by another process. This
has the unfortunate property of triggering a race condition in Python
exposed by running run-webkit-tests using a lot of threads and spawning
off image_diff. There doesn't seem to be a good reason to disallow files
that are open in other processes, so I'm changing this.
BUG=none
TEST=run_webkit_tests doesn't produce "image_diff: can't open file" errors
R=darin@chromium.org
Review URL: http://codereview.chromium.org/668022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
request does not generate a separate row in the history
database.
BUG=34350
Review URL: http://codereview.chromium.org/668051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dialog. It was a trivial fix that set the SetAllowCharacterBreak property to true for the message label. As a result, the hostname url does not truncate and wraps to the next line.
Original patch by Abhishek Arya <aarya@google.com>
BUG=36772
TEST=Try a hostname url longer than 42 chars to see that it wraps correctly and wraps to the next line.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a regression appearing in revision 39455 by adding an additional NULL check.
TEST=Open Chromium, close all open windows, open bookmark manager, double click any bookmark. Chromium shouldn't crash.
BUG=37386
Review URL: http://codereview.chromium.org/669078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the right dataset for the v8-latest and webkit.org bots.
Review URL: http://codereview.chromium.org/669138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37466
TEST=none
Review URL: http://codereview.chromium.org/668126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- If the user has a system-level chrome and it is trying to install user level, instead of having omaha show an error, the existing system level install is launched with --first-run
- Disable toast experiment
BUG=37410
TEST=see bug
Review URL: http://codereview.chromium.org/668114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still waiting for IPC to be able to test anything.
BUG=27218
TEST=none
Review URL: http://codereview.chromium.org/669128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on mac debug.
TBR=levin
Review URL: http://codereview.chromium.org/669129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed the way we reload an extension when toggling it for incognito.
Also fixed a small bug this exposed with the browser action container where it
would shrink to 0 size when reloading an extension.
BUG=36292
Review URL: http://codereview.chromium.org/668107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in math calculations related to memory access.
Refactored code to use them where appropriate.
One issue that has come up is we need to make sure that
no GLES2 client call can crash the GPU process. In other
words, the GLES2Implementation must never generate a
command the service side will see as malicious.
For example: glTexImage2d(..width = 0x7fffffff, height = 0x7fffffff)
should return an gl error rather than pass it through to the
service side which will currently return a parse error and stop
the GPU process.
It does make me wonder if the service side should return GL errors
for more things rather than parse errors.
TEST=none
BUG=35942,35943,35941,35938
Review URL: http://codereview.chromium.org/669011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Now OpenMAX library has to be loaded dynamically.
Review URL: http://codereview.chromium.org/667010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
versions of the test
harness (WebKit/WebKitTools/Scripts/newrunwebkittests).
This also adds an old_run_webkit_tests for the moment for testing purposes.
I will remove this file when I obsolete everything under
webkit/tools/layout_tests/webkitpy.
BUG=23099
TEST=bots stay green
R=tony@chromium.org
Review URL: http://codereview.chromium.org/669037
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/668121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=37440
Review URL: http://codereview.chromium.org/669097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=36978
The unit test failure is fixed for Mac valgrind. Run it again.
Review URL: http://codereview.chromium.org/669023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was originally added to make events in plugin-opened windows work, but it no longer appears to be necessary (presumably because we are now doing full Cocoa initialization vi CrApplication).
BUG=none
TEST=Plugin-opened windows (Flash 10.0 full screen, Gmail attachment selection, etc.) should still work correctly.
Review URL: http://codereview.chromium.org/661317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In DoSSLConnectComplete, we still need to set using_spdy_
if we get a certificate error.
In HandleCertificateError, we need to ignore the error
after adding the certificate to the allowed_bad_certs list.
R=mbelshe
BUG=37367
TEST=Connect to a SPDY server with a bad certificate. Clicking
"Proceed anyway" in the SSL blocking page should not result in
a download.
Review URL: http://codereview.chromium.org/668111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22044
Review URL: http://codereview.chromium.org/669104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the load state poller may call OnUploadProgress() while a redirect is in progress.
It should be safe to remove the CHECK(), since it was recently added and execution used to pass through previously in this case.
BUG=37035
TBR=wtc
Review URL: http://codereview.chromium.org/669117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
harness (WebKit/WebKitTools/Scripts/new-run-webkit-tests).
This also adds an old_run_webkit_tests for the moment for testing purposes.
I will remove this file when I obsolete everything under
webkit/tools/layout_tests/webkitpy.
BUG=23099
TEST=bots stay green
R=tony@chromium.org
Review URL: http://codereview.chromium.org/669037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
performance too.
BUG=http://crbug.com/29874
TEST=as in bug
Review URL: http://codereview.chromium.org/669009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=oshima
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=37439
Review URL: http://codereview.chromium.org/668089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
size is changing. Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen.
BUG=35464
TEST=resize desktop after starting chrome; create notifications.
Review URL: http://codereview.chromium.org/606007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18119
TEST=load https site, click page info then certificate info button.
Review URL: http://codereview.chromium.org/669030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has a prefix like
gcf:attach_external_tab&. When the ExternalTabContainer receives an updated navigation state
it passes this off to IE, where we look for the IWebBrowserEventSvc interface to fire navigation events
which cause IE to update the address bar, etc. However this interface does not exist on IE6.
The IDocObjectservice interface is available on IE6 which provides the functionality we need.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=33381
Bug=33381
Review URL: http://codereview.chromium.org/668033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rolling our own TestTabContents. Fixes a leak in the tests.
BUG=37385
TEST=AutoFillInfoBarDelegateTest
Review URL: http://codereview.chromium.org/668088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ui_tests should cycle green
Review URL: http://codereview.chromium.org/669093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40665 0039d316-1c4b-4281-b951-d872f2087c98
|