| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=17667
TEST=see bug
Review URL: http://codereview.chromium.org/160142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=glen@chromium.org
BUG=None
Test=None
Review URL: http://codereview.chromium.org/159393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/160148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProxyResolver dependency.
ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests.
The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver.
This refactor lays the groundwork for:
(1) http://crbug.com/11746 -- Run PAC proxy resolving out of process.
(Can inject an IPC bridge implementation of ProxyResolver)
(2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads.
(Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though).
BUG=http://crbug.com/11746, http://crbug.com/11079
TEST=existing unit-tests.
Review URL: http://codereview.chromium.org/149525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Protobuf was removed in favour of protobuf2.
(Patch by Joel Stanley)
Review URL: http://codereview.chromium.org/159334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17434
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/159392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
turns out many servers send the no-sniff option, including the
one we use for our sample extensions.
So we can't rely on mime types to detect Chrome extensions, at
least until we have some place to put our samples that doesn't
have this problem.
TBR=erikkay
Review URL: http://codereview.chromium.org/159391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
remove --enable-extension requirement.
Review URL: http://codereview.chromium.org/159390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
requirement.
Review URL: http://codereview.chromium.org/160141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
extensions is not from the gallery.
Review URL: http://codereview.chromium.org/159379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* fix crasher in theme parsing with no images
Review URL: http://codereview.chromium.org/160124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/160135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than the "bindings/npruntime.h" that we must use in the WebKit API code.
Change this back and revert the DEPS file change that allowed it to happen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the UI to not say tips or recommendations.
BUG=None
TEST=Starting chrome should not show any tips byt default
Review URL: http://codereview.chromium.org/160138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16026
TEST=play a movie trailer with 5.1 audio. It should sound roughly the same as quicktime.
Review URL: http://codereview.chromium.org/155894
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
abarth: can you review the changes to mime_sniffer.cc?
paul: everything else?
BUG=13296
TEST=Added unit tests
Review URL: http://codereview.chromium.org/159345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaFilter now has asynchronous Play() and Pause() methods that are implemented by default. Since we are a completely pull-based system, it turns out only AudioRendererBase and VideoRendererBase need to override them to halt reading from decoders.
When a seek is received by the pipeline, it goes through the following state transitions:
1) Playing -> Pausing -> Paused (notify filters to stop reading)
2) Paused -> Seeking (notify filters to flush buffers and preroll)
3) Seeking -> Playing (preroll completed, resume playback)
The key to this system is that there must be no pending reads in *any* filter when we start transitioning into the seeking state. That means the audio/video renderers do not complete their pausing->paused transition until they have completed all pending reads. To reiterate, since we're pulled based if the renderers are not reading any data, then *nothing* is happening in the pipeline.
We get a lot of nice benefits from this assertion, namely no callbacks are ever "lost", they are always replied to until we are fully paused. Furthermore, we can guarantee that the first buffer received after a Seek() will be guaranteed to be discontinuous.
This change also properly handles end-of-stream, seeking from an end-of-stream state, and displaying frames while paused. In summary, I was able to call Seek() in a while(true) loop without crashing or going out of sync.
BUG=16014,16021,17456
TEST=seeking should be way more robust
Review URL: http://codereview.chromium.org/160005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unittest code in line with the other tests in image_operations_unittest. My half-educated suspicion is that alpha wasn't getting initted correctly, as a new UMR appeared in the "SkColor alpha_pixel = " line. (Can't verify as all my machines are in boxes).
(This is TBR because the build is red).
TBR=tony
BUG=15762
TEST=Run valgrind/purify as in bug
Review URL: http://codereview.chromium.org/159381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=None.
BUG=17710 (http://crbug.com/17710)
Review URL: http://codereview.chromium.org/160136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code needs to be rewritten after beta to handle localized content.
BUG=15079
TEST=Start chrome with a new profile. There should be 2 thumbnails on
the new tab page.
Review URL: http://codereview.chromium.org/160126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16636
TEST=we should respect the codecs= parameter when provided as a media mime type
Review URL: http://codereview.chromium.org/160073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17568
TEST=none
Review URL: http://codereview.chromium.org/160034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
theme installation can happens sans-prompt.
Review URL: http://codereview.chromium.org/160087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17709
TEST=None
Review URL: http://codereview.chromium.org/159380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=layout tests should pass
TBR=fbarchard
Review URL: http://codereview.chromium.org/160134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar.
BUG=16890
TEST=should be obvious
Review URL: http://codereview.chromium.org/159326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15686
TEST=none
Review URL: http://codereview.chromium.org/159371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: thiago
Review URL: http://codereview.chromium.org/159378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This might break some layout tests, but that's ok -- we'll disable them for now.
BUG=16636,16779
TEST=none
Review URL: http://codereview.chromium.org/160125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group.
Bug=7028
Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly)
Review URL: http://codereview.chromium.org/159336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thiago
Review URL: http://codereview.chromium.org/159377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=nsylvain
Review URL: http://codereview.chromium.org/159375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=glen@chromium.org
BUG=15079
TEST=none
Review URL: http://codereview.chromium.org/160130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16669
TEST=Make sure that resetting your theme to the default on Aero Glass causes you to see a black frame.
Review URL: http://codereview.chromium.org/159332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15854
TEST=NONE
Review URL: http://codereview.chromium.org/159360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Patch by tfarina
Original Review: http://codereview.chromium.org/155888
Review URL: http://codereview.chromium.org/160088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12969
TEST=Open a page with a redirect loop. The error page should mention allowing third-party cookies as a way to fix the problem.
Review URL: http://codereview.chromium.org/159145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before the sandbox is triggered.
BUG=16860 (http://crbug.com/16860 )
TEST=Run Chrome with LC_ALL=en_US.UTF-8. 1. Make sure that you don't see
any warning about 'setlocale failing'. 2. Upload a file whose name
contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The
filename field in a form should be populated with the name (rather than empty).
Review URL: http://codereview.chromium.org/160112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o3djs.util.setMainEngine(...V8) in any sample
and you use scripts that you don't want run in V8,
for example Adsense, Google Analyitics, Wave,
Google WebElements then the o3djs would attempt
to pull in that javascript and execute it in V8.
Specifically this refers to inline <script> tags
instead HTML. Not <script src="url"> tags.
The solution is we add an id to the tags we want
o3djs to pull in. Any script with an id that starts
with "o3d" will get pulled in.
This CL changes our samples to have that id on their
script tags.
Review URL: http://codereview.chromium.org/159339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
moving image_diff from chrome/tools/test/image_diff to tools/imagediff
(not moving to tools/image_diff to avoid some svn unpleasantness with that
directory having been created in CL 21366).
Also change test_shell.gyp to depend on everything needed to run the layout
tests.
R=darin@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21584 0039d316-1c4b-4281-b951-d872f2087c98
|