summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Delete mysterious and spurious ^K character in bug_report_window_controller.h.viettrungluu@chromium.org2010-01-061-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/527002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35628 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Mac QuickTime quirk, which we don't need after allstuartmorgan@chromium.org2010-01-062-26/+7
| | | | | | | | | | | See bug for full explanation of why the quirk isn't necessary. The short version is that the quirk was actually compensating for a bug of our own that has since been fixed, not a real problem with QuickTime. BUG=29357 TEST=See bug; given URLs shouldn't crash. Review URL: http://codereview.chromium.org/523083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35626 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac/Linux] TitleCase the report a bug options menu.thomasvl@chromium.org2010-01-063-34/+79
| | | | | | | | BUG=26884 TEST=report a bug menu options are title case Review URL: http://codereview.chromium.org/523092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35625 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Chrome Frame tests to the chromium_builder target in all.gyp.robertshield@chromium.org2010-01-061-0/+3
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/519052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35624 0039d316-1c4b-4281-b951-d872f2087c98
* Make debug build happy again.antonm@chromium.org2010-01-061-0/+2
| | | | | | Review URL: http://codereview.chromium.org/525066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35622 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Terence's namegman@google.com2010-01-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/515038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35621 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 291.0 to 292.0chrome-bot@google.com2010-01-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35620 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more WinInet stuff.phajdan.jr@chromium.org2010-01-065-145/+0
| | | | | | | | | BUG=25520 TEST=none Review URL: http://codereview.chromium.org/525026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35619 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Add a minimum_chrome_version key to the manifest.aa@chromium.org2010-01-067-8/+100
| | | | | | | BUG=24737 TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35618 0039d316-1c4b-4281-b951-d872f2087c98
* Place main menu and otr icon in right places.oshima@chromium.org2010-01-065-10/+31
| | | | | | | | | | | | | | Changed opaque frame to use main menu's width as offset Extender simply places the main menu on left edge. Moved extender's Init call to browser view so that Init can use extender inside (just to be more safe). BUG=chromium-os:985 TEST=None Review URL: http://codereview.chromium.org/518033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35617 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of duplicated code in platform_util_xxx.pyhayato@chromium.org2010-01-062-29/+27
| | | | | | | | | TEST=none BUG=7199 Review URL: http://codereview.chromium.org/465117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35615 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.LimitPerPage as flaky on Linux.viettrungluu@chromium.org2010-01-061-0/+5
| | | | | | | | | BUG=30307 TEST=no more redness on Linux Tests (dbg)(1) due to this? Review URL: http://codereview.chromium.org/523089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35614 0039d316-1c4b-4281-b951-d872f2087c98
* linux: implement gpu pluginpiman@chromium.org2010-01-0615-48/+125
| | | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35509 Review URL: http://codereview.chromium.org/500132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35609 - AppCache quota tracking groundwork, store response sizes in ↵michaeln@google.com2010-01-0613-128/+29
| | | | | | | | | | | | | | the SQL database. TEST=updated existing unittests BUG=none Review URL: http://codereview.chromium.org/523046 TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/525059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35610 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache quota tracking groundwork, store response sizes in the SQL database.michaeln@chromium.org2010-01-0613-29/+128
| | | | | | | | | TEST=updated existing unittests BUG=none Review URL: http://codereview.chromium.org/523046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35609 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix for GLES2gman@chromium.org2010-01-061-1/+1
| | | | | | | | | | | | | Needs unit test but unfortunately that unit test needs some rather large setup to test so for now just checking in the fix. TEST=none BUG=none Review URL: http://codereview.chromium.org/525039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35608 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Improve LocationBarViewGtk.suzhe@chromium.org2010-01-064-32/+227
| | | | | | | | | | | | | | This CL improves LocationBarViewGtk: 1. Add type to search hint. 2. Show/hide selected keyword, keyword hint and type to search hint automatically when resizing the browser window. 3. Use weak gray to display hint text, instead of black. BUG=11258 TEST=Resize the browser window when one of selected keyword, keyword hint and type to search hint is visible, to see if the hint can be shown or hidden automatically. Review URL: http://codereview.chromium.org/508008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35606 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35602 - Add a "minimum_chrome_version" key to the manifest.arv@chromium.org2010-01-067-94/+8
| | | | | | | | | | | | | Broke unit_test on Mac10.5 Tests (dbg)(1) BUG=24737 Review URL: http://codereview.chromium.org/521036 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35604 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "minimum_chrome_version" key to the manifest.aa@chromium.org2010-01-067-8/+94
| | | | | | | | BUG=24737 Review URL: http://codereview.chromium.org/521036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35602 0039d316-1c4b-4281-b951-d872f2087c98
* linux: only use hardcoded font list in layout test modeevan@chromium.org2010-01-061-100/+103
| | | | | | | | | | | | | | | It's helpful to be able to use test_shell to debug problems seen with a more complicated system fontconfig. You can always pass --layout-test-mode (which is what layout tests do) to get the old behavior back. I lost like two hours to this today. :( Even wrote a separate small program to use fontconfig to see why it wasn't pulling out fonts I knew were available... Review URL: http://codereview.chromium.org/521038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35601 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Clean up X lock files if vnc got killed with SIGKILL.thestig@chromium.org2010-01-061-0/+3
| | | | | | | | BUG=none TEST=Bot master restart does not break wine_valgrind bot. Review URL: http://codereview.chromium.org/525052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35600 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: allow TLS renegotiation.agl@chromium.org2010-01-061-0/+15
| | | | | | | | | | | | | | | Renegotiation was disabled when we switched to using our internal version of NSS. The default in the new versions is to prohibit renegotiation. However, since we are a client this is rather pointless. An attacker can easily convince us to start a new TLS connection to a host if they wish. http://codereview.chromium.org/501178 BUG=none TEST=Go to a site that uses renegotiation (generally because they want to request a client-side cert). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35596 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: One more suppression and we'll be close to green.thestig@chromium.org2010-01-061-0/+10
| | | | | | | | | TBR=dank BUG=none TEST=none Review URL: http://codereview.chromium.org/524042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35595 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-063-2/+46
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Widen a net_unittest suppression for flaky ftp tests; fix a typo.thestig@chromium.org2010-01-061-2/+6
| | | | | | | | | TBR=dank BUG=none TEST=none Review URL: http://codereview.chromium.org/523079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35593 0039d316-1c4b-4281-b951-d872f2087c98
* Convert webkit_glue.cc over to using WebKit API.darin@chromium.org2010-01-061-79/+47
| | | | | | | | | | | | | | | Removed unnecessary code to reset the JS line number, which was only added for the Chrome+JSC build. I don't have a way to test if it would still be necessary, and I'd rather not add a WebKit API for it unless I can prove that I need it. R=dglazkov BUG=28065 TEST=none Review URL: http://codereview.chromium.org/517038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35590 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Make sure that we do not focus the thumbnails on mouse down.arv@chromium.org2010-01-061-0/+7
| | | | | | | | | | | | | We used to focus the thumbnail on mousedown which makes the thumbmail hover effect show up which confuses users. BUG=31361 TEST=Right click on a thumbnail and dismiss the context menu. The thumbnail should not be focused. Review URL: http://codereview.chromium.org/525045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35589 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Suppress more memory leaks in unit_tests.thestig@chromium.org2010-01-061-0/+36
| | | | | | | | | TBR=dank BUG=31644 TEST=none Review URL: http://codereview.chromium.org/523078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35588 0039d316-1c4b-4281-b951-d872f2087c98
* When RSS feed has no links, show the title (but don't create an anchor).finnur@chromium.org2010-01-064-8/+35
| | | | | | | | | | | This used to show up as blank preview. BUG=None TEST=Covered by (new) automatic tests. Review URL: http://codereview.chromium.org/523029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35587 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid excessive nesting / recursion in browser URL handling.cevans@chromium.org2010-01-062-2/+16
| | | | | | | | | BUG=31517 TEST=ChildProcessSecurityPolicyTest Review URL: http://codereview.chromium.org/525038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35585 0039d316-1c4b-4281-b951-d872f2087c98
* Add LayoutTests/svg/W3C-SVG-1.1/animate-elem-30-t.svg to layout test ↵arv@chromium.org2010-01-061-1/+5
| | | | | | | | | | | expectations. BUG=31642 TEST=None Review URL: http://codereview.chromium.org/525043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35584 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Suppress a memory leak in ↵thestig@chromium.org2010-01-051-0/+8
| | | | | | | | | | | BookmarkModelWorker::CallDoWorkFromModelSafeThreadAndWait. TBR=tim BUG=31643 TEST=none Review URL: http://codereview.chromium.org/526014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35582 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make devtools window dockable.thakis@chromium.org2010-01-0512-107/+196
| | | | | | | | | | | | | | | | | | | | xib change: Deleted NSBox, added NSSplitView instead (with a thin divider and without any child views). I added the devtools tabcontents to TabContentsController; windows and linux instead add it to the browser window and switch it on every tab change. What I've done makes more sense to me and might work better with a) dragging a tab with docked devtools into a new window and b) toggling fullscreen. BUG=17368 TEST= * Inspect element, click the "attach" item in the lower left corner. Devtools should attach to the tab. Click it again, should detach. Re-attach, switch tabs. Should only be in the tab it was attached to. Open another devtools window in another tab, should be attached there. Drag tab with attached devtools into a new window, should work. * Inspect element with docked devtools, close devtools, inspect another element. devtools should open with the same size it had when it was closed, and should still be docked. * Hover link with docked devtools. Status bubble should not overlap devtools. * Go to http://www.pagetutor.com/keeper/http_authentication/index.html and make sure the http auth sheet still shows up Review URL: http://codereview.chromium.org/526001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35576 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the calculation of desktop size to use an existing common method ↵johnnyg@chromium.org2010-01-054-45/+17
| | | | | | | | | | | rather than windows-specific logic. Part of notifications port to linux. BUG=23954 TEST=none Review URL: http://codereview.chromium.org/524039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35575 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Suppress a bunch of Valgrind errors for unit_tests.thestig@chromium.org2010-01-052-1/+57
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/525040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35574 0039d316-1c4b-4281-b951-d872f2087c98
* Add additional pasteboard tests to BookmarkTreeControllerTest.snej@chromium.org2010-01-053-23/+110
| | | | | | | | | | Split up one method in BookmarkTreeController to improve testability. BUG=13149 TEST=BookmarkTreeControllerTest.MoveNodes Review URL: http://codereview.chromium.org/523069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35573 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make tab context menu use tab_menu_modelestade@chromium.org2010-01-058-64/+138
| | | | | | | | | | | flesh out some more menu model implementation for MenuGtk BUG=28977 TEST=menu still works as before Review URL: http://codereview.chromium.org/523049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35569 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Popup Blockers close buttonfeldstein@chromium.org2010-01-056-54/+723
| | | | | | | | | | | | | The change at http://codereview.chromium.org/484006 changed all the close buttons to use a single HoverCloseButton class, but this didn't work for the popup blocker. The reason is that all the initialization was done in awakeFromNib since in most other cases, the button was created in a nib, but was done with initWithFrame for the popup blocker case. I refactored the initialization code out into -initButton to be called from both initWithFrame and awakeFromNib. I also removed the references to the images and alt images from each of the xib files. The images are specified in the class itself so it was redundant to have it in the xibs, and could probably cause confusion if we change the images later on. BUG=16041 TEST=Ensure that the popup blocker button has rollover image changing, and that it works correctly still for TabView, InfoBar, and DownloadShelf Review URL: http://codereview.chromium.org/521010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35568 0039d316-1c4b-4281-b951-d872f2087c98
* Add session and emit_login_prompt_readyeblake@chromium.org2010-01-051-0/+2
| | | | | | | | These are chromeos specific files to be added to the zip archive Review URL: http://codereview.chromium.org/521033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35567 0039d316-1c4b-4281-b951-d872f2087c98
* Enhance a function comment per feedback from a code review.eroman@chromium.org2010-01-051-1/+2
| | | | | | | | TBR=wtc Review URL: http://codereview.chromium.org/521032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35565 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix bookmark bar hide animation; also some clean-up.viettrungluu@chromium.org2010-01-051-16/+16
| | | | | | | | | | | | As a mass-drive-by, I also got rid of unneeded |? YES : NO| (etc.), since apparently |bool| and |BOOL| are interchangeable. BUG=31635 TEST=Navigate to non-NTP page; switch theme to, say, "Anna Sui" (or be prepared to look very carefully); toggle bookmark bar (Cmd-Shift-B), back and forth; make sure that it looks correct when hiding. Review URL: http://codereview.chromium.org/523070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35563 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a ChromeFrame crasher reported by go/crash. The crash ↵ananta@chromium.org2010-01-052-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | occurs while tearing down the ChromeFrameAutomationClient instance, which only gets called from the destructor of the ChromeFramePlugin class which is a base class of the ChromeFrame ActiveX. When this executes the worker thread which is used for handling urlmon requests has been destroyed. The crash occurs in the UrlmonUrlRequest::Stop function while posting a task back to an invalid message loop. We already clean up the requests in the WM_DESTROY handler, meaning that there seems to be a scenario where we don't receive a WM_DESTROY. It is unclear what that is. The fix is to call Uninitialize on the ChromeFramePlugin object in the destructor of the ActiveX which ensures that it executes while the thread is still valid. Added checks for the message loop in the relevant functions in the UrlmonUrlRequest class. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31557 Bug=31557 Review URL: http://codereview.chromium.org/518034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35561 0039d316-1c4b-4281-b951-d872f2087c98
* Widen Mac Valgrind unit test suppression.rsesek@chromium.org2010-01-051-21/+1
| | | | | | | | | BUG=31586 TEST=Mac Valgrind unit tests Review URL: http://codereview.chromium.org/519051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35560 0039d316-1c4b-4281-b951-d872f2087c98
* Rename StorageNamespace and StorageArea to DOMStorageNamespace and ↵jorlow@chromium.org2010-01-059-108/+109
| | | | | | | | | | | DOMStorageArea. TEST=none BUG=none Review URL: http://codereview.chromium.org/488014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35559 0039d316-1c4b-4281-b951-d872f2087c98
* New Valgrind supression for Mac Valgrind UI regression between r35536 and ↵ajwong@chromium.org2010-01-051-0/+79
| | | | | | | | | | | | r35540. TBR=rjkroege BUG=31634 TEST=none Review URL: http://codereview.chromium.org/524036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35558 0039d316-1c4b-4281-b951-d872f2087c98
* Write the webkit thread unittests. (Er...test.)jorlow@chromium.org2010-01-052-4/+15
| | | | | | | | | | | | If you have any suggestions for other unit tests I can write for this, please suggest them! TEST=none BUG=16155 Review URL: http://codereview.chromium.org/491035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35557 0039d316-1c4b-4281-b951-d872f2087c98
* Marking Reliability bot failure for V8 during HTML tokenization.ajwong@chromium.org2010-01-051-0/+3
| | | | | | | | | | R=arv BUG=31632 TEST=none Review URL: http://codereview.chromium.org/525034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35556 0039d316-1c4b-4281-b951-d872f2087c98
* Add x64 configs for ffmpeg to ChromeOS.fbarchard@chromium.org2010-01-054-0/+1536
| | | | | | | | | BUG=31558 TEST=build with export GYP_DEFINES="target_arch=x64 chromeos=1 branding=Chrome buildtype=Official" Review URL: http://codereview.chromium.org/519043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit fallback to DIRECT when proxies fail. This better ↵eroman@chromium.org2010-01-0512-149/+310
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | matches other browsers, and simplifies the code. To better understand what this means, here are some examples how the behaviors will differ for the user: (1) You start chrome with --proxy-server="foobar:80". The server "foobar:80" is refusing connections. Before: Would fallback to direct after failing to connect through foobar:80. Now: Will error-out with connection refused after failing to connect through foobar:80. (2) You start chrome with --proxy-pac-url="file:///foobar.pac". The server "foobar:80" is unreachable, and foobar.pac reads: function FindProxyForURL(url, host) { return "PROXY foobar:80"; } Before: Would fallback to direct after failing to connect through foobar:80. Now: Will error-out with connection refused after failing to connect through foobar:80. (3) You start chrome with --proxy-pac-url="file:///foobar.pac". The server "foobar:80" is unreachable, and foobar.pac reads: function FindProxyForURL(url, host) { return "PROXY foobar:80; DIRECT"; } *No change, since the fallback to DIRECT is explicit in the PAC script* BUG=12303 Review URL: http://codereview.chromium.org/502068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35549 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement WindowSizer::GetDefaultPopupOrigin()rohitrao@chromium.org2010-01-052-1/+35
| | | | | | | | BUG=http://crbug.com/30239 TEST=Popups should not appear under the Dock when the Dock is on the left. Review URL: http://codereview.chromium.org/510001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35548 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 15:45:15 +0000