| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
- Check for auth identity in URL (new http stack only)
- Move auth cache logic out of url request job, and hide it in the url request ftp job and http transaction classes.
Note: Somehow the original codereview thread got corrupted so it was recreated.
The real review comments should be under (http://codereview.chromium.org/6481)
Review URL: http://codereview.chromium.org/8231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The goal is to see if registering a listener on the body of a document causes any perf regression.
Review URL: http://codereview.chromium.org/9724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pop-up menu talk to each other. Pop-up menu appears containing suggestions.
Review URL: http://codereview.chromium.org/9462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that we can detect Chrome instances across user sessions.
Review URL: http://codereview.chromium.org/10234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default button.
When the focus is not a button, then the default button should be the one the delegate specifies.
BUG=4132
TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button.
Review URL: http://codereview.chromium.org/10230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9711
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
chrome\browser\net\referrer.cc to the SCons build (on Windows).
Review URL: http://codereview.chromium.org/9710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9703
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to the SCons build.
Review URL: http://codereview.chromium.org/9705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9707
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9701
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new WebCursor code will know how to load them.
BUG=4149
R=tony
Review URL: http://codereview.chromium.org/9713
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
makes it more portable, fixes some bugs, and
removes glue from port.
Review URL: http://codereview.chromium.org/9801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everywhere else in this class we look to see
if view_ is NULL before dereferencing it, except
in this case.
This would fix a crash found in the distributed tests.
BUG: 1074508
Review URL: http://codereview.chromium.org/9674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- relanding the CL that fixes the layout tests
- turning on more of the autofill popup to see if this is causing the perf regression.
TBR=nsylvain
Review URL: http://codereview.chromium.org/9708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Zero sized chunks
- Redirect URL format changes
http://crbug.com/3418
Review URL: http://codereview.chromium.org/10222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we only restore the page info window position, but not the size.
Plus some dead code removal in options_window_view.
BUG=3509
Review URL: http://codereview.chromium.org/10218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing garbage in files types combobox.
BUG=4211
TEST=bring up bookmark manager, click on import, click on 'files of
type' and make sure you only see *.html.
Review URL: http://codereview.chromium.org/10225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ipc channel and sending the last message. Sometimes that last
write is cancelled so there will be a channel error at the other end.
Review URL: http://codereview.chromium.org/9629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the separation between MessagePumpForUI and
MessagePumpForIO, and convert the latter to use Completion
Ports instead of MsgWaitForMultipleobjects to sleep
when idle.
Remove all traces of Windows messages from MessagePumpForIO,
remove the transitional API of completion port notifications
and remove WatchObject API.
Modify all callers of RegisterIOHandler so that they are no
longer using RegisterIOContext, and also handle properly
the new semantics of completion ports (notifications even when
the IO completes immediately).
Add a new interface to allow proper cleanup of disk cache (to
replace code that was waiting for pending APCs from the destructor).
Add a way for the message pump to perform cleanup of abandoned IO.
BUG=B/1344358, 3497, 3630
TESt=unit tests
R=darin
Review URL: http://codereview.chromium.org/8156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for all tests. Otherwise, depending on which tests ran and in which order,
EventNames::init() would not get called. I lost a couple hours last night
debugging to figure this out. :(
While I was at it, I rearranged the test functions for cleanliness and fixed
some minor style bits.
Review URL: http://codereview.chromium.org/10213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will investigate on the bot.
TBR=nsylvain
Review URL: http://codereview.chromium.org/9700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics mode of a ADVANCED doesn't work with a RTL layout for this
code.
BUG=4175
TEST=bring up the bookmark manager in the hebrew locale, make sure the
text isn't mirrored.
Review URL: http://codereview.chromium.org/10216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
messages directly to the targeted window.
http://crbug.com/4067
Review URL: http://codereview.chromium.org/9485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This probably needs some bigger adjustments. Some things need to be decided,
like where to store profile files on Linux/Mac.
BUG=3649
Review URL: http://codereview.chromium.org/8059
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A test list was accidentally commited with a line commented out.
Aditionally, some of the animation tests are flaky. When running all
tests, one of the tests seems to consistently time out. When running
only the animation tests another test is timing out. Updating the
test list with the test that currently times out on the buildbot.
Review URL: http://codereview.chromium.org/10211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the number of CPUs. This at least allows the build to function
on unknown systems.
Remove a now-unnecessary addition of $V8_DIR to LIBPATH. The
v8 libraries now get installed in $LIBS_DIR like everyone else.
Review URL: http://codereview.chromium.org/10208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageChannel.
I create the MessagePort wrappers when a MessageChannel is constructed
and put references to them in internal fields in the MessageChannel.
This is a fix for
http://code.google.com/p/chromium/issues/detail?id=4195
Review URL: http://codereview.chromium.org/9508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
up to date anymore.
Review URL: http://codereview.chromium.org/9649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
indexers which are interested in indexing Chrome's web history. These should
register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and
this is be used by Chrome to publish its index.
Added code to publish the index too.
Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We work around all event names being null (!!!) by testing a enum instead. This code should be faster anyway, but I will also investigate the enum.
Review URL: http://codereview.chromium.org/9495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's not being kept up to date and is therefore not useful. We will
continue to maintain the JSC build, just not its layout test results.
BUG=4207
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
or two.
Review URL: http://codereview.chromium.org/10204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menus.
BUG=4186
TEST=try cut/copy/paste from table/tree in the bookmark manager as
well as context menus in bookmark manager.
Review URL: http://codereview.chromium.org/9481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I have only compiled this on linux and tested it there but that shouldn't be a problem as the file does seem to be linux-specific.
Review URL: http://codereview.chromium.org/9685
Patch from Craig Schlenter.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4992 0039d316-1c4b-4281-b951-d872f2087c98
|