| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This CL adds automated tests for AutocompleteEditView.
BUG=20422: Autocomplete edit view needs automated testing
TEST=none
Review URL: http://codereview.chromium.org/177052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
condition causing it
to be registered from multiple threads.
Logged a bug http://code.google.com/p/chromium/issues/detail?id=21827 against this and assigned
it to rvargas.
Workaround for http://b/issue?id=2111432 for now.
Bug=2111432
Review URL: http://codereview.chromium.org/204014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionShelf::ToolstripAtX would never find a toolstrip for any value of x (or would find wrong one).
BUG=11880
TEST=Load chrome with --lang=he, add 2-3 extensions and try dragging and switching their positions. It should work as LTR.
Review URL: http://codereview.chromium.org/204015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Leftover cruft.
Review URL: http://codereview.chromium.org/194109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the compile error on the toolkit builder.
TBR:finnur
Review URL: http://codereview.chromium.org/203064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21728
Review URL: http://codereview.chromium.org/203060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
due to initialization order).
TBR=erikkay
BUG=None
TEST=Linux build compiles.
Review URL: http://codereview.chromium.org/204016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a missing function. We shouldn't need any extra implementation
once we roll deps.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/205004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The callback function in this case should not have been wrapped in an automated callback because this tests handles it's own termination.
Review URL: http://codereview.chromium.org/196116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=None
Review URL: http://codereview.chromium.org/193108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a window when message_loop_ could be non-NULL and invalid. The code
assumed that when message_loop_ is non-NULL, it's valid. Added a stopping_
flag which indicates a state in which we shouldn't access the message loop
because it is not safe.
Also, reused StopSoon logic in Stop and fixed a comment which was inaccurate.
TEST=Covered by base_unittests.
BUG=15331
Review URL: http://codereview.chromium.org/201108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarView.
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.
Known issues:
Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).
BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/203034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
needs to be ifdef'd out.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jianli
TEST=none
BUG=10352
BUG=10271
Review URL: http://codereview.chromium.org/205002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/204012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix the line endings
TBR=dglazkov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13338
TEST=Import bookmarks from another browser, in the progress dialog History should be the first progress item and Bookmarks should be the last.
Review URL: http://codereview.chromium.org/194058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21416
Review URL: http://codereview.chromium.org/203058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProcessSingletonLinux.
Also, include full path in error about creating the lock.
BUG=20982
TEST=chown your profile & lockfile to root.root and run. Should print error about unlink ... permission denied.
Review URL: http://codereview.chromium.org/193105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
auto detect
In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message).
The new logic is as follows:
-) If the user turns auto-detect OFF, nothing happens (as requested in the bug description)
-) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding
I.e., turning auto-detect on resets a previous override setting.
The reverse is not true, however: specifiying a new override setting will not turn auto-detect off.
BUG=2932
TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 :
1.) load the file while auto-detect is turned off
-> garbage is displayed
2.) turn auto-detect on
-> proper Chinese text should appear
-> in the encoding menu, Chinese encoding should be highlighted
3.) turn auto-detect off
-> proper Chinese text should remain
-> in the encoding menu, Chinese encoding should remain highlighted
4.) choose any other encoding
-> garbage is again displayed (in the new encoding)
5.) turn auto-detect on
-> proper Chinese text should again appear
-> in the encoding menu, Chinese should again be highlighted
Original Review: http://codereview.chromium.org/173265
Patch by Roland Steiner (rolandsteiner@google.com)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is neither sufficient nor necessary. The header does not actually include a
definition for futex(). And while it does include definitions for useful
constants, the version of the file that is shipped by some distributions (e.g
Centos) doesn't even compile as it is meant to only be used by the Linux kernel.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/193104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
use in the dashboard.
Review URL: http://codereview.chromium.org/193097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new file, bubble_border.cc, so that InfoBubble will be able to start using it. This also renames the resources to be more generic.
This should not result in any visual changes.
BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change test_is_pending_ and test_is_preparing_ to be globals. This
way other windows in the same test can see the same values. Without
this, frame load events that occur in other windows are not logged.
R=dglazkov
BUG=21644
TEST=none
Review URL: http://codereview.chromium.org/204008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The bug tracker lists all the missing stuff anyway.
Review URL: http://codereview.chromium.org/204010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell, so that we can render controls in a platform-verion-independent
manner, allowing us to use (almost) a single set of baselines for all
versions of Windows.
test_shell is modified to accept three new switches: --ux-theme (for the
default or "new" XP/Vista theming engine), --classic-theme (for the older
"Classic" theming engine), and --generic-theme (for the new Skia-based
test theme). Specifying --layout-tests will default to --classic-theme,
otherwise --ux-theme is the default (this is compatible with existing
test_shell behavior). Once the new version-independent baselines are
checked in, we will flip this behavior so --layout-tests defaults to
--generic-theme as well.
This change adds test_shell_webtheme{engine,control}.{cc,h} as Windows-only
build files, and adds documentation to webkit/api/public/win/WebThemeEngine.
It also adds a chromium-win-xp platform baseline directory (currently empty)
and modifies the layout_test/layout_package/platform_utils_win.py baseline
search path to confirm to WebKit's directory search logic (vista and win7
look just in chromium-win, but XP looks in chromium-win-xp first, followed by
chromium-win).
BUG=none
R=darin,pkasting
TEST=none
Review URL: http://codereview.chromium.org/192021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=7246
TEST=Download a file with an unknown extension using the "Save as"
option. The Save As dialog will populate the "Save Type" combo
box with the unknown type and "All Files", instead of just
"All files".
Review URL: http://codereview.chromium.org/202032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a bold font warning question and a normal font explanation to better
map to the Mac UI guidelines.
BUG=19755
TEST=Try to exit chrome with a download in progress. The dialog
text should have two paragraphs: the first in bold font asking
a question, and the second in normal font with an explanation.
Review URL: http://codereview.chromium.org/193080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"net-internal:*" ==> "chrome://net-internals/*"
"view-cache:*" ==> "chrome://net-internals/view-cache/*"
"view-cache:stats" ==> "chrome://net-internals/httpcache.stats"
As before, there are also aliases from the "about:*" page:
"about:net-internal[/*]" aliases "chrome://net-internals/*"
"about:cache[/*]" aliases "chrome://net-internals/view-cache"
BUG=http://crbug.com/21551
Review URL: http://codereview.chromium.org/202067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
introduced by r26143.
That commit should have also included the following commit message:
This patch avoids unnecessary layout work by calling
FrameView::layoutIfNecessaryRecursive() from WebFrameImpl::Layout() rather than
manually recursing through frames and calling FrameView::layout()
This patch should greatly help out slow scrolling on sites like gmail. Gmail
has some position:fixed elements that prevent the renderer from simply blitting
on a scroll event, so it has to repaint the onscreen elements. In order to
avoid painting a stale or incorrect image the renderer has to check that layout
is up-to-date before painting which invokes WebFrameImpl::Layout(). Previously,
this called FrameView::layout() for each frame. This meant a lot of extra work
was being done even if the render tree was up to date and didn't need any more
layout work. This patch calls FrameView::layoutIfNeededRecursive() instead
which checks the needsLayout() flag on each FrameView in the tree. In the case
of gmail, the onscroll handler does not invalidate layout so this call returns
nearly instantly. This matches WebKit/Safari behavior.
On my workstation the times for scrolling a large thread in gmail look like
this:
Before: 40ms of layout, 19ms of painting on each scroll event
After: 0ms of layout, 19ms of painting on each scroll event
This changes the pixel results of fast/repaint/fixed.html, but the post-change
results appear to be correct.
Review URL: http://codereview.chromium.org/196112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remains at 64.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that are described in README.chromium and
a .diff file, under review separately.
I removed some of the weightier
autoconf/configure scripts. This brought the
size of the library from 3.8MB to about 2.3MB.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolkit views.
It also contains clean-ups and implementation of different minor focus related things.
BUG=None
TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab.
Also test that deactivating/reactivating the browser window still restores focus properly.
Review URL: http://codereview.chromium.org/194041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21742
Review URL: http://codereview.chromium.org/200124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fix is necessary for the Totem plugin on Linux, which is used
for media playing (mp3, quicktime, etc.).
BUG=19712,21224
Review URL: http://codereview.chromium.org/196105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21600
Review URL: http://codereview.chromium.org/200100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the valgrind logs
have astronomical suppression counts for this.
BUG=17966,17996
Review URL: http://codereview.chromium.org/204009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Pixel-perfect with Windows.
BUG=21772
Review URL: http://codereview.chromium.org/203054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch was prepared by Alexander Potapenko (cc'ed),
we work together on ThreadSanitizer for Chromium.
Review URL: http://codereview.chromium.org/194106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I broke this in r25841.
The fix makes TestShell support both URLs as well as file paths
on the command line.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/204007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/201093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005
BUG=None
TEST=run unit_tests.exe, base_unittests.exe.
Review URL: http://codereview.chromium.org/193101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
still not ideal.
BUG=none
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/194105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the http auth dialog.
Add the explanation to the http auth dialog.
Autosize the http auth dialog after putting in the explanation.
TEST=http auto ui should now be localized.
BUG=20532
Review URL: http://codereview.chromium.org/196109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Libjingle depends on it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
show up in the task bar.
Review URL: http://codereview.chromium.org/201103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26138 0039d316-1c4b-4281-b951-d872f2087c98
|