| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=linux-hardy/moz is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3146017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding more setup content to remoting. Including the gaia authenication
and done message. This provides the basic flow for the setup.
There's a lot still needs to be worked on:
1. Merge RemotingSetupFlow and RemotingSetupMessageHandler because we shouldn't
splitting the logic into two separate classes.
2. Cleanup the memory ownership.
3. Perform the actual gaia login.
4. Perform host registration.
Review URL: http://codereview.chromium.org/3160016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cycler.
BUG=51411,52103
TEST=page cycler
Review URL: http://codereview.chromium.org/3170020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46512
TEST=manual
Review URL: http://codereview.chromium.org/3186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
themselves based on their managed state.
- Disable the proxy settings button if they are managed.
BUG=52335
TEST=Verify appropriate options are disabled in Enterprise version w/ --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3122021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a test. If this test passes, I'll convert the
rest of the measures. It includes a change to the
expectations to account for this test's new performance.
If it didn't include that change, the line would be
improve: -9, regress: 9.
BUG=none
TEST=linux/moz is green
Review URL: http://codereview.chromium.org/3115012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, it fixes another ancient bug that prevented downloads search
from working in Incognito mode.
The design of DownloadHistory is also nicer now, with no dependencies
on DownloadManager.
TEST=see bug
BUG=51955
Review URL: http://codereview.chromium.org/3112011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CGPDFDrawingContextDraw() which have been happening on mac UI tests.
BUG=52364
Review URL: http://codereview.chromium.org/3125013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/3133014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove call to WaitForInfobarCount(0) so test doesn't hang on Win and look for better solution.
Review URL: http://codereview.chromium.org/3169015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stuff page.
Remove the trigger for showing list.
Make the remove button work.
BUG=49093
TEST=None
Review URL: http://codereview.chromium.org/3137011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem here was that in the case where the container was sized all the way open, we never saved the result, because we never called Animate(). Having the size saving happen at the end of animation seemed subtle, so this:
* Saves at the beginning, not end, of animation (so shutdowns during animation don't forget the right size)
* Renames Animate() to make it clearer that it's also saving the desired size
* In general simplifies things by basing animation on a target number of icons instead of a target width
BUG=51179
TEST=Size browser actions container to hide one action (and show the rest); restart; size to show all; restart. On both restarts, you should see the same number of visible actions as at shut down.
Review URL: http://codereview.chromium.org/3114014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
manual RTL position calculations.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3176013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
blasting it away.
BUG=26888
TEST=TBD
Review URL: http://codereview.chromium.org/3106015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests were failing on Chrome OS because we were
incorrectly calling OnUserChoseDatatypes() during sync setup. This is
something that needs to be done only on non-Chrome OS platforms.
With this fix, the sync integration tests should run on Windows, Mac,
Linux and Chrome OS.
BUG=52006
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3175013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/3161021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
at least r55814.
BUG=52346
Review URL: http://codereview.chromium.org/3157014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better..." on ChromeOS."
Broke compile on Windows:
first_run_search_engine_view.cc
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/google_chrome_strings.h(53) : error C2220: warning treated as error - no 'object' file generated
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/google_chrome_strings.h(53) : warning C4005: 'IDS_OPTIONS_ENABLE_LOGGING' : macro redefinition
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/chromium_strings.h(55) : see previous definition of 'IDS_OPTIONS_ENABLE_LOGGING'
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/google_chrome_strings.h(54) : warning C4005: 'IDS_OPTIONS_RESET_MESSAGE' : macro redefinition
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/chromium_strings.h(53) : see previous definition of 'IDS_OPTIONS_RESET_MESSAGE'
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/google_chrome_strings.h(55) : warning C4005: 'IDS_CANT_WRITE_USER_DIRECTORY_SUMMARY' : macro redefinition
C:\b\slave\chromium-rel-builder\build\src\build\Release\obj\global_intermediate\chrome\grit/chromium_strings.h(54) : see previous definition of 'IDS_CANT_WRITE_USER_DIRECTORY_SUMMARY'
TBR=zelidrag
Review URL: http://codereview.chromium.org/3111007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to reduce the amount of false positive crash reports - when exception is swallowed and is almost always not a problem due ChromeFrame code.
BUG=51830
Review URL: http://codereview.chromium.org/3171011
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/3191003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green webkit dbg(2) bots
TBR=yutak,mpcomplete
Review URL: http://codereview.chromium.org/3176015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on ChromeOS.
BUG=chromium-os:5556
TEST=make sure we say Chrome OS in options dialog.
Review URL: http://codereview.chromium.org/3169014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5646
TEST=option chrome:options on chromeos build, go to system page and make timezone is back there
Review URL: http://codereview.chromium.org/3143009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5164 http://code.google.com/p/chromium-os/issues/detail?id=5164
TEST=See bug description.
Review URL: http://codereview.chromium.org/3083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50554
Review URL: http://codereview.chromium.org/3106012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window class to checking for IChromeFrame.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3137010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
amount of false positive crash reports - when exception is swallowed and is almost always not a problem due ChromeFrame code.
BUG=51830
Review URL: http://codereview.chromium.org/3171011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the right binary to run.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=500
TEST=this CL
Review URL: http://codereview.chromium.org/3171010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL originally caused crashes on the bots. I tracked the problem down to a bug in ANGLE that I fixed upstream:
http://codereview.appspot.com/1956042/show
This fix was committed upstream and I rolled the Chrome DEPS so the bot crash issue should be resolved.
Original comment for r55510:
Prelaunch GPU process after 10 seconds.
This will happen if the --prelaunch-gpu-process command line switch is present
or for 5% of users in a field trial.
This is so we can collect some stats of GPU capabilities.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3179010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3188004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3164011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/3185008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add Ask setting (default and exception) behind this flag.
BUG=51375
TEST=manual
Review URL: http://codereview.chromium.org/3137005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO: need to show a little triangle
TODO: need to animate the show/hide
TODO: need to remove ellipsis from end of "Exceptions..." text
BUG=51375
TEST=manual
Review URL: http://codereview.chromium.org/3148012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3184006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think it was a failed experiment, and it only
ever worked for base_unittests.
This removes some potentially risky code from LazyInstance
that was only needed for the test isolation.
The lesson from this experiment is that removing singletons
works better than trying to make tests work fine even when
singletons are overused.
TEST=none
BUG=12710
Review URL: http://codereview.chromium.org/3127012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Closing the infobar after decline translation.
Review URL: http://codereview.chromium.org/3160019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it's possible to hit them with invalid button IDs. While the DCHECKs won't happen in release builds, what probably will happen is some sort of other problem due to invalid memory access. So just convert the DCHECKs to conditionals.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3155018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/3005033
Patch by Ahmad Sharif <asharif@google.com>.
Review URL: http://codereview.chromium.org/3134014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
inline a few things that don't need it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3140012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After discussion with Brian and the search engine group for EMEA, the decision was made to fix by adding the distinct logo for Yahoo, in the case of Canada, and allowing Bing to be represented by one search engine out of the three in the Arab states and BE. Because Bing, like Google, does not use distinct logos for different locales, and allows users to change language easily from the home page (based on market area), we treat Bing like Google, and have it represented by only a single search engine in the dialog of three choices.
The Search Engine Dialog is populated by the top three search engines in the template_url_prepopulate_data.cc for each country, so to make this change, we move the second Bing language search engine out from the third into the fourth position. Thus both will still be available in the user's "manage search engines" options, but only one will appear in the dialog.
BUG=51224
TEST=Search engine dialog has three separate search engines for each country -- especially BE, CA, DZ, MA, SY.
Review URL: http://codereview.chromium.org/3110016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3150001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default values.
R=pinkerton
BUG=51733
TEST=Chromium-->Preferences-->Under the Hood. Change the download directory. Click Reset to Defaults. UI updates to ~/Downloads.
Review URL: http://codereview.chromium.org/3110019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
completing the connect asynchronously, we never set the connected_
flag to true. This is usually benign, because we don't often
check the flag.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
too slow.
Review URL: http://codereview.chromium.org/3181014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: joth@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/3132012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3119016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Compile/unit_tests
Review URL: http://codereview.chromium.org/3173017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56202 0039d316-1c4b-4281-b951-d872f2087c98
|