| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Already reviewed by Vangelis.
Review URL: http://codereview.chromium.org/609006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/606005 afterward.
TBR=vangelis
Review URL: http://codereview.chromium.org/609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35588
TEST=Linux build; these targets should compile without warnings
Review URL: http://codereview.chromium.org/601061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35869
TEST=gclient runhooks --force should work for arm configurations of linux.
Review URL: http://codereview.chromium.org/600144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parties can more easily redistribute the O3D NPAPI plugin under a different brand.
Analogous change for the ActiveX plugin will be in a forthcoming CL.
TEST=built on Linux with various overridden values and checked that about:plugins showed the right thing; trybots
BUG=none
Review URL: http://codereview.chromium.org/599012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=25324
TEST=No more crashes in libX11?
Review URL: http://codereview.chromium.org/598025
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/596125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/606005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes that bug.
BUG=35602, 35482
TEST=Navigate to a page in a foreign language. The tranlate infobar
is shown. Reload the page, the infobar should be shown again.
Review URL: http://codereview.chromium.org/597065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35867
TEST=None
TBR=levin
Review URL: http://codereview.chromium.org/600143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=opens Options dialog, go to the Under the Hood tab, see if the order of the sections are the
same as in Windows.
Review URL: http://codereview.chromium.org/596113
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=35858
TEST=None.
Review URL: http://codereview.chromium.org/607010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=yurys
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
renderers.
BUG=35575
Review URL: http://codereview.chromium.org/600137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=This is to reduce false positive "Unable to terminate process" log entries in unit tests.
BUG=none
Review URL: http://codereview.chromium.org/600108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes the code compile under NP_NO_QUICKDRAW and NP_NO_CARBON (modulo some gyp stuff that 64-bit builds will need to prevent compiling the shim library), and makes the tweaking of DYLD_INSERT_LIBRARIES 32-bit only.
Also removes a QuickDraw variable left over from an earlier version of the QuickDraw support.
BUG=none
TEST=none; supports future 64-bit compilation
Review URL: http://codereview.chromium.org/597053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33497
Review URL: http://codereview.chromium.org/600127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jparent
Review URL: http://codereview.chromium.org/605029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/604030
Patch from Bernhard Bauer <bauerb@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
provide an empty d'tor for the abstract base class, so sub-classes can be instantiated.
Review URL: http://codereview.chromium.org/606059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fast/multicol/client-rects.html fails because of scrollbar difference on Windows and Linux. On Mac there is also some subtle difference.
TBR=jparent
Review URL: http://codereview.chromium.org/608011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33497
Review URL: http://codereview.chromium.org/593109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Without this, the linker wants the vtable for GeolocationArbitrator
to exist, despite it never having a definition.
Review URL: http://codereview.chromium.org/606052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=30785
Review URL: http://codereview.chromium.org/607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents a leak of RenderProcessHost, and possibly other
bad bugs.
TEST=Added to base_unittests; also existing browser and unit tests.
BUG=35571
Review URL: http://codereview.chromium.org/604048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jar,antonm
Review URL: http://codereview.chromium.org/596083
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/604063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change re-implements the SpellcheckWordIterator class to use ICU custom rules so we can use the ICU dictionary to handle Thai and Korean.
Also, this class has added a couple of new features to improve the spell-checking quality:
* Decompose Hangul syllables into Korean Jamos.
This helps us support Korean spell-checking.
* Filter out some characters not needed by our spell-checker (e.g. Hebrew niqquds and Arabic vowel signs).
This prevents us from marking a word that includes these characters as misspelled.
BUG=8487
TEST=unit_test.exe --gtest_filter=SpellcheckWordIteratorTest*
Review URL: http://codereview.chromium.org/577020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/593111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a bunch of NOTIMPLEMENTEDs and stub files,
moving them to a different place.
TEST=it compiles
Review URL: http://codereview.chromium.org/594057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1390
TBR=jparent
Review URL: http://codereview.chromium.org/608008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jparent
Review URL: http://codereview.chromium.org/593107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
int and long are the same size on the platforms we care about,
but gcc doesn't like comparing int against LONG_MAX.
Review URL: http://codereview.chromium.org/604056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetFileExtensionFromPath function.
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/604049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/593105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
persistence (via local state prefs)
BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc*
Review URL: http://codereview.chromium.org/603040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jparent,pfeldman
Review URL: http://codereview.chromium.org/601075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The driving rationale for this change was to prevent choosing an AuthHandler when it
is not supported on the system due to a missing runtime component (such as not being
able to locate a gssapi shared library when seeing a Negotiate scheme).
It also has the advantage (currently unused) of determining some per-auth-scheme properties
only the first time that a challenge for that scheme is seen (such as maximum token length for
the SSPI implementation of NTLM).
Finally, it may make unit tests easier to generate since the factory can be easily mocked.
BUG=34795
TEST=New unit test for HttpAuthHandlerDispatchFactory.
Review URL: http://codereview.chromium.org/582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35016
TEST=With --login-manager=network screen should be shown. Ethernet and Wifi networks are shown and could be selected.
Review URL: http://codereview.chromium.org/597046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It appears this dependency was just copied around over the
years; there's no reason for it.
Review URL: http://codereview.chromium.org/608004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jparent
Review URL: http://codereview.chromium.org/601073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Skip websocket/test/cookies/httponly-cookie.pl
BUG=35660
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a non-deterministic issue. After some investigation, we learned that
the following callback functions are called before the horizontal candidate
window is rendered.
OnUpdateLookupTable()
OnUpdateAuxiliaryText()
OnSetCursorLocation()
As shown, OnSetCursorLocation() is the last function to be called.
We should request a resize and a paint in OnSetCursorLocation() to
to ensure that the candidate window is always rendered properly.
TEST=manually
BUG=crosbug.com/1560
Review URL: http://codereview.chromium.org/594046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Namely:
- current_page_index
- cursor_row_index
- num_candidates_in_current_page
- num_pages (not used in candidate_window.cc, but this will also be deleted in libcros)
These members will be deleted from libcros in a separate CL.
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/606012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This effectively reverts patch set 6 from http://codereview.chromium.org/596039 and adds patch set 1 instead.
Also add a regression test to make sure the bug is actually fixed.
The problem with using navigation state was that allowScripts() was still called before the FrameNavigate message was sent.
BUG=35011
TEST=See bug.
Review URL: http://codereview.chromium.org/608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable websocket tests.
BUG=35526,35560
TEST=layout_tests passes
TBR=yurys,dglazkov
Review URL: http://codereview.chromium.org/608002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The demise of temp scaffolding has left the shared build in
an unhappy state where the compiler complains about vtable
issues with PrintJob because only half the class is implemented.
Fix this by compiling some more printing files on linux and
stubbing out AskUserForSettings.
BUG=none
TEST=linux shared build compiles. Other builds still ok too.
Review URL: http://codereview.chromium.org/598066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSLClientSocketMac reports certificate error before SSL handshake is completed,
so just returning OK for LOAD_IGNORE_CERT_* won't work (completed_handshake_ is false yet, so we can't Read()/Write() on the socket).
Add the cert in allowed_bad_certs, and reconnect again.
BUG=35108
TEST=none
Review URL: http://codereview.chromium.org/593013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23368
Review URL: http://codereview.chromium.org/596081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for routing network requests
to the host. The crash happens while dereferencing a NULL AutomationResourceMessageFilter pointer in a pending
job.
We already NULL check the pointer in the if block above. Moving this check at the top.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=35728
Bug=35728
Review URL: http://codereview.chromium.org/605022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39035 0039d316-1c4b-4281-b951-d872f2087c98
|