summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-1914-108/+68
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a release mode crash. Work should not be done inside of DCHECK()s.zork@google.com2009-12-191-2/+2
| | | | | | | | BUG=none TEST=run sync_unit_tests in a release build. Review URL: http://codereview.chromium.org/500147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35015 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CreateBridge method to the ChildThread.jcampan@chromium.org2009-12-1913-220/+193
| | | | | | | | | | | | | The intent is to allow unit-tests that use render view to override ChildThread::CreateBridge() to provide their own resource loading. This is used by the upcoming translate unit-test. BUG=None TEST=None Review URL: http://codereview.chromium.org/503032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35014 0039d316-1c4b-4281-b951-d872f2087c98
* add unit test for ExtensionURLToRelativeFilePathestade@chromium.org2009-12-191-0/+33
| | | | | | | | | BUG=30749 TEST=this patch Review URL: http://codereview.chromium.org/507054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35013 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-1914-68/+108
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Set the address field type based on how many address fields we encountered.jhawkins@chromium.org2009-12-191-0/+27
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/501092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35011 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup from being webkit gardener. Update bug numbers on 2, rebaseline one ↵jparent@chromium.org2009-12-196-13/+9
| | | | | | | | | | | | test that changed upstream. TEST=try servers BUG=30816,29737 Review URL: http://codereview.chromium.org/500145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35010 0039d316-1c4b-4281-b951-d872f2087c98
* Add two more unit tests for SOCKS5:eroman@chromium.org2009-12-182-22/+47
| | | | | | | | | | | | | * Check that connecting again after having disconnected works. * Check that trying to connect with a very large hostname fails. Also removes some unused code from socks_client_socket.cc. BUG=NONE Review URL: http://codereview.chromium.org/501112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35008 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a number of issues with extension disable-on-update:mpcomplete@chromium.org2009-12-183-8/+10
| | | | | | | | | | | | | - No longer create 2 infobars. - No longer leak infobars. This fixes a crash. - Update the disabled list before sending the notification, so that the extension management page updates properly. BUG=30407 Review URL: http://codereview.chromium.org/501104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35003 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for Google Mail Checker memory leak.mpcomplete@chromium.org2009-12-182-17/+1
| | | | | | | | | | | | We don't have a limit on the number of console messages we hold in memory. Until we can get this bug fixed in WebKit, I'm removing the console.log statements. BUG=29919 Review URL: http://codereview.chromium.org/502081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35001 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement DnD of URLs onto Omnibox.viettrungluu@chromium.org2009-12-1813-95/+179
| | | | | | | | | | | (DnD of text coming in another patch.) BUG=24631 TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location. Review URL: http://codereview.chromium.org/481012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34998 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedit to the description of detectLanguage.kathyw@google.com2009-12-182-2/+2
| | | | | | | | | | TEST=none BUG=none TBR=cira Review URL: http://codereview.chromium.org/501123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame test failures on the builder caused by my CL to change the ↵ananta@chromium.org2009-12-183-19/+28
| | | | | | | | | | | | | | | | | | way the automation launch parameters are propagated to the ChromeFrameAutomationClient object. I also fixed the ChromeFrame automation mock tests which don't use gmock and instead relied on an incorrect behavior in ChromeFrame where we would deny the navigation from the automation client and still navigate in Chrome when the external tab is created. Will work on changing these tests to gmock in a subsequent CL. TBR=stoyan and thanks to him for helping debug the gmock failures. Review URL: http://codereview.chromium.org/500143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34996 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedit to i18n, added link to example directory.kathyw@google.com2009-12-182-7/+23
| | | | | | | | | | TEST=none BUG=none TBR=cira Review URL: http://codereview.chromium.org/504061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34995 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cpu/memory measurements on OS X.thakis@chromium.org2009-12-1810-64/+212
| | | | | | | | | | | Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156,25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34994 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing migration of directory_backing_store.cc to Chromium sqlite wrappers.zork@google.com2009-12-183-41/+45
| | | | | | | | | BUG=none TEST=Run sync_unit_tests Review URL: http://codereview.chromium.org/500114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34993 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implements popups for Page Actions, plus fixes a leak within the ↵andybons@chromium.org2009-12-184-13/+38
| | | | | | | | | | Browser Action popup class. BUG=12281 TEST=Install the RSS feed page action extension. Go to a site with multiple feeds on the page, like http://ask.metafilter.com, observe a popup upon clicking the page action icon. Review URL: http://codereview.chromium.org/500138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34992 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit from r52293 to r52323.pkasting@chromium.org2009-12-182-1/+4
| | | | | | | | | TBR=jparent BUG=30792 TEST=none Review URL: http://codereview.chromium.org/501122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34991 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34983 - Split more targets from chrome.gyp to add support for ↵slightlyoff@chromium.org2009-12-1814-1781/+1273
| | | | | | | | | | | | | | | | | building Native Client for 64bit Windows. This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries. For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/501125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34990 0039d316-1c4b-4281-b951-d872f2087c98
* Add videos to the doc where appropriate.kathyw@google.com2009-12-1810-10/+77
| | | | | | | | | | | | Mostly links, but a few embedded videos. TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/504054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34989 0039d316-1c4b-4281-b951-d872f2087c98
* Bring the remove notifications up from the WebDatabase to the WebDataService.skrul@chromium.org2009-12-182-31/+75
| | | | | | Review URL: http://codereview.chromium.org/505046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34986 0039d316-1c4b-4281-b951-d872f2087c98
* Multiple chrome frame activex controls should instantiate and navigate ↵ananta@chromium.org2009-12-189-50/+202
| | | | | | | | | | | | | | | | | | | | | | | correctly in IE. This was not the case due to a race condition between put_src getting called for subsequent activex instances and the external tab to hold the chrome frame instance getting created. Fix is to pass in the URL if we have it when the automation client is initialized to launch the chrome automation server. If not we navigate when the external tab is created. To achieve this we stuff in all relevant parameters into a structure which is populated when the automation client is initialized. I also changed the CreateExternalTab message to carry the referrer for the initial navigation. Fixes http://code.google.com/p/chromium/issues/detail?id=28236 Test=added unit tests for the same. The firefox one is not working at this point. Disabled this test for now while I debug it. Bug=28236 Review URL: http://codereview.chromium.org/500123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34985 0039d316-1c4b-4281-b951-d872f2087c98
* Split more targets from chrome.gyp to add support for building Native Client ↵gregoryd@google.com2009-12-1814-1273/+1781
| | | | | | | | | | | | | for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34983 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for GAFYD.aa@chromium.org2009-12-183-8/+128
| | | | | | Review URL: http://codereview.chromium.org/497003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34982 0039d316-1c4b-4281-b951-d872f2087c98
* Added confirmation dialog for stopping syncing.akalin@chromium.org2009-12-181-3/+36
| | | | | | | | | | | Added some explanatory comments. BUG=30642 TEST=manual testing Review URL: http://codereview.chromium.org/501108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34981 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we insert the screenshot into the correct tab by making each tab's ↵skerner@chromium.org2009-12-181-9/+10
| | | | | | | | | | | | | | url different. It was possible to make the existing code insert the image in the wrong tab by clicking the snapshot twice quickly. This change eliminates the race condition that made this possible. BUG=none TEST=Manual testing on Linux, windows. Review URL: http://codereview.chromium.org/502060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34980 0039d316-1c4b-4281-b951-d872f2087c98
* supress valgrind complaints about zlib conditional jump performance ↵slightlyoff@chromium.org2009-12-181-0/+9
| | | | | | | | | | | | | | optimization. See: http://www.zlib.net/zlib_faq.html#faq36 BUG=None TBR=mbelshe TEST=None Review URL: http://codereview.chromium.org/503057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34979 0039d316-1c4b-4281-b951-d872f2087c98
* Need to allow accessibility exceptions to flow to allow the Accessibility ↵avi@chromium.org2009-12-181-9/+30
| | | | | | | | | | | Verifier to work. BUG=none TEST=none Review URL: http://codereview.chromium.org/503048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34975 0039d316-1c4b-4281-b951-d872f2087c98
* Adds bookmarks.getRecent that returns the recently bookmarked items.arv@chromium.org2009-12-187-0/+301
| | | | | | | | | BUG=None TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.FLAKY_Bookmarks Review URL: http://codereview.chromium.org/503053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34972 0039d316-1c4b-4281-b951-d872f2087c98
* Expose the TransportDIB through the reserved pointer so that the NaCl pepper ↵sehr@google.com2009-12-182-1/+29
| | | | | | | | | host can find it to transfer to the NaCl module. Review URL: http://codereview.chromium.org/500121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34970 0039d316-1c4b-4281-b951-d872f2087c98
* Update DirectoryBackingStore::SaveChanges() to use Chromium's SQlite helper ↵zork@chromium.org2009-12-181-45/+37
| | | | | | | | | | | functions. BUG=none TEST=Run sync_unit_tests and observe that they pass. Review URL: http://codereview.chromium.org/502061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak on ExtensionMessageBundle.cira@chromium.org2009-12-184-24/+9
| | | | | | | | | | Revert valgrind suppresion. BUG=30762 Review URL: http://codereview.chromium.org/501115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34968 0039d316-1c4b-4281-b951-d872f2087c98
* wine_valgrind: Disabled https/ssl tests while I investigate.thestig@chromium.org2009-12-181-0/+8
| | | | | | | | | TBR=dank BUG=none TEST=none Review URL: http://codereview.chromium.org/501111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34967 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue with url not being encoded before passing to it Google Reader ↵finnur@chromium.org2009-12-184-20/+48
| | | | | | | | | | | | | | | | | (issue 29929). Also, a little bit more UI polish: Make sure really long titles don't destroy the layout of the subscribe page. Move the Edit/Remove links closer to the combo box. Add a link to the feed page so that people with desktop feed readers can get at the url. BUG=http://crbug.com/29929 TEST=See bug 29929. Review URL: http://codereview.chromium.org/500131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34966 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for page action icons on Mac.pamg@google.com2009-12-182-4/+111
| | | | | | | | BUG=12281 TEST=covered by unit tests Review URL: http://codereview.chromium.org/500110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34963 0039d316-1c4b-4281-b951-d872f2087c98
* Put the fontconfig FcFini call in the PlatformShutdown() method instead ofevan@chromium.org2009-12-181-1/+1
| | | | | | | | | | | | | | | PlatformCleanUp(). The latter is called multiple times, which results in fontconfig being shutdown too early. Fixes buildbot failure introduced in revision 34945. BUG=9245 TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes. Also use valgrind to check for invalid reads. Patch from Jochen Eisinger <eisinger@google.com>. Review URL: http://codereview.chromium.org/502072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34961 0039d316-1c4b-4281-b951-d872f2087c98
* Add 30790 to known crash to turn reliability bot green.huanr@chromium.org2009-12-181-0/+3
| | | | | | Review URL: http://codereview.chromium.org/505051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34960 0039d316-1c4b-4281-b951-d872f2087c98
* Enable windowless-based npapi_test_plugin tests on the Mac.stuartmorgan@chromium.org2009-12-185-11/+46
| | | | | | | | | BUG=30488 TEST=N/A Review URL: http://codereview.chromium.org/501074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34959 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the title of the in-product EULAs to not contain "OEM"gwilson@google.com2009-12-1841-62/+62
| | | | | | | | | | R=cpu BUG=30711 TEST=Run in-product EULA, should not see "OEM" in the title. Review URL: http://codereview.chromium.org/500107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34958 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when message IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW has ↵cira@chromium.org2009-12-181-2/+2
| | | | | | | | | | | non-ASCII characters. BUG=30736 TEST=Open chrome with --lang=sr and try to pack extension. It shouldn't crash, and files with be generated. Review URL: http://codereview.chromium.org/503051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34957 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34954 - Fix issue 11258: Linux: gracefully handle small browser windowrsesek@chromium.org2009-12-1814-527/+118
| | | | | | | | | | | | | | TODO: Make location bar to be freely shrinkable. Will be addressed in another CL. BUG=11258 TEST=See bug report. Review URL: http://codereview.chromium.org/507022 TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/502073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 11258: Linux: gracefully handle small browser windowsuzhe@chromium.org2009-12-1814-118/+527
| | | | | | | | | | | TODO: Make location bar to be freely shrinkable. Will be addressed in another CL. BUG=11258 TEST=See bug report. Review URL: http://codereview.chromium.org/507022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34954 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34951 - Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.rsesek@chromium.org2009-12-1827-380/+510
| | | | | | | | | | | | | | | | | | | | | | | | | The combined IPC means that scrolling only requires one transport DIB instead of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels for the exposed region, and then we'd use a second one in the PaintRect IPC to pass up the pixels for the updated scroll bar rendering. Now all paints are done using a single transport DIB. Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions. This means calling GetUpdateRgn and GetRegionData to enumerate the list of damage rects. Then only those rects are copied from the backing store. The same optimization is not done for Linux or Mac yet. R=brettw BUG=29591 TEST=none Review URL: http://codereview.chromium.org/506013 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/506075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34953 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: correctly fix Omnibox drawing (again), and make the focus ring come back.viettrungluu@chromium.org2009-12-182-55/+29
| | | | | | | | | | | (Somehow I managed to miss the drawing code I should have modified before.) BUG=30188,30716 TEST=Make sure Omnibox border draws correctly (zoom in closely and look) and matches the buttons; do so with a wide variety of themes. Make sure the blue focus ring appears when appropriate. Review URL: http://codereview.chromium.org/501103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34952 0039d316-1c4b-4281-b951-d872f2087c98
* Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.darin@chromium.org2009-12-1827-510/+380
| | | | | | | | | | | | | | | | | | | | | | The combined IPC means that scrolling only requires one transport DIB instead of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels for the exposed region, and then we'd use a second one in the PaintRect IPC to pass up the pixels for the updated scroll bar rendering. Now all paints are done using a single transport DIB. Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions. This means calling GetUpdateRgn and GetRegionData to enumerate the list of damage rects. Then only those rects are copied from the backing store. The same optimization is not done for Linux or Mac yet. R=brettw BUG=29591 TEST=none Review URL: http://codereview.chromium.org/506013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34951 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 275.0 to 276.0chrome-bot@google.com2009-12-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34946 0039d316-1c4b-4281-b951-d872f2087c98
* Shut down fontconfig in test_shell to lower the amount of memory leaked inevan@chromium.org2009-12-181-0/+1
| | | | | | | | | | | | | | | fontconfig. The remaining leaks are due to static variables in pango holding references to fontconfig data structures. These should go away for a more up to date version of pango. BUG=9245 TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes Patch by Jochen Eisinger <eisinger@google.com>. Review URL: http://codereview.chromium.org/507038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34945 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.0.5sgjesse@chromium.org2009-12-181-1/+1
| | | | | | | | | | This gets the version of V8 which allows for larger map space. TEST=none BUG=http://crbug.com/29428 Review URL: http://codereview.chromium.org/505050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34944 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the tcmalloc patch for Valgrind.glider@chromium.org2009-12-182-18/+39
| | | | | | | | | Now Valgrind is able to intercept bash and Python allocation functions. This prevents ui_tests from crashing because of mismatched malloc/sh_malloc/free/sh_free calls inside Bash. Review URL: http://codereview.chromium.org/502029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34943 0039d316-1c4b-4281-b951-d872f2087c98
* Add a keyboard shortcut on Escape that emits the IDC_STOP command.thakis@chromium.org2009-12-187-7/+81
| | | | | | | | | | BUG=20916 TEST=Load something big (http://cnn.com/) and hit escape. Page load will stop. Review URL: http://codereview.chromium.org/491023 Patch from Jochen Eisinger. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34942 0039d316-1c4b-4281-b951-d872f2087c98