| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
defined in the WebCore namespace (it isn't in any of the other ports).
Review URL: http://codereview.chromium.org/7680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and identify revisions where the tests started failing.
Review URL: http://codereview.chromium.org/7527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
JavaScriptCore/wtf.
R=dglazkov
Review URL: http://codereview.chromium.org/7677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an issue with a windowed flash instance not rendering content at times.The bug occurs as a result of the following:-1. The flash plugin executes a script via GetURLNotify. This script calls window.open with the target as self, which shows up as a new tab in the browser. This causes a new RenderView object to be instantiated (See RenderView::CreateWebView).2. RenderView::CreateWebView sends over the ViewHostMsg_CreateWindow IPC message to the browser. The handler in the browser sends over an ack for this message with the window handle. This is used as the parent window for any plugins instantiated in the page.3. At times, the newly created view starts receiving data which is processed before the ViewMsg_CreatingNew_ACK message is received and processed by the view. This causes the plugin to be instantiated without a parent window thus ending up as a top level window.The fix is to queue up resource messages and process them after we receive the ack for the ViewHostMsg_CreateWindow IPC.
Tests :- Covered by UI tests.
R=jam
Review URL: http://codereview.chromium.org/7514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the style.
Review URL: http://codereview.chromium.org/7624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
correctly.
TBR=sky
Review URL: http://codereview.chromium.org/7333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Implement BindToWindowObject for JSC.
Review URL: http://codereview.chromium.org/7673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rollback was not needed to correct distributed test regression.
This reverts changes in 3608, which were done to try to repair the
regression.
r=huanr
Review URL: http://codereview.chromium.org/7522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Construct the $THIRD_PARTY_DIR and $WEBKIT_DIR variables consistently
with other $*_DIR variables.
Don't execute test scripts from the VariantDir by default; everything
isn't installed in the proper place yet.
Use the 'build_component' variable from the submodule SConstruct
files to restrict how much we build by default (e.g. don't try to
build all of webkit if you're only working in base or net).
Review URL: http://codereview.chromium.org/7524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
too timing-sensitive.
Review URL: http://codereview.chromium.org/7671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(V8Bindings, libport and WebCore being the most significant example.) Since the
GNU linker does only a single pass over the archives we need some extra
trickery to deal with these unavoidable cycles. That trickey is --start-group
and --end-group (aka -( and -) ). That causes ld to loop over the group until
no more undefined symbols are found. In an ideal world we would only make
groups from those libraries which we knew to be in cycles. However, that's
tough with SCons, so we bodge it by making all the archives a group by
redefining the linking command here.
Review URL: http://codereview.chromium.org/7523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was just an artifact of how I changed my mind a number of times during the AutocompleteEdit model/view split and failed to ultimately do the right thing here.
BUG=2901
Review URL: http://codereview.chromium.org/7672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think I've finally fixed this. Knock on wood. Turns out that these two
additional places do non-client rendering:
- DefWindowProc for WM_NCLBUTTONDOWN
- the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu)
For the first case, we also need to unlock updating when we begin to receive
mouse move events during modal size/move loops, otherwise the feedback won't be
visually continuous.
http://crbug.com/3264
Review URL: http://codereview.chromium.org/7662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebFrameImpl::CreateChildFrame is based on third_party/WebKit/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp, which is based on WebKit/mac/WebView/WebFrame.mm:_loadURL. WebKit change 31264
(http://trac.webkit.org/changeset/31264/trunk/WebKit/mac/WebView/WebFrame.mm), fixed this bug on Mac, but was never ported to Windows, so webframe_impl.cc didn't get that fix. (FYI, WebFrame.mm:_loadURL has since moved to WebCore/loader/FrameLoader.cpp, with the appropriate changes.)
Note that these layout tests also fail for WebKit on Windows (disabled in LayoutTests/platform/win/Skipped). This same change still needs to be made upstream to WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp.
Review URL: http://codereview.chromium.org/7503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Add error strings in Chrome installer.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mimetypearray. In order to get this working, I had to
change the v8 templates to allow for both void* and
RefPtr<> types.
This has a short-term hack for using namedItem instead
of nameGetter, which I will be able to undo once I fix
https://bugs.webkit.org/show_bug.cgi?id=21606
Also, unforks Navigator.h, which will need some love
from scons/mac folk for updating build files since
Navigator.h/cpp have moved.
Review URL: http://codereview.chromium.org/7373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
available on the default Win XP/Vista installation) and
the default fantasy font to 'Impact'. 'Impact' is not a 'fantasy'
font, but there's no suitable font to use on the default Win XP.
Fantasy is very rarely used so that this should not matter.
In addition, change the serif font for Simplifed Chinese Chrome
to Simsun from Simhei. The current setting is :
A. serif : simhei
sans-serif : simsun
monospace : nsimsun
What we should have if we want to keep the diestinction between serif and sans-serif in Simplified Chinese Chrome
B. serif : simsun
sans-serif: simhei
monospace : nsimsun
(Chinese has different typographic traditions from the western so that mapping is 'approximate')
However, Simhei is rather ugly so that we do the following (losing the distinction between serif and sans-serif)
C. serif: simsun
sans-serif: simsun
monospace: nsimsun
So, for both serif and sans-serif, we just
use Simsun. With that, even in rare occassions (for Chinese web sites)
where serif is specified, we'd use Simsun rather than Simhei.
BUG=2830
Review URL: http://codereview.chromium.org/7653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/7654
Patch by tulrich@google.com, reviewed by pkasting
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe
Review URL: http://codereview.chromium.org/7520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with fewer restrictions. Change the tests accordingly.
BUG=3542
Review URL: http://codereview.chromium.org/7496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff, pinkerton
Review URL: http://codereview.chromium.org/7510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
vary indepdendently.
Review URL: http://codereview.chromium.org/7632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes definition of a FieldTrial class to support this.
I have thoughts in my head about how this will eventually
extend to be controllable via UMA (as well as being able
to run tests defined at compile time, as was done in this
example.
r=mbelshe, mmentovai
Review URL: http://codereview.chromium.org/7638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we know where they should be placed, instead of waiting until the Layout call to do so. This fixes an issue of the links not appearing at all -- something, that I can't reproduce myself, but Darin could on his Vista machine (until he tried this fix).
Review URL: http://codereview.chromium.org/7513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plotting log parser.
BUG=b/1221588
TEST=once scripts and data are also switched, perf tests still plot
Review URL: http://codereview.chromium.org/6431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently.
I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit.
I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it.
Review URL: http://codereview.chromium.org/7650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
patch by icefox (Torchmobile) at http://codereview.chromium.org/7488
Review URL: http://codereview.chromium.org/7658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7656
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PLATFORM(CHROMIUM) being referenced in ScrollView.h and Widget.h.
I predict that you will still see green!
TBR=pinkerton
Review URL: http://codereview.chromium.org/7655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/7509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/7652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/7508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/7649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
port/platform/chromium/PlatformKeyboardEventChromium.cpp
- this is KeyEventWin.cpp renamed and mostly deleted. we just needed to define two static methods.
- the big switch case goes to event_conversion.cc.
port/platform/chromium/DragDataChromium.cpp
- yay, no more dropData wrapper!
port/platform/chromium/TemporaryLinkStubs.cpp
- just stubbing scheduleDispatchFunctionsOnMainThread() for now since i think we should really use an implementation based on MessageLoop, and we don't use background threads in webkit yet.
port/platform/chromium/DragImageChromium.cpp
- PLATFORM(WIN) to PLATFORM(WIN_OS)
port/platform/chromium/PopupMenuChromium.cpp
- lots of nice cleanup. no more dummy HWNDs!
port/platform/chromium/PlatformScrollBarChromium.cpp
port/platform/chromium/ScrollViewChromium.cpp
- GraphicsContext::getWindowsContext is gone. just use the skia canvas directly.
port/platform/network/chromium/NetworkStateNotifierChromium.cpp
- delete the PLATFORM(WIN) stubs
port/platform/win/KeyEventWin.cpp
port/platform/win/PlatformMouseEventWin.cpp
port/platform/graphics/IntPointWin.cpp
port/platform/graphics/IntSizeWin.cpp
port/platform/graphics/IntRectWin.cpp
- deleted :)
port/platform/win/ScreenWin.cpp
- compensate for no longer having implicit conversion between RECT and IntRect
port/platform/UniscribeStateTextRun.cpp
- scriptCache and scriptFontProperties now live on FontPlatformData as discussed with brett and hyatt.
port/platform/graphics/FontCacheWin.cpp
- getFontLinkInterface() function doesn't exist outside of PLATFORM(WIN)
port/platform/graphics/FontPlatformData.h
port/platform/graphics/FontPlatformDataWin.cpp
- support storing script{Cache,FontProperties} on FontPlatformData. need to implement assignment operator and copy constructor. the script{Cache,FontProperties} objects are not copied per discussion with hyatt.
- i moved m_isMLangFont into RefCountedHFONT so that we would know how to "destroy" the HFONT.
port/platform/graphics/SimpleFontDataWin.cpp
port/platform/graphics/GlyphPageTreeNodeWin.cpp
- modified to support changes to FontPlatformData
port/platform/graphics/ImageSkia.cpp
- getHBITMAP, etc. were never used and are not needed
port/platform/graphics/IconWin.cpp
- modifications corresponding to my changes to Icon.h. m_icon is of type PlatformIcon.
port/platform/graphics/GraphicsContextSkia.cpp
- {get,release}WindowsContext are no longer defined
port/platform/Cursor.h
pending/NetworkStateNotifier.h
pending/PlatformKeyboardEvent.h
- we no longer need to fork these files.
port/page/chromium/EventHandlerChromium.cpp
- add #include "Clipboard.h" to support non-WIN_OS
port/page/chromium/AccessibilityObjectWrapper.h
- changed to no longer be a COM interface
port/page/AccessibilityObjectWrapperWin.h
- moved to port/page/chromium/AccessibilityObjectWrapper.h
pending/AccessibleBase.cpp
pending/AccessibleBase.h
- modified to support changes to a11y wrapper class
- by the way, these files should not be in pending! will fix that later.
glue/glue_util.cc
glue/glue_util.h
- add conversion functions for rect structures.
glue/webframe_impl.cc
glue/webplugin_impl.cc
- use new webkit_glue rect conversion functions.
glue/glue_accessibility.cc
- add header that is needed to build this file on windows
glue/webview_impl.cc
- no longer supports auto-conversion between IntPoint and POINT
glue/event_conversion.cc
- initialize by modifying member variables of the base class directly.
- moved a static function from KeyEventWin.cpp
R=tony,brettw
BUG=3488
Review URL: http://codereview.chromium.org/7495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GetProfilePersonalization returns a pointer.
Review URL: http://codereview.chromium.org/7639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3582 0039d316-1c4b-4281-b951-d872f2087c98
|