summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Bring back SimpleThread, but with a Delegate interface.deanm@google.com2008-08-296-0/+306
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1519 0039d316-1c4b-4281-b951-d872f2087c98
* fix base_unittets bustage observed on mac/linuxdarin@google.com2008-08-291-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1516 0039d316-1c4b-4281-b951-d872f2087c98
* Get a good piece of port building under Linux.erg@google.com2008-08-296-93/+105
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1515 0039d316-1c4b-4281-b951-d872f2087c98
* fix purify errordarin@google.com2008-08-281-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1514 0039d316-1c4b-4281-b951-d872f2087c98
* Provide what looks like the minimal platform specific interface for skia. ↵erg@google.com2008-08-2810-4/+237
| | | | | | This will undoubtedly grow in the future. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1513 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ClearBrowsingDataView that can only occur during thesky@google.com2008-08-282-6/+19
| | | | | | | | | | | | | | automated tests. If the window is closed while a removal is in progress the BrowsingDataRemover would be left with a reference to a deleted object. This can only happen during automated testing as while clearing is in progress we don't allow the user to close the dialog. BUG=1138705 TEST=covered by automated test bot git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1512 0039d316-1c4b-4281-b951-d872f2087c98
* Reading the comments on a later change, it seems I should have only used a ↵dsh@google.com2008-08-281-1/+1
| | | | | | copyright of 2008 on this new file, so this fixes it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1509 0039d316-1c4b-4281-b951-d872f2087c98
* We should not EXPECT to get a browser object or a window object, we should ↵finnur@google.com2008-08-283-13/+18
| | | | | | ASSERT that we got it (which ends the test on NULL pointers). Otherwise we continue on and crash when we try to use these pointers, such as when passing it into GetBrowserForWindow. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1508 0039d316-1c4b-4281-b951-d872f2087c98
* Forgotten unit test chanes.brettw@google.com2008-08-284-9/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1507 0039d316-1c4b-4281-b951-d872f2087c98
* Make a step on refactoring navigation. The eventual plan is to have the ↵brettw@google.com2008-08-2812-255/+299
| | | | | | | | | | | | | NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable). This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed. Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway. BUG=1343593,1343146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1506 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tests that break with Chromium build.rahulk@google.com2008-08-283-3/+20
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1505 0039d316-1c4b-4281-b951-d872f2087c98
* If we receive an HTTP authentication header with a non-ASCIIwtc@google.com2008-08-281-3/+3
| | | | | | | | | | | | | realm string, the ASCIIToWide call in PopulateAuthChallenge hits a DCHECK failure. Change the ASCIIToWide call to a base::SysNativeMBToWide call, which produces the correct result when the OS "language for non-Unicode programs" is set to the language of the realm string. R=darin,jungshik BUG=1348130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1504 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run the big script every time.erg@google.com2008-08-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1503 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify OneShotTimer and RepeatingTimer. Fix up all consumers.darin@google.com2008-08-2828-259/+469
| | | | | | | | | | | | | | | | | | | | | | | | Major changes: OneShotTimer and RepeatingTimer become template classes that no longer require a Task or a Timer object. They just use PostDelayedTask. Under the hood that still uses a Timer object. The API is much simpler for consumers as they now no longer need to worry about allocating a Task or managing the lifetime of the object pointer held by the Task. I added some new unit tests to timer_unittest.cc to cover the API. I preserved the old TimerManager / Timer API for now, but I plan to soon kill it. R=brettw BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in TaskManager. I'm skeptical this is it, butsky@google.com2008-08-281-2/+2
| | | | | | | | | | it's worth a shot. BUG=1345092 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1501 0039d316-1c4b-4281-b951-d872f2087c98
* Forgotten a rebaselined testcase.dglazkov@google.com2008-08-281-0/+29
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1500 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the redness in the interactive test. We were using GetActiveWindow ↵finnur@google.com2008-08-281-6/+5
| | | | | | to get the Browser window, which internally uses ::GetForegroundWindow(). This means that when other application windows are on top we fail to get the Browser window. By switching to GetLastActiveWindow() we avoid that. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1498 0039d316-1c4b-4281-b951-d872f2087c98
* Another layout test fix. Technically, this is a test_shell tweak to avoid ↵dglazkov@google.com2008-08-289-18/+9
| | | | | | frame focus-related side effects when tests are run in a sequence. For more information, see http://b/issue?id=845337This change also restores the baseline of frame-click-focus-expected test to the original one by Apple WebKit. See http://b/issue?id=759889 for details. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1497 0039d316-1c4b-4281-b951-d872f2087c98
* The GetWindowRect must return the rect of the container HWND; not the actual ↵erg@google.com2008-08-289-12/+36
| | | | | | | | | | window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls. So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect(). BUG=1344367,1186573,1334505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1496 0039d316-1c4b-4281-b951-d872f2087c98
* This call is incorrect because calling it here allows any subframe to update ↵mmoss@google.com2008-08-281-4/+0
| | | | | | | | | | "is_loading_", which represents state on the main frame, and thus should only be updated to reflect changes to that frame (as ProgressTracker is careful to do by testing "m_originatingProgressFrame"). It's also redundant because it is already triggered through the ProgressTracker, even when there is a ProvisionalLoad error. This fixes issues where the favicon for a page was not being loaded because of errors in subframes. BUG=1186854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1495 0039d316-1c4b-4281-b951-d872f2087c98
* Enable logging on memory tests for debugging.mbelshe@google.com2008-08-281-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1494 0039d316-1c4b-4281-b951-d872f2087c98
* WorkerPool implementation for Mac, using NSOperationQueuemmentovai@google.com2008-08-284-1/+148
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1493 0039d316-1c4b-4281-b951-d872f2087c98
* Split the AutocompletePopup into model and view classes, step 1.pkasting@google.com2008-08-285-821/+791
| | | | | | | | | | | | The just adds "Model" and "View" to the end of the current classname, leaves everything in the same files, and doesn't really change or remove any functionality, creation order, ownership semantics, etc. In other words, it's basically just moving some code around to get things split into two classes, and the harder work comes later. Also removes/trims some overly long comments, fixes a couple comment errors I noticed, and trims one or two bits of logic to be shorter. What really needs review the most is the high-level decisions about how to split data and functionality between the two classes. BUG=1343512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1492 0039d316-1c4b-4281-b951-d872f2087c98
* No code change, just changing a comment (a nit from my previous review). ↵finnur@google.com2008-08-281-3/+3
| | | | | | | | | This fixes that. TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1491 0039d316-1c4b-4281-b951-d872f2087c98
* fix typorahulk@google.com2008-08-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1490 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style = LF and normalize newlines as on other filesmmentovai@google.com2008-08-285-35/+38
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1489 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test to catch regressions where the Find box moves when you open ↵finnur@google.com2008-08-2812-71/+274
| | | | | | | | | | | and close a tab. Test is disabled until we fix the bug. Also made the error message for when tests fails because crash_service isn't running a bit explicit (unrelated to the rest of this change). BUG=1343052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1488 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where we were no longer deleting TabContents whensky@google.com2008-08-282-11/+21
| | | | | | | | | | navigating to a new TabContents. BUG=1349274 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1487 0039d316-1c4b-4281-b951-d872f2087c98
* Use distribution specific branding for binaries version stamp.rahulk@google.com2008-08-284-7/+12
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1486 0039d316-1c4b-4281-b951-d872f2087c98
* Bring EventHandlerMac.mm over from WebKit to port so that we can turn off ↵avi@google.com2008-08-281-0/+641
| | | | | | some of the direct layer-breaking behavior that Apple provides. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1485 0039d316-1c4b-4281-b951-d872f2087c98
* The main thread of test_shell.exe needs to have a UI message loop.darin@google.com2008-08-281-1/+1
| | | | | | I overlooked this in my previous CL that introduced the different ML types. This actually has no functional impact today since the ML does not yet do anything based on the selected ML type. But, it soon will! git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of safebrowsing database removing an add for a hostname when it ↵jabdelmalek@google.com2008-08-282-2/+31
| | | | | | | | got a sub for some prefixes. BUG=1315628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1481 0039d316-1c4b-4281-b951-d872f2087c98
* Add region-specific suggest URLs for Yahoo_xx search engines where suggest ↵jungshik@google.com2008-08-281-45/+86
| | | | | | | | | | | | | | | | | | | | | | service is available. Add utf8 output flag to Naver (#1 engine in Korea) so that JSON comes back in UTF-8. meta.ua (Ukraine search engine) was changed similarly. Change the url for Yahoo_sg to sg.yahoo.com (from tw.yahoo.com) and that for Yahoo_nz to nz.yahoo.com (from sg.yahoo.com) Disable the suggestion service for Daum because it returns the result in EUC-KR and currently we assume it's in UTF-8 (issue 1293145). Also disable Yahoo_xx's that do not offer suggestion/ac services. We can do some mappings (e.g. at, ch => de, qc => ca or fr, hk => tw or en and nl,no,dk, fi => en, the rational for the last being that English proficiency of general public in those countries is rather good.), but disable it for now. BUG=1342120 TEST=Install various language versions of Chrome and set the default search engines to a regional Yahoo variant and see if suggest works in the omnibar. Install Korean Chrome and set the default search engine to Naver and see if suggesst works. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1480 0039d316-1c4b-4281-b951-d872f2087c98
* Check the return value of GetFontUnicodeRange. If it fails, call ↵jungshik@google.com2008-08-281-1/+14
| | | | | | | | | | | | | | | EnsureFontLoaded (to load font in the browser process) and try again. Google Georgian is the easiest to reproduce and test, but a similar symptom was reported for Chinese and Japanese pages. BUG=1346275 TEST=In Simplified Chinese XP VM, go to http://www.google.ge and see Georgian characters are rendered correctly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1477 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure Cocoa sets up its multithreaded environmentmmentovai@google.com2008-08-285-10/+74
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1476 0039d316-1c4b-4281-b951-d872f2087c98
* Run some disk cache unit tests on the Macmmentovai@google.com2008-08-2810-34/+59
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1475 0039d316-1c4b-4281-b951-d872f2087c98
* Change Chrome references to Chromium on about:memory page. rahulk@google.com2008-08-282-4/+4
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1474 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Google Chrome specific strings from common resources file and use ↵rahulk@google.com2008-08-27126-2151/+319
| | | | | | | | | them from new resources file that is specific to only Google Chrome. BUG=1110882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1473 0039d316-1c4b-4281-b951-d872f2087c98
* [1 of 3] Get rid of test_shell/resources/fonts/*ericroman@google.com2008-08-272-44/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1472 0039d316-1c4b-4281-b951-d872f2087c98
* fix build breakrahulk@google.com2008-08-271-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1471 0039d316-1c4b-4281-b951-d872f2087c98
* fix build breakrahulk@google.com2008-08-271-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1470 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 148 that got submitted by mistake and is not ready yet.rahulk@google.com2008-08-2742-0/+2142
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1469 0039d316-1c4b-4281-b951-d872f2087c98
* Add new generated_resources.grd file (with all references to Google Chrome ↵rahulk@google.com2008-08-2742-2142/+0
| | | | | | | | | removed) and its 41 translation files. Also add distribution specific strings rc file depending on compile time flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1468 0039d316-1c4b-4281-b951-d872f2087c98
* Add distribution specific strings. rahulk@google.com2008-08-2744-0/+2432
| | | | | | | | | | | Google Chrome specific strings also have translation files for them. Chromium strings are all going to be in English for now (that how the chromium_strings.grd file is defined). Even though this change generates google_chrome_strings_*.rc/chromium_strings_*.rc files we do not use them yet. The next change will use these rc files and delete the same strings from generated_resources.grd BUG=1110882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1467 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for WorkerPool and add a working but poor implementation for ↵dsh@google.com2008-08-273-1/+83
| | | | | | Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1466 0039d316-1c4b-4281-b951-d872f2087c98
* Send the close browser window command via a automation messagejoshia@google.com2008-08-271-12/+12
| | | | | | | | | | | | | | instead of directly posting a WM_CLOSE to the browser window. This is a speculative fix to avoid the crash during automated UI tests. The theory is that the automation message will arrive after the other automation commands and would give a chance for graceful shutdown. BUG=1145714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1465 0039d316-1c4b-4281-b951-d872f2087c98
* Move std::string16 to base::string16. Don't pollute the std namespace. Don'tmmentovai@google.com2008-08-2713-155/+178
| | | | | | assume that all string types can be represented as std::basic_string<CHAR>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1464 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct decls for non-windows platforms. Create a platform-neutral ↵pinkerton@google.com2008-08-272-4/+11
| | | | | | wrapper for everyone to use. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1463 0039d316-1c4b-4281-b951-d872f2087c98
* Add more net unit tests to linux.rvargas@google.com2008-08-271-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1461 0039d316-1c4b-4281-b951-d872f2087c98
* Some more passing tests in base for Linuxmmentovai@google.com2008-08-274-64/+37
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1460 0039d316-1c4b-4281-b951-d872f2087c98