| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
startup without doing the cocoa locale force (since it isn't valid there).
BUG=none
TEST=ntp tips, history times stamps, etc. all still in the right locale
Review URL: http://codereview.chromium.org/449076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
frame builder.
Fixes as below:-
1. Instantiate the SystemMonitor object as it is needed to instantiate the profile.
2. Adds the single-process command line to the chrome_frame_net_tests executable to ensure
that the webkit thread gets initialized correctly.
3. Register additional prefs in the profile to get around some DCHECKS which fire in debug
mode
TBR=tommi
Review URL: http://codereview.chromium.org/464001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/23058
TEST=none
Review URL: http://codereview.chromium.org/460015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/453012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bindings patch has been landed that should take care of this one.
BUG=29041
TEST=none
Review URL: http://codereview.chromium.org/459014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unflaky tests on Mac.
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=list-marker.html,single-character-pi-stylesheet.xhtml,cache-override.html,bug28341.html,access-control-basic-allow-preflight-cache-invalidation-by-method.html,xmlhttprequest-no-content-length-onProgress.html,xmlhttprequest-setrequestheader-no-value.html
BUG=18978,10323,10361,23473,28417,29167
TEST=none
Review URL: http://codereview.chromium.org/462005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than Chromium specific, and clean up a few headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/459013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/459012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/457025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not flaky LayoutTests/websocket/tests/frame-length-skip.html
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=websocket
BUG=28044
TEST=none
Review URL: http://codereview.chromium.org/460011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/459011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28266
TEST=trybots
Review URL: http://codereview.chromium.org/462003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UrlmonUrlRequest::EndRequestInternal task
executing and the OnStopBinding function getting called by Urlmon. If our task executes first we essentially
operate on an invalid object.
Fixes http://code.google.com/p/chromium/issues/detail?id=29033
Added a comment to the EndRequest function indicating that it is invalid to access any members after it
is called. Added a helper function to release the bindings and revoke the bind status callback.
Bug=29033
Review URL: http://codereview.chromium.org/456013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/455028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/458006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/repaint/list-marker.html
LayoutTests/css2.1/t1205-c561-list-displ-00-b.html
LayoutTests/css2.1/t1205-c565-list-pos-00-b.html
LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag.html
They are marked as expected failures in
http://codereview.chromium.org/454017
The list-marker one is a bit trickier than others.
The position of texts after the list makers were wrong in expected image.
However, it seems italic-styled character 'p' is lacking with the current
test_shell and this is why it was marked as an expected failure.
As its dump render tree result is correct, I've just rebaselined the text
and added some comments on test_expectations.txt.
Note that the following upstream change will fix the rest tests.
https://bugs.webkit.org/show_bug.cgi?id=32014
BUG=28183
TEST=trybots
Review URL: http://codereview.chromium.org/450033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29157
TEST=none
Review URL: http://codereview.chromium.org/460010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of resource loading from WebKit into the network stack.
In order to fully make these work, webkit changes are needed
as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
declaration order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/460008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/461002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of storing pointers into a vector, store offsets. That
way, if the vector resizes, we should still be OK.
Also, add a DCHECK that we only enter this method once, which
is my current assumption.
Review URL: http://codereview.chromium.org/457028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/460006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/460007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29149
Review URL: http://codereview.chromium.org/460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SIGTERM and SIGINT handler for player_x11 tool so that it terminates
the media pipeline properly when CTRL+C is received.
Review URL: http://codereview.chromium.org/450030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SVN .ignore file is added in r23. No code change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28276
TEST=dump_syms works with ToT Chrome.
Review URL: http://codereview.chromium.org/414049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes for a child window of the popup, as it is the case
with select popups.
BUG=28110
TEST=Make sure extension popups are still working as expected.
Open an extension popup with a select popup (combo box)
in it. Click on the select to bring up its popup, the
extension popup should stay opened.
Review URL: http://codereview.chromium.org/459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=no new tests; covered by existing layout test
BUG=none
Review URL: http://codereview.chromium.org/459004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
template magic
Review URL: http://codereview.chromium.org/414024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
collection.
BUG=28884
Review URL: http://codereview.chromium.org/455026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were accidentally setting the opacity to 1/255.
This bug was introduced in r32643. Fix the unittest too.
BUG=29107
Review URL: http://codereview.chromium.org/461003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accidentally
setting the opacity to 1/255.
This bug was introduced in r32643.
BUG=29107
Review URL: http://codereview.chromium.org/452040
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/460004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting the opacity to 1/255.
This bug was introduced in r32643.
BUG=29107
Review URL: http://codereview.chromium.org/452040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regroup tests failed due to the same reason.
R=japhet
TEST=none
BUG=3273,29059
Review URL: http://codereview.chromium.org/459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=29025
The crash occurs while dereferencing the automation channel to send out the SetCookie IPC message on the
automation channel to the host browser. Based on what I could see from the crash dump and the code
it seems like there could be a scenario where the AutomationResourceContext object could be destroyed
while the AutomationCookieStore object is still around and thus ends up with a stale pointer which crashes
when dereferenced.
Fix is to ensure that all related code paths hold on to a refcounted AutomationResourceContext instance.
I will look into whether it is possible to come up with a unit test for this.
Bug=29025
Review URL: http://codereview.chromium.org/450020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29096
Review URL: http://codereview.chromium.org/450043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark manager and bookmark bar.
BUG=29029
TEST=drag a bookmark into an <input> field
Review URL: http://codereview.chromium.org/449067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It gets buffered otherwise, which is inconvenient when trying
to follow what's going on in the Chrome OS window manager.
TEST=compiled and ran it
Review URL: http://codereview.chromium.org/459001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(We have a fixed profile per browser.) The Mac code never had this SetProfile().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/450038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Local State when writing to disk.
BUG=28836
Review URL: http://codereview.chromium.org/449074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=24182
Review URL: http://codereview.chromium.org/453024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
target.
Review URL: http://codereview.chromium.org/449070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=24182
Review URL: http://codereview.chromium.org/457030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add --copy option to omx_test for benchmarking
memcpy performance from the output of OpenMAX decoder.
Review URL: http://codereview.chromium.org/450031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33513 0039d316-1c4b-4281-b951-d872f2087c98
|