| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that isn't tied to the bookmark bar. Removes some dead code from the
bookmark bar, and fixes a UMR in chrome_menu that I found when running
under purify. There isn't any behavior change in this patch.
BUG=none
TEST=this is a large refactoring of how bookmark menus are
shown. Please thoroughly test menus on the bookmark bar to make sure I
didn't screw anything up.
Review URL: http://codereview.chromium.org/42128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There are situations in which the machine can return a time slightly earlier (up to a few ms) than it previously returned. Therefore, I paused for 50ms in between timer checks in order to compensate for this. This should hopefully fix the test.
Review URL: http://codereview.chromium.org/42001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
means of various crazy hacks.
Review URL: http://codereview.chromium.org/42106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(in favor of letting the gyp generator pass us $DESTINATION_ROOT,
which gives us the right absolute path name to the output directory).
Review URL: http://codereview.chromium.org/43108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=davemoore
Review URL: http://codereview.chromium.org/42134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/42135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some more suppressions to the suppressions file. I don't have any errors when running Chromium on my workstation.
Review URL: http://codereview.chromium.org/43129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_COPY_AND_ASSIGN
TBR=finnur
Review URL: http://codereview.chromium.org/43140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we can share code across platforms.
See http://code.google.com/p/chromium/wiki/FindBarRefactoring for
more information about the design.
Review URL: http://codereview.chromium.org/42057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/svg/dom/animated-tearoff-equality.xhtml
LayoutTests/svg/dom/animated-tearoff-lifespan.xhtml
in Release only.
The cause was the use of an invalid hash function.
Review URL: http://codereview.chromium.org/42094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trying to autoupdate, it looks like this was not the
cause of the failure.
Review URL: http://codereview.chromium.org/42126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
expectated behavior on both Windows and Linux.
Review URL: http://codereview.chromium.org/42120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Net agent.
Dom agent provides API for querying for DOM nodes and receiving notifications
on
Dom updates. It has some logic in and this logic is covered with the unit
tests.
Net agent pushes an initial set of request/response-related events to the
client. It is to be filled with more data later on. It currently caches loaders
for all the requests which is Ok for the case when this agent is turned ON (at
least for now).
Note that this code is not yet wired to the dev tools agent (this is by design).
The plan is to start enrolling the dev tools agent glue that connects these
sub-agents with the IPC transport once this CL is in.
Original CL: http://codereview.chromium.org/41008/show
Review URL: http://codereview.chromium.org/43128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy().
BUG=8707
Review URL: http://codereview.chromium.org/42119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows).
BUG=8236
Review URL: http://codereview.chromium.org/42074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Grab enter key events before they get to GtkTextView.
We need to do this, otherwise enter when text is selected
will replace the text, and we won't get a chance to catch
that happening. This might have problems with IME, but it
should be straightforward to fix anything IME related.
- Don't deselect when we lose focus. This sometimes looks a
bit strange, but it's the GTK thing to do. This also unbreaks
copy and paste via the context menu, since popping up the
context menu makes the GtkTextView lose focus.
- Rewrite the inefficent newline eater. This should now only be
needed for newlines that didn't come from the keyboard (like when
you paste text). Use the builtin iter support for finding line
boundaries, hopefully more efficient than checking the characters
one by one. Still might have some bad behavior when pasting a ton
of newline characters, but that can be improved later.
This fixes inline autocomplete, you can now hit the enter key on an
inline autocompleted suggestion, and you will get the intented navigation,
instead of the navigation with the selected completion removed.
This also adds support for alt-enter in Omnibox to navigate in a new tab.
BUG=8236
Review URL: http://codereview.chromium.org/43072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0.
Review URL: http://codereview.chromium.org/43077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This includes layout test rebaselining:
http://codereview.chromium.org/43011/show
http://codereview.chromium.org/39347/show
Review URL: http://codereview.chromium.org/43126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A race condition existed since the listener thread could dispatch messages in two ways: a task being posted to it, or because the dispatch messages event is set. The latter is needed to avoid deadlock when multiple SyncChannels are used on the same listener thread. If the latter method was used to dispatch a message, it might occur before the task that calls OnChannelConnected gets run.
The fix is to call OnChannelConnected manually if we notice a message is being dispatched before it's called.
Note: I couldn't think of a way to test this since it depends on a race condition in the listener message looop (whether the task or objectwatcher gets run first).
Review URL: http://codereview.chromium.org/42113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The bot was trying to auto-update... and no one was clicking "yes."
bug=8690
tbr=brettw
Review URL: http://codereview.chromium.org/42112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8655
TEST=see bug
Review URL: http://codereview.chromium.org/42103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes propset changes:
Property changes on: C:\clients\chrome6\src\skia
___________________________________________________________________
Modified: svn:ignore
- skia.xcodeproj
+ skia.xcodeproj
skia.sln
Property changes on: C:\clients\chrome6\src\third_party\zlib
___________________________________________________________________
Modified: svn:ignore
- zlib.xcodeproj
+ zlib.xcodeproj
zlib.sln
Property changes on: C:\clients\chrome6\src\third_party\libpng
___________________________________________________________________
Modified: svn:ignore
- libpng.xcodeproj
+ libpng.xcodeproj
libpng.sln
Property changes on: C:\clients\chrome6\src\third_party\libjpeg
___________________________________________________________________
Modified: svn:ignore
- libjpeg.xcodeproj
+ libjpeg.xcodeproj
libjpeg.sln
Property changes on: C:\clients\chrome6\src\build
___________________________________________________________________
Modified: svn:ignore
- all.xcodeproj
+ all.xcodeproj
all.sln
All.vcproj
Property changes on: C:\clients\chrome6\src\base
___________________________________________________________________
Modified: svn:ignore
- base.xcodeproj
+ base.xcodeproj
base.vcproj
base_gfx.vcproj
base_unittests.vcproj
debug_message.vcproj
Property changes on: C:\clients\chrome6\src\testing
___________________________________________________________________
Modified: svn:ignore
- gtest
gtest.xcodeproj
+ gtest
gtest.xcodeproj
gtest.sln
Review URL: http://codereview.chromium.org/43101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=brettw
Review URL: http://codereview.chromium.org/43118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"host_id". This allows ResourceDispatcher to be used by child processes other than renderers. I've done minor related cleanup on the way to make the code simpler.
Review URL: http://codereview.chromium.org/42054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
scripts the parent element to make it invisible/visible.
BUG=8657
Review URL: http://codereview.chromium.org/45005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It may be nicer to just have teh java test failing than all the tests.
Perhaps teh memory ordering is causing this... as the new (large set of)
failing test run before the disabled java test.
tbr=brettw
Review URL: http://codereview.chromium.org/43117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Modify DOM checker to work with the UI test framework.
- Add expected failure list for DOM checker.
Note that this only runs the tests over HTTP, not file:///.
BUG=6274
Review URL: http://codereview.chromium.org/43029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
being activated. Not sure why this worked in the first place and then regressed.
BUG=8318
Review URL: http://codereview.chromium.org/43107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsView. This makes TabContents less dependent on views.
This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically.
BUG=None
TEST=Run the interactive tests.
Review URL: http://codereview.chromium.org/39269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=abarth
Review URL: http://codereview.chromium.org/43112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=abarth
Review URL: http://codereview.chromium.org/42101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the intl1 performance regression
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11490 0039d316-1c4b-4281-b951-d872f2087c98
|