| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3012014
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3015013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser.custom_chrome_frame for now).
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3025007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2847058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44090
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3029016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49268
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2884031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for ethernet not getting detected in login screen
Old version would always chose the last available
ethernet service in the list. This change makes it
so it chooses a connected service over a unconnected
service.
BUG=None
TEST=Ran browser with this change
Review URL: http://codereview.chromium.org/3027015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/42028
TEST=Scroll. See scroll. See scroll faster.
Review URL: http://codereview.chromium.org/3030008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/49638
TEST=green tree
Review URL: http://codereview.chromium.org/2878041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step to make test server easier to use
and more reliable.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3040011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3017015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/2861070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2856052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
temporary workaround to prevent DOS'ing the browser with large profile data.
BUG=49172
TEST=WebDatabase.*
Review URL: http://codereview.chromium.org/2811059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In my previous patch today, I moved LIBXML_STATIC into a Windows-only
block in the gyp file. It turns out I misread the #defines and it's
not needed on any OS.
libxml.h has this:
#ifndef PIC
# define LIBXML_STATIC
#endif
The PIC define mentioned there appears to be a Linuxism, which is fine
for us because we want it to be static anyway.
Review URL: http://codereview.chromium.org/2825052
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/3049004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
artifacts caused by the toolbar border/highlight not matching the tab's. Also clean up the tab view class a bit.
http://cl.ly/09ac3bec2f1e0eca91db
TEST=visual
BUG=44574
Review URL: http://codereview.chromium.org/2834059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49346,46516
TEST=manual, unit tests
Review URL: http://codereview.chromium.org/2884027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=sargrass
TEST=bots go green
Review URL: http://codereview.chromium.org/3012014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46886
TEST=Valgrind net gets greener.
Review URL: http://codereview.chromium.org/3056006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a wrapper window class on top of GtkWindow to intercept its
move_focus method, so that we can handle focus traversing by ourselves.
BUG=49204: Chrome/views toolbar "tab" accessibility broken.
TEST=See bug report.
Review URL: http://codereview.chromium.org/3013006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In my previous patch today, I moved LIBXML_STATIC into a Windows-only
block in the gyp file. It turns out I misread the #defines and it's
not needed on any OS.
libxml.h has this:
#ifndef PIC
# define LIBXML_STATIC
#endif
The PIC define mentioned there appears to be a Linuxism, which is fine
for us because we want it to be static anyway.
Review URL: http://codereview.chromium.org/2825052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2809059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
You need shell=True on Windows for it to understand PATH.
(Python's subprocess module is confusing: the Windows semantics
are significantly different than the Unix ones. Either way on
Windows, the command array is flattened and shell-escaped.)
Review URL: http://codereview.chromium.org/3032009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/49638
TEST=green tree
Review URL: http://codereview.chromium.org/2824065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the browser with extremely large field data.
BUG=49332
TEST=none
Review URL: http://codereview.chromium.org/2811058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
Review URL: http://codereview.chromium.org/3029015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2805088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The URL field doesn't yet enable/disable based on the radio button selection; that will be a follow-up.
BUG=48713
TEST=Radio buttons and URL field on the Basics page should work.
Review URL: http://codereview.chromium.org/3025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppressions to the right file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3022017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ouch I typed in the wrong path. Now it is correct.
TBR=awong
Review URL: http://codereview.chromium.org/3035013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(AllBrowsersClosed()->AllBrowsersClosedAndAppExiting()).
TBR=pinkerton
Review URL: http://codereview.chromium.org/2832065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added "gfx/" to media/DEPS
TBR=pinkerton
Review URL: http://codereview.chromium.org/2861068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49346,46516
TEST=new unit tests, manual
Review URL: http://codereview.chromium.org/2884025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
headers to be terminated by
a single \r\n combination as wininet adds the terminating \r\n at the end while sending the headers out.
TBR=stoyan
Review URL: http://codereview.chromium.org/2888019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3017014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Made so that ResourceTracker keeps the refs-by-plugin count, and when the ppapi plugin releases the last reference, it UnRefs the resource.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2871027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49354
TEST=visual
Review URL: http://codereview.chromium.org/2834057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=49396
Review URL: http://codereview.chromium.org/2836060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49645
TEST=Set up sync, make sure throbbers that appear spin.
Review URL: http://codereview.chromium.org/3029012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it can be used on all platforms. Updated observers (ExtensionProcessManager,
BackgroundContents) to listen for APP_TERMINATING instead of listening for
BROWSER_CLOSED on some platforms.
APP_TERMINATING is now sent just before the main message loop exits rather than just after, but no code depends on this timing.
Updated Mac code to always call BrowserList::CloseAllBrowsers() even if there
are no open browsers, to ensure that APP_TERMINATING is always fired.
Changed BackgroundContentsService to keep the browser process alive when there
are BackgroundContents running and updated the unit tests.
Renamed BrowserList::IsInPersistentMode() => WillShutdownWhenLastBrowserCloses() and AllBrowsersClosed() => AllBrowsersClosedAndAppExiting() to more precisely indicate their true functions.
Exposed BrowserProcess::ModuleRefCount() so BrowserList can determine when the application is going to exit so the right notifications/callbacks can be generated.
Updated background-auto-update-restart code to use new BrowserList APIs to determine whether the application is running "in the background".
Added code to cancel shutdown on all plaforms if the user selects cancel in an onbeforeunload dialog.
BUG=45275
TEST=RunInBackgroundTest (ui_test)
Review URL: http://codereview.chromium.org/2866034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is follow-up from review http://codereview.chromium.org/2835041.
BUG=none
TEST=UserSettingsTest.PersistEmptyToken, UserSettingsTest.PersistNonEmptyToken
Review URL: http://codereview.chromium.org/2854049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Reviewed: http://codereview.chromium.org/2812050/show
Submitted for: imcheng@google.com
Review URL: http://codereview.chromium.org/3003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- only compile IE stuff on Win
- delete unused vars, mismatched signage
- don't create the profile directory explicitly. CopyDirectory with recursive=true will move the directory *into* the target dir, rather than merging its contents with those of the target dir. The easiest workaround is to make the target dir non-existant, which changes the behavior to what we want.
- get rid of CRLF in the firefox2 history example, which was making the history import fail.
- relax NSSDecryptor::Decrypt.
BUG=none
TEST=ImporterTest runs/passes on all trybots
Review URL: http://codereview.chromium.org/2811036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
submit) that results in a 302 to GET the page to load.
BUG=49202
TEST=manual
Review URL: http://codereview.chromium.org/2806059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/49340
TEST=Open a bookmark folder.
With the VIEW MENU (not the keystroke), go fullscreen.
--> see "chrome" gone (unless mouse at top of screen); see bookmark menu gone.
With the VIEW MENU (not the keystroke), go normal-screen.
--> see no bookmark menu.
Review URL: http://codereview.chromium.org/3044012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6623/steps/memory%20test:%20unit/logs/stdio
BUG=49638
TEST=none
Review URL: http://codereview.chromium.org/2873053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
Review URL: http://codereview.chromium.org/3019012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<iostream> creates a static initializer. Most people don't need <iostream>
anyway--they really need <ostream> for operator<< overloads. <iostream>
should *never* be included in a header file; <iosfwd> exists for that purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3014015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginHandler references
This avoids problems where the objects disappear while the
ResourceDispatcherHostRequestInfo still holds pointers. In particular,
SSLClientAuthHandler handler adds and removes a reference to itself when the
user dismisses the dialog. ResourceDispatcherHost, however, still holds a
pointer and may attempt to notify it of a cancelled request. This stray write
may NULL out a useful field and crash.
BUG=49352
TEST=steps in bug report
Review URL: http://codereview.chromium.org/3043008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-ordered some of the
startup calls, most important being to call pa_threaded_mainloop_start() right away instead
of after further calls, and creating pa_context_ while the lock was held.
BUG=48553
TEST=See if Valgrind stops suppressing 48553
Review URL: http://codereview.chromium.org/2948013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53081 0039d316-1c4b-4281-b951-d872f2087c98
|