| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
In the browser, we currently assume that a page has not loaded until a load complete comes from the renderer. However, this does not appear to be the way WebKit behaves. One can move the focus on a webpage that has not completely loaded for example. In such cases, this patch sends a "fake" load complete to keep with our assumptions before allowing the original notification to go through our previous logic.
BUG=90787,93232
TEST=manual (OS X only).
Review URL: http://codereview.chromium.org/7712018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Un-disable the ReservedAccelerators test. Now seems to pass linux debug.
Get rid of usage of WaitForNavigationInCurrentTab
R=phajdan.jr@chromium.org
BUG=69475
TEST=browser_tests.*,interactive_ui_tests.*,ui_tests.*
Review URL: http://codereview.chromium.org/7693013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled failed test.
-find_in_page.FindMatchTests.testSearchInPDF
BUG=93956
TEST=Run above
Review URL: http://codereview.chromium.org/7714013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
was declared in content but defined in chrome. I initially tried to move the create method to be a member function on TabContentsView, but that would require passing in the ConstrainedWindowDelegate, which is a typedef to a chrome type. So instead I made the chrome code that called TabContents::CreateConstrainedDialog create the dialog.
BUG=76697
Review URL: http://codereview.chromium.org/7719020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac 10.5
It seems to take some time before Flash files can be loaded on Leopard.
These tests open a flash file right after launching the browser, and instead
of opening the flash, the browser downloads it, so it seems like the plugin
info isn't registered yet. This used to work in the past, so it's a
regression. Also, this happens only on 10.5
This CL works around the problem by calling GetPluginsInfo() which would
trigger the plugins to get registered.
BUG=94123
R=dennisjeffrey@chromium.org
TEST=
Review URL: http://codereview.chromium.org/7727002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This build flag will control which set of native types views builds with on various platforms.
Also fixes mouse event handling in the demo app so that the window can be moved.
http://crbug.com/84070
TEST=none
Review URL: http://codereview.chromium.org/7717015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OSX Lion changes when things are autoreleased WRT windows and field editors.
BUG=93927
TEST=unit_tests --gtest_filter=Autocomplete\*:Instant\* doesn't crash.
Review URL: http://codereview.chromium.org/7715015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=rolled output into NaCl
Review URL: http://codereview.chromium.org/7669034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages which are sent
by content(renderer) via the TabContentsDelegate. We eventually want to get rid of the pattern of sending
IPC messages from content and handling them in chrome and vice versa.
BUG=87335
Review URL: http://codereview.chromium.org/7721003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7671005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=93620
TEST=duration is allll good
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7715029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94087
TEST=no
R=smus@chromium.org
Review URL: http://codereview.chromium.org/7718029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are leaf nodes in moving tab_contents_view_gtk, and usage is sparse
enough that I'm just moving the headers and fixing up the three places that
they are included.
BUG=93804
TEST=none; code move
Review URL: http://codereview.chromium.org/7720014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The comment stated that gyp include paths come after cflags, but
that is not true: include paths come before cflags. Use the gyp
prepend operator just to be extra sure.
Review URL: http://codereview.chromium.org/7720016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a print preview tab and reload. Notice the print preview tab
title. It should be "Print - <Initiator tab title>".
Review URL: http://codereview.chromium.org/7698008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7718030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7717026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7631055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=90443
Review URL: http://codereview.chromium.org/7714012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are 2 sources of flakiness addressed in this CL:
1) There was previously no synchronization between submitting a webpage
form and having the autofill data updated internally within Chrome.
This has been fixed by encapsulating the form submission and the observer
waiting within a single automation hook.
2) NavigateToURL() may return before all fields in
a webpage form are ready to be accessed and filled in. I work around this
issue for now by waiting in the pyauto test until all form fields are
accessible, before proceeding to fill in and submit the form.
I've enabled the relevant pyauto tests that were previously disabled due
to this flakiness.
BUG=90232,89784
TEST=None
Review URL: http://codereview.chromium.org/7706025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content, but the implementations are in chrome. Instead ask the embedder to create a TabContentsView.
BUG=76697
Review URL: http://codereview.chromium.org/7717011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7631016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93245
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7701027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the KeyboardManager is a Singleton, it gets destroyed after all of views
goes away. Trying to destroy it (as a Widget) at that point causes problems that
can lead to crashes on shutdown. So split out the Widget and destroy it when chrome
is terminating to avoid such crashes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7721004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/7720025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Mask old PIN input.
* Old PIN restrictions.
BUG=chromium-os:14191
TEST=Manual.
Review URL: http://codereview.chromium.org/7714034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes all resource _impl's derive directly from ppapi::Resource so we
can share code better. This means removing PluginInstances and converting
them to PP_Instances.
This adds a new ResourceHelper static class to help in the conversion of
resources to PluginInstances for the _impl classes.
Overall the new code is in general slightly worse than the old because using
the ResourceHelper is more annoying than just calling instance() on the old
webkit::ppapi::Resource object. However, I'm hoping that, because this will
allow us to move more code into shared_impl and reduce duplicate logic, it
will eventually have a net positive effect.
This also adds a ScopedPPResource class that works just like a scoped_refptr. We need this in a few places. Most of the places that used the old ScopedResourceId class could be removed now since resources have PP_Resource IDs generated even when there's no plugin reference (this didn't use to be the case) so we can pass resources as input params to the plugin even when there's no plugin ref, as long as there's a scoped_refptr to the Resource.
Review URL: http://codereview.chromium.org/7669055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=90221, 93551
TEST=Valgrind
Review URL: http://codereview.chromium.org/7724002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93708
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7724001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7719027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for RLZ.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7715002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:19713
TEST=manual
Review URL: http://codereview.chromium.org/7582031
TBR=glotov@google.com
Review URL: http://codereview.chromium.org/7715028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"EH") even when launching a child passed in via
switches::kBrowserSubprocessPath.
This allows browser_tests to operate even with the strict process type checks
in ChromeMain.
BUG=90221, 93551
TEST=browser_tests (for example, PrerenderBrowserTest.PrerenderDelayLoadPlugin)
Review URL: http://codereview.chromium.org/7718024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Enforce PIN restrictions
* length: min 4 (max 8 is already restricted)
* only numeric symbols 0..9 and fn keys
2. Enforce PUK restrictions
* length: min 8 (max 8 is already restricted)
* only numeric symbols 0..9 and fn keys
3. Disable submit button when PIN/PUK entered value is not valid
4. Enter key should work as submit in PIN/PUK input areas.
5. New/old PIN fields should be masked.
BUG=chromium-os:14191
TEST=Manual.
Review URL: http://codereview.chromium.org/7721009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7685056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fourth attempt:
Switching IRT to be built inside the chrome build. Dropping the IRT download
step from the DEPS. Step3 of a many step plan to switch where ppapi + irt
are built.
Dropping download_nacl_irt because we no longer rely on a prebuilt copy.
Dropping irt download drop source tarball (assume people using it will have
to download / build their own nacl toolchain).
Old Review URL: http://codereview.chromium.org/7669058
Review URL: http://codereview.chromium.org/7701017
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/7701026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 97925 - Linux: allow linking directly with Kerberos instead of using dlopen.
dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.
BUG=92689
Review URL: http://codereview.chromium.org/7655046
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7719025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98029 0039d316-1c4b-4281-b951-d872f2087c98
|