| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handles are available.
Don't create a console, just attach to any existing console.
R=cpu
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3574008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/3673002/show.
BUG=38475
TEST=Next patch changes the callback mechanism TemplateURLFetcher to make it much more testable and adds tests. (I kept it out of this one to make this more focused.)
Review URL: http://codereview.chromium.org/3652003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3645003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are re-opened
and address profile created identical to existing address profile should not be saved
BUG=56308,49708
TEST=in the bugs
Review URL: http://codereview.chromium.org/3611015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
integration. This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3375002
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't drawing the new chromium scrollbars exactly the same
as webkit had, causing layout test failures.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/3697003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support
BUG=38475
TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true).
Review URL: http://codereview.chromium.org/3673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also track corruption separately for old and new file formats.
BUG=58552
TEST=none
Review URL: http://codereview.chromium.org/3632004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58567
TEST=none
Review URL: http://codereview.chromium.org/3710002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the authentication dialog is active, we have to re-layout because
the in-process text put on the button might be larger.
When setting up the desciption for enabled or disabled state, get the
containing scroll view to do the layout, because the height of the
description may have changed. Be nice to the user and make sure the
right things are visible again after that layout.
BUG=none
TEST=use a really long username to enable the cloud print proxy such that the description text wraps to 3 lines. The UI should stay all visible with nothing clipped.
Review URL: http://codereview.chromium.org/3701003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of methods that add and navigate tabs in Browser.
This function is intended to replace at least the following:
Browser::OpenURLAtIndex
Browser::AddTabWithURL
Browser::AddNewContents
... as well as the myriad other functions that call into these.
Right now it's just a standalone thing with a set of unit tests.
A TBD for me is to support singleton tabs. I'm going to work on that next.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3591011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- explicitly invalidate the tab contents (makes appearance of drop shadow less delayed/janky)
- correct color of closing infobar arrow
- correct color of infobar arrow after the top infobar was closed and a lower one of a different color took its place
BUG=48996
TEST=manual (see above)
Review URL: http://codereview.chromium.org/3656001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3375002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add FileUtilProxy::Create that does not leave a file_handle opened.
2. Update the file_util_operation to use FileUtilProxy::Create instead of FileUtilProxy::CreateOrOpen so that no other tasks get queued in before we close the handle.
BUG=58424,58473
TEST=fast/filesystem/
Review URL: http://codereview.chromium.org/3717001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58712
TEST=Sign in to sync with two-step verification account. SigninManagerTest.
Review URL: http://codereview.chromium.org/3702002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes issue 55475 (the Bookmarks manager being blocked with --disable-extensions)
BUG=55475
TEST=ExtensionsServiceTest
Review URL: http://codereview.chromium.org/3711002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows, only hide server data delete if switch is not set. Mirror to r62147.
nib changes:
- for the five "clear server data" items, hidden bound to !owner.isSyncVisible
- for the "clear server data" button, enabled bound to owner.isSyncEnabled, enabled2 bound to !isClearing
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3674005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56749,56750,57041,57185
TEST=none
TBR=patrick
Review URL: http://codereview.chromium.org/3667004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the relay_channel and syncer_event_channel in favor of having
listeners live on the SyncSessionContext and be notified
directly.
Remove some unnecessary event types and variables.
BUG=26339
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/3538011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in a timely manner, avoiding a subtle bug wherein enabling datatypes does not cause a resync.
BUG=56416
TEST=Disable all but one datatype, wait until last sync time is not "just now", re-enable. A resync should happen.
Review URL: http://codereview.chromium.org/3609004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is triggered by the secure infobars on the new tab page when toggling the floating bookmark bar. The reason it comes up is because it applies in the CairoShowRect() case, but not in the XShowRect() case.
BUG=none
TEST=manual; perf bots (after landing)
Review URL: http://codereview.chromium.org/3644001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open Chat Manager and a chat panel. Type in the panel until it reaches its max height. Roster and panel ht should match
Review URL: http://codereview.chromium.org/3721001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ppapi r282 fixes a clang warning. This should get the clang/mac bot green.
BUG=None
TEST=None
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
try to make the shadow follow the arrow's contour better with some fuzzy math.
BUG=48996
TEST=visual
Review URL: http://codereview.chromium.org/3674003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(ERR_INTERNET_DISCONNECTED)
on Windows and Mac.
BUG=56457
TEST=manual
Review URL: http://codereview.chromium.org/3714001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green bots
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/3669004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we lumped the intranet host warning in with mixed content warning. This calls it out as a separate warning.
BUG=58162
TEST=None
Review URL: http://codereview.chromium.org/3536019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open a page with an accelerated plugin (e.g., Unity). The pugin should not visibily animated to full size from the lower-left corner.
Review URL: http://codereview.chromium.org/3649003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is where the interesting is. The rest is something about video deinterlacing. It also speeds it up a bit.
Also formatted vendor and device IDs as hex since that is how they are usually presented.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3652001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the requested byte range looks wrong.
We postpone the decision about what to do with a cached
entry until we receive confirmation from the server, so
we cannot skip asking the server about it!.
This CL also makes it so that if the server returns 304
(so that our cached copy is curent), we don't destroy the
entry, and we return 416 (bad range request) to the caller.
BUG=58047
TEST=net_unittests
Review URL: http://codereview.chromium.org/3611013
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/3644005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prelim commit for renaming SSLNonSensitiveHostInfo to
SSLHostInfo.
No code change.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7598
TEST=manual. keyboard menu on oobe won't crash.
Review URL: http://codereview.chromium.org/3712002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change 'getSyncLogin' to 'getBrowserLogin', and add notion of the login
token to it (although this isn't actually sent yet).
BUG=58033
TEST=Should be covered by browser tests.
Review URL: http://codereview.chromium.org/3641001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the requested byte range looks wrong.
We postpone the decision about what to do with a cached
entry until we receive confirmation from the server, so
we cannot skip asking the server about it!.
This CL also makes it so that if the server returns 304
(so that our cached copy is curent), we don't destroy the
entry, and we return 416 (bad range request) to the caller.
BUG=58047
TEST=net_unittests
Review URL: http://codereview.chromium.org/3611013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also re-enable test on Windows (can't repro crashes)
BUG=56945,45595
TEST=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/3672003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53991
TEST=no
Review URL: http://codereview.chromium.org/3651001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Raise the bubble a little, so that it is aligned vertically with the bubble we use for the star icon.
Align the help center link at the bottom of the bubble with the rest of the text.
BUG=58538, 58480
TEST=None
Review URL: http://codereview.chromium.org/3702004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will help break down why it is slow.
BUG=54717
Review URL: http://codereview.chromium.org/3667003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new chrome switch --force-stub-libcros to force stub libcros use (even on the device).
This should help us isolate chrome from the rest of OS for testing purposes (VM autotest runs, testing
change like this one on the device).
BUG=chromium-os:7569
TEST=none
Review URL: http://codereview.chromium.org/3655003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
offscreen target is used.
This didn't happen for non-multisampled offscreen targets that didn't have a parent.
BUG=58557
TEST=None
Review URL: http://codereview.chromium.org/3654002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Add hide/show details for the result panel.
-Add option to load URLs from file.
-Add handling of one common redirection case: missing "/" at the end of a directory URL.
-Add handling of whitespace in URL input.
-Modify blank page handling.
-Modify to let the result panel refresh after each single run.
-Avoid error shown in debugger "Uncaught TypeError: Object DOMWindow has no method 'setUrl'".
-Avoid error shown in debugger "Error during tabs.remove: No tab with id xx" when the user closes the testing tab.
Contributed by Jianxia Ning <jning@google.com>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3532008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
amount of randomness. This will reduce the size of bookmark IDs by
20 bytes per object: meaning potential savings of 40-60 bytes per bookmark
SyncEntity.
Old and new server IDs (for example):
0DXKZkVqHIRcWYy00MzUzMjc1MDMzNjU1MDIzOTkyeDgxNjQ4NzEyNjczODUyMTk4NzB4fC02NTUzOQ
0DXKZkVqHIRcWYzBaWVRHN29zdzV4OFpTR1RWSE1STEE9PXwtMg
BUG=
TEST=
Review URL: http://codereview.chromium.org/3614015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added accessors.
BUG=58556
TEST=DirectoryBackingStore tests
Review URL: http://codereview.chromium.org/3664002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a stub file called browser_thread.h that includes chrome_thread.h.
- Use this new file instead of chrome_thread.h under chromeos directory.
BUG=56926
TEST=trybots and locally.
Review URL: http://codereview.chromium.org/3713001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This suffers from a few potential issues, stemming from the lack of feedback of whether an authentication attempt succeeded.
- It will count failures from preemptive authentication but not preemptive authentication attempts.
- It will count challenges which do not result in Authorize headers being sent back up (UrlFetcher requests before HttpAuthCache is populated, user canceling an auth attempt).
Still, it seems better than having no insight right now. If it's too noisy I'll look at ways to improve it.
BUG=57628
TEST=Manually verified that histogram counts worked.
Review URL: http://codereview.chromium.org/3590012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38008
TEST=Manual
Review URL: http://codereview.chromium.org/3539017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sending out the notification. This is needed for the password integration
tests.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3529027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58556
TEST=ChromeSystemResources unit tests
Review URL: http://codereview.chromium.org/3610015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62155 0039d316-1c4b-4281-b951-d872f2087c98
|