| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1651/src@225150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1651/src@225149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1651/src@225135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1651/src@225133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The actual change is at http://crrev.com/224814.
THis is to port BreakIterator::getRuleStatus from ICU 52 to use in Blink.
See https://codereview.chromium.org/23618052
BUG=232922
TEST=Blink with the above CL gets built and layout tests pass.
TBR=mark
Review URL: https://codereview.chromium.org/24395010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/24438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExternallyConnectableMessagingTest.BackgroundPageClosesOnMessageReceipt test.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=ExternallyConnectableMessagingTest.BackgroundPageClosesOnMessageReceipt
TBR=juanlang@google.com
BUG=297866
TEST=none
Review URL: https://codereview.chromium.org/24453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show a notification when user signs into a multiple profile session
for the first time.
BUG=293641
R=dpolukhin@chromium.org, mnissler@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/24227011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/24429002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current code uses base::TimeTicks::Now(), which might be sampled
after the animation time used for the first frame with the deadline
scheduler.
NOTRY=true
BUG=297631
Review URL: https://chromiumcodereview.appspot.com/24463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains no changes to the FAQ, it merely ReST-ifies it. My next
CL will update the many outdated FAQ questions/answers, and will add
more (especially regarding PNaCl).
R= eliben@chromium.org
NOTRY=true
(doc-only change)
Review URL: https://chromiumcodereview.appspot.com/24295005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These will imminently be called entered/leftViewCallback, not
entered/leftDocumentCallback.
BUG=234509
Review URL: https://chromiumcodereview.appspot.com/23638010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=vtl@google.com
Review URL: https://codereview.chromium.org/24250009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263913
R=dpolukhin@chromium.org, thakis@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/23513067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/24250010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When OpenDevice is called with non-empty string for device id and that device doesn't exist (e.g., unplugged),
failure should be returned, instead of falling back to default device.
R=xhwang@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/24170005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=zork@chromium.org
BUG=290395
Review URL: https://codereview.chromium.org/24458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_NCCALCSIZE hack to get windows
to show up correctly with Glass.
This got added by mistake in my previous change.
BUG=296820,296836
R=sky@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/24457002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This button globally disables privet notifications using the
enable_notifications preference. Once users click it, they should not see
notifications again.
BUG=297337
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24316006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to help debug an invalid memory access issue. Using a CHECK here is no
worse than a DCHECK, as no attempt is currently made to gracefully fall back to
any safe behavior on release builds.
BUG=276347
Review URL: https://chromiumcodereview.appspot.com/24256005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When calling into DOMActivityLogger::log, the current location and title
for the page should always be passed in--otherwise, when a
DOMActivityLogger is re-used across multiple pages stale data can be
logged.
This is the second in a set of related changes--the previous change,
https://codereview.chromium.org/23817008/, updates the blink code. This
change is intended to be committed after that change lands in blink.
BUG=294500
Review URL: https://chromiumcodereview.appspot.com/24243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the last few hardcoded references to "out" directory.
Also, fixes up passing a qualified path to the test apk.
TEST=CHROMIUM_OUT_DIR=out_android ./build/android/test_runner.py instrumentation --test-apk ChromeTest -f Geolocation
BUG=
Review URL: https://chromiumcodereview.appspot.com/24228006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When uninitialized, MFC uses default H.264 level 1.0 in the stream header, which does not
support the resolution required. Fix is to set H.264 level 4.0 (allows up to 8192 MBs per
frame).
The uninitialized level doesn't appear to cause problems with certain receivers, but the
H.264 JM reference decoder does encounter an error with the produced bitstream.
BUG=none
TEST=manually dumped MFC output buffer and verified that level is set to 4.0 in the SPS.
R=fischman@chromium.org, sheu@chromium.org
Review URL: https://codereview.chromium.org/24281009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) RenderText was drawing unfocused selections with the non-selection
background color, but the selected text color, leading to white-on-white
text. Fix by drawing unfocused selected text as unselected.
(2) OmniboxViewViews was preserving selections across focus changes using
SaveStateToTab(), leading to problems when something about the omnibox state
changed after the omnibox was unfocused -- a later state restoration would
restore a selection model that no longer lined up with the rest of the
omnibox state (e.g. the current text). Fix by tracking selection across
focus changes in the same way OmniboxViewWin does.
(3) On tab changes, OnTabChanged() could be followed by an OnBlur()/OnFocus()
call if changing from a tab where the omnibox was focused to one where it
wasn't (or vice versa). This led to the selection state being stomped.
Fixed by making Browser give BrowserWindow first crack at handling the tab
change. This makes tabbing out of the omnibox, changing tabs away and back,
and tabbing back in correctly restore the selection even when changing
between tabs that disagree about whether the omnibox is focused.
BUG=293258
TEST=Following steps in bug comment 0 does not result in invisible text
R=msw@chromium.org, shess@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23536075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I cleaned up the formatting and fixed some links. I also added the Twitter handle, which I'll try to take over once I find who has it.
R= eliben@chromium.org
NOTRY=true
(doc-only change)
Review URL: https://chromiumcodereview.appspot.com/24222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The profile_creation_type- was being cleared before it was checked to see
whether a new window should be opened immediately. Consequently the supervised-
user confirmation/welcome overlay was being skipped.
BUG=297431
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24122003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect border_widget_ has been destroyed at the time we get
here. Some changes were done to when visibility change notifications
are sent out that could have contributed to this.
This is just a guess, I have no proof if this is in fact causing the crash.
BUG=293147
TEST=none
R=ananta@chromium.org, msw@chromium.org
Review URL: https://codereview.chromium.org/24315006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overlap. This introduces a limit of how many windows can be docked at the same time (2 by default). If additional windows are docked the last active one gets minimized. Restored window is always docked near the top of the docked area.
Animations are changed a bit so that a window that is being restored into docked state is fading in with 720ms animation, a docked window being minimized is using standard minimize animation and windows moving in the dock are sliding with 120ms time constant. This is done in order to create a visually connected animation that ends with the afterglow of the last window being restored.
BUG=275812
TEST=ash_unittests --gtest_filter=*Dock*ThreeWindowsMinimize*
Review URL: https://chromiumcodereview.appspot.com/23769012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do this to not impact Chrome startup. This change also adds a UMA to
track how long this warmup takes, which will tell us how long this
blocks the UI and roughly the speedup we can expect to see on App List
launcher.
BUG=292969
Review URL: https://chromiumcodereview.appspot.com/23710086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trunk on Windows.
In the client size changed notification, we were adjusting for the inset adjustment which we do in the
WM_NCCALCSIZE handling without checking whether this adjustment was applied in the first place
leading to the windows not showing up.
BUG=296820,296836
R=scottmg@chromium.org, sky@chromium.org, scottmg, sky
Review URL: https://codereview.chromium.org/24353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port and update the docs to match the new state of the examples.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3634
NOTRY=true
(just update to documentation)
Review URL: https://chromiumcodereview.appspot.com/23522065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
characters will now transition to capslock until the shift key is released.
BUG=252707
Review URL: https://chromiumcodereview.appspot.com/23496075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is speculative fix for a crash in
WrenchMenuModel::AddGlobalErrorMenuItems(). My guess is that we're
modifying a list while iterating over it. Fix is to move the modifying
call out of the loop.
BUG=278543
TEST=Can't repro the crash. Just built and ran Chrome.
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224987
Review URL: https://chromiumcodereview.appspot.com/23435011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Add a default impl of instant_service_observer.
. Move pref change listener for default search provider to
instant_service and pass to browser_instant_controller and
instant_ntp_prerenderer via instant_service_observer.
. Add a search-domain-check listener to instant_service in a similar
manner.
. Replaced ReloadStaleNTP, PreloadInstantNTP etc with ReloadInstantNTP
. Introduce InstantUnitTestBase
- InstantServiceTest and BrowserInstantControllerTest are subclasses.
. InstantService Unit Test
- Use a mock observer to verify the search provider change and
google url update is triggered on observers.
- Verify the prerendered NTP is reloaded.
. BrowserInstantController Unit Test
- Moved the tab reload test from interactive ui test to
BrowserInstantControllerTest.
R=jered@chromium.org, samarth@chromium.org
TBR=sky@chromium.org
BUG=254206
Review URL: https://chromiumcodereview.appspot.com/20388003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compiled on linux_chromeos, but doesn't compile in cros.
> linux_aura: Implement most of DesktopScreenX11.
>
> The linux_aura port didn't deal with multiple monitors very well because
> it was treating the X root window as one big display. When xrandr is
> present, get the screen areas from it, and exposes this data back to
> chrome.
>
> This patch also factors out the EDID parser than chromeos was using into
> a common directory. Like chromeos, we use it to assign stable display
> IDs.
>
> BUG=287972
> R=brettw@chromium.org, derat@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/23536057
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/24365012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other, and drop a bunch of DEPS files in to make checkdeps happy.
See https://codereview.chromium.org/24162009/ for try runs.
BUG=none
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225020
Review URL: https://codereview.chromium.org/24273005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The linux_aura port didn't deal with multiple monitors very well because
it was treating the X root window as one big display. When xrandr is
present, get the screen areas from it, and exposes this data back to
chrome.
This patch also factors out the EDID parser than chromeos was using into
a common directory. Like chromeos, we use it to assign stable display
IDs.
BUG=287972
R=brettw@chromium.org, derat@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23536057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/24395008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a ModelNeutralMutableEntry that exists between Entry and
MutableEntry in the hierarchy of syncable::Entry classes.
This new class inherits all of Entry's getter methods, so it can has the
same ability to read from entries as the current Entry and MutableEntry
classes.
All the setter methods from MutableEntry that are not model-changing
have been moved into ModelNeutralMutableEntry. The non-model-changing
setters are those whose mutations do not need to be communicated to the
model-specific change processors.
Because we know can guarantee all changes made through the
ModelNeutralMutabeEntry functions will not need to be relayed to the
change processors, it would be safe to skip calling SaveOriginal() in
its setter functions. For now, though, we leave these setter functions
unmodified.
BUG=284672
Review URL: https://chromiumcodereview.appspot.com/23549038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none
NOTRY=true
(documentation-only change)
Review URL: https://chromiumcodereview.appspot.com/23484066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Suggest timvolodine@chromium.org as additional reviewer.
Review URL: https://chromiumcodereview.appspot.com/23556013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=289546
R=jennyz@chromium.org
Review URL: https://codereview.chromium.org/24228005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a user policy "ChromeOsMultiProfileUserBehavior" that binds to
user pref "settings.multiprofile_user_behavior";
- Add a MultiProfileUserController that caches the pref value in local state
to make decisions before user actually signs in and also observe the pref
change to update the cache and check if the policy is broken;
BUG=288764
R=dpolukhin@chromium.org, joaodasilva@chromium.org, mnissler@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23856014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297038
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/24323007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38784
Review URL: https://codereview.chromium.org/23874026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/24076020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Tighten up DEPS rules in src/ui: prevent components from including from each other, and drop a bunch of DEPS files in to make checkdeps happy.
>
> BUG=none
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24273005
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/24257013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225032 0039d316-1c4b-4281-b951-d872f2087c98
|