summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* GTTF: Avoid assertion failures caused by clock drift.phajdan.jr@chromium.org2010-08-043-11/+47
| | | | | | | | | | | | | | | Instead, we add a test dedicated to verifying the QPC time drift. Otherwise the assertion is being flakily hit in unrelated tests, which crashes the entire test binary. With a dedicated test, we still have necessary monitoring, but it's in one place. TEST=base_unittests, net_unittests (stop crashing) BUG=none Review URL: http://codereview.chromium.org/3082014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54978 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug 12305 -- 1.66:1 should be UNKNOWN, not URL.erg@google.com2010-08-042-32/+51
| | | | | | | | | | | | Rearranges the autocomplete heuristics to reject malformed IP addresses before accepting them based on having a port or a username or a password. BUG=12305 TEST=AutocompleteTest.InputType Review URL: http://codereview.chromium.org/2868085 Patch from Ilya Sherman <isherman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54977 0039d316-1c4b-4281-b951-d872f2087c98
* Add back the lost mock data to get rid of "undefined" in users options page.xiyuan@chromium.org2010-08-041-0/+5
| | | | | | | | | BUG=none TEST=Verify the mock user in users options page does not has "undefined" as their names. Review URL: http://codereview.chromium.org/3076031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54976 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Add more NameField tests and fix incorrect logic in ParseEmpty.jhawkins@chromium.org2010-08-043-5/+201
| | | | | | | | | | | ParseEmpty should only match against the label text. BUG=none TEST=NameFieldTest.*;AddressFieldTest.* Review URL: http://codereview.chromium.org/3067029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54974 0039d316-1c4b-4281-b951-d872f2087c98
* Let the Nigori client import and export raw encryption keys.albertb@chromium.org2010-08-044-38/+121
| | | | | | | | | BUG=48701 TEST=NigoriTest.* Review URL: http://codereview.chromium.org/3013047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove GetSwitchValue() from chrome/* where easy."evan@chromium.org2010-08-0425-131/+111
| | | | | | | | This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-0425-111/+131
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete npapi plugins copied into <(PRODUCT_DIR)/pluginstony@chromium.org2010-08-041-4/+2
| | | | | | | | | | | | | | during UI tests. The layout test plugin is copied over via a build step and needed when running the layout tests. If you run the UI tests before the layout tests, the npapi layout test plugin is deleted and causes layout tests to fail. Seems like it's safe to keep the plugins even after the UI tests end. Review URL: http://codereview.chromium.org/3066033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54965 0039d316-1c4b-4281-b951-d872f2087c98
* Allow open local pdf file from FileBrowse UI.xiyuan@chromium.org2010-08-042-3/+17
| | | | | | | | | | | Allow local pdf file to be opened if a pdf plugin is available. BUG=chromium-os:5263 TEST=Verify local pdf file could be opened and viewed by pdf plugin. Review URL: http://codereview.chromium.org/3083015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54964 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54906 - Refactor HttpNetworkTransaction to eliminate the SPDYdhollowa@chromium.org2010-08-043-121/+227
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | specific states of the state machine. This required adding two new states: STATE_INIT_STREAM STATE_INTI_STREAM_COMPLETE The http_stream_ and spdy_http_stream_ member fields have been removed, and replaced by a single stream_ member field which is initialized with either an HttpBasicStream, or SpdyHttpStream depending on the underlying connection. In the process, the NetLog no longer receives TYPE_SPDY events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc needed to be modified accordingly. This seems to causing Valgrind leaks: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6887/steps/memory%20test:%20net/logs/stdio E.g.: Leak_DefinitelyLost 78,766 (888 direct, 77,878 indirect) bytes in 2 blocks are definitely lost in loss record 6,975 of 7,027 operator new(unsigned long) (mp/vg-bins/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:276) net::SpdySessionPool::GetSpdySessionFromSocket(std::pair<net::HostPortPair, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, net::HttpNetworkSession*, net::ClientSocketHandle*, net::BoundNetLog const&, int, scoped_refptr<net::SpdySession>*, bool) net::HttpNetworkTransaction::DoInitStream() net::HttpNetworkTransaction::DoLoop(int) net::HttpNetworkTransaction::OnIOComplete(int) net::ClientSocketHandle::OnIOComplete(int) net::internal::ClientSocketPoolBaseHelper::InvokeUserCallback(net::ClientSocketHandle*) RunnableMethod<net::internal::ClientSocketPoolBaseHelper, void (net::internal::ClientSocketPoolBaseHelper::*)(net::ClientSocketHandle*), Tuple1<net::ClientSocketHandle*> >::Run() MessageLoop::RunTask(Task*) MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) MessageLoop::DoWork() base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) MessageLoop::RunInternal() MessageLoop::Run() TestCompletionCallback::WaitForResult() net::SpdyNetworkTransactionTest_SocketWriteReturnsZero_Test::TestBody() testing::Test::Run() testing::internal::TestInfoImpl::Run() testing::TestCase::Run() testing::internal::UnitTestImpl::RunAllTests() TestSuite::Run() main Suppression (error hash=#-444E9002#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN3net15SpdySessionPool24GetSpdySessionFromSocketERKSt4pairINS_12HostPortPairESsEPNS_18HttpNetworkSessionEPNS_18ClientSocketHandleERKNS_11BoundNetLogEiP13scoped_refptrINS_11SpdySessionEEb fun:_ZN3net22HttpNetworkTransaction12DoInitStreamEv fun:_ZN3net22HttpNetworkTransaction6DoLoopEi fun:_ZN3net22HttpNetworkTransaction12OnIOCompleteEi fun:_ZN3net18ClientSocketHandle12OnIOCompleteEi fun:_ZN3net8internal26ClientSocketPoolBaseHelper18InvokeUserCallbackEPNS_18ClientSocketHandleE fun:_ZN14RunnableMethodIN3net8internal26ClientSocketPoolBaseHelperEMS2_FvPNS0_18ClientSocketHandleEE6Tuple1IS4_EE3RunEv fun:_ZN11MessageLoop7RunTaskEP4Task fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop6DoWorkEv fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE fun:_ZN11MessageLoop11RunInternalEv } BUG=50267 TEST=none Review URL: http://codereview.chromium.org/3064033 TBR=rch@chromium.org Review URL: http://codereview.chromium.org/3038048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54963 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 64638:64658atwilson@chromium.org2010-08-041-1/+1
| | | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/3014054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54962 0039d316-1c4b-4281-b951-d872f2087c98
* Add view class names to some classes used in the Wrench menu.dmazzoni@chromium.org2010-08-046-0/+45
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2832106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54960 0039d316-1c4b-4281-b951-d872f2087c98
* Start passwords exceptionssargrass@google.com2010-08-048-1/+110
| | | | | | | | | BUG=None Test=None Review URL: http://codereview.chromium.org/3061049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54959 0039d316-1c4b-4281-b951-d872f2087c98
* Modify client to open up chromoting connection in a new tab.ajwong@chromium.org2010-08-043-54/+83
| | | | | | | | | | BUG=50248 TEST=connects locally. TBR=hclam Review URL: http://codereview.chromium.org/2808104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54958 0039d316-1c4b-4281-b951-d872f2087c98
* Adding \n's to some files so that try bots can work for changes that ↵tommi@chromium.org2010-08-045-4/+9
| | | | | | | | | | | | actually do something. TBR=amit TEST=n/a BUG=none Review URL: http://codereview.chromium.org/3061051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54957 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: unbreak extension badges.estade@chromium.org2010-08-042-15/+27
| | | | | | | | | BUG=50682 TEST=load make_page_red, you can see the badge; dragging still works, clicking still works, removing icons still works Review URL: http://codereview.chromium.org/3064039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54954 0039d316-1c4b-4281-b951-d872f2087c98
* To effectively test some parts of chrome for cros on the linux desktop, we ↵davemoore@chromium.org2010-08-0433-2213/+2324
| | | | | | | | need a way to start chrome logged in. The login UI requires the WM to display, so I added command line options to do this. But we needed the full functionality of login, which doesn't work when libcros can't be loaded. I created stubs for all the cros api. I then took both stubs and the real implementations and put them entirely inside the .cc files (no separate declaration of the implementations in the .h files). Review URL: http://codereview.chromium.org/3076029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54950 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache: Provide a way to override the default quota for an origin. The ↵michaeln@chromium.org2010-08-044-5/+92
| | | | | | | | | | | intent is to use this to support the 'unlimited_storage' privilege of Chrome Applications. BUG=49993 TEST=AppCacheStorageImplTest.FailStoreGroup Review URL: http://codereview.chromium.org/3083014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54949 0039d316-1c4b-4281-b951-d872f2087c98
* Pass notifications to the browser when a document is accessing an appcache.michaeln@chromium.org2010-08-041-2/+4
| | | | | | | | | BUG=45230 TEST=manual Review URL: http://codereview.chromium.org/3023038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54948 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views] Refactor accelerator handler related code.suzhe@chromium.org2010-08-0412-154/+176
| | | | | | | | | | | | | | | | | This CL removes the accelerator handling logic in accelerator_handler_gtk.cc and implements a much simpler solution in WidgetGtk. The new approach always sends a key event to the focused View and native GtkWidget first and only sends it to the focus manager if it's not handled by any View or native GtkWidget. BUG=23383 AcceleratorHandler on Windows should not dispatch the KEYUP messages eaten by the FocusManager BUG=40966 BrowserKeyEventsTest.AccessKeys is crashy BUG=49701 [Linux Views]Some Emacs keybindings are broken in omnibox and find in page box. TEST=Press Alt key in different place (web page, omnibox, find bar, etc.) to see if menu bar can be focused correctly. Press alt-F to popup wrench menu and Escape to close it, then try alt key again. Review URL: http://codereview.chromium.org/3046041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54947 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-048-18/+12
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring-ness from some more locale variables.evan@chromium.org2010-08-0411-15/+15
| | | | | | Review URL: http://codereview.chromium.org/3043055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54945 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetStringAsUTF16() to GetString() (and overload), etc.viettrungluu@chromium.org2010-08-0415-168/+147
| | | | | | | | | | | | Also do some drive-by wstring/wchar_t -> string/char changes (in addition to the necessary ones). BUG=none TEST=builds and tests pass Review URL: http://codereview.chromium.org/3091005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54944 0039d316-1c4b-4281-b951-d872f2087c98
* Leaks found in PrefValueStoreTest testsdhollowa@chromium.org2010-08-042-0/+65
| | | | | | | | | | | Suppresses leaks apparently introduced in revision 54902. http://codereview.chromium.org/2858060 BUG=51176, 45324 TEST=Run Valgrind. No leaks reported. PrefValueStoreTest.TestRefreshPolicyPrefsCompletion, PrefValueStoreTest.TestRefreshPolicyPrefsCompletion, PrefValueStoreTest.TestConcurrentPolicyRefresh Review URL: http://codereview.chromium.org/3076030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54943 0039d316-1c4b-4281-b951-d872f2087c98
* Makes browser windows always render active on chromeos.sky@chromium.org2010-08-041-0/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3007031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54942 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Other..." to wireless networks.xiyuan@chromium.org2010-08-043-5/+49
| | | | | | | | | | | | | - Create a fake network item for "Other..." in InternetOptionsHandler; - Update js to handle "Other...". That is, no icon, status and action buttons for this item and click on the item brings up the wifi dialog; - Show default cursor on network item text; BUG=chromium-os:4744 TEST=Verify that "Other..." shows up at the end of wireless networks and works. Review URL: http://codereview.chromium.org/3046044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54941 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of unused code.avi@chromium.org2010-08-041-1/+0
| | | | | | | | | BUG=none TEST=no change Review URL: http://codereview.chromium.org/3064040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54940 0039d316-1c4b-4281-b951-d872f2087c98
* Update my email address for watch lists, and add plugin watchingstuartmorgan@chromium.org2010-08-041-2/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3060041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54936 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of minor fixes for CopyTexImage2Dgman@chromium.org2010-08-045-44/+39
| | | | | | | | | TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/3030038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54935 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes warm-start performance on Vista and Win7 when using pre-reading ↵slightlyoff@chromium.org2010-08-041-16/+57
| | | | | | | | | | | optimization. Avg times go from ~500ms to ~300ms. TEST=run chrome_frame_perftests.exe --gtest_filter=*X.PerfWarm on Vista/Win7 and XP. Note that warm starts are now faster on Vista and unchanged on XP. BUG=45510 Review URL: http://codereview.chromium.org/3058023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54934 0039d316-1c4b-4281-b951-d872f2087c98
* PrependWrapper is platform-specific, so it should take a platform string.evan@chromium.org2010-08-049-24/+23
| | | | | | | | | Though the comments said it was POSIX only, I see it used on Windows as well so I'm updating the comment. Review URL: http://codereview.chromium.org/3030043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54933 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an option, enabled by default, to net-internals tocbentzel@chromium.org2010-08-045-18/+51
| | | | | | | | | | | | | | | | | | | remove cookies from log dumps. Also, SPDY headers are now displayed (And stored) just like http ones. Cookies are always shown on the Requests page. As an added bonus, removes a superfluous </b> from index.html. Contributed by: mmenke@google.com BUG= 50668 TEST= Go to about:net-internals, and check for properly hiding cookies for both HTTP and SPDY, for both sent and received cookies. Review URL: http://codereview.chromium.org/3072013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54932 0039d316-1c4b-4281-b951-d872f2087c98
* tabbed content settings:estade@chromium.org2010-08-041-5/+39
| | | | | | | | | | | | - Implement add button - disable edit/remove buttons when appropriate BUG=48862 TEST=manual Review URL: http://codereview.chromium.org/3076028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54931 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54771 - Enable speculative preconnection by defaultjar@chromium.org2010-08-0412-219/+38
| | | | | | | | | | | | | | Added histogram to track utilization (vs waste). [The stability bot was reporting problems, so I'm reverting] r=mbelshe Review URL: http://codereview.chromium.org/3026038 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/3090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54795 - Initialize was_ever_connected_ in ClientSocket.jar@chromium.org2010-08-041-2/+1
| | | | | | | | | | | | | | I'm reverting 54771... so I had to revert this first. BUG=51079 TEST=Built net_unittests Review URL: http://codereview.chromium.org/3010050 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3029057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54929 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix upgrade notification dot.estade@chromium.org2010-08-042-17/+18
| | | | | | | | | | | Changing the wrench menu to a custom button broke it. BUG=50682 TEST=visual Review URL: http://codereview.chromium.org/3058041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind mem leak per chromium:51134.xiyuan@chromium.org2010-08-042-29/+2
| | | | | | | | | BUG=chromium:51134 TEST=CrOS UI (valgrind) should not complain mem leak as in issue 51134. Review URL: http://codereview.chromium.org/3036042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54927 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that catches |const NSString*| and friends.thakis@chromium.org2010-08-041-0/+23
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54925 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make clang compile unit_tests.thakis@chromium.org2010-08-043-3/+2
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3012045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54924 0039d316-1c4b-4281-b951-d872f2087c98
* Initial port of accelerated compositor to Mac OS X 10.6. Reusedkbr@google.com2010-08-0428-46/+403
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | infrastructure added for Pepper 3D and Core Animation plugins to render the compositor's output. The implementation allocates a fake "plugin window handle" on the browser side which is the "root" handle, containing the compositor's output, and which, if present, is drawn before any other accelerated plugin instances. Added messages from GPU process to browser process for handling window resizing and presentation of output. Added support to GGL for "view" contexts on Mac OS X, used only for the accelerated compositor, and requiring explicit resize notifications. The remainder of this port will go into the WebKit repository under https://bugs.webkit.org/show_bug.cgi?id=43398 after this for dependency reasons. Tested manually with CSS 3D and WebGL demos. Several stability and correctness issues remain and will be addressed in following CLs; however, the current code works for the majority of basic use cases including switching between accelerated compositing on and off, and scrolling of content. BUG=38969 TEST=none Review URL: http://codereview.chromium.org/3067026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54923 0039d316-1c4b-4281-b951-d872f2087c98
* Make options tabs keyboard-accessible.dmazzoni@chromium.org2010-08-041-0/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3083010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Firefox import lock dialog on Windows.mirandac@chromium.org2010-08-045-20/+27
| | | | | | | | BUG=50577 TEST= run chrome first_run with import while Firefox is default browser and open. Dialog should pop up telling user to close FF. Review URL: http://codereview.chromium.org/2868077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54920 0039d316-1c4b-4281-b951-d872f2087c98
* Rudamentary Chrome extension version of the chromoting client UI.ajwong@chromium.org2010-08-046-69/+302
| | | | | | | | | | | | | This implements a bare-bones interface to starting a chromoting client session. It currently loads the plugin within the popup itself which is bad, but at least it works as a proof of concept. BUG=50248 TEST=runs and connects locally. Review URL: http://codereview.chromium.org/3046045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54919 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out NormalizeToNativeFilePath from NormalizeFilePathcpu@chromium.org2010-08-042-42/+46
| | | | | | | | | | | | - Also do some cleaning up, fixing invalid usage of ScopedHandle BUG=50774 TEST=existing unit tests suffice Review URL: http://codereview.chromium.org/3043050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54918 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from l10n_util/ResourceBundle locale functions.evan@chromium.org2010-08-0421-64/+62
| | | | | | Review URL: http://codereview.chromium.org/3069026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54917 0039d316-1c4b-4281-b951-d872f2087c98
* When toggling an extension in incognito, don't disable/reenable the extensionmpcomplete@chromium.org2010-08-041-3/+8
| | | | | | | | | | | unless it's already enabled. BUG=50582 TEST=toggling extension in incognito still works, and syncs properly Review URL: http://codereview.chromium.org/3043053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54916 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).viettrungluu@chromium.org2010-08-0418-391/+392
| | | | | | | | | | | | | Also do a bunch of drive-by changes while I'm at it. Still to do: rename GetStringAsUTF16() to GetString(). BUG=none TEST=builds everywhere, tests pass Review URL: http://codereview.chromium.org/3033050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54915 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing css layoutsdhg@chromium.org2010-08-044-53/+90
| | | | | | Review URL: http://codereview.chromium.org/3030040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54914 0039d316-1c4b-4281-b951-d872f2087c98
* Adding mocked out pages for the proxy settings.dhg@chromium.org2010-08-048-1/+230
| | | | | | Review URL: http://codereview.chromium.org/3051007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54913 0039d316-1c4b-4281-b951-d872f2087c98
* Wording change for network options UI.xiyuan@chromium.org2010-08-041-2/+2
| | | | | | | | | | | | "Wireless network" -> "Wireless networks" "Remembered network" -> "Remembered networks" BUG=chromium-os:4744 TEST=Verify plural form of "network" is used for wireless and remembered network section header. Review URL: http://codereview.chromium.org/3075020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54912 0039d316-1c4b-4281-b951-d872f2087c98