| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup to an earlier change (r38266) which did most of the
warning-related cleanup. This one just flips the flag, and fixes some
new warnings that crept in during the window while the flag was off.
Second try, now with some libpng fixes.
BUG=34160
Review URL: http://codereview.chromium.org/1320011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- FreeBSD has ALSA, add it to media.gyp
Review URL: http://codereview.chromium.org/1301003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding to valgrind exception list while we determine source of failure. Note, same test does not fail
under other platforms, nor does it fail under non-valgrind Mac bots.
BUG=39401
TEST=none
Review URL: http://codereview.chromium.org/1342003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reload the correct tab, not the full browser.
BUG=chromium-os:2057
Review URL: http://codereview.chromium.org/1238006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=power_menu_button_browsertest
Review URL: http://codereview.chromium.org/1338003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1321002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Pass expecations into _get_iterable_expectations (this changed at some point and all usages weren't updated).
2. Change unit test expected results to strip out whitespace. Code appearantly changed to strip whitespace at some point, which seems fine.
3. Change unit test expected results to include extra new lines. This seems questionable, but we'll see if this is an issue in practice and address it then if it is.
TEST=Run update_expectations_from_dashboard_unittest.py
BUG=none
Review URL: http://codereview.chromium.org/1234002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Review URL: http://codereview.chromium.org/1207005
TBR=neb@chromium.org
Review URL: http://codereview.chromium.org/1344003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8.
Implementation notes:
Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:
"Delete Browsing History":
IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.
IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.
"InPrivate Filtering":
IE 8 (only): more testing required.
"InPrivate Browsing":
IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.
BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003
TBR=slightlyoff@chromium.org
Review URL: http://codereview.chromium.org/1353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39378
TEST=none
TBR=ahendrickson
Review URL: http://codereview.chromium.org/1393001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Compiled locally and on trybots but failed on builder?!
This reverts commit r42688.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup to an earlier change (r38266) which did most of the
warning-related cleanup. This one just flips the flag, and fixes some
new warnings that crept in during the window while the flag was off.
BUG=34160
Review URL: http://codereview.chromium.org/597023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please remove the suppression when you fix the leak.
BUG=39378
TEST=none
TBR=ahendrickson
Review URL: http://codereview.chromium.org/1390001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://chrome-buildbot:8014/builders/Chromium%20Mac%20UI%20(valgrind)(2)/builds/2299
BUG=39376
TEST=valgrind on mac
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/1384001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
strings are generated from checked in .grds from revision 42543.
BUG=24305
Review URL: http://codereview.chromium.org/1361001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory for non-priv mode users on IE < 8.
Implementation notes:
Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change:
"Delete Browsing History":
IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual.
IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8.
"InPrivate Filtering":
IE 8 (only): more testing required.
"InPrivate Browsing":
IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected.
BUG=22846
TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming)
Review URL: http://codereview.chromium.org/858003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39373
TEST=none
TBR=dhollowa
Review URL: http://codereview.chromium.org/1382001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made default constructor public, but DCHECK() on any use of a
default-constructed object.
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/1364002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it appears that some rely on these numbers, like the help center, sigh
BUG=38927
TEST=none
TBR=mal
Review URL: http://codereview.chromium.org/1323002
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/1362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added ability for renderer processes to render to a real window (Windows only so far).
- Added ability to create offscreen frame buffer objects that can be resized later.
- OpenGL context can have a "parent" context that can access its last swapped back buffer through a texture ID.
- Moved code to establish GPU channel from RenderWidget to RenderThread.
- Changed way service size command buffer object lifetimes are managed.
TEST=trybot and visual verification that OpenGL can clear the browser window to magenta.
BUG=none
Review URL: http://codereview.chromium.org/1136006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all FDs.
BUG=35229
TEST=Let Chrome idle with a flakey net connection, and check that the number of open FDs is not increasing.
Review URL: http://codereview.chromium.org/1336004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test runs. This is only done
if ChromeFrame is running in headless mode.
Review URL: http://codereview.chromium.org/1346003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the known crashes list.
Bug=39356
Review URL: http://codereview.chromium.org/1340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser is tagged for CF navigation.
I found that if I load a CF page, then go to the address bar and press enter, we will actually get both OnHttpEquiv(done==false) and then followed by OnHttpEquiv(done==TRUE) even though we kicked off a new navigation in between. When this happened we would clear the cache in OnHttpEquiv(done==true) and subsequently we'd have to go to the network to fetch the content once CF is instantiated.
TEST=See description.
BUG=none
Review URL: http://codereview.chromium.org/1330001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
downloaded by the host browser.
Before the request could under some circumstances be terminated before we handed it over to the host for download.
In such cases we would just drop the request and not download anything.
TEST=Fixes flakyness of _some_ download scenarios. This is only a part of a fix needed for the related bug.
BUG=36694
Review URL: http://codereview.chromium.org/1240004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bring up FileBrowseUI.
<http://crosbugs.com/2056>
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1315003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
linux/views yet.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27905
TEST=Verify fix for 27095.
Review URL: http://codereview.chromium.org/1351001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39353
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/1333006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180
TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)
BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.
Review URL: http://codereview.chromium.org/1344002
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1367002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make tcmalloc compatible with the seccomp sandbox by avoiding making direct system calls from within tcmalloc.
BUG=38973
TEST=none
Review URL: http://codereview.chromium.org/1294001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
happnening anymore.
BUG=23138
TEST=none
Review URL: http://codereview.chromium.org/1338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180
TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)
BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.
Review URL: http://codereview.chromium.org/1344002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Use callbacks, while I'm at it.)
BUG=34515
TEST=none
Review URL: http://codereview.chromium.org/1372001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_test.exe --gtest_filter=BookmarksUITest.*
Review URL: http://codereview.chromium.org/1292002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39342
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/1373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed version of r42646 which was reverted at r42653.
BUG=none
TEST=none (but Gears should continue working on Windows)
Review URL: http://codereview.chromium.org/1349004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
request_time
response_time
vary_data
There is also a unit test to exercise the new functionality.
- Changed CreateSpdyHeadersFromHttpRequest() to use std::string::append()
rather than std::string::operator+() to append a single '\0' character
to the string, as the former does nothing.
- Now using SpdyFramer.
- The unit tests now include all server push cases.
BUG=34505
TEST=Run netunittests.exe --gtest_filter=SpdyNetworkTransactionTest.*
Review URL: http://codereview.chromium.org/634002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
- GLEW doesn't load the GL shader functions, so we have to load them ourselves
- Replace our varying vec2 with glTexCoord[0].st
- Replace our uniform mat3 with manual matrix multiplication
BUG=33329
TEST=try it out on anything with an I915
Review URL: http://codereview.chromium.org/1219006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=maruel
BUG=39342
TEST=none
Review URL: http://codereview.chromium.org/1362001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.
Nib changes: Change the "fonts and languages" string to refer to "fonts" only. Remove the "languages" tab from the "fonts and languages" xib.
BUG= 39008
TEST= open preferences in Mac. see no reference to languages in "Under the Hood".
Review URL: http://codereview.chromium.org/1306002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Review URL: http://codereview.chromium.org/1207005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Oriya translation updated any more.
BUG=37562
TEST=On Windows, 'chrome --lang=or' will bring up English Chrome.
Review URL: http://codereview.chromium.org/1144001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All widgets are now displayed and the notification has a curved border.
BUG=34514
TEST=none
Review URL: http://codereview.chromium.org/1247005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none (but Gears should continue working on Windows)
Review URL: http://codereview.chromium.org/1336002
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/1355002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38349
TEST=none
Review URL: http://codereview.chromium.org/1320001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
anything. This flag was leftover from initial product development when there
was no opt-in preference for enabling the metrics service.
The only user was a ChromeFrame unit test which I modified to use a different
one that has the same effect.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1290004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the extension popup API when using borderStyle=rectangle.
I will submit a follow-up CL containing tests that will catch future regressions on the positioning of the pop-up.
BUG=39235
TEST=None
Review URL: http://codereview.chromium.org/1217009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit test
Review URL: http://codereview.chromium.org/1142004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42649 0039d316-1c4b-4281-b951-d872f2087c98
|