| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This allows me to change one of the callers to not parse the
"REVISION=1234" output, which will allow me to change that output
in a future change.
BUG=41264
Review URL: http://codereview.chromium.org/6265021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All strings that remain are either probably actually used (e.g. by chrome frame or chromeos or the windows installer), or may be used soon (i.e. less than 6 months old).
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6360009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6249010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=about:gpu page shows Drive Vendor, GL_RENDERER, etc.
Review URL: http://codereview.chromium.org/6289011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Private key is cloned instead of transferred. This eliminates the leak in
JingleSessionTest.*.
BUG=70291
TEST=valgrind bot is green
Review URL: http://codereview.chromium.org/6317009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=50943
Review URL: http://codereview.chromium.org/6363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to the normal method reordering, this patch also deinlines
net/base/test_completion_callback.h and places the compiled code in the
net_test_support target. Minimization of that header also required adding
includes in a few unit tests.
BUG=68682
TEST=compiles
Review URL: http://codereview.chromium.org/6341004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There was a lot of thread hopping from IO to UI back to IO to answer requests. This is was GpuProcessHostUIShim is for. Refactored to take advantage of it.
BUG=none
TEST=by hand and trybots
Review URL: http://codereview.chromium.org/6374007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This fixes an error with the gyp file that was causing some compiler
flags to be double included. It also fixes a number of MSVC compiler
warnings.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error status. CertGetCertificateChain no longer detects the error.
R=agl
BUG=70210
TEST=none
Review URL: http://codereview.chromium.org/6331009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=this is it
BUG=none
Review URL: http://codereview.chromium.org/6250024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure IndexedDBContext is deleted before returning from
~WebKitContext. Otherwise, UtilityProcessHost may still be in batch mode
when the IO thread is shut down.
BUG=67422
TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.*
Review URL: http://codereview.chromium.org/6209005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compute the rectangle for the paint, and create a hole inside it, instead of
making a giant all-consuming hole.
BUG=70410
TEST=manually, see bug.
Review URL: http://codereview.chromium.org/6261019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and make PasswordManager just dispatch the IPC message directly to achieve this. I've also combined WebNavigationObserver with IPC message filtering (I hadn't seen the former when I added it). This allows a little more cleanup in AutoFillManager.
Review URL: http://codereview.chromium.org/6368011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extends the external_metrics interface to recognize a new metric kind (crash) which gives a string to describe which kind of crash. We handle three currently non-Chrome user space crashes, kernel crashes, and unclean system shutdowns. These are accumulated, but not yet put into xml uploads until the server side is ready.
BUG=chromium-os:9352
TEST=unit_tests and tested in chromeos that log messages were generated corresponding with crashes.
Review URL: http://codereview.chromium.org/6077013
Patch from Ken Mixter <kmixter@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for multi-profile.
devtools
kDevToolsSplitLocation
browser
kBrowserWindowPlacement
Also add a method to browser_prefs to delete obsolete preferences from local state, and fix all related tests.
BUG=66717
TEST=all browser, interactive, and ui tests work properly
Review URL: http://codereview.chromium.org/5915006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No functionality change, just code move.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6257008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
separately, to make it pass the commit bot.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6261020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bots will go green.
TBR=jorlow,rniwa
Review URL: http://codereview.chromium.org/6377005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"Release".
Include both case since it's case-sensitive.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit change http://trac.webkit.org/changeset/76291 may have affected this test.
TBR=brettw
BUG=70408
TEST=BrowserTest: RenderViewTest.OnNavStateChanged
Review URL: http://codereview.chromium.org/6330006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6353012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70388,70389
TBR=glider
TEST=DrM/FYI should go green on printing
Review URL: http://codereview.chromium.org/6270005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6245009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- do not strip User-Agent while flattening headers in renderer
- do not override User-Agent header in the network stack if one is already supplied by higher level;
- added RequestHeaders::SetHeaderIfMissing
TEST=URLRequestTestHTTP.OverrideUserAgent
BUG=http://crbug.com/67063
Review URL=http://codereview.chromium.org/6065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was initially a way to try to prevent prerendering non-idempotent GETs. A large number of pages were unable to prerender effectively this way due to short max-age's or other cache directives.
BUG=None
TEST=unit_tests --gtest_filter="*PrerenderResourceHandler*"
Review URL: http://codereview.chromium.org/6312008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70231
TEST=LoginPromptBrowserTest.PrefetchAuthCancels
Review URL: http://codereview.chromium.org/6321013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move it from standard_layout.h and rename to just CreatePanel.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/drmemory/issues/detail?id=275
TBR=glider
TEST=DrM/FYI should go greener
Review URL: http://codereview.chromium.org/6303015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function where TSan doesn't understand a shared memory lock
TBR=glider
BUG=45083,66994
TEST=TSan/interactive_ui tests should become greener
Review URL: http://codereview.chromium.org/6354012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppressions
TBR=glider
TEST=DrM/FYI bot should go greener
BUG=70225
Review URL: http://codereview.chromium.org/6380009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, Add some browser tests for clearing plugin data and enable npapi_test_plugin on 64-bit Linux; apparently it's been fixed.
BUG=58235, 18337, 26625
TEST=PluginDataRemoverTest.*
Review URL: http://codereview.chromium.org/6308001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes feeds from Twitter searches to break because the hash
sign (%23) gets decoded before passed to Twitter.
BUG=70226
TEST=ExtensionBrowserTest.ParseFeedInvalidFeed4
Review URL: http://codereview.chromium.org/6332008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix http://src.chromium.org/viewvc/chrome?view=rev&revision=71785
revealed possible flow, when active downloads list contains non-existing
downloads. This fix removes redundant method call, which is also
dangerous.
BUG=none
TEST=cancel dangerous download, notice that Chromium is alive.
Review URL: http://codereview.chromium.org/6372003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add GetScreenMode() to status_area_host.h, and remove IsBrowserMode() and IsScreenLockerMode() APIs. The old APIs seem to be a bit confusing since only 3 combinations out of 2^2 are valid. (I mean, IsBrowserMode() == true and IsScreenLockerMode() == true is invalid.)
BUG=chromium-os:8386
TEST=manually, try bot.
Review URL: http://codereview.chromium.org/6378008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
As a result, memcheck_analyze was waiting for dead Valgrind processes for 3
extra minutes. D'oh.
BUG=17453,44545
TEST=trybots, experiments by eugenis@
Review URL: http://codereview.chromium.org/6258010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69965
TEST=GeolocationBrowserTest.TabDestroyed,GeolocationPermissionContextTests.TabDestroyed
Review URL: http://codereview.chromium.org/6340011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://git.chromium.org/gitweb/?p=cros.git;a=commit;h=34a0e132afad573f7595c1c813ae03d9d5ff6eec
BUG=chromium-os:11101
TEST=try
Review URL: http://codereview.chromium.org/6364003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6293007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature is now behind --enable-in-browser-thumbnailing flag.
The in-browser thumbnailing works as follows:
- The scroll offset is sent from the renderer to the browser.
- The thumbnail is taken when the page info is sent from the renderer process.
- Since thumbnails are generated in the browser, we can avoid the generation when unnecessary (ex. off-the-record mode, or New Tab Page).
- The quality of thumbnails is as good as before, as the patch doesn't change timing heuristics.
- The drawback is that we cannot take thumbnails from background tabs.
New functions are added to ThumbnailGenerator for clipping thumbnails, with tests.
BUG=65936
TEST=add unit tests for thumbnail_generator. confirmed that the thumbnails are updated with and without --enable-in-browser-thumbnailing
Review URL: http://codereview.chromium.org/6246007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The CL ifdef'ed out for some parts of HTML, but it did not touch the corresponding JS code that modifies the part.
BUG=chromium-os:11142
TEST=manually open chrome://settings
Review URL: http://codereview.chromium.org/6342013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on GTK implementation. Please see the header file for features that are not implemented yet.
Textfield changes (files under views/controls/textfield) are being reviewed by Ben in separate CL (http://codereview.chromium.org/6314012/), so you don't have to review them (but you're welcome to do so).
* Updated factory method in AutocompleteEditViewGtk to return views-implementation when TextfieldViews is enabled.
* Added new option to FillLayout so that it lays out its child inside border.
* Added missing GD_PK_Delete to keycode conversion.
* Enabled tests in autodomplete_edit_view_browsertests for views-implementation as well. I moved the test body to the class and then called them from each test class to avoid having another test configuration on bots. Let me know if there is better way.
BUG=none
TEST=Enabled autocomplete_edit_view_browsertest for views-implementation.
Review URL: http://codereview.chromium.org/6245003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6346011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6265018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
return value as a bool
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6346010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6360010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=it compiles BUG=none
Review URL: http://codereview.chromium.org/6336010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
few annoying cases where someone has been monitoring Chrome under windbg,
which can skip over __debugbreak() and then show them a scary-looking
access violation.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6372008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98
|