| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1662/src@227222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1662/src@227220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spectacular breakages include:
- nacl integration tests constantly crashing.
- browser tests running in a busted environment.
- interactive_ui_tests being weirdly broken despite not running.
- Size regressions
BUG=125106,303342,304554,125106,304555
TBR=cpu@chromium.org,mseaborn@chromium.org,tim@chromiium.org,phajdan.jr@chromium.org,koz@chromium.org
Review URL: https://codereview.chromium.org/26157003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304555
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/26160002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125106
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/26159002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Casualty of turning on linux_aura.
BUG=304554
TBR=tim@chromium.org
Review URL: https://codereview.chromium.org/26157002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This widens some suppressions from windows to linux, and suppresses some memory errors in third party libraries that we now use.
BUG=125106,303342
R=cpu@chromium.org, mseaborn@chromium.org
Review URL: https://codereview.chromium.org/25120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/26000004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test is failing on android_dbg_triggered_test bot, blocking cq.
However it is still passing on main waterfall for some reason.
BUG=304549
TBR=michaelbai@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/26145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test is failing on android_dbg_triggered_test and blocking cq. But
seem to be passing on main waterfall bots.
BUG=304548
TBR=mnaganov@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/26144002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
os.uname is only available on unix platforms, while platform.uname should be available almost anywhere
BUG=225939
R=dtu@chromium.org, kbr@chromium.org
Review URL: https://codereview.chromium.org/26095002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My latest theory is CaptureController::SetCapture() is being invoked
recursively, leading to out of order notification. I want to verify
that is in fact happening.
BUG=275760
TEST=none
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/25792003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/25606004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=justinlin
Review URL: https://codereview.chromium.org/26141002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=justinlin
Review URL: https://codereview.chromium.org/26138002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=justinlin
Review URL: https://codereview.chromium.org/26137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=varkha
BUG=304544
Review URL: https://codereview.chromium.org/26136002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed mock PrivetDeviceLister, changed LocalDiscoveryUIBrowsertest to use a
testing ServiceDiscoverySharedClient that delegates to a
ServiceDiscoveryClientImpl with a mocked network, allowing the test to be
written in terms of packets rather than calls to method of PrivetDeviceLister.
BUG=
Review URL: https://codereview.chromium.org/25649002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
area or points which return HTNOWHERE as we only receive
WM_TOUCH messages for the client area.
This fixes bug https://code.google.com/p/chromium/issues/detail?id=291092 where chrome apps don't respond to touch events
on the sysmenu buttons like minimize/restore, etc as their non client view implementation expects to handle them via the
mouse click notifications.
In any case we should not be ignoring synthesized mouse messages for outside the client area as we don't receive touch messages
for the non client.
BUG=291092
R=girard@chromium.org, sky@chromium.org, sky
Review URL: https://codereview.chromium.org/23965008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jbauman, piman
BUG=286548
Review URL: https://codereview.chromium.org/26069002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test is very similar to Connect_Local_Host.
I also made two changes in the webapp:
1. Added a helper to map a host name to the host id
2. Add an id to the host name cell in the host list for easy retrieval in the test.
BUG=134210
Review URL: https://codereview.chromium.org/26055002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When ffmpeg AVFrame objects are freed, the current code calls
avcodec_free_frame(). However, this can cause "use after free"
errors. The correct call is to call avcodec_free_frame().
Also updating the remaining places that use av_free() to free up
an AVFrame to use avcodec_free_frame() instead.
Requires a roll of ffmpeg to pick up avcodec_free_frame().
BUG=303927
TEST=No errors reported by ASAN for repro.
Review URL: https://codereview.chromium.org/26023006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=304236
Review URL: https://codereview.chromium.org/25953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The invocation of std::set_intersection() in InvalidatorRegistrar was
using the wrong kind of output iterator, which would lead to crashes
under some conditions (eg. valgrind). It was technically invalid under
any conditions; we were "lucky" that it didn't crash most of the time.
BUG=304250
Review URL: https://codereview.chromium.org/25855007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Un-editable fields are field by the controller with values that do not
need to be validated - skip them during validation runs.
BUG=277321
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/25830002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reimplemented ScreenCaptureNotificationUICocoa to make it consisten
with the Views implementation.
BUG=190156
Review URL: https://codereview.chromium.org/25824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Added FloatValueBetween which makes more sense for float in/ouputs.
~ Changed overloads to {Type}ValueBetween.
~ Fixed call sites to use the correct new function.
R=danakj
BUG=304263
Review URL: https://codereview.chromium.org/25804013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1736 remove ez_setup import from setup.py
r1737 ninja/mac: Allow per configuration SDKROOT.
r1738 ninja/mac: Fix _XcodeVersion parsing for Xcode 3.2.
r1739 Let eclipse generator use MSVS compiler flags on Windows.
r1740 Add support for DisableSpecificWarnings for ninja
r1741 make: Add AIX support.
r1742 Add AIX to platforms that use "make" in gyptest.py
r1743 homogenize msvs and ninja library_dir and libraries settings for Windows
r1744 Revert homogenize msvs and ninja library_dir and libraries settings
r1745 Add an option to prune targets
r1746 Revert r1745: "Add an option to prune targets"
r1747 Refactor calculation of variables, common to many generators.
r1748 ninja/mac: Create -iphoneos device builds for iOS ninja generator.
r1749 Avoid MSB8012 on Windows
r1750 reland r1743 with reverted test case
R=thakis@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25786004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/25727011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow up to r226477 as requested by jam in
https://codereview.chromium.org/25378002/#msg17.
BUG=265753
R=jam@chromium.org
Review URL: https://codereview.chromium.org/25705004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=299180
Review URL: https://codereview.chromium.org/25675012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to the SignalSyncPoint() move, the goal here is to expose this functionality
directly from gpu:: so we don't have to depend on WebGraphicsContext3D in order to
use queries.
R=piman,sievers
Review URL: https://codereview.chromium.org/25645007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=292738
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/25415007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=danakj@chromium.org
BUG=259095
Review URL: https://codereview.chromium.org/25353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client Hints can be used as input to proactive content negotiation;
just as the Accept header allowed clients to indicate what formats
they prefer, Client Hints allow clients to indicate a list of device
and agent specific preferences.
See:
https://github.com/igrigorik/http-client-hints/blob/draft2/draft-grigorik-http-client-hints-01.txt
Patched from https://codereview.chromium.org/23654014/, which was
patched from https://codereview.chromium.org/11970002
BUG=170388
CONTRIBUTOR=yoav@yoav.ws
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225425
Review URL: https://codereview.chromium.org/24451003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a precision lost issue for texture layers with CSS
transforms(Scaling) when applying TextureDrawQuad::PerformClipping()
to avoid explicitly setting a scissor. The rect is first divided by
the scale_factor, then round to integer value and finally multiplied
by the scale_factor in GLRenderer::EnqueueTextureQuad(). The round
process loses precision and the later scale operation enlarges the
error. This error leads to wrong width and height drawn and
introduces visual defects.
BUG=240259
Review URL: https://codereview.chromium.org/24427006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Per protocol http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html a byte range request of 'bytes=START_BYTE-' should return bytes starting at START_BYTE till end of file.
BUG=278611
Review URL: https://codereview.chromium.org/24293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=267888
TEST=content_unittests --gtest_filter="WebCryptoImpl*"
Review URL: https://codereview.chromium.org/23621050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
confirmation dialog.
Add a "Learn more" link to a troubleshooting page at the bottom of the "Sign in with a different account" dialog.
Expected result:
http://i.imgur.com/txdpn4R.png (Mac)
http://i.imgur.com/QvIfDr4.png (Windows)
TEST=
1. Sign in to Chrome with a first account (hot-dog menu > Sign in to Chrome...).
2. Sign out (hot-dog menu > Settings > Disconnect your Google Account...).
3. Sign in to Chrome with a different account than the one used at step 1.
Expected result: In the "Sign in with a different account" confirmation dialog that appears, there should be a "Learn more" link.
4. Click on the "Learn more" link.
Expected result: A help page is loaded in a popup.
BUG=268379
Review URL: https://codereview.chromium.org/22165004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not valid to wrap a NULL cc::ContextProvider in a
WebGraphicsContext3DProvider, so NULL check it before wrapping. The
SharedMainThreadContextProvider() could be NULL if we can't create
and bind a valid context, which can happen if the GPU is unhappy or
the process crashes any early point in initialization.
BUG=301555
Review URL: https://codereview.chromium.org/26028004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RenderSurfaceLayerList is supposed to contain any layers which are visible
or that are eligible for hit testing. This change ensures that empty layers
(those with drawsContent=false) are left in the RSSL when they have touch or
wheel handlers, so that we can find them in hit testing.
BUG=289766
R=danakj@chromium.org
Review URL: https://codereview.chromium.org/25712004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed in order to produce properly formatted gtest output.
However, runtest.py isn't yet properly picking up the output from the
WebGL conformance tests. Still investigating.
BUG=225939
R=bajones@chromium.org, dtu@chromium.org
Review URL: https://codereview.chromium.org/26070002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change was incorrect.
> Ignore the --gtest_output command line argument.
>
> This is required in order to run the Telemetry based WebGL conformance
> tests under runtest.py, which is in turn needed in order to properly
> parse the test results and upload them to the flakiness dashboard.
>
> Eventually Telemetry should ignore this argument rather than each
> individual test, so that all Telemetry based tests can easily be run
> on the bots, but that will require a full review, so doing this
> workaround for now.
>
> BUG=225939
> TBR=bajones@chromium.org
>
> Review URL: https://codereview.chromium.org/25399005
TBR=kbr@chromium.org
Review URL: https://codereview.chromium.org/26078003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=gpu_unittests
R=kbr@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/23509013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove old Windows gyp workaround to enable Ash if use_aura on Windows (as it is now on by default).
BUG=Using use_aura=0 on Windows doesn't compile as it tries to build Ash.
Review URL: https://codereview.chromium.org/25665008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::MessageLoop::Quit(), ...Run(), ...RunUntilIdle() are all deprecated (replaced by base::RunLoop).
Content::TestBrowserThread is deprecated (replaced by Content::TestBrowserThreadBundle).
This change will also reduce the number of threads each test spawns.
BUG=272091
Review URL: https://codereview.chromium.org/25536016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227158 0039d316-1c4b-4281-b951-d872f2087c98
|