| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This was caused by http://trac.webkit.org/changeset/42549 upstream.
Will rebaseline on linux in the next change.
Review URL: http://codereview.chromium.org/79030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
[FATAL:at_exit.cc(40)] Check failed: false. Tried to RegisterCallback without an AtExitManager
in (possibly unused) binary perf_tests
Review URL: http://codereview.chromium.org/60103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removes a call to Layout that should be removed now that we have RemoveTabAnimation.
Review URL: http://codereview.chromium.org/79029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clipped by the containing popup's roundrect. No text yet, though they seem to actually work when clicked on.
This is not the final construction I'd like, but I'm checkpointing here before the changelist gets any bigger.
In the end, I'm thinking AutocompletePopupView will end up being implemented by the popup's contents view rather than the popup itself. I want to do this because the popup, the contents view and the individual result item views need access to the model and as it stands I need to wire model data methods all the way from the result view up to the popup which is annoying. But for now, I have some of that wiring. I'll do this adjustment after this one, since it requires creating some new files.
Review URL: http://codereview.chromium.org/79023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removed in CL http://codereview.chromium.org/18550.The UI will be reworked in a CL immediately following review/submission of this code.Please contact Nick Baum for information regarding this change.
Review URL: http://codereview.chromium.org/66065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BrowsingInstances when we force a transition for DOM UIs.
BUG=9364
TEST=see bug
Review URL: http://codereview.chromium.org/67201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
* Modify the tabstrip input handling to match the new interface.
Review URL: http://codereview.chromium.org/79025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
set the non client frame view.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/67236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
properly, If window is not maxmized.
(http://crbug.com/5729).
The fix is to popup tabstrip context menu from the left of the click in RTL UI.
Without the fix, tabstrip context menu always popup from the right of the click.
Review URL: http://codereview.chromium.org/73021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsService.
Also add "chrome-extension" to the list of schemes that BrowsingInstance
groups per-site, instead of per-tab. This means that navigating to an
extension URL will use the same process as a running extension toolstrip.
Review URL: http://codereview.chromium.org/77002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/79027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/67237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/42579
ScriptController::createInlineEventListener was changed to take
4 params instead of 3, so I updated the V8 ScriptController
to do the same. We don't seem to need the extra arg because both
v8_proxy::createSVGEventHandler and
v8_proxy::createInlineEventListener are identical.
Also one new .cpp/.h file from
http://trac.webkit.org/changeset/42580
Review URL: http://codereview.chromium.org/79008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. Punch holes in Sandbox config to accomodate changes in the Font Server.
2. Add warmup for CGImageSourceGetStatus().
3. Misc cleanup for rendererMainPlatformDelegate::PlatformInitialize() function.
Review URL: http://codereview.chromium.org/67232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(which has numerical limits) and Chrome version (which does not).
Use Chrome version when we can.
Review URL: http://codereview.chromium.org/79021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See 1st post at (XXX internal URL removed XXX)
Code coverage for base: 85% (!!!)
Review URL: http://codereview.chromium.org/67235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mind and not intercept after all. This allows the decision to start or not to start to be made asynchronously.2) Allow an interceptor to intercept on error conditions if the original job fails. This is to support the FALLBACK semantics in the appcache.Info about where this is going can be found in the appcache design doc at https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=enI still have to put together test cases, so I'm not ready to submit this yet, but wanted to get some feedback at this point.
Review URL: http://codereview.chromium.org/67019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It had 200 seconds on the linux bot and still failed
on one run and passed on another in 1.1 seconds.
Review URL: http://codereview.chromium.org/67231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
argument to -t
rather than just the abbreviation.
Review URL: http://codereview.chromium.org/42654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a renderer CrashForBitmapAllocationFailure does not crash in any of the 4 CHECKS(), it
crashes calling GetProcessMemoryInfo()
- Because GetProcessMemoryInfo() tries to load PSAPI.dll and the sandbox blocks it.
- Now it gives a better dump by disabling the iniling of the function
- Adds a check for the shared memory, which I suspect is the real cause for some of the crashes
BUG=10585
Review URL: http://codereview.chromium.org/75027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular the USE_SYSTEM_MALLOC macros aren't properly defined.
This turns out to be benign in our current builds, but will be significant
with my future checkins.
Overall, this checkin doesn't change anything, except to get the right
definitions in place for JSC.
Review URL: http://codereview.chromium.org/79014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add link to upstream bug report
Review URL: http://codereview.chromium.org/79011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checkin, I'll add a ton of slow tests and reduce the timeout for non-slow tests to something like 1 second.
To aid in that, I've added 90th percentile and 99th percentile times to the statistics we report. Also made it so that tests marked as slow and timeout/crash tests are listed separately from the slowest 50 tests so that list can be used to know which tests to mark slow.
Tests cannot be marked as both SLOW and TIMEOUT. If the test times out, then we want it to timeout early to avoid waiting a long timeout for a test that we know is just going to timeout.
TestShell can now do per-test timeouts. We could easily make run-webkit-tests do per-test timeouts, but I think just having the one modifier of SLOW is easier to grok. Makes the test lists simpler and allows for having longer timeouts on debug/purify builders.
BUG=9324
Review URL: http://codereview.chromium.org/67198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove calls to CoInitialize / CoUninitialize
- CoUninitialize sometimes causes the OS to try to load oleauth.dll
- An exception for in-process-plugins.
BUG=10589
Review URL: http://codereview.chromium.org/75028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch by Craig Schlenter <craig.schlenter@gmail.com>
Review URL: http://codereview.chromium.org/67228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First step to have smoother audio playback. We previously
performed audio messages handling on render thread, which
gave us huge amount of latency, especially when renderer
is busy compositing or is blocked by synchronous IPC call.
A lot of these latencies are eliminated by moving audio
messages handling to IO thread, this is the first step to
see if sharing the regular IPC channel for audio messages
is creating too much stress for the IPC channel. Also
doubled the audio packet size to 8192 samples, ~194ms of
audio for 16bit/44.1khz/2ch.
Review URL: http://codereview.chromium.org/62125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier).
Review URL: http://codereview.chromium.org/77004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPP_HandleEvent, as it might have gone away depending on JavaScript that was executed by the plugin.
BUG=9955
Review URL: http://codereview.chromium.org/75026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.
Also:
- Fixes window dispositions (shift-click works on bookmark bar items).
- Reorganizes gtk_utils
Original Review URL: http://codereview.chromium.org/76002
Review URL: http://codereview.chromium.org/67223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- A fix to reported deadlock: don't start the real-time thread until the inital buffers are filled
- A new unitest that uses a slow source, the idea is to try to repro the deadlock
- Implements GetVolume and SetVolume
Review URL: http://codereview.chromium.org/67154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more readable. I verified chromebot has no
problem parsing it.
Review URL: http://codereview.chromium.org/79003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/69019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
external tab has finished loading. Unfortunately we cannot
reuse AutomationMsg_InitialLoadsComplete because it has
overloaded meaning.
Review URL: http://codereview.chromium.org/69018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inlineBoxWrapperNullCheck.html is a test that changed due to drawRect.
generated.html is the same output as windows, just with anti-aliased
fonts on linux.
The other three (bug56201 bug23847 008) are tests that have checksums
checked in, but no png. I'm checking in the pngs so they're there
for comparison.
Review URL: http://codereview.chromium.org/75025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
2. Lookup object properties before expanding them in the sidebar.
Review URL: http://codereview.chromium.org/69013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same as how ResourceBundle owns the SkBitmaps it loads.
This should be faster than before because ResourceBundle will only
load each bitmap once and cache the image.
Also fix a memory leak in GdkPixbufFromSkBitmap.
valgrind says we're not leaking here.
BUG=9988
Review URL: http://codereview.chromium.org/67179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13828&r2=13827&pathrev=13828
TBR=brettw
Review URL: http://codereview.chromium.org/77005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactor a bunch of the Pango attributes code.
- Walk the classifications, and create the pango attributes for
the text foreground color and weight (bolding).
- Cache the GdkGC and PangoLayout across expose messages.
Review URL: http://codereview.chromium.org/75041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, I removed the GetWebFrame method on WebDataSource since it is not
actually needed.
Removed some dead-code from webframe_impl.cc.
Removed some bogus null-checking of WebCore::Frame::loader().
R=dglazkov
Review URL: http://codereview.chromium.org/67169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/75022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13839 0039d316-1c4b-4281-b951-d872f2087c98
|