summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert r18354.sgk@google.com2009-06-133-5/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary addition of urlmon.lib to AdditionalDependenciessgk@google.com2009-06-133-10/+5
| | | | | | | | | | | of activex_shim. Add it as a dependency of default_plugin. Add urlmon.lib to AdditionalDependencies in unittests.vcproj (going away soon, but this makes the transition smooth). BUG=none TEST=none Review URL: http://codereview.chromium.org/125099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18354 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-1355-52/+107
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions visible in the Task Manager.phajdan.jr@chromium.org2009-06-136-23/+108
| | | | | | | | | | | | | - register for notifications when extension hosts are created/destroyed - collapse extension tabs into just one table row, also for tabs opened while the task manager stays open TEST=Start chrome.exe with --enable-extensions. Install the buildbot monitor extension. Open the task manager. You should see an extension process. http://crbug.com/12127 Review URL: http://codereview.chromium.org/125047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18352 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension id format back to mp-decimal, and change theaa@chromium.org2009-06-1338-89/+143
| | | | | | | | length to 32 chars (exactly 128 bits). Review URL: http://codereview.chromium.org/126074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18351 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a flaky layout test which has been timing out on some runs.ericroman@google.com2009-06-131-1/+1
| | | | | | | | | BUG=13767 TBR=tony Review URL: http://codereview.chromium.org/125098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18350 0039d316-1c4b-4281-b951-d872f2087c98
* The context menu in external hosts would not work as expected as the command ↵ananta@chromium.org2009-06-132-0/+18
| | | | | | | | | | | | | | ids received from the TrackPopupMenuEx call were the indices of the commands. This was because of the MNS_NOTIFYBYPOS menu style on the context menu coming in from chrome. Fix is to turn off this style for external hosts. R=ben Review URL: http://codereview.chromium.org/126091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18349 0039d316-1c4b-4281-b951-d872f2087c98
* Restructure menu initialization for the TabContents. InitMenu cannot be ↵ben@chromium.org2009-06-133-3/+6
| | | | | | | | | | called from the constructor because it seems to break RenderViewContextMenuExternalWin's virtual AppendItem from being called. BUG=none TEST=none Review URL: http://codereview.chromium.org/126089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18348 0039d316-1c4b-4281-b951-d872f2087c98
* Add image baseline for "generated-content.html" on linux.eroman@chromium.org2009-06-132-0/+1
| | | | | | | | | | Differs from windows baseline only by text renering. TBR=tony Review URL: http://codereview.chromium.org/126088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18347 0039d316-1c4b-4281-b951-d872f2087c98
* Add chromium-win baseline for new test "generated-content.html" which was ↵ericroman@google.com2009-06-133-0/+18
| | | | | | | | | | | | added in <http://trac.webkit.org/changeset/44640>. This layout-test is really just checking for crash. Our actual output looks fine (although upstream webkit has no pixel baseline checked in to compare against). TBR=tony Review URL: http://codereview.chromium.org/125096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18346 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 44626:44645ericroman@google.com2009-06-132-36/+25
| | | | | | | | | | | | | | | | | | | * <http://trac.webkit.org/changeset/44634>: Moves the skia image decoder files out of "skia/" and into {"png/", "bmp/", "ico/", "jpeg/", "xbm/"}. I made the corresponding updates to webkit.gyp. The semantics of "don't use skia decoders on Mac" should still be in effect. * <http://trac.webkit.org/changeset/44636> This adds a new file, V8StorageCustom.cpp, which I HAVE NOT pulled into webit.gyp. There is a chromium-side component to this, which jorlow will take care when he is ready to pull the file into our build. Review URL: http://codereview.chromium.org/126085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18345 0039d316-1c4b-4281-b951-d872f2087c98
* gtk bookmark manager:estade@chromium.org2009-06-132-26/+76
| | | | | | | | | | | | - Implement list view activation. - Fix a crasher. TEST=double click on something in the right pane (folder or bookmark) http://crbug.com/13110 Review URL: http://codereview.chromium.org/126084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18344 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix refresh accelerators.estade@chromium.org2009-06-131-6/+3
| | | | | | | | | by Jacob Mandelson <jacob@mandelson.org> original review: http://codereview.chromium.org/127001 Review URL: http://codereview.chromium.org/125093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18342 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some layout testshclam@chromium.org2009-06-1328-9/+107
| | | | | | | | | | | | | | | | Rebaseline the following layout tests: LayoutTests/fast/media/mq-animation.html LayoutTests/fast/media/mq-aspect-ratio.html LayoutTests/fast/media/mq-orientation.html LayoutTests/fast/media/mq-transform-01.html LayoutTests/fast/media/mq-transform-02.html LayoutTests/fast/media/mq-transform-03.html LayoutTests/fast/media/mq-transform-04.html LayoutTests/fast/media/viewport-media-query.html Review URL: http://codereview.chromium.org/125091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18341 0039d316-1c4b-4281-b951-d872f2087c98
* Add favicons to Mac bookmark bar.jrg@chromium.org2009-06-136-7/+244
| | | | | | | | | | | | BUG=8381 TEST=Open bookmark bar (Cmd-B). Add some bookmarks with sites that have favicons (cnn.com). See icons in bookmark buttons. Make sure color is correct. Review URL: http://codereview.chromium.org/125061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18340 0039d316-1c4b-4281-b951-d872f2087c98
* Make findbar paint themed image.estade@chromium.org2009-06-135-29/+81
| | | | | | | | | | | | | Also, fixed drawing of background images that are not 1 pixel wide. (The code for this is somewhat speculative as there is no way of testing it at the moment, but for now it should still at least look correct.) If you open the findbar while the bookmark bar is opened and then close the bookmark bar, the findbar painting is a little messed up in that it still thinks it's farther away from the tabstrip than it really is. The solution (unfortunately) is to continuously repaint the findbar as it is closing. Since this is glitch is hardly noticeable, I'm putting off fixing it. TEST=findbar should look more integrated with bookmark bar, toolbar. BUG=none Review URL: http://codereview.chromium.org/125084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18339 0039d316-1c4b-4281-b951-d872f2087c98
* Restores an early return that was incorrectly removed in the PasswordStore ↵stuartmorgan@chromium.org2009-06-131-0/+4
| | | | | | | | | | refactoring. BUG=13979 TEST=Save a password on a site with a valid SSL certificate, then visit in when the cert is no longer valid. Review URL: http://codereview.chromium.org/125074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18338 0039d316-1c4b-4281-b951-d872f2087c98
* Create a basic test case for the common usage of BlockedPopupContainer.erg@google.com2009-06-134-1/+116
| | | | | | Review URL: http://codereview.chromium.org/125083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18336 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reversed focus traversal order issue.yutak@chromium.org2009-06-127-95/+115
| | | | | | | | | | | | | | | | This change fixes several problems in handling focus traversal and resolves TabbedPane's traversal order issue. Reversed focus traversal is very tricky, and the original traversal code overlooked several things. (1) A focusable view may have a FocusTraverasble. (2) When we are going down, we have to check if the current view has a FocusTraversable. (3) When we are going up from a FocusTraversable, the parent view may gain the next focus. This change fixes these issues. BUG=6871 TEST=See issue 6871. Review URL: http://codereview.chromium.org/125062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18335 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where both restore and maximize buttons were showing aftertc@google.com2009-06-121-1/+1
| | | | | | | | | | | toggling window manager decorations on/off. TBR=estade Review URL: http://codereview.chromium.org/125090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18334 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test a expected fail which has been failing in debug mode for a while.ericroman@google.com2009-06-121-0/+4
| | | | | | | | | BUG=14014 TBR=darin Review URL: http://codereview.chromium.org/125089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18333 0039d316-1c4b-4281-b951-d872f2087c98
* Back out the building of LoginDatabase due to Windows bustage.stuartmorgan@chromium.org2009-06-121-5/+0
| | | | | | | | | TBR=pinkerton BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18332 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling failing test on mac.bradnelson@google.com2009-06-121-1/+2
| | | | | | | | | | | | I wanna test more of the pipeline and would like the build to go green for a bit. BUG=None TEST=None TBR=crogers Review URL: http://codereview.chromium.org/125088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18331 0039d316-1c4b-4281-b951-d872f2087c98
* Copy login-related section of WebDatabase into a new class for use in ↵stuartmorgan@chromium.org2009-06-126-0/+739
| | | | | | | | | | | | | | PasswordStore. The platform-specific inheritence here is because the current Windows implementation of PasswordStore is a temporary shim, and will eventually need to use its own database instead; since we'll need almost all the fields on the Mac for the bag-on-the-side anyway, it makes sense to share as much of this implementation as possible. The code and unit tests are pretty much unchanged from WebDatabase (except for the inheritence stuff); the duplication should be temporary as the WebDatabase copy will be removed once Windows switches (and migrates their passwords). BUG=none TEST=none Review URL: http://codereview.chromium.org/119392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18330 0039d316-1c4b-4281-b951-d872f2087c98
* Add expected failure for "dns-prefetch-control.html" which has been flaky on ↵ericroman@google.com2009-06-121-1/+1
| | | | | | | | | | | | linux for a while. The cause of the flake is an extra output line (warning from pkix_CacheCertChain_Add), see bug for details. TBR=tony BUG=14009 Review URL: http://codereview.chromium.org/126077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18329 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the titlebar code into its own class because it's getting bigtc@google.com2009-06-128-279/+389
| | | | | | | | | | | | | | | and cluttering up browser_window_gtk. Fix a small painting bug when a menu is drawn over the titlebar background. Also move the tab strip context menu into the titlebar background container by adding an event box. Now the context menu appears e.g., below the min/max/close buttons or above the tab strip. Review URL: http://codereview.chromium.org/125078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18328 0039d316-1c4b-4281-b951-d872f2087c98
* Use a bool instead of disconnecting/reconnecting the changedtc@google.com2009-06-122-11/+11
| | | | | | | | | signal handler. I don't really care one way or the other :) Review URL: http://codereview.chromium.org/118518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18327 0039d316-1c4b-4281-b951-d872f2087c98
* Google Gears should be renamed to Gearsmhm@chromium.org2009-06-123-4/+4
| | | | | | | | | | | BUG=6234 (http://crbug.com/6234) TEST=Checked the Google Gears screen to see if they got changed. Wrench > Options > Under the Hood > Web Content Review URL: http://codereview.chromium.org/125037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18326 0039d316-1c4b-4281-b951-d872f2087c98
* Add configuration items for unit_tests.exe (not fully gyp converted yet):sgk@chromium.org2009-06-121-6/+36
| | | | | | | | | | | | | * sort the platform-independent dependency list; * add dependencies on convert_dict_lib, installer_util_strings and hunspell; * exclude hunspell_tests.cc on mac. * add missing resources; * add system libraries oleacc.lib and comsupp.lib. BUG=none TEST=none Review URL: http://codereview.chromium.org/118404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18324 0039d316-1c4b-4281-b951-d872f2087c98
* Adding back in o3dextras build.bradnelson@google.com2009-06-122-0/+33
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/126069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18323 0039d316-1c4b-4281-b951-d872f2087c98
* Specify new methods for supporting SSL client authentication.wtc@chromium.org2009-06-1225-60/+282
| | | | | | | | | | | | | | | | | See the changes to url_request.h and ssl_cert_request_info.h. They are similar to the methods for handling SSL certificate errors and HTTP authentication. The handling of servers that request but don't require SSL client authentication is reimplemented using the new methods. R=rvargas,eroman BUG=http://crbug.com/318 TEST=none Review URL: http://codereview.chromium.org/118039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18322 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to the try chrome toastcpu@google.com2009-06-122-5/+24
| | | | | | | | | | | | | - Wire it to the cmdline param --try-chrome-again - Set window bounds so it looks nice on Vista - Enable the link to help center BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/126029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18321 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream V8Helpersjaphet@chromium.org2009-06-126-108/+27
| | | | | | Review URL: http://codereview.chromium.org/125023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix themed toolbar drawing following tabstrip changes.estade@chromium.org2009-06-127-13/+46
| | | | | | | | | | | The code should also be more robust to future changes. BUG=none TEST=active tab blends into toolbar Review URL: http://codereview.chromium.org/126013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18319 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file descriptor exhaustions a little more gracefully. This prevents ↵stuartmorgan@chromium.org2009-06-122-3/+12
| | | | | | | | | | the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue. TEST=none BUG=none Review URL: http://codereview.chromium.org/125024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18318 0039d316-1c4b-4281-b951-d872f2087c98
* Mark two media layout tests as crashhclam@chromium.org2009-06-121-1/+4
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/125075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18317 0039d316-1c4b-4281-b951-d872f2087c98
* Verify signed .crx extension installationsrafaelw@chromium.org2009-06-1237-301/+473
| | | | | | | | | | | | | | | This is second try of: http://codereview.chromium.org/115682 that was comitted in in 18189 and reverted. BUG=12114 R=erikkay,wtc,aa Review URL: http://codereview.chromium.org/126014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-1224-248/+342
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* Disblae some media layout testshclam@chromium.org2009-06-121-6/+23
| | | | | | | | | | TBR=scherkus Disable soem flaky media tests.. Review URL: http://codereview.chromium.org/125073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18314 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit Update 44622:44626ericroman@google.com2009-06-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/125070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18313 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-126-17/+1
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Add headers missing in r18291.thestig@chromium.org2009-06-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/125072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18311 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'theme_dll' a loadable_module, not a shared_library, so dependentsgk@google.com2009-06-121-1/+1
| | | | | | | | | | targets don't expect it to produce an import library (which it doesn't because it has no symbols...). BUG=none TEST=successful build Review URL: http://codereview.chromium.org/125069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18310 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 44597:44622ericroman@google.com2009-06-126-19/+1
| | | | | | | | | | * LayoutTests/editing/deleting/4875189.html Deleting the baselines since the test was changed to dumpAsText(), so no need for our platform-specific ones <https://bugs.webkit.org/show_bug.cgi?id=26284>. Review URL: http://codereview.chromium.org/125042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert thakis's changes to download_file.cc from r17595.estade@chromium.org2009-06-121-15/+8
| | | | | | | | BUG=13991 Review URL: http://codereview.chromium.org/126066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18307 0039d316-1c4b-4281-b951-d872f2087c98
* Included text/css content type into list of the supported non image files. abarth@chromium.org2009-06-123-5/+14
| | | | | | | | | | | | | | | | | | Now css files are opened inside browser instead of download. Also - making lint happy on the mime_util.cc BUG=7192 R=abarth TEST=MimeTypeTests.MimeTypeTests Patch by Yuri Gorobets. Original review URL: http://codereview.chromium.org/125005 Review URL: http://codereview.chromium.org/125058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18306 0039d316-1c4b-4281-b951-d872f2087c98
* Add resources necessary for building chrome.exe via gyp-generated files.sgk@chromium.org2009-06-121-0/+50
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18305 0039d316-1c4b-4281-b951-d872f2087c98
* Use pointers instead of references in SpellCheck function.sidchat@google.com2009-06-124-10/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18304 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups from post-submit suggestions.mmoss@chromium.org2009-06-123-11/+12
| | | | | | | Review URL: http://codereview.chromium.org/126062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18303 0039d316-1c4b-4281-b951-d872f2087c98
* Change some DCHECKs to CHECKs in hope of tracking down a crash.pkasting@chromium.org2009-06-121-2/+2
| | | | | | | | BUG=13986 TEST=none Review URL: http://codereview.chromium.org/125066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18302 0039d316-1c4b-4281-b951-d872f2087c98