| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14272007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/14178005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/14023006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provides a 3x speedup on all platforms for subsequent kernel
creations with only an extra 8k in memory.
BUG=none
TEST=media_unittests
Review URL: https://codereview.chromium.org/13741004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A 0 mask resource means we don't use a mask, it's a valid value. Don't iterate
over it, because we never want to send 0 to the parent, nor do we want to look
up 0 in the child->parent map.
BUG=None
Review URL: https://codereview.chromium.org/14167007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=231523
Review URL: https://codereview.chromium.org/13925019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows us to have multiple instances of a specific component, for example each renderer will have a separate main thread and compositor.
BUG=155367
Review URL: https://codereview.chromium.org/13874002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The creation date in GetChildPids is in the form <date>[-+]<timezone>. The
old code only handled negative timezones. This updates it to handle both.
BUG=232254
TEST=morejs page cycler on windows with timezone set to israel
NOTRY=True
Review URL: https://codereview.chromium.org/14328005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, the offline load page is not picking up the default system font but instead defaulting to Times New Roman. This CL fixes it by explicitly setting the font style for the page body.
R=dbeam@chromium.org
BUG=223934
TEST=Go offline and verify that the font used is the ChromeOS system font.
Review URL: https://codereview.chromium.org/14311003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bluetooth mice are not required to be paired, but we attempt to pair
to them anyway because some mice, namely the Apple magic mouse,
require pairing. Some other mice do NOT support pairing or pretend
to support it without doing it properly.
This patch adds a small database of bluetooth mice known to not
support pairing and tries to connect to them without pairing.
BUG=210518
TEST=Attempt to pair with a Verbatim mouse. No pincode should be ask and the mouse should just work.
Review URL: https://codereview.chromium.org/13933012
Patch from Alex Deymo <deymo@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: https://codereview.chromium.org/14225012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- frame called ::SetCapture
- mouse down on menu button
- menu opens and calls ::SetCapture
- Windows notifies frame that it's lost capture
- The DesktopCaptureClient release its internal capture state, but
also releases native capture
- which releases the menu's capture, not its capture.
This makes sure that the window that's releasing capture is really
the one that has it.
R=ben@chromium.org
BUG=232155
Review URL: https://codereview.chromium.org/14312007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/14101006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++11 provides unique_ptr<T[]>, and Chromium has implemented
scoped_ptr<T[]> to match its behavior during the transition period. As a
result, scoped_array<T> is now redundant and is being removed.
BUG=171111
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194649
Review URL: https://codereview.chromium.org/14081006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://codereview.chromium.org/13950005/ for where it's required.
R=thakis@chromium.org
BUG=232421
Review URL: https://codereview.chromium.org/14093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we're launched from an extension with the filepath given, set the checkbox to checked.
This CL also fixes a bug which was preventing attach file from an extension from working.
R=dbeam@chromium.org
BUG=223160
TEST=Attach a file from the QO extension and confirm that everything works.
Review URL: https://codereview.chromium.org/13853008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes dropping text and files onto the omnibox work in linux_aura
builds of chrome. The parts that implement dragging out of chrome still don't
work.
BUG=130806
Review URL: https://codereview.chromium.org/14189002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rtenneti@chromium.org
BUG=232777
TEST=waterfall.sh
Review URL: https://codereview.chromium.org/14205013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/14195007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to discover indexeddb's that are in apps and extensions.
Each StoragePartition is calling back through to the JavaScript separately,
and each section will get rendered with its own header.
BUG=174188
TBR=joi@chromium.org,estade@chromium.org
Review URL: https://codereview.chromium.org/14156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Force STYLE_BUTTON instead of STYLE_NATIVE_TEXTBUTTON.
( easier to revert than replacing all uses, if necessary )
Make STYLE_BUTTON focusable like STYLE_NATIVE_TEXTBUTTON.
Give default STYLE_BUTTON buttons bold text.
Make STYLE_BUTTON buttons big enough for bolded text.
( so they'll fit bold text when made default without resizing )
See before/after pics at http://crbug.com/155363#c62
TODO(followup): Tweak individual buttons' layout as needed.
TODO(followup): Officialy deprecate/remove STYLE_NATIVE_TEXTBUTTON.
BUG=155363
TEST=The new button style appears everywhere as intended.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/14077011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=171111
Review URL: https://codereview.chromium.org/14265020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=231139
TEST=net_unittests
Review URL: https://codereview.chromium.org/13932033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/13926012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The 'frame info' comes from the CompositorFrame message, and the fields
are useful only if the update implies a Swap (--composite-to-mailbox or
ubercomp). (In other words, a scroll offset is not useful if you don't
know what frame it is for.)
Review URL: https://codereview.chromium.org/14210004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change Consume/ProduceTexture to use the same texture target validator as BindTexture(). Otherwise, external and rectangle textures will fail this call, since we exclude these targets from the wider GL APIs using the texture_target validator
Also, pass stream texture flag along and reset it to |false| after Produce() since the new GL texture will be disconnected from the stream.
BUG=230327,179729
Review URL: https://codereview.chromium.org/14095009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=140037
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/14312006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're going to change to use more than one background windows to enclose panels in the stack because not all panels are fully aligned when some of them are being dragged. The 'Window' suffix is added to the naming to make it clear.
BUG=223155
TEST=none due to no functionality change
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/14188014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent change to accessibility on Chrome OS is triggering a call to
MenuItemView::GetAccessibleState on a MenuItemView that has a delegate
but no command id, which asserts in MenuModelAdapter when we try to
look up a command that's not there.
The fix is to not call MenuModelAdapter::GetAccelerator to look up a
command when the command is zero.
BUG=230107,232079
Review URL: https://codereview.chromium.org/14161006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function was used in only one place and that place was wrong.
The implementation was long and complicated on Windows, and long and
complicated and copied verbatim from elsewhere with 3 lines different on Posix.
The place it was used was in the proxy launcher when copying the profile. It's
not clear to me why we wouldn't want the profile files in the filesystem cache
when running tests. Quite the opposite, we want the tests to run as fast as
possible.
The only place this should matter is in the startup tests. And the startup
tests do things to the profile after it gets copied that should page some files
back in! This adds another step to the startup tests to evict the profile files
for cold startup tests only.
This is a reland of r192940 which crashed on Mac. The previous perf startup
test used the profile directory before it was initialized. That patch was in
turn a reland r191854 which broke the startup test. The previous patch
replaced the CopyRecursive call with CopyDirectory which does something
slightly different. This new patch implements a CopyDirectoryContents function
to do what's required here.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On some platforms, listening on "localhost" binds to the IPv6 loopback
(::1), even if there's no global IPv6 connectivity. In such situations,
HostResolverImpl restricts lookups to IPv4 (AF_INET) for performance
reasons, but then navigating to http://localhost results in "connection
refused".
HostResolverProc has a workaround for this situation. This CL adds a
test for this behavior and replicates the workaround in
HostResolverImpl::ServeFromHosts (for the built-in asynchronous DNS).
BUG=224215
Review URL: https://codereview.chromium.org/14208010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/14178004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148536%3A148558&mode=html
TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/13870008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark bubble controller is showing.
BUG=180102
TEST=ActionBoxTest.BookmarkAPageTest reliably works
Review URL: https://codereview.chromium.org/14130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two small tweaks to the audio indicator:
- change the equalizer levels to look better with fewer bars
- make animation slightly faster 300 ms per frame to 250 ms per frame.
This doesn't noticeably increase CPU usage on my machine.
Also fixed a small bug where the indicator would be drawn incorrectly
when an equalizer level was 0.
BUG=3541
TEST=Played a youtube video. Verified that the audio indicator in the
favicon was updated.
Review URL: https://codereview.chromium.org/14139022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=222681
For BrowserProcessImpl change:
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/14200028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a way to add ConsumeCallbacks to a SpdyBuffer in order to be notified
when Consume() is called. Use that to ensure that flow control receive
windows are updated appropriately regardless of what the SpdyStream's
delegate does.
Make IncreaseRevWindowSize private in both SpdyStream
and SpdySession.
BUG=176592
Review URL: https://codereview.chromium.org/14311002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove scoped_array usage from RegistryKeyBackup.
>
> BUG=171111
>
> Review URL: https://codereview.chromium.org/14265020
TBR=dcheng@chromium.org
Review URL: https://codereview.chromium.org/14330007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove scoped_array from Chromium.
>
> C++11 provides unique_ptr<T[]>, and Chromium has implemented
> scoped_ptr<T[]> to match its behavior during the transition period. As a
> result, scoped_array<T> is now redundant and is being removed.
>
> BUG=171111
>
> Review URL: https://codereview.chromium.org/14081006
TBR=dcheng@chromium.org
Review URL: https://codereview.chromium.org/14225009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Style-only change.
R=danakj
BUG=
Review URL: https://codereview.chromium.org/14205009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++11 provides unique_ptr<T[]>, and Chromium has implemented
scoped_ptr<T[]> to match its behavior during the transition period. As a
result, scoped_array<T> is now redundant and is being removed.
BUG=171111
Review URL: https://codereview.chromium.org/14081006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is the 4th in a series of changes that straddle webkit vs chromium repositories.
1) WK: Declare new virtual createSnapshotFile/didCreateSnapshotFile public api methods.
2) CR: Implement the new create method such that the didCreate method is invoked in response.
3) WK: Use the new create method and implement the new didCreate method.
4) CR: Cleanup the obsolete/deprecated blocks of code.
BUG=174200
Review URL: https://codereview.chromium.org/13891009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=170229
TEST=by hand as per repro on bug
Review URL: https://codereview.chromium.org/13972011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug when reading from a HTTP mount, if the Content-Length header
is not available.
It occurs because the code was caching a pointer to a std::vector's buffer,
after it had resized it.
BUG=none
R=noelallen@chromium.org
Review URL: https://codereview.chromium.org/13831005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/14017004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hopefully this is the last one before the scoped_array removal can land.
BUG=171111
Review URL: https://codereview.chromium.org/14161010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=171111
Review URL: https://codereview.chromium.org/14265020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
'bit' indicating executable.
BUG=101800
Review URL: https://codereview.chromium.org/13881003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Local environment:
$ cat ~/.gyp/include.gypi
{
'variables': {
'debug_devtools': 1,
},
}
The build fails with the following error:
../../chrome/browser/ui/webui/devtools_ui.cc: In constructor 'DevToolsUI::DevToolsUI(content::WebUI*)':
../../chrome/browser/ui/webui/devtools_ui.cc:239:59: error: cannot allocate an object of abstract type '{anonymous}::LocalhostDataSource'
../../chrome/browser/ui/webui/devtools_ui.cc:172:7: note: because the following virtual functions are pure within '{anonymous}::LocalhostDataSource':
../../content/public/browser/url_data_source.h:40:23: note: virtual std::string content::URLDataSource::GetSource() const
Review URL: https://codereview.chromium.org/14328007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194641 0039d316-1c4b-4281-b951-d872f2087c98
|