summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add new option --show-possible to valgrind for later use by valgrind_test.py ↵dank@chromium.org2009-07-232-0/+61
| | | | | | | | | | | to speed up log processing. BUG=17484 TEST=run to install new valgrind; sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit --show-possible=no"; grep PossiblyLost valgrind.tmp/* should find no matches. Review URL: http://codereview.chromium.org/159251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21365 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak thumbnail sizes a bit so it the NNTP looks better side by side onarv@google.com2009-07-235-21/+23
| | | | | | | | | | | | | | | | | | a 1920x1200 screen. Also, tweak the default size of new windows slightly. In case we decide to use side by side windows size the window in such a way that 2 windows fit on the screen and have the kWindowTilePixels spacing between each other and the screen edges. BUG=None TEST=Show two windows side. On a 1920x1200 screen they should both be showing the thumbnails in normal size. Review URL: http://codereview.chromium.org/155930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
* Update supressions.jam@chromium.org2009-07-231-6/+6
| | | | | | Review URL: http://codereview.chromium.org/159253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21363 0039d316-1c4b-4281-b951-d872f2087c98
* Fix undefined object properties showing up in reference pages.rafaelw@chromium.org2009-07-231-4/+7
| | | | | | Review URL: http://codereview.chromium.org/159231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21362 0039d316-1c4b-4281-b951-d872f2087c98
* Don't kill dsymutil after it finishes.dank@chromium.org2009-07-231-3/+5
| | | | | | | | | BUG=17441 TEST=sh tools/valgrind/chrome_test.sh -t ui on mac, watch it not time out when running dsymutil Review URL: http://codereview.chromium.org/159196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21361 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Fix handling of invalid entries that are detectedrvargas@google.com2009-07-2310-80/+200
| | | | | | | | | | | | | | | | | | | | when doing evictions or enumerations. This cl fixes an issue with dirty entries being deleted twice from disk, and improves the whole thing so that different flavors or corrupt entries are removed gracefully. We started deleting things twice when we created the map of currently-open entries, because we don't want to have dirty entries on that map, so it is possible to have multiple EntryImpl objects that refer to the same entry (for corrupt entries). BUG=17474 TEST=Unittests, stress_cache.exe Review URL: http://codereview.chromium.org/155951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21360 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit-test for 16199, to check caching behavior of conditonalized cache ↵ericroman@google.com2009-07-231-3/+132
| | | | | | | | | | | | requests (if-modified-since). This test does not pass, and is currently disabled -- it will be enabled once 16199 is fixed. BUG=http://crbug.com/16199 Review URL: http://codereview.chromium.org/159220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21359 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on V8Proxy.h from test_shell.cc.dumi@chromium.org2009-07-233-6/+10
| | | | | | | | | | BUG=17300 TEST=none Review URL: http://codereview.chromium.org/159232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21358 0039d316-1c4b-4281-b951-d872f2087c98
* ignore audio error and play video without audiofbarchard@chromium.org2009-07-231-6/+5
| | | | | | | | BUG=16023 TEST=play a multichannel audio video and it should play with audio muted Review URL: http://codereview.chromium.org/155937 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21357 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations after WebKit merge r46194:46229.paul@chromium.org2009-07-231-4/+5
| | | | | | | | | | TBR=darin TEST=None BUG=None Review URL: http://codereview.chromium.org/155968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21356 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the first thread in a child process to be the main thread, and make ↵jam@chromium.org2009-07-2329-355/+219
| | | | | | | | theIO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/155944 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak that only happens in layout test mode.tc@google.com2009-07-234-10/+5
| | | | | | | | | | | | | MockWebClipboardImpl is only used in layout test mode and it contains some member variables. Since the destructors weren't virtual, it was leaking these member variables. BUG=17184 Review URL: http://codereview.chromium.org/159238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21354 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 17468 - Regression: Extra white rectangle showing when ↵xji@chromium.org2009-07-231-8/+10
| | | | | | | | | | | | | | mouse hovering on every web page Should check tooltip text against empty before adding Unicode Marks for directionality. BUG=http://crbug.com/17468 BUG=http://crbug.com/17176 BUG=http://crbug.com/5996 TEST= open a webpage, mouse over plain text area, empty square should not show up as tooltip. Review URL: http://codereview.chromium.org/159222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21353 0039d316-1c4b-4281-b951-d872f2087c98
* Add --file_paths to converter to allow converter to rungman@google.com2009-07-238-42/+233
| | | | | | | | | | | | | | | | | | | | with typical collada files found on the net. Often someone will export a collada file with absolute paths like "z:\someplace\somewhere\texture.tga" and "k:\shared\stuff\othertexture.tga" The converter needed a way to handle these without requiring an artist to manually edit XML files. I also refactored the original_data_ stuff to make sure we don't get 2 datas for the same path. I'm doing that in prepartion for shortening the paths where possible using base-path or some mechanism. Review URL: http://codereview.chromium.org/159118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21352 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NOTIMPLEMENTED from IsDefaultPluginEnabled for Macstuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=17392 TEST=Less console spew on test bots. Review URL: http://codereview.chromium.org/155881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21351 0039d316-1c4b-4281-b951-d872f2087c98
* Populate the Linux extension shelf with placeholder labels containing each ↵phajdan.jr@chromium.org2009-07-232-22/+108
| | | | | | | | | | | extension's name. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/155957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21350 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BitmapPlatformDevice::DrawToContext handling of NULL src_rect on Macstuartmorgan@google.com2009-07-231-5/+4
| | | | | | | | | BUG=none TEST=Crash/kill a plugin process on the Mac; sad tab should draw in the right place. Review URL: http://codereview.chromium.org/155958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21349 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a regression from r21320 which caused a crash when dragging a tab ↵jhawkins@chromium.org2009-07-232-1/+11
| | | | | | | | | | out of the browser. We must wrap the tab renderer widget in a GtkFixed in order to maintain the size we request for the widget; otherwise, the widget will fill the entire window. BUG=none TEST=Drag a tab out of the window. This should not crash. Review URL: http://codereview.chromium.org/155965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21348 0039d316-1c4b-4281-b951-d872f2087c98
* Flip on crashed plugin name lookup on the Mac.stuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=none TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path. Review URL: http://codereview.chromium.org/155952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21347 0039d316-1c4b-4281-b951-d872f2087c98
* One part of many for enabling DOM Storage.jorlow@chromium.org2009-07-237-22/+536
| | | | | | | | | | | | | | Add browser-process IPC code + tweak the WebKit Thread. Note that this code can't possibly be called/run yet. WebKitThread now has a PostIOThreadTask methods that can safely post back to the IO thread. This should be used for all WebKit thread -> the rest of the world communication. There are many TODOs in this code that should be resolved before this is shipped without a --enable-local-storage flag. BUG=4360 TEST=none Review URL: http://codereview.chromium.org/155845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21346 0039d316-1c4b-4281-b951-d872f2087c98
* make sure to destroy main window when test shell is shutting down so we ↵estade@chromium.org2009-07-232-8/+5
| | | | | | | | | | | | don't get called back in our signal handlers and access freed memory. BUG=17188 TEST=sh tools/valgrind/valgrind_webkit_tests.sh LayoutTests/editing/pasteboard works Review URL: http://codereview.chromium.org/155893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21345 0039d316-1c4b-4281-b951-d872f2087c98
* Show bookmark manager context menu on mouse down, not up.estade@chromium.org2009-07-232-4/+56
| | | | | | | | | | | If the mouse down occurs over an unselected row, let the default handler run before we show the context menu (so that row will be selected when we show the menu). If the mouse down occurs over a selected row, don't let the default handler run (because if multiple rows are selected the rest of the selection would get clobbered). BUG=http://crbug.com/17388 TEST=see bug Review URL: http://codereview.chromium.org/159179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21344 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NULL_RETURN defect found by Coverity.cmp@google.com2009-07-231-1/+5
| | | | | | | | | | CID=4773 BUG=17081 TEST=Compile, run, and browse google.com with Chromium. Review URL: http://codereview.chromium.org/159227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21343 0039d316-1c4b-4281-b951-d872f2087c98
* Split the IPC code into ipc/agl@chromium.org2009-07-22128-745/+945
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Fix my previous revert. Merge issues.mpcomplete@chromium.org2009-07-221-3/+0
| | | | | | TBR: aa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix an issue with unregistering content script contexts."mpcomplete@chromium.org2009-07-224-38/+27
| | | | | | | | | | | | browser_tests are not happy. TBR=aa BUG=no TEST=no Review URL: http://codereview.chromium.org/159243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21340 0039d316-1c4b-4281-b951-d872f2087c98
* Use $PROGRAMFILES instead of "C:\Program Files\".pkasting@chromium.org2009-07-221-1/+3
| | | | | | Review URL: http://codereview.chromium.org/159241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21339 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/155945 which was erroneously reverted.rafaelw@chromium.org2009-07-227-341/+576
| | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/159240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21338 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge r46194:46229.paul@chromium.org2009-07-221-1/+1
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/159233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21337 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 2 extension messaging browsertests until I can figure out why they arempcomplete@chromium.org2009-07-221-0/+4
| | | | | | | | | | | | failing on the buildbot. TBR=aa BUG=no TEST=no Review URL: http://codereview.chromium.org/159235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21336 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in FileDataSourcehclam@google.com2009-07-221-4/+5
| | | | | | | | | | | FileDataSource broke the linux valgrind build because the callback for read was not deleted. TBR=scherkus Review URL: http://codereview.chromium.org/159234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21335 0039d316-1c4b-4281-b951-d872f2087c98
* revert r21327, which broke MessagingExtensionTabestade@chromium.org2009-07-227-576/+341
| | | | | | | | | | <http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests> tbr=rafaelw Review URL: http://codereview.chromium.org/155955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21334 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Skia merge 279:284"agl@chromium.org2009-07-222-2/+2
| | | | | | | | | This reverts commit r21332. REVERT=21332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21333 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 279:284agl@chromium.org2009-07-222-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21332 0039d316-1c4b-4281-b951-d872f2087c98
* A couple more notations for flaky media tests.estade@chromium.org2009-07-221-2/+2
| | | | | | | | TBR=awong Review URL: http://codereview.chromium.org/155949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21331 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations for WebKit merge r46143:46194.paul@chromium.org2009-07-221-11/+4
| | | | | | | | | | | I've updated revelant bugs to indicate new test status. BUG=None TEST=None Review URL: http://codereview.chromium.org/155948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21330 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent omnibox autocomplete from stealing the primary X selection.estade@chromium.org2009-07-222-31/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly accomplished by decoupling autocomplete (and the auto-select-all when first clicking in the omnibox to focus it) from GTK's clipboard code. Before we update the selection marks, I unregister the clipboard and block the signal from reaching my handler. Afterwards, I restore things. This creates the possibly-odd effect that text can be highlighted both in the omnibox and in Webkit, assuming that the omnibox text isn't actually the primary selection. I think that this is reasonable, but let me know if you can think of a better way that it should be handled. To test, I confirmed that all of the cases listed in http://codereview.chromium.org/151006's description still work, along with the following new ones: 1. Highlight text in an xterm to make it the primary selection. Start typing an autocomplete-able URL into Chrome's omnibox. Middle-click in the xterm and check that the xterm's text, rather than the autocompleted text from the omnibox, is pasted. 2. Now switch to a different tab and middle-click in the xterm again. The xterm's text should still be pasted. 3. Switch to the original tab and check that the xterm's text is still the primary selection. 4. Highlight text in an xterm. Click in Webkit to make sure that the omnibox doesn't have the focus. Left-click in the omnibox. Its text should be highlighted but not made the primary selection (middle-clicking in the xterm should still paste the xterm's text). EDIT: I've changed this behavior -- clicking in the omnibox to focus it now sets its text as the primary selection. 5. Now triple-left-click in the omnibox to highlight all of its text. This time, the URL should become the primary selection. EDIT: This is no longer relevant. I noticed the following annoying behavior, but it's also present in the official build without this change, so I don't think it's a regression (there's probably something going on in GTK that I don't understand): Highlight some text in the omnibox to make it the primary selection. Now double-left-click to highlight a word in an xterm. The word flashes in the xterm, but Chrome automatically grabs the selection again. Double-clicking in the xterm again lets it hang on to the selection. Patch by Dan Erat <derat [at] google> original review url: <http://codereview.chromium.org/159185> Review URL: http://codereview.chromium.org/159230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21329 0039d316-1c4b-4281-b951-d872f2087c98
* Made the title of panels show focused state with black textdavemoore@chromium.org2009-07-224-6/+62
| | | | | | | (as opposed to grey text in unfocused panels) Review URL: http://codereview.chromium.org/159176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21328 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions Doc:rafaelw@chromium.org2009-07-227-341/+576
| | | | | | | | | | | | | | | | Expand complex types in reference pages. Support $ref for types in docs. Added Kathyw's template changes including leftNav and header. Remove old api files. R=aa Review URL: http://codereview.chromium.org/155945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21327 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to provide asynchronous read in data source:hclam@chromium.org2009-07-2228-1258/+2501
| | | | | | | | | | | | | 1. FFmpegGlue now taks a FFmpegProtocol instead of DataSource as input 2. FFmpegDemuxr implements FFmpegProtocol and does the blocking read and submit asynchronous read request to DataSource (with unit tests) 3. Changed SimpleDataSource to work with asynchronous read (with unit tests) 4. Reimplemented BufferedDataSource to work with asynchronous read (with unit tests) 5. Moved BufferedDataSource from chrome/renderer/media to webkit/glue/media (for faster build/debug and better coverage in automated testing) TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*, FFmpegDemuxerTest.* Review URL: http://codereview.chromium.org/149567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21326 0039d316-1c4b-4281-b951-d872f2087c98
* Modified the hud-2d-overlay sample to reset the icon transforms and preventvangelis@google.com2009-07-221-8/+13
| | | | | | | them from moving when running the selenium tests in order to get consistent snapshots. Review URL: http://codereview.chromium.org/155928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21325 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue with unregistering content script contexts.mpcomplete@chromium.org2009-07-224-28/+38
| | | | | | | | | | | Reenable content script messaging test. BUG=no TEST=no Review URL: http://codereview.chromium.org/155887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21324 0039d316-1c4b-4281-b951-d872f2087c98
* Make UtilityProcessHost destructor virtual.mattm@chromium.org2009-07-222-8/+1
| | | | | | | | BUG=17129 Review URL: http://codereview.chromium.org/155946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21323 0039d316-1c4b-4281-b951-d872f2087c98
* Try and improve result coalescing/display in the omnibox popup.pkasting@chromium.org2009-07-224-144/+66
| | | | | | | | | | | | | | | | | | | | | | | | This eliminates the delay timer in the popup view, and also eliminates the coalesce timer in the controller. Instead, we simply coalesce until we're done, we have at least as many results as we're already showing, or the "maximum delay timeout" (300 ms) fires, indicating we've gone too long without updating. Additionally, in order to be more responsive when typing rapidly, the controller updates observers immediately with the available results from a previous query if one is still running when a new query is started. While in theory this seems like it might produce flicker, in practice _not_ having it also results in flicker (just less-predictable flicker) since the 300 ms timeout starts kicking in at random times relative to when new keys are pressed. I also fixed a few small problems with leaving 1-pixel high white rows at the bottom of the popup during rapid typing (which weren't visible before this change since the popup would never shrink during rapid typing). After eliminating the timeout in the popup view, I was able to refactor the code to be shorter since a few members and helper functions could all be inlined. Then I added some long comments and made things not much shorter after all :/. I also changed two other (self-contained) unrelated spots in the popup to be shorter. Please patch this in locally and try how it feels. Things to test with this change vs. the old code vs. the old, old (original omnibox) code: * Type one letter at a time with long pauses in between; see how flickery the popup is * Type one letter (e.g. "a") and then type rapidly for a while; see how responsive the popup is * Type words like "amazon", "compusa" and "comcast" at various different speeds and observe the flicker vs. responsiveness tradeoff * Type or paste some long series of letters (that default to searching), then rapidly press and release the ctrl key My hope is that this hits a good balance (it's very difficult to be both flicker-free and responsive, I view the previous two sets of code as being off first one side of the scale and then the other). Possible tweaks include the animation tweening mechanism and timing (I experimented with various different speeds and linear tweening, nothing felt significantly better to me but my machine sucks w.r.t. animation quality) and tweaking the controller "max timeout" value and notification behavior upon starting a new query (I tried notifying only if two keys had been typed since the last notification, it didn't feel better). BUG=none TEST=see above Review URL: http://codereview.chromium.org/149659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21322 0039d316-1c4b-4281-b951-d872f2087c98
* Nasty short-term hack to special case display of dialogaa@chromium.org2009-07-225-31/+65
| | | | | | | | | | | | | | | on theme installation. It should not be displayed if the theme was installed from our gallery URL. I intend to fix this very soon, but I wanted it to make this coming build, so I did this quick thing for now. Also, I found another bug in ExtensionsService install logic. There was a test, it was ensuring the wrong behavior :(. Review URL: http://codereview.chromium.org/155936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21321 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Keep track of the tab bounds using the size-allocate signal. ↵jhawkins@chromium.org2009-07-222-7/+29
| | | | | | | | | | Previously we assumed that the tab was immediately sized as requested, which was not always happening. This fixes a problem seen in RTL layout where the close button would be incorrectly positioned. BUG=16756 TEST=Open the browser in a RTL language. Notice that the close buttons on tabs are positioned correctly. Review URL: http://codereview.chromium.org/155942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken build because of r21317hclam@google.com2009-07-221-13/+16
| | | | | | | | TBR=scherkus, nsylvain Review URL: http://codereview.chromium.org/159226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21319 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore errors about creating audio output streamhclam@chromium.org2009-07-222-5/+7
| | | | | | | | | | | | | | | Instead of failing the media playback pipeline completely, this change will ignores all errors reported by the browser about audio output streams. This is the first step towards handling audio hardware errors. TEST=MediaTest.VideoBearTheora Review URL: http://codereview.chromium.org/159205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21318 0039d316-1c4b-4281-b951-d872f2087c98
* Additional test to exploit memory leaks in <video>hclam@google.com2009-07-222-10/+58
| | | | | | | | | | | | | TEST=MediaLeakTest.ManyVideoBear This test inject and remove a <video> element many (50) times. Trying to exploit memory leaks during the creation and destruction of the internal media player and the glue code with WebKit. Review URL: http://codereview.chromium.org/159204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21317 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected test failures for WebKit merge r46143:46194.paul@chromium.org2009-07-221-8/+8
| | | | | | | | | | TBR=darin BUG=None TEST=None Review URL: http://codereview.chromium.org/159223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21316 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-12 06:47:46 +0000