summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixing bug that 8bit PCM stream is gabbledhclam@chromium.org2009-06-151-8/+10
| | | | | | | | | | | | | | | | | | The CodecContext passed into FFmpegAudioDecoder by the FFmpegDemuxer says the output samples are 16bits. So we tell the audio renderer to create a 16bits audio output stream. But after the decoder is allocated by avcodec_find_codec, the sample bits information in |codec_context_| is changed to 8bit! So we are feeding 16bits output stream with 8bits data. The decoder should knows more about the actual output format. So query the sample bits information after the decoder is allocated. Review URL: http://codereview.chromium.org/125027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18406 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add support for chrooted renderers.agl@chromium.org2009-06-1517-20/+1103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxSandboxIPC Without filesystem access from the renderers, we need another way of dealing with fontconfig and font loading. This add support for: * An "SBX_D" environment variable in the renderers which is used to signal the end of dynamic linking so that the chroot can be enforced. * A sandbox_host process, running outside the sandbox, to deal with fontconfig requests from the renderers. See the wiki page for the reasoning behind making it a separate process. * A new, custom SkFontHost for Skia. Because this is Chrome specific, it will live outside the upstream Skia tree. This FontHost can be configured either to drive fontconfig directly (for the browser process and for any unsandboxed renderers) or to use an IPC system. Since the same SkFontHost has to be linked into both the browser and renderer (they are the same binary), this switch has to be made at run time. Sandbox IPC calls are rare (a couple of dozen at page load time) and add about 50us of overhead for each call. (Reland of r17575 which was reverted in r17577) http://codereview.chromium.org/112074 BUG=8081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18405 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a UMR that happens while trying to forward mouse events.tc@google.com2009-06-151-2/+5
| | | | | | | | | | | | | The input param gets clobbered so we need to make a copy before using it. TEST=Run chrome via valgrind and move the mouse over the content area. There should be no errors. Review URL: http://codereview.chromium.org/126081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18404 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug that <video> is not rendered if clipped/mirroredhclam@chromium.org2009-06-151-4/+13
| | | | | | | | | | | | Since we are not using the YUV->RGB code to perform fast flipping and mirroring. Use FastPaint to handle flipping and mirroring was wrong. There's no plan to support fast flipping and mirroring in the short future so fall back to SlowPaint for this case. Review URL: http://codereview.chromium.org/126093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18403 0039d316-1c4b-4281-b951-d872f2087c98
* Fix focus traversal cycle.yutak@chromium.org2009-06-153-40/+11
| | | | | | | | | | This change makes traversal order of focus cycle consistent between forward and backward traversal. This is a partial fix for issue 6785. BUG=http://crbug.com/6785 TEST=Move the focus to the find bar, and push [Shift]+[Tab]. The focus should not cycle inside the find bar, but go out to the omnibox (or somewhere outside the find bar). Review URL: http://codereview.chromium.org/125130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18402 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6223 (comment #10 and #15).xji@chromium.org2009-06-151-10/+54
| | | | | | | | | | | | | | | | | | | | | There are the following 3 issues: 1. the tab image in gray box is wrong in RTL locale. This is fixed by flipping canvas in RTL locale when draw those images. 2. dropped tab was not rendered in the correct position when gray box appears but the tab was not dropped inside the gray box. This is fixed by adjusting x coordinate of the dropped tab when there is dock information available in RTL in CompleteDrag(). 3. when chrome is maximized, drag/drop a tab to left/right window, then drag the tab through original main browser tabstrip and drop it anywhere else, dropped tab was not rendered in the right position. This is fixed by initialize window create point based on source_tabstrip_, not attached_tabstrip_, and move the initialization function from Attach() (since the position is no longer related to attached_tabstrip_) to CaptureDragInfo() where the mouse_offset_ is set. BUG=http://crbug.com/6223 TEST= 1. Open Hebrew Chrome, 2. drag a tab to the right of the screen till the gray box showed up, the tab image showed in the gray box should be similar to the tab image in Hebrew Chrome (not that in English Chrome), 3. drop the tab outside of the gray box while gray box is showing, the dropped tab should be rendered using the mouse click as the top-right corner (not top-left corner). 4. maximize chrome and open at least 2 tabs in it. 5. drag a tab out to left screen till the "left-half of screen" gray box showed up and drop it inside the gray box so that the tab was in the left-half of the screen and the original chrome browser is still maximized. 6. drag this tab back to the title of chrome (as if to re-insert it back to the maximized chrome's tabstrip) but do not release mouse, continue drag it back to somewhere on the screen and drop it. The dropped tab should be rendered using the mouse click as a point in its tabstrip (not rendered far away from the mouse click). Review URL: http://codereview.chromium.org/126006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18401 0039d316-1c4b-4281-b951-d872f2087c98
* Use linked_ptr for the ExternalExtensionProviders.finnur@chromium.org2009-06-152-35/+36
| | | | | | | | | BUG=None TEST=Covered by automated tests. Review URL: http://codereview.chromium.org/125137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18400 0039d316-1c4b-4281-b951-d872f2087c98
* Capture more necessary settings while trying to land conversionsgk@google.com2009-06-152-0/+9
| | | | | | | | | | | of the last targets to gyp: * 'unit_tests' depends on 'chrome_dll_version'. * Various VCCLCompilerTool and VCLinkerTool settings for mini_installer.exe. BUG=none TEST=none Review URL: http://codereview.chromium.org/125136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix segfault in HttpNetworkLayerTest.GoogleGET when network connection fails.phajdan.jr@chromium.org2009-06-151-1/+1
| | | | | | | | | | | | | | | This is rather a workaround for the root cause (test touches the network), but it should not crash anyway. After this patch the test will fail, not segfault. TEST=Covered by net_unittest. Check with network connection disabled. BUG=http://crbug.com/13195 Review URL: http://codereview.chromium.org/125128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18398 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up extension loading:erikkay@google.com2009-06-158-303/+365
| | | | | | | | | | | | | | | | | | | * load extensions from prefs rather than by scanning filesystem * fix multiple loading bug * in-place upgrade * split out Init() behavior into individual pieces that can be called by tests Also: * add look up of extension by URL * rename GetExtensionByID -> GetExtensionById BUG=12399 BUG=14053 TEST=ExtensionServiceTest.* Review URL: http://codereview.chromium.org/125102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in CocoaUtils::SkBitmapToNSImagenirnimesh@chromium.org2009-06-151-0/+1
| | | | | | Review URL: http://codereview.chromium.org/125127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18396 0039d316-1c4b-4281-b951-d872f2087c98
* Extract form related classes from the guts of WebFrameImpl.darin@chromium.org2009-06-1542-601/+665
| | | | | | | | | | | | | | | | | | | Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so. This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API. Most significant change: Now, RenderView always sets a NavigationState on WebDataSource instances. We used to only do so for browser initiated navigations. This is done so that we can store things like SearchableFormData and friends on the NavigationState. To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement. This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens. Some of the other changes are about moving more things into the webkit_glue namespace. On hindsight, I probably should have done that as a separate CL. BUG=10041 TEST=none R=brettw Review URL: http://codereview.chromium.org/126083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18395 0039d316-1c4b-4281-b951-d872f2087c98
* Popuplate bookmark menus on 1st launch.jrg@chromium.org2009-06-152-3/+22
| | | | | | | | | | | | | BUG=13794 TEST=launch Chrome. Before doing anything (e.g. changing focus or creating new windows), make sure the bookmark menu is populated. If you have no bookmarks you'll need to add them ('star' some URLs) then restart Chrome. Review URL: http://codereview.chromium.org/125094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18394 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing test under Purify to green the tree. This ↵erikkay@google.com2009-06-151-0/+3
| | | | | | | | | | | | | | | change should be rolled back ASAP (when the underlying bug is fixed). BUG=crbug.com/14103 TEST=ExtensionsServiceTest.PackExtension under purify TBR=aa Review URL: http://codereview.chromium.org/125134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18392 0039d316-1c4b-4281-b951-d872f2087c98
* Use current dir as working directory if %TEMP% directory doesnt work.kuchhal@chromium.org2009-06-151-17/+29
| | | | | | | | | BUG=6471 TEST=set TMP to invalid dir and run mini_installer.exe, it should still work. Review URL: http://codereview.chromium.org/125068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18391 0039d316-1c4b-4281-b951-d872f2087c98
* Badge browser window with incognito icon when in incognito modepinkerton@chromium.org2009-06-152-0/+29
| | | | | | | BUG=12536 TEST=incognito icon on window opened in incognito mode git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18390 0039d316-1c4b-4281-b951-d872f2087c98
* Fix favicon display on the NTP on os x. The favicons get corrupted before ↵thakis@chromium.org2009-06-151-0/+6
| | | | | | | | | | | | | | | they are written to the favicon db, so this patch will only fix new favicons. TEST=Open the NTP and see that favicons with transparency look broken. Close Chromium, delete ~/Library/Application\ Support/Chromium, go to a page with a favicon with transparency (e.g. http://codereview.chromium.org/), open another NTP, and make sure that the favicon is now displayed correctly. BUG=None as far as I know. Review URL: http://codereview.chromium.org/126108 Review URL: http://codereview.chromium.org/126108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18389 0039d316-1c4b-4281-b951-d872f2087c98
* Make WidgetGtk::SetBounds use a single call if it can.sky@chromium.org2009-06-151-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18388 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronizes message types.sky@chromium.org2009-06-151-12/+42
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18387 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting Rev 18383 since it brings down the performance of single core page ↵mad@chromium.org2009-06-1512-382/+117
| | | | | | cyclers too much... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18385 0039d316-1c4b-4281-b951-d872f2087c98
* Use V8 benchmark suite version 4 on the buildbots.ager@chromium.org2009-06-1511-2536/+476
| | | | | | | BUG=12674 Review URL: http://codereview.chromium.org/126126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18384 0039d316-1c4b-4281-b951-d872f2087c98
* This is to thest the page cycler performance without the resize corner, to ↵mad@chromium.org2009-06-1512-117/+382
| | | | | | | | | | | | | see if these paint optimizations are worth it. I will revert these changes as needed... You may revert them yourself if they cause you trouble before I get to revert them. I have tested these changes on two different linux configuration, but there are more code paths that I couldn't verify myself, though agl gave me the OK anyway. These changes have already been reviewed here: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18383 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add exception handling support into the window context evaluation.pfeldman@chromium.org2009-06-155-17/+38
| | | | | | Review URL: http://codereview.chromium.org/126122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18382 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize IOBuffers in new FTP unit tests (issue detected by valgrind).phajdan.jr@chromium.org2009-06-151-4/+13
| | | | | | | | | | TEST=none BUG=http://crbug.com/12409 Review URL: http://codereview.chromium.org/126120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert processing naming change, which breaks UI tests iterating over thedeanm@chromium.org2009-06-152-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chrome processes by name. Reverting: commit b60e93b5ccb3bf0eefbc5b15b74b5a8be30aa589 Author: deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Jun 15 09:59:38 2009 +0000 Set process name on Linux This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://chrome-svn/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98 Review URL: http://codereview.chromium.org/126119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18380 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the GLib message pump.deanm@chromium.org2009-06-153-10/+555
| | | | | | | | | | | This CL also adds a few comment updates that were lost in CL 115812 submission. Patch by Antoine Labour. Review URL: http://codereview.chromium.org/118155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix o3djs.loader.loadScene so it has opt_options argument.gman@google.com2009-06-151-6/+10
| | | | | | Review URL: http://codereview.chromium.org/118366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18378 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Provisional commit for ↵pfeldman@chromium.org2009-06-153-38/+59
| | | | | | | | https://bugs.webkit.org/attachment.cgi?id=31255 landing. Review URL: http://codereview.chromium.org/125119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18377 0039d316-1c4b-4281-b951-d872f2087c98
* Set process name on Linuxdeanm@chromium.org2009-06-152-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for new FTP network transaction.phajdan.jr@chromium.org2009-06-155-186/+706
| | | | | | | | | | TEST=Covered by net_unittests. http://crbug.com/12409 Review URL: http://codereview.chromium.org/115779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18375 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: extension content script names are shown with a background color ↵yurys@google.com2009-06-154-5/+50
| | | | | | | | | different from other scripts. BUG=13677 Review URL: http://codereview.chromium.org/125116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18374 0039d316-1c4b-4281-b951-d872f2087c98
* Consider a redirect following user gesture as user-initiated in maintainingyuzo@chromium.org2009-06-1518-33/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | navigation entries. Also, ignore redirect- or machine-initiated- new subframe navigations. The current code treats all redirects as machine-initiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement user-initiated navigation (Bug 11896). This change assumes that a machine-initiated redirect happens within 300ms since the last document load was completed, while a user-initiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine- initiated or user-initiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18373 0039d316-1c4b-4281-b951-d872f2087c98
* [Refactor] Rename DnsResolutionObserver --> HostResolver::Observer.ericroman@google.com2009-06-159-60/+23
| | | | | | | | | | TEST=this is striclty a refactoring; just needs to compile and pass existing tests. BUG=14056 Review URL: http://codereview.chromium.org/126110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18372 0039d316-1c4b-4281-b951-d872f2087c98
* * Move the global "DnsResolutionObserver" code depended on by DNS ↵ericroman@google.com2009-06-1522-264/+523
| | | | | | | | | | | | | | prefetcher, into HostResolver. This has the advantage that consumers of DNS no longer have to remember to call "DidFinishDnsResolutionWithStatus()" followed by "DidStartDnsResolution()" in order for the prefetcher to observe the resolution. Instead it just happens automatically, and subscribers register via HostResolver::AddObserver() on a particular resolver instance. * To accomodate the prefetcher's observer, HostResolver::Resolve() needs an additional "referrer" parameter. This is slightly awkward since "referrer" has nothing to do with the actual resolve request. To simplify plumbing through this and other optional parameters, Resolve() was changed to take a "RequestInfo&" parameter in place of say {hostname, port, flags}. * Added an option to HostResolver::Resolve() for disallowing cached responses (RequestInfo::allow_cached_response). This will be used when you refresh a page, to bypass the host cache. The code to do this has been added to HttpNetworkTransaction, but is commented out pending an appropriate unit-test to verify it. BUG=14056 Review URL: http://codereview.chromium.org/125107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18371 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed 3 tests that failed in hebrew enabled vistahbono@chromium.org2009-06-157-3/+75
| | | | | | | | | | | | | | | | | | | | | | | | | BrowserTest.NoTitle BrowserTest.Title AutomationProxyVisibleTest.WindowGetViewBounds Some notes : There has been a small regression in the UI tests which makes them get stuck even more on my very slow machine (maybe race conditions) however, the fixes i post here do not make this state any worse and fix these 3 tests above which always failed TEST=1. run ui_tests on a RTL windows (or use --extra-chrome-flags=--lang=he) 2. the 3 tests listed above will always fail, as they expect LTR behavior 3. this fixes it BUG=12636 http://code.google.com/p/chromium/issues/detail?id=12636 Original Patch by Yoav Zilberberg <yoav.zilberberg@gmail.com> Original review: http://codereview.chromium.org/118441 R=me,jeremy,sky Review URL: http://codereview.chromium.org/125036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18370 0039d316-1c4b-4281-b951-d872f2087c98
* Fix commented-out favicon dumping code.thakis@chromium.org2009-06-141-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18369 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsViewWin and RenderViewContextMenu*Win to ↵ben@chromium.org2009-06-148-18/+18
| | | | | | | | | | | | | | | browser/views/tab_contents They are dependent on the views API (WidgetWin, Menu2, SadTabView, etc etc) so this makes sense. As a follow-on step, I will create a new tab_contents_view_gtk.cc/h in browser/views/tab_contents as well, so TOOLKIT_VIEWS is not exposed to bustage introduced from the non-TOOLKIT_VIEWS version of this file as it is now. I cannot have two files called "tab_contents_view_gtk" in the same directory (browser/tab_contents). Mimicking TabContentsViewWin, TOOLKIT_VIEWS TabContentsViewGtk will subclass WidgetGtk, use browser/views/sad_tab_view and utilize RenderViewContextMenuWin which is now cross platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/126099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18368 0039d316-1c4b-4281-b951-d872f2087c98
* Wean activex_shim from urlmon.lib:sgk@google.com2009-06-144-12/+7
| | | | | | | | | | | | | | Remove urlmon.lib from activex_shim's AdditionalDependencies. Add urlmon.lib to AdditionalDependencies in chrome_dll.vcproj and unittests.vcproj. Add activex_shim as a dependency of default_plugin, so the things that link against default_plugin get urlmon.lib from the activex_shim link_settings. BUG=none TEST=none Review URL: http://codereview.chromium.org/126103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18366 0039d316-1c4b-4281-b951-d872f2087c98
* Add .fragment and .sigs to non-compilable suffixes.craig.schlenter@chromium.org2009-06-141-1/+3
| | | | | | | | This fixes the shared build on Linux after r18122. Review URL: http://codereview.chromium.org/123015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell_tests going over the limit of /I directoriessgk@google.com2009-06-141-0/+3
| | | | | | | | | passed to the resource compiler, too. BUG=none TEST=none Review URL: http://codereview.chromium.org/125110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18364 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the PlatformContext layer to have only one class.brettw@chromium.org2009-06-1460-968/+844
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Review URL: http://codereview.chromium.org/125109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected results.abarth@chromium.org2009-06-141-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18362 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit DEPS and fix build.abarth@chromium.org2009-06-143-6/+10
| | | | | | | TBR=pkasting Review URL: http://codereview.chromium.org/125108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18361 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18359.sgk@google.com2009-06-144-5/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18360 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.dll to gyp generation.sgk@google.com2009-06-144-11/+5
| | | | | | | | | | | | | | | | Remove unnecessary addition of urlmon.lib to AdditionalDepenedencies of activex_shim. Add activex_shim as a dependency of default_plugin (so the things that link against it get urlmon.lib from the link_settings of activex_shim). Add urlmon.lib to AdditionalDependencies in unittests.vcproj (which is going away soon, but this makes the transition smooth). BUG=none TEST=none Review URL: http://codereview.chromium.org/126073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18359 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in gyp support for a 'resource_include_dirs' setting.sgk@google.com2009-06-132-1/+4
| | | | | | | | | | Use it to keep the number of /I options we pass to webkit resource compilation within acceptable limits. BUG=none TEST=none Review URL: http://codereview.chromium.org/125104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18358 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix Linux bustagepkasting@chromium.org2009-06-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18357 0039d316-1c4b-4281-b951-d872f2087c98
* Include sys/types.h for ssize_t. This fixes compliation with gcc-4.3.darin@chromium.org2009-06-132-1/+1
| | | | | | | | | Patch contributed by Joel Stanley R=deanm Review URL: http://codereview.chromium.org/125097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18356 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18354.sgk@google.com2009-06-133-5/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary addition of urlmon.lib to AdditionalDependenciessgk@google.com2009-06-133-10/+5
| | | | | | | | | | | of activex_shim. Add it as a dependency of default_plugin. Add urlmon.lib to AdditionalDependencies in unittests.vcproj (going away soon, but this makes the transition smooth). BUG=none TEST=none Review URL: http://codereview.chromium.org/125099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18354 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-07 13:21:39 +0000