| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so we can do basic UTF8/16/32 conversions without linking all of ICU.
Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using
these new functions. I will remove the Sys versions of these functions in a
later patch.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wasn't aware of it in my initial change that made us use
override-redirect windows for InfoBubbleGtk, but clicking on
the bookmark bubble's folder combobox steals InfoBubbleGtk's
pointer and keyboard grabs, resulting in the other widgets
in the window behaving as if they're inactive after the
combobox's popup is closed. This somewhat hacky change
makes us reinstall the bubble's grabs after the popup closes.
TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally
Review URL: http://codereview.chromium.org/260019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm still seeing some defunct processes, but not one for every tab, and they don't appear to be former renderer processes, so that's probably a separate bug.
BUG=23778
TEST=after closing a tab ps shows that the renderer is gone (not just defunct)
Review URL: http://codereview.chromium.org/242155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22608
Review URL: http://codereview.chromium.org/256084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well.
I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907
BUG=22836
TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes.
Review URL: http://codereview.chromium.org/255086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show.
BUG=23902
TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar.
Review URL: http://codereview.chromium.org/258038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object goes out of scope.
The control flow was as follows:
1. user initiates a save page command
2. user initiates a second save page command
3. tab contents creates a SavePackage, shows dialog
4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl
5. At this point two dialogs are visible.
6. User dismisses second dialog.
7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl.
8. Bad stuff.
BUG=23817
TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared.
Review URL: http://codereview.chromium.org/243117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/257074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit_tests compiles with views.
Review URL: http://codereview.chromium.org/255102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
which failed on XP Perf (single).
This reverts commit r28199.
TBR=tony
Review URL: http://codereview.chromium.org/265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused kernel scoped unlock.
BUG=19895
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/246097
TBR=chron@chromium.org
Review URL: http://codereview.chromium.org/265001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/263001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
due to test_expectations corruption. This should be the same,
just without crazy changes to test_expectations.
I have no idea how that happened.
BUG=none
TEST=none
TBR=johnnyg
Review URL: http://codereview.chromium.org/260025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23043
TBR=senorblanco
Review URL: http://codereview.chromium.org/242169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798,18584
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/260024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/258040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It somehow really screwed up test_expectations.
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/259066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NPN_GetAuthenticationInfo. With these NPAPI functions there's no need to simulate being in Firefox and implement NPN_GetValue for NPNVserviceManager.
TEST=run manual test that Ken added in test\data\plugin over http
Review URL: http://codereview.chromium.org/251101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents sends a notification which is picked up by the browser
automation controller which keeps a map of events and times. Add
an automation IPC so that tests can get these values from the
browser automation controller. Finally, add a feature startup test
to collect these values.
This is just to get some consistent timings from the buildbot.
BUG=23120
Review URL: http://codereview.chromium.org/246105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused kernel scoped unlock.
BUG=19895
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/246097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/256074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/48989 and 48999 updated text kerning which broke the text-rendering tests.
http://track.webkit.org/changeset/49003 changed the name of the box-shadow style, and also changed the ordering of the
computed style values, necessitating rebaselining.
Review URL: http://codereview.chromium.org/243110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the buildbots.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/257072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/22727
TEST= Set preferred language to a different setting from the locale in the OS X system settings.
Make sure that the language of the tips matches the language setting (which
should be the same as that of the Chrome UI). If tips are not available in
the Chrome UI language, no tips should be shown.
Review URL: http://codereview.chromium.org/258037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=johnnyg
TEST=try servers
BUG=none
Review URL: http://codereview.chromium.org/255095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixed min size of the browser to take into account the browser actions.
BUG-23924
TESTS=Open Chrome with --bookmark-menu and make sure browser actions you install appear to the left. Also, resize the browser horizontally and make sure it always shows all the controls in the chrome (from Back to App menu).
Review URL: http://codereview.chromium.org/246102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserActionsContainer is the child view of ToolBarView. When BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to re-layout ToolBarView, its parent.
BUG=23381
TEST=none
Review URL: http://codereview.chromium.org/246107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/242168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
build, and also removes a hack that was put in to get around Linux
Gyp's old odd behavior.
Review URL: http://codereview.chromium.org/260023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=23833,23835
TEST=none
Review URL: http://codereview.chromium.org/259065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798,14207,18584
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/257073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=23549
Review URL: http://codereview.chromium.org/260015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Shows a Gmail logo with a strike out diagonal line when not logged in.
- Allows the user to click on the BrowserAction to log in.
- If there are unread emails on login, the GMail logo blinks.
- Shows the number of unread emails as a Badge (red in color!).
- Shows the number of unread emails as a tooltip text if hovered on.
- When a new email comes, the GMail logo blinks and the badge text updates.
BUG=23898
TEST=none
Review URL: http://codereview.chromium.org/246093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/259063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
comments in http://codereview.chromium.org/251097 .
Review URL: http://codereview.chromium.org/243111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798,13907,14207,23498
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/260022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23458
TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme.
Review URL: http://codereview.chromium.org/243114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds legacyExpectationsSemantics hash parameter to have the dashboard
use the fuzzy logic that test_expectations uses for FAIL. But also,
when a test had an IMAGE and TEXT failure in the past, we would only
record it as an IMAGE failure, so we don't yet have a way of
distinguishing IMAGE from IMAGE+TEXT. I have a change to run_webkit_tests
to record that information, but it'll take a few runs on the bots before
there is enough data to be reliable.
Review URL: http://codereview.chromium.org/256085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new tab times didn't change on linux/mac so that's probably
not the problem. This will speed up the new tab tests.
Review URL: http://codereview.chromium.org/256083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
update time. Change manifest-fb-404 entry ordering so all 3 requests always happen regardless of which order the url requests complete in.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/257065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
2. Change hiding the WONTFIX test to also include SKIP tests.
3. Make the search case-insensitive and treat all paths as search queries.
4. If a test is expected to TIMEOUT, but never does, still mark it as needing
SLOW if it takes >2 seconds to run.
Review URL: http://codereview.chromium.org/260016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
turning off border work.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/256080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
output of run_webkit_tests. This is so the dashboards
can match test_expectations.txt semantics. Eventually,
we can use this data to replace all the FAIL expectations
with TEXT/IMAGE/IMAGE+TEXT as appropriate.
Add a TODO to run_webkit_tests to get statistics right
now that we have IMAGE+TEXT expectations.
Treat simplified diff failures as TEXT failures for the JSON
output since noone seems to care about tracking it anymore.
We really should just stop spitting out simplified diffs at all.
Review URL: http://codereview.chromium.org/251096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for landing in Chrome.
The biggest pieces here are moving some of the third party
dependencies back into o3d/third_party because they need
to be distinct from the chrome versions of the same packages,
and because O3D is the only one using the dependency.
(NPAPI in particular).
Also the plugin gyp file is now modified so that it can handle
being part of both a chrome developer tree and an o3d developer
tree (in the latter case, it generates the plugin and installer, in
the former it does not)
BE AWARE that this change will change the main solution/xcodebuild file
from "build/all" to be "build/o3d", but rebuilding from gyp files will NOT
remove the old "build/all" one, so you might be tricked into opening the
wrong one.
Review URL: http://codereview.chromium.org/256081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/242166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green bots
TBR=pkasting
Review URL: http://codereview.chromium.org/260020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
form.
TESTED=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests)
Review URL: http://codereview.chromium.org/255093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28166 0039d316-1c4b-4281-b951-d872f2087c98
|