| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed fallback to english defaults in the grd file.
BUG=7319 (http://crbug.com/7319)
TEST=Open browser with --lang=ml and confirm fonts in the UI are the
same size as before (and look ok).
Original review: http://codereview.chromium.org/126238
Patch by cira
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Consistent use of <(SHARED_INTERMEDIATE_DIR)/setup for the
output directory of the generated setup_exe_version.rc file.
* Add setup/setup_util.{cc,h}.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14231
Review URL: http://codereview.chromium.org/125235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a new TabContentsViewGtk specifically for views. This subclasses WidgetGtk similar to how TabContentsViewWin subclasses WidgetWin.
There was a bug in NativeViewHostGtk - reparenting needs to be done atomically using gtk_widget_reparent since GtkWidgets are refcounted and when removed from a container are released, causing a crash when a TabContents is reparented.
The code now compiles thanks to a stubbed BlockedPopupContainer, however there is one remaining issue - the browser window no longer paints and the app instantly hangs. However this is better than the current state so I figured I'd send the code review.
Review URL: http://codereview.chromium.org/126107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review that this belongs to is: <http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I relanded it in smaller chunks to see at which point problem happens.
This differs from the original, in that I have changed the unit-test to no longer use ScopedMapper + WaitingMapper, which I believe was the source of a race.
Review URL: http://codereview.chromium.org/125232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14231
Review URL: http://codereview.chromium.org/126257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(javascript:...) on a web page does not belong to (the profile's) bookmark model.
Currently the following function returns DRAG_NONE and thus the drop operation is not accepted. The reason for the return value is because ops becomes DragDropTypes::DRAG_MOVE (since data.profile_path_ is not empty()) but event.GetSourceOperations() returns DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK.
int BookmarkBarView::CalculateDropOperation(const DropTargetEvent& event,
...
int ops = data.GetFirstNode(profile_)
? DragDropTypes::DRAG_MOVE
: DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK;
return bookmark_utils::PreferredDropOperation(event.GetSourceOperations(),
ops);
BUG=12290
TEST=Open http://delicious.com/help/bookmarklets page and drag the "Bookmark on Delicious" link on "Google Chrome" section to the bookmark bar.
Review URL: http://codereview.chromium.org/125111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification of cancellation during destruction).
The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides
Review URL: http://codereview.chromium.org/126254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/13999
TEST=when you fullscreen, it should be impossible to see any of the following: frame, tabstrip, tool bar, bookmark bar.
Review URL: http://codereview.chromium.org/125230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This particular subset should be a no-op: It adds an unused interface method (OnResolutionCancelled), and an unused test (CancelObserver), and lastly renames Cancel --> MarkAsCanceled().
The code in "dns_global.cc" is also unused since it is unreachable.
The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138)
The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides.
Review URL: http://codereview.chromium.org/126253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Checked these manually.
BUG=12563
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review for this change was:
<http://codereview.chromium.org/125171>
The particular subset is the third bullet point in original description:
* Fix a bug where completion notification wasn't being sent when the response
was cached. (BUG=14188)
Note that the original was rolled-back because something was upsetting valgrind (BUG=14218).
Review URL: http://codereview.chromium.org/125227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14067
TEST=open browser, click on other bookmarks button. It should work on the first try.
Review URL: http://codereview.chromium.org/126249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed some trailing whitespace as well and fixed some style nits. No code change.
TEST=none
BUG=none
TBR=hclam
Review URL: http://codereview.chromium.org/125225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This results in kind of an ugly icon sometimes. When we get SVG support the number of ugly cases should go down.
http://crbug.com/13791
Review URL: http://codereview.chromium.org/126245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original code review for this change was:
<http://codereview.chromium.org/125171>
It is being reverted because it seems to have caused a valgrind on linux regression:
<http://crbug.com14218>
BUG=14218,14138,14188
Review URL: http://codereview.chromium.org/126248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Back before the gyp conversion was complete CRC checking was commented out.
This change re-enables CRC checking.
BUG=none
TEST=none (existing tests still pass)
Review URL: http://codereview.chromium.org/126186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This happens when the ThumbnailGenerator is initialized because the
NotificationService doesn't exist yet. This patch adds a function that
TabContentscalls to make sure it is registered to avoid this problem.
Review URL: http://codereview.chromium.org/126239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
examples, but wanted to get the compile fixes checked in.
Pulling out the main.scons so as not to affect the build.
Review URL: http://codereview.chromium.org/125169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13907
TEST=some media layout tests should start passing consistently
Review URL: http://codereview.chromium.org/126243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/126246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=finnur, scherkus
Review URL: http://codereview.chromium.org/126242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on startup).
TEST=set bookmark bar open, restart chrome, bookmark bar should just be open (no animation)
BUG=none
Review URL: http://codereview.chromium.org/125223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference build which would change the baseline on lot of tests and not just the page cycler.
Enable the intl* tests on mac.
TEST=the intl page cycler tests will run and also the reference version will.
BUG=8390
Review URL: http://codereview.chromium.org/125210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/125216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The code has a glitch in handling LWS near to the "bytes" token.
BUG=14216
Review URL: http://codereview.chromium.org/126229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Original issue: http://codereview.chromium.org/119325
r=rafaelw,Jói,stoyan,aa
Review URL: http://codereview.chromium.org/125206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through prefs.
First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions
This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory.
BUG=14202
TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201)
Review URL: http://codereview.chromium.org/125219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The cause of the problem is not fully understood yet, suppressing to remove noise from the tree.
BUG=14218
Review URL: http://codereview.chromium.org/126236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locales more than that).Fixed spelling in font.h.Added windows only unittest for
it.
BUG=2919 (http://crbug.com/2919)
TEST=Pass font_unittest on Windows
Patch by cira
Original Review: http://codereview.chromium.org/125159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Make sure that localized text on NTP, History and Downloads still
look the same.
Review URL: http://codereview.chromium.org/125076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Simple ui test that goes through some test clips.
TEST=MediaTest.*
Review URL: http://codereview.chromium.org/125173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will be used by the buildbots after Xvfb is executated to make sure that Xvfb is alive.
Review URL: http://codereview.chromium.org/126165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in a UMR purify fix. According to the integration
builders this is a safe change.
TBR=levin
Review URL: http://codereview.chromium.org/126232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MockReader.
Previously only used by FFmpegDemuxerTest, it's not templated so we can use it with FFmpegVideoDecoderTest and FFmpegAudioDecoderTest and any other sort of demuxer or decoder for that matter.
Review URL: http://codereview.chromium.org/126027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
TBR=sgk
Review URL: http://codereview.chromium.org/125214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/125215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This listens to tab events and tries to keep thumbnails ready to go. See
thumbnail_generator.cc for a more detailed design.
This adds a painting observer to the RenderWidgetHost to enable this new
behavior, as well as a notification to allow the thumbnail generator to hook
its observer in. There is also a new notification that a backing store has been
disabled, which required making the backing stores know about their owning
widget hosts.
This component is currently disabled. We just need to uncomment the member in
Profile and it will start to work.
Original review: http://codereview.chromium.org/118420
Review URL: http://codereview.chromium.org/126101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of Firefox is not part of the source tree. Selenium will try to find
a version of Firefox in /Applications and use that one
Review URL: http://codereview.chromium.org/126231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18539 0039d316-1c4b-4281-b951-d872f2087c98
|