| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we always share delete and request delete access when we
open the files, and don't close the handle before deleting a
file. The result is that the delete operation should not be
prevented by someone opening the file right after we close
our handle.
The downside is that anybody attempting to open one of our
files while the browser is running will have to also share
delete or their request will fail. On the other hand, we
don't really want other people modifying the files at the
same time, so the change may be for good.
The caveat is that I think most of the failures are result
of improper AV behavior, so we have to see what happens.
BUG=16723
TEST=net_unittests
Review URL: http://codereview.chromium.org/3475025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm trying to make sure all IO objects clean up appropriately when HttpNetworkSession goes away. SpdySession can cause problems since it pointlessly keeps itself alive for another MessageLoop loop even though all references may have gone away. This fixes that.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3547003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=
TEST=
Review URL: http://codereview.chromium.org/3539005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Be careful to leave errno untouched if the file open fails, so that
the latter logging statements that print errno will print the right
message. Also format the logging text such that the perror-like
output (appending text like ": Permission denied") makes more sense.
Previously we'd end up printing text like
Try [...] to fix.: Permission denied
BUG=57305
TEST=shared_memory_unittest should still pass
Review URL: http://codereview.chromium.org/3517003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/3555002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also stop the display link thread for background tabs even if --disable-hole-punching is active.
BUG=55754
TEST=Go to a page that uses the compositor (e.g. http://webkit.org/blog/386/3d-transforms/), then keep resizing the browser window for ~10 minutes. The browser should stay functional.
Review URL: http://codereview.chromium.org/3549004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Establishes that HttpNetworkSession owns all the socket pools.
Move out all the socket pools into a ClientSocketPoolManager. This is because
of the dependency tree amongst socket pools, which dictates the order in which
they must be constructed and destructed. In order to better establish it, I
moved them out to their own class. HttpNetworkSession owns the
ClientSocketPoolManager which owns the pools. We pass the pools as raw
pointers everywhere.
Note that ClientSocketPoolManager owns more pools than are publicly accessible via its interface. That's because some of them are wrapped by publicly exposed pools.
Also, ClientSocketPoolHistograms used to be reference counted. That's because it can be shared by multiple ClientSocketPools. But it's effectively a global as well, so I make their lifetimes persist for the length of ClientSocketPoolManager too.
I also removed internal refcounting in ClientSocketPoolBase. I had refcounted
it before I knew about ScopedRunnableMethodFactory back when I first started.
I cleaned up the unit tests a lot. Back when I was a young padawan, I didn't
really know what I was doing, so I copy/pasted a metric asston of code. Turns
out most of it was stupid, so I fixed it. I also stopped the use of
implementation inheritance with ClientSocketPoolTest because it's discouraged
by the style guide and more importantly because it caused the
ClientSocketHandles within the TestSocketRequest vector to be destroyed _after_
the pools themselves were destroyed, which is bad since the handles will call
pool_->Release() which blows up.
BUG=56215,56215
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/3389020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed one-line deletion.
Tested, reproed the breakage, verified the fix.
BUG=none
TEST=none
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/3567006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
deletion.
Tested, reproed the breakage, verified the fix.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Created 2 tabs, one for for clearing local browsing data, one for clearing server data
- Refactored the old local browsing code to use a grid layout rather than less-wieldy math
- Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress
- Clear server tab will be behind a flag until I deploy the server endpoint
- Retained old clearing behavior: dialog closes on successful lear
- Clear server UI only visible if user is syncing
Outstanding issues:
- Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix
- Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again
BUG=54349
TEST=Clear from UI, or run sync backend tests checked in for issue 54280
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60845
Review URL: http://codereview.chromium.org/3412032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to enable some work we're doing to change the uninstall event to be
delivered after the unload event.
BUG=54415
TEST=An extension using the management API should just get the extension id
instead of the full ExtensionInfo data for the onUninstalled event.
Review URL: http://codereview.chromium.org/3575003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix "Save As" test by sending a single WM_CHAR to the text box.
BUG=56294
TEST=chrome_frame_tests --gtest_filter=*CFSaveAs
Review URL: http://codereview.chromium.org/3531004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set of hosts. this shouldn't be treated as a privilege increase, but is.
Also, centralize the logic for permission messages in preparation for splitting this out of Extension altogether.
BUG=56794
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3501013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented VLOG(), VLOG_IF(), VLOG_IS_ON(). Added --v and --vmodule
switches.
Changed some spammy sync-related logs to use VLOG.
BUG=56965
TEST=New unittests
Review URL: http://codereview.chromium.org/3448028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all tests pass, especially nacl_ui_tests
Review URL: http://codereview.chromium.org/3461034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means that these template instantiations will be built once in cancelable_request.cc instead of in each of the 20 files that use it. The definitions have been moved to make them not inline (as explicit template instantiation only works with non-inline members).
This cuts more than 4 megabytes off libbrowser.a in Debug mode.
This patch does nothing when compiled with MSVC, due to compiler problems.
BUG=none
TEST=compiles smaller
Review URL: http://codereview.chromium.org/3520001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54095
TEST=none
Review URL: http://codereview.chromium.org/3571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so that DOMUI menu can use the same image.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3435033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the disabled pyauto test.
BUG=57189
TEST=crash_reporter.py on official build
Review URL: http://codereview.chromium.org/3530003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it can be reused.
Added GeImageDataUrl(SkBitmap& bitmap) that convert SkBitmap to data url. This will be used in DOMUI based menu.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3561001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Commit the match preview on mouse up for instant results. This is
needed as instant results may shift up during the commit. If we
didn't do this it could mean the mouse up event appears over a
different item then the mouse went down on.
. Makes match preview revert if focus goes to the page and wasn't
initiated by a mouse event.
. Makes transition from about:crash to valid page not commit the match
preview.
. Changes setOmniboxDimensions to setDropdownDimensions.
BUG=54833 56179
TEST=none
Review URL: http://codereview.chromium.org/3531001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and AsyncFileWriterClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3397030
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/3590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AsyncFileWriterClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3397030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was testing to be sure that timing was
correctly monitored during the lifetime of
these UrlHostInfo instances. The new code defensively
checks values, and when tehy appear to be out of
spec, it verifies that the test bot is indeed
running slowly, and exits. This will usually
run the test as expected, but gracefully
exit when the bot is just too slow (or
has too much variance in execution speed)
to run the test carefully.
r=phajdan.jr
BUG=55169
Review URL: http://codereview.chromium.org/3431028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497)
Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3533001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added DecoderVp8 and unit test for chromoting.
TEST=remoting_unittests
BUG=50235
Review URL: http://codereview.chromium.org/3032047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sergeyu
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/3571007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
should result in data going to an external file.
After PrepareBuffer() we must always have either a buffer
that will receive the user data, or an initialized address
that points to the correct block or external file to
receive the data.
This CL makes sure that when we end up without a buffer, the
second condition is met.
BUG=56872
TEST=net_unittests
Review URL: http://codereview.chromium.org/3471016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Together, these sit for two minutes and fail every run.
BUG=55477,56364
Review URL: http://codereview.chromium.org/3586003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/3543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a BubbleFrameView that uses BubbleBorder as its border;
- Add a BubbleWindow that uses BubbleFrameView as its window frame;
- Change NativeDialogHost to use BubbleWindow as its container;
BUG=chromium-os:6305
TEST=Verify javascript dialog is inside a bubble frame per mock in chromium-os:6305.
Review URL: http://codereview.chromium.org/3402037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3436030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is first step towards "offline first login".
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6638
TEST=Manual: login, login failures, Guest mode should work well.
Review URL: http://codereview.chromium.org/3461033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TBR=lzheng
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3580002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
E.g.
#0 0xBD108DD: Replace_memcpy vgpreload_tsan-x86-darwin.so
#1 0xBD136C5: memcpy vgpreload_tsan-x86-darwin.so
#2 0x120C7B94: thread_encoding_proc src/xcodebuild/Release/libffmpegsumo.dylib
#3 0xBD14CD7: ThreadSanitizerStartThread vgpreload_tsan-x86-darwin.so
BUG=57266
TBR=glider
TEST=TSan/Mac should go green
Review URL: http://codereview.chromium.org/3516006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/libvpx/include
third_party/libvpx/lib and third_party/safe_browsing/testing.
This is killing the tree server this morning.
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=morrita
Review URL: http://codereview.chromium.org/3579002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken for external_extensions.json key "update_url".
BUG=57044
TEST=ExtensionsServiceTest.ExternalInstallPrefUpdateUrl
Review URL: http://codereview.chromium.org/3471022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57266
TBR=glider
Review URL: http://codereview.chromium.org/3573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
Review URL: http://codereview.chromium.org/3584002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In webkit patch https://bugs.webkit.org/show_bug.cgi?id=46799 I'm renaming the
input element's @speech attribute to @webkitspeech. This chromium CL updates
the relevant test files with both the old and new attribute names so that they
won't break while the webkit change is being submitted.
BUG=53598
TEST=browser_tests --gtest_filter=SpeechInputBrowserTest.*
Review URL: http://codereview.chromium.org/3585001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=satish
BUG=44548
TEST=none
Review URL: http://codereview.chromium.org/3587001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will remove once it is determined what is happening, or if the fail
still happens but this logging doesn't fire.
BUG=56427
TEST=none
Review URL: http://codereview.chromium.org/3473026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3527002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is early in-progress implementation, no cert handling supported. So only available under a build-time flag. (GYP_DEFINES="'use_openssl=1'")
Adds a new build dependency for system OpenSSL libraries, and a new USE_OPENSSL define. Eventually this will disable USE_NSS but for now the two coexist.
BUG=none
TEST=build with use_openssl=1. Goto some https:// pages.
Review URL: http://codereview.chromium.org/3495005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54955
TEST=PrefChangeRegistrarTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60169
Review URL: http://codereview.chromium.org/3304015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7123
TEST=manual
Review URL: http://codereview.chromium.org/3526003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60934 0039d316-1c4b-4281-b951-d872f2087c98
|