| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=36734
TEST=build/run chrome_frame_perftests.exe, note that they all run now
Review URL: http://codereview.chromium.org/1433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the handle(e) function is called by a separate function instead of as an
event handler when pasting, it was trying to call preventDefault on a
non-existant event and throwing an exception.
Do we need to do something for paste to prevent the system beep? I'm not sure
how to cause the beep to test it out.
Review URL: http://codereview.chromium.org/1473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=38691
TEST=manual testing with various sites
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42822
Review URL: http://codereview.chromium.org/1128008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test is still failing on the Valgrind bot. Disabling it again.
TBR=amit
BUG=29586
TEST=NewTabUITest.ChromeInternalLoadsNTP on Linux Valgrind 2
Review URL: http://codereview.chromium.org/1468003
TBR=creis@chromium.org
Review URL: http://codereview.chromium.org/1489001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which in its unload handler sets
a cookie which the new page attempts to read. This does not work as expected in ChromeFrame as the cookie
reading and writing attempts are routed to the host browser, in this case IE which is waiting for the
WM_DESTROY message sent to the external tab to return.
Fix is to process the AutomationMsg_GetCookiesFromHost and AutomationMsg_SetCookieAsync IPC messages
in the background thread which works in IE. For Firefox they continue to be processed on the UI thread
as before.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37231
Bug=37231
Review URL: http://codereview.chromium.org/1342004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has failed randomly on
the vista and XP builders.
Bug=39532
TBR=arv
Review URL: http://codereview.chromium.org/1429003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=39333
TEST=Create 2 windows.
Add a new folder on the bookmark bar.
Add Page... on it.
In 2nd window delete --> dialog should ben canceled.
Add a new folder on the bookmark bar.
Add Folder... on it.
In 2nd window delete it --> dialog should ben canceled.
Review URL: http://codereview.chromium.org/1476001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes pyauto bookmark bar visibility test on ChromeOS.
Review URL: http://codereview.chromium.org/1461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42846 - Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unittest
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1337001
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/1478001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=39529
TBR=amit
Review URL: http://codereview.chromium.org/1477001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We try to find an associated window for the calling extension page.
- If there is none (bg pages), fallback to the topmost browser window.
- If the extension is enabled in incognito, include incognito windows in the
search for "topmost".
This fixes a bug where clicking a browser action in an incognito window might open a tab in a normal window, which is confusing.
BUG=39113
Review URL: http://codereview.chromium.org/1422001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. Corrected signature calculations.
2. Added unit-test
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1337001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
container. Also fixes an issue where the grippy was being shown when no Browser Actions were installed.
Known issue: You can drag the buttons outside of the container, even though they will recover by snapping back into place. This will be fixed in a further revision.
TEST=try dragging browser action buttons in order to reorder them.
BUG=26990
Review URL: http://codereview.chromium.org/1418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1455001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension URL in a new tab. Since we don't allow extension URLs in incognito
tabs, we need to force the tab to be in a regular window.
BUG=39351
Review URL: http://codereview.chromium.org/1392001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=36229
TEST=none
Review URL: http://codereview.chromium.org/1464001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=use chromium on ogg videos and they should still work.
Review URL: http://codereview.chromium.org/1463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16197
TEST=Verify fix for 16197.
Review URL: http://codereview.chromium.org/1448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
BUG=29586
TEST=NewTabUITest.ChromeInternalLoadsNTP on Linux Valgrind 2
Review URL: http://codereview.chromium.org/1468003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Different versions of Chromium support different codecs, which results in all media layout tests failing since they are generated against ogg/vorbis/theora content. By overriding supportsMediaMIMEType() all media layout tests will use ogg/vorbis/theora test input.
BUG=25886
TEST=test_shell on offical builder should start passing media layout tests
Review URL: http://codereview.chromium.org/1356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything keeps on building properly
Review URL: http://codereview.chromium.org/1471001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unit test, and its suppression.
Another issue's (1321002) CL accidentally checked in a preliminary fix; this cleans it up.
BUG=39378
TEST=Valgrind
Review URL: http://codereview.chromium.org/1378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9604
TEST=point AccExplorer to Edit Bookmark dialog, see if everything has a MSAA information, like: Name, Role, State, Value.
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/928001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42822 - Mac: Make clientcert picker only show certs the server will accept.
BUG=38691
TEST=manual testing with various sites
Review URL: http://codereview.chromium.org/1128008
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/1417003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38554
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/1445001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also hooked them up to GetExtensionViews and consolidated
various methods of getting views into one (getViews, which
now takes an optional param type).
BUG=26463
TEST=None
Review URL: http://codereview.chromium.org/1397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The radio button seems to be non-functional; probably the backend probably isn't there yet.
xib changes: Added a location tab to contentsettings.xib, bind its radio buttons and normal button to the new methods in the controller. In the bubble, enable the "settings" button.
BUG=11246
TEST=content settings now has a "location" tab.
Review URL: http://codereview.chromium.org/1428002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
randomly on the valgrind
Linux builder.
It appears that this was already marked flaky in revision 42358. I synced to head and still can't get
that change.
Bug=39057
TBR=amit
Review URL: http://codereview.chromium.org/1468002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It used to live in the experimental.bookmarkManager namespace.
BUG=35320
TEST=none
Review URL: http://codereview.chromium.org/1353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This fixes a gyp KeyError due to an empty 'files' when building on unsupported
platforms (e.g. Linux x64).
Review URL: http://codereview.chromium.org/1423006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/1468001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38691
TEST=manual testing with various sites
Review URL: http://codereview.chromium.org/1128008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see http://codereview.chromium.org/1332001 )
This is to fix a brekage in Chrome Official buildbot.
BUG=NONE
TEST=ChromeOfficial Build bot goes through.
TBR=tony
Review URL: http://codereview.chromium.org/1431005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu should flash mini-tabs.
BUG=none
TEST=create three tabs, pin the first two, right click on the first
and hover over the context menu item close tabs to right,
make sure the second tab (which is pinned) doesn't highlight.
Review URL: http://codereview.chromium.org/1439001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything should still build
Review URL: http://codereview.chromium.org/1409003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Not perfect (doesn't handle custom sized docks) but helps in the short term.
Long term fix is to finish http://crbug.com/38268
Review URL: http://codereview.chromium.org/1458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
backtraces of stripped executables look more reasonable.
BUG=39232
TEST=gdb backtrace in a stripped executable with no symbols loaded should show
thread 0 beginning in main
Review URL: http://codereview.chromium.org/1460001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Push the code to handle finding menus into the cell, which knows most
about page actions. Also more thoroughly work around issues with
Control-click context menus.
BUG=none
TEST=Right-click and Control-click work the same in the Omnibox proper.
TEST=Right-click and control-click bring up appropriate menu on page actions.
Review URL: http://codereview.chromium.org/1431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that was being reverted:
TBR=ananta
Views: fix a crash where in the browser actions container.
This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return).
BUG=38964
TEST=crash an extension while the context menu for it is showing.
original review: http://codereview.chromium.org/1237004/show
Review URL: http://codereview.chromium.org/1449001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in random showing/hiding of the blocked url bar notification
when databases were in use.
It also caused lots of crashes.
BUG=38857
Review URL: http://codereview.chromium.org/1458001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1432002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
So that automation tests can tell when the communication between Chrome and Chrome Frame was cut.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1237003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/9340
TEST=Empty bookmark bar. Context menu --> Add Folder named "one". Do it.
(Note you can only click on left side; I will file bug about that).
Repeat on bar, add folder named "three" --> adds to end.
Repeat with menu OVER "one" --> adds folder between one and three.
Add a bookmark (however; e.g. with *) in a folder. Call it SUB.
Right click on SUB --> Add folder ENDO. Should put after SUB.
Right click on SUB --> Add folder. Should put after SUB but before ENDO.
Review URL: http://codereview.chromium.org/1339002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will regress default startup time for users by 50ms. This doesn't matter
because this is what the users want--I've lost count of the number bloggers,
people on twitter, and people in our IRC channel complaining about the lack of
GTK+ integration...when it's just not on by default.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
makes it look like start calls ChromeMain directly, because nobody's got
symbols for start.
BUG=39232
TEST=Breakpad reports should show thread 0 beginning in main
Review URL: http://codereview.chromium.org/1457001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39242
Review URL: http://codereview.chromium.org/1340005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=hclam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42801 0039d316-1c4b-4281-b951-d872f2087c98
|