summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Try to reland r19170 (Pick up extensions (if any) and extensionskuchhal@chromium.org2009-06-243-0/+11
| | | | | | | | definitions file for installation.) Review URL: http://codereview.chromium.org/146109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19182 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension unpacking on linux/mactc@google.com2009-06-246-9/+177
| | | | | | | | | Add a unittest that pretends to be the UtilityProcessHost and launches a chrome utility process for unpacking a theme. Review URL: http://codereview.chromium.org/147001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19181 0039d316-1c4b-4281-b951-d872f2087c98
* Return potentially more specific error code in FtpNetworkTransaction.phajdan.jr@chromium.org2009-06-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/147111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19180 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for RTL languages in the gtk bookmark bar.jhawkins@chromium.org2009-06-244-42/+48
| | | | | | | | BUG=none TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout. Review URL: http://codereview.chromium.org/146105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fail more gracefully when ProcessSingleton fails to bind.agl@chromium.org2009-06-241-1/+8
| | | | | | | | | | | | | For users with AFS home directories, we cannot create UNIX domain sockets for ProcessSingleton. Before this patch we would spin because the socket would be constantly 'readable' for accept. http://codereview.chromium.org/139008 BUG=14237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19178 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent infinite loop in new FtpNetworkTransaction.phajdan.jr@chromium.org2009-06-241-1/+4
| | | | | | | | | | It tried to send a QUIT command when sending QUIT command failed. BUG=none TEST=none Review URL: http://codereview.chromium.org/146103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19177 0039d316-1c4b-4281-b951-d872f2087c98
* We were hitting a DCHECK when removing a password in the password option panel.jcampan@chromium.org2009-06-241-4/+6
| | | | | | | | | | | This is a regression introduced by a recent change that fixed another bug. The problem was that we were not dealing with the empty selection case in the password table. BUG=http://crbug.com/15215 TEST=Open the "show saved password" dialog in the options. Move the selection around. Delete a password. Show a password, then move the selection, the password should not be shown anymore. Review URL: http://codereview.chromium.org/147104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19176 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Add more clients to the current experiment.rvargas@google.com2009-06-241-5/+21
| | | | | | | | | | | | | For some reason, I have less than 1% of clients taking part of the eviction algorithm experiment, so I'm adding clients again. BUG=none TEST=none Review URL: http://codereview.chromium.org/147066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19175 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathComponents from file_util to FilePath, add FilePath::IsParent()rafaelw@chromium.org2009-06-247-84/+188
| | | | | | | | r=erikkay,mark Review URL: http://codereview.chromium.org/145026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19174 0039d316-1c4b-4281-b951-d872f2087c98
* Start to disable bzip2 support. First step: Stop advertising support.jar@chromium.org2009-06-242-9/+12
| | | | | | | | | | | | | | | | | | | Although it would be nice to just yank it all, it is good to do so slowly so that any cached data that might required bzip2 decoding will still decode and render. Maybe I'm being paranoid... but this seems like a nice first small step. I also disabled the tests that depend on this modified code, and linted the unittest file a bit. BUG=14801 TEST= Be sure you can still view http://ukcp09.defra.gov.uk/content/view/16/6/index.html which is (currently) bzip encoded. r=hunar Review URL: http://codereview.chromium.org/147058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19173 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Pick up extensions (if any) and extensions definitions file for ↵kuchhal@chromium.org2009-06-243-11/+0
| | | | | | | | | | installation." This reverts commit r19170. Review URL: http://codereview.chromium.org/146106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19172 0039d316-1c4b-4281-b951-d872f2087c98
* Get the *correct* image results for this test. The rebaseline toolojan@chromium.org2009-06-242-1/+1
| | | | | | | | | | | grabbed the wrong ones. TBR=amanda to green tree TEST=NONE BUG=15132 Review URL: http://codereview.chromium.org/147106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19171 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up extensions (if any) and extensions definitions file for installation.kuchhal@chromium.org2009-06-243-0/+11
| | | | | | | | BUG=14201 Review URL: http://codereview.chromium.org/147092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19170 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test (really, you call this a test?) that I broke in r19167mark@chromium.org2009-06-241-3/+3
| | | | | | Review URL: http://codereview.chromium.org/147105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19169 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a browser test to catch a WebKit crash that was fixed infinnur@chromium.org2009-06-242-0/+24
| | | | | | | | | | | revision 18898 (when WebKit revision 44901 was merged in). BUG=14491 TEST=That's what this is all about. Review URL: http://codereview.chromium.org/146102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19168 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite some tab controller stuff to maybe (but probably not) improve perf.mark@chromium.org2009-06-243-39/+39
| | | | | | | | BUG=15232 TEST=watch perf graphs Review URL: http://codereview.chromium.org/147103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19167 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issues with the last patch.arv@google.com2009-06-241-1/+4
| | | | | | | | | | | | BUG=14959 TEST=The option menu on the new new tab page should react to keyboard and mouse events. Review URL: http://codereview.chromium.org/147097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19166 0039d316-1c4b-4281-b951-d872f2087c98
* Removed rebaseline in previous commit and the test startedojan@google.com2009-06-241-1/+1
| | | | | | | | | | | | | failing with missing expected results. Skipping the test for now. This points out a bug in run_webkit_tests.py. It should *not* skip tests that have rebaseline modifiers. That said, rebaseline modifiers should never be checked in either! TBR=amanda to green tree Review URL: http://codereview.chromium.org/148004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19165 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid setting a widget's allocation outside of a widget implementation.estade@chromium.org2009-06-242-13/+5
| | | | | | | | | | | | | | | | | GtkFixeds do allocate their children. They give them an allocation that matches their size request. Hence when you directly allocate the child, it gets two allocates right in a row (one from you, one from the fixed). This was causing flicker in slide animator gtk (most noticeable when opening a new browser window and seeing the restore infobar, but also confirmed with debugging statements). The original reason for needing to use size_allocate() instead of set_size_request() (which had to do with browser window resizing) is now obsolete, so revert these back to size_request()s. BUG=none TEST=less flicker when an infobar is opening; border at bottom of toolbar/bookmark bar still looks the same Review URL: http://codereview.chromium.org/147100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19164 0039d316-1c4b-4281-b951-d872f2087c98
* svn cp net/socket/tcp_client_socket_pool_unittest.cc ↵willchan@chromium.org2009-06-241-0/+621
| | | | | | | | | | net/socket/client_socket_pool_base_unittest.cc In preparation for moving tests from tcp_client_socket_pool_unittest.cc to client_socket_pool_base_unittest.cc. Review URL: http://codereview.chromium.org/147101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19163 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for RTL languages in the gtk toolbar layout.jhawkins@chromium.org2009-06-241-14/+34
| | | | | | | | BUG=none TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout. Review URL: http://codereview.chromium.org/147102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19162 0039d316-1c4b-4281-b951-d872f2087c98
* Set the executable bit on the rebaseline tool so it ojan@google.com2009-06-241-0/+0
| | | | | | | | | | can be run from linux/mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/147093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19161 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: When a browser is shown to the user, it should immediatly become theerg@google.com2009-06-241-0/+9
| | | | | | | | | | | active browser. Not doing so was breaking code that opened a new window and then immediatly opened aditional tabs in it. http://crbug.com/14018 Review URL: http://codereview.chromium.org/147091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19160 0039d316-1c4b-4281-b951-d872f2087c98
* Make find bar match label pretty.estade@chromium.org2009-06-242-12/+46
| | | | | | | | | | | This also makes the findbar entry look the same on all system themes (dark themes no longer distinct). BUG=none TEST=when you fail to find something the background of the match count label turns orange, and when you succeed in finding something the background is white. Review URL: http://codereview.chromium.org/147053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19159 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test that changed upstream.ojan@google.com2009-06-244-7/+4
| | | | | | | | BUG=15132 TEST=NONE Review URL: http://codereview.chromium.org/147094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19158 0039d316-1c4b-4281-b951-d872f2087c98
* perbotpinkerton@chromium.org2009-06-241-0/+3
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests by not relying on the unit tests having a local_state object, ↵pinkerton@chromium.org2009-06-242-1/+11
| | | | | | | | | fallback to the prefs object. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19156 0039d316-1c4b-4281-b951-d872f2087c98
* add LayoutTests/fast/js/switch-behaviour.html to the test list.jungshik@google.com2009-06-241-1/+1
| | | | | | | | | | | | | This may or may not be due to the last couple of webkit merges, but it showed up after them. BUG=15217 TEST=webkit bots turn green TBR=awalker Review URL: http://codereview.chromium.org/146099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19155 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19131.glen@chromium.org2009-06-243-82/+9
| | | | | | Review URL: http://codereview.chromium.org/147095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19154 0039d316-1c4b-4281-b951-d872f2087c98
* drag-to-navigate either timeouts or fails.jungshik@google.com2009-06-241-1/+1
| | | | | | | | | BUG=15132 TEST=webkit bots turn green TBR=dglazkov Review URL: http://codereview.chromium.org/147090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in directory_watcher_inotify.cc: release lock before ↵phajdan.jr@chromium.org2009-06-241-16/+24
| | | | | | | | | signaling the event dtor waits on. http://crbug.com/15055 Review URL: http://codereview.chromium.org/147052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19151 0039d316-1c4b-4281-b951-d872f2087c98
* In case current language is RTL we mark file names as LTR to avoid problems ↵cira@chromium.org2009-06-242-1/+6
| | | | | | | | like A-B.jpg becoming B.jpg-A on download page and new-new-tab/download section.BUG=http://crbug.com/15094TEST=Start Chrome with --lang=he --new-new-tab options and check that filename with - in the name has the proper form (check bug on how to get the file). I've checked LTR language (sr) too and output remains correct. Review URL: http://codereview.chromium.org/146064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19150 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Privacy prefs and cookie prefs in "under the hood".pinkerton@chromium.org2009-06-243-89/+406
| | | | | | | | BUG=15078 TEST=prefs listed in bug. Not sure how to test nav errors or usage stats (since we don't really send them) or DNS pre-fetch. Review URL: http://codereview.chromium.org/146088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19149 0039d316-1c4b-4281-b951-d872f2087c98
* Update the test list after the webkit merge to r45086jungshik@google.com2009-06-241-0/+7
| | | | | | | | | | BUG=15217 TEST=Webkit bots go green TBR=dglazkov Review URL: http://codereview.chromium.org/146098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19148 0039d316-1c4b-4281-b951-d872f2087c98
* Toast experiment control groupcpu@google.com2009-06-241-1/+9
| | | | | | | | | | | | | - The analisis team needs a control group; these are users that qualify don't get the experiment. - Select 50 % at random BUG= b/1484308 TEST = see the bug Review URL: http://codereview.chromium.org/147057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19147 0039d316-1c4b-4281-b951-d872f2087c98
* perfbotpinkerton@chromium.org2009-06-241-0/+2
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19146 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect CSS selector for global off switch for animations.arv@google.com2009-06-241-1/+1
| | | | | | | | | | | BUG=None TEST=If you use remote desktop you should not see any animations as you hide/show the thumbnails on the new new tab page. Review URL: http://codereview.chromium.org/147086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19145 0039d316-1c4b-4281-b951-d872f2087c98
* Updating unused DEPS file for unused GYP build.gspencer@google.com2009-06-241-2/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19144 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing broken common.gypigspencer@google.com2009-06-241-3/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19143 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Add support for ranges with an unknown start or end.rvargas@google.com2009-06-244-23/+112
| | | | | | | | | BUG=12258 TEST=unittest Review URL: http://codereview.chromium.org/147042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19142 0039d316-1c4b-4281-b951-d872f2087c98
* Make the options menu keyboard navigatable. Hide the menu when thearv@google.com2009-06-243-36/+167
| | | | | | | | | | | | | | | | button is clicked a second time. BUG=14959, 15067 TEST=Tab to the options button. Try pressing the down arrow, up arrow or enter. These should show the menu. Try pressing esc to hide the menu. Try pressing enter to execute the item. Try opening the menu, both using the mouse and keyboard and make sure that it is hidden as expected. Review URL: http://codereview.chromium.org/147071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19141 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes types.h with a conditional block so that it provides down_cast<>,gspencer@google.com2009-06-242-0/+37
| | | | | | | | but only in the GYP build. The GYP build uses a newer chrome/base that doesn't provide down_cast<> anymore. Review URL: http://codereview.chromium.org/146092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the screen bounds calculation of windowless widgets. Only windowed ↵jhawkins@chromium.org2009-06-241-3/+14
| | | | | | | | | | parent widgets' allocation should be taken into account when calculating the widget screen bounds. BUG=none TEST=Open a browser and set the frame to custom. Drag tabs around. They should not be offset vertically. Review URL: http://codereview.chromium.org/147065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19139 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit to r45086.darin@chromium.org2009-06-242-1/+2
| | | | | | | | R=amanda Review URL: http://codereview.chromium.org/146094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19138 0039d316-1c4b-4281-b951-d872f2087c98
* Add hover and pressed states for the home button.glen@chromium.org2009-06-242-0/+0
| | | | | | | | | BUG=13821 TEST=Verify that the home hover and pressed states look right TBR=mirandac git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19137 0039d316-1c4b-4281-b951-d872f2087c98
* Merge WebKit r42737, which added port 3659wtc@chromium.org2009-06-243-7/+10
| | | | | | | | | | | | | | (apple-sasl / PasswordServer) to the list of blocked ports and to LayoutTests/security/block-test.html. Fix cpplint.py nits. R=eroman BUG=http://crbug.com/10861 TEST=LayoutTests/security/block-test.html should pass on Windows Review URL: http://codereview.chromium.org/147069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19136 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PerWindowShelf test on Linux because it's flakyjshin@chromium.org2009-06-241-1/+4
| | | | | | | | | BUG=15211 (http://crbug.com/15211 ) TEST=PerWindowShelf test does not show up as a failure on Linux bot TBR=thakis Review URL: http://codereview.chromium.org/146091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19135 0039d316-1c4b-4281-b951-d872f2087c98
* perfbot.pinkerton@chromium.org2009-06-241-5/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19134 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the code that writes magic string to the registry.kuchhal@chromium.org2009-06-241-8/+18
| | | | | | | | BUG=15095 Review URL: http://codereview.chromium.org/146063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19133 0039d316-1c4b-4281-b951-d872f2087c98
* Pass through non-character codepoints in UTF-8,16,32 and Wide conversion ↵jshin@chromium.org2009-06-244-16/+56
| | | | | | | | | | | | | | | | | | | | functions. They're structurally valid code points unlike malformed byte/surrogate sequences. I believe it's better to leave them alone in conversion functions. This CL was triggered by file_util_unittest failure on Linux/Mac with my upcoming change to file_util::ReplaceIllegalCharacters (a part of http://codereview.chromium.org/126223 ). In addition, the upper bound for the output length in CodepageToWide was tightened. TEST=pass string_util and file_util unittests BUG=NONE Review URL: http://codereview.chromium.org/147038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19132 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 05:37:05 +0000