summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rejigger how we format the display of bytes.evan@chromium.org2010-04-152-18/+24
| | | | | | | | | | | | | | | | | | | | | | | (Note that this does *not* touch the mega/mebi issue, despite my recent discussion of it.) What had been bugging me was that when downloading a file, you'd see it count up 10.7, 10.8, 10.9, *11*, 11.1. That is, previously when we rounded to displaying a trailing zero, we'd clip it off, which would make a download display like "11.1 / 50.2MB" jiggle to the left every time the trailing digit lined up. Now we try to always display three digits, which means we count up like 98.8, 98.9, *99.0*, 99.1, ... 99.9, 100, ... 101. This code is after fiddling the test into the shape I wanted it to be, then making the code produce that behavior. TEST=covered by unit test, updated with new expected behavior Review URL: http://codereview.chromium.org/1558025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44671 0039d316-1c4b-4281-b951-d872f2087c98
* 10.6 SDK build fix.mark@chromium.org2010-04-151-1/+2
| | | | | | | | | | | | A DCHECK_EQ comparing self (id) to -[NSWindow delegate] (id prior to the 10.6 SDK and id<NSWindowDelegate> after) introduced in r44383 fails with the 10.6 SDK because the types aren't compatible. Add a "do what I mean" cast. BUG=none TEST=none Review URL: http://codereview.chromium.org/1653005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44670 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: sync with upstream (Camino) NSPasteboard+Utils.mmviettrungluu@chromium.org2010-04-151-6/+3
| | | | | | | | | | | | | | | | The upstream commit message is: Fix bug 448058 - 'Bookmark bar -> Copy Information to Clipboard -> Mail fails' and bug 491448 - 'Copy Link/Image Location does not paste into Pages or RTF Mail message' by setting a non-empty title string in WebURLsWithTitlesPboardType. Patch by Christopher Henderson <trendyhendy2000@gmail.com>, r=cl, r=me, sr=smorgan BUG=none (probably *something*, but what?) TEST=trybots, unit tests, everything still works Review URL: http://codereview.chromium.org/1545040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44669 0039d316-1c4b-4281-b951-d872f2087c98
* Start up extension event routers later in BrowserMain, sohuanr@chromium.org2010-04-153-14/+16
| | | | | | | | | | | | | | | | | | | bookmarks is loaded after bookmark import in first run. I am not familiar with the extension code. It seems currently ExtensionHistoryEventRouter and ExtensionAccessibilityEventRouter are always initialized while ExtensionBrowserEventRouter and ExtensionBookmarkEventRouter are initialized on demand. Since we have a build in bookmark manager extension, I start all event routers by default in this change. Let me know if this is an issue. BUG=40144 TEST=chrome.exe --first-run Review URL: http://codereview.chromium.org/1578032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix README.chromium and add LICENSE for third_party/mozilla.viettrungluu@chromium.org2010-04-152-44/+51
| | | | | | | | | BUG=none TEST=src/tools/licenses.py should be happy Review URL: http://codereview.chromium.org/1599032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44666 0039d316-1c4b-4281-b951-d872f2087c98
* Use the correct target when binding a cubemap texture.amarinichev@chromium.org2010-04-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1530042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44665 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation hooks to get info about downloads.nirnimesh@chromium.org2010-04-155-2/+181
| | | | | | | | | | | | Makes info about downloads available to pyauto. Also add JSONInterfaceError to represent an error in the json ipc interace. TEST=None BUG=None Review URL: http://codereview.chromium.org/1637008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44664 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Alternate-Protocol changes.willchan@chromium.org2010-04-159-20/+43
| | | | | | | | | Change chromium to expect npn-spdy/1 instead of npn-spdy to match server-side changes. Move the use of Alternate-Protocol to be behind command line flag: "--use-alternate-protocols". Review URL: http://codereview.chromium.org/1593029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44663 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Use the plugin_npapi_filename variable to choose the bundle name ↵tschmelcher@chromium.org2010-04-156-15/+20
| | | | | | | | | | | (rather than the static "O3D" name) so that differently branded versions can co-exist. This also changes the default name from O3D.plugin to npo3dautoplugin.plugin to harmonize it with the other platforms. TEST=built & tested a rebranded plugin and non-rebranded plugin on Mac BUG=none Review URL: http://codereview.chromium.org/1585034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44662 0039d316-1c4b-4281-b951-d872f2087c98
* AutofillDataTypeController should invoke start callback on abort. Also ↵skrul@chromium.org2010-04-1517-34/+425
| | | | | | | | | | | gracefully handle stopping the data type startup while waiting for the PDM, WDS, and association. BUG=41361 TEST=unittest Review URL: http://codereview.chromium.org/1513034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44660 0039d316-1c4b-4281-b951-d872f2087c98
* Modified the extract script to create a file including the hash column. ↵evan@chromium.org2010-04-152-3/+527
| | | | | | | | | | | | | | | Added the created file as well, so that dashboard code can pick up the file out of the repository. BUG=28849 TEST=run the extract_actions.py script. No automated tests required Patch by Frank Mantek <fmantek@google.com> Review URL: http://codereview.chromium.org/1518026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44659 0039d316-1c4b-4281-b951-d872f2087c98
* Pass tools/licenses.py for more directories.evan@chromium.org2010-04-156-16/+86
| | | | | | | | | | | | | We're now down to only 4 dirs that don't pass the license checker. They will require separate changes. Modify the license checker to only print failing dirs. BUG=39240 Review URL: http://codereview.chromium.org/1530040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44656 0039d316-1c4b-4281-b951-d872f2087c98
* Move third_pary/mozilla/include up one directory.evan@chromium.org2010-04-1522-22/+19
| | | | | | | | | | This allows the license checker to find the README. BUG=39240 Review URL: http://codereview.chromium.org/1596025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44655 0039d316-1c4b-4281-b951-d872f2087c98
* The timeout for the ChromeFrame FullTabModeIE_KeyboardTest was incorrectly ↵ananta@chromium.org2010-04-151-1/+1
| | | | | | | | | | | | set to 0x9999 in a recent CL. Correcting this to get the IE8 builder green. TBR=amit Review URL: http://codereview.chromium.org/1545039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44651 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Improve behavior of "Add Folder" contextual menu item.jeremy@chromium.org2010-04-151-3/+7
| | | | | | | | | | | | | * "Add Folder" on a current folder now inserts the new folder as the last child of the parent folder rather than it's sibling. * "Add Folder" on the "others" folder works as above. This matches Windows behavior. BUG=40722 TEST=See bug. Review URL: http://codereview.chromium.org/1659003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44650 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last remnants of windowless_needs_set_window_ from Linux pluginsstuartmorgan@chromium.org2010-04-154-46/+15
| | | | | | | | | | | | | Also removes the variable now that it's unused on all platforms, the WindowlessSetWindow argument that went with it, and a completely dead clipping variable. Fixes Windows to call WindowlessSetWindow for clip rect changes (a case that used to be covered by the now-removed WindowlessSetWindow call in Draw). BUG=none TEST=Linux and Windows windowless plugins should still work (especially test scrolling them partially and completely off screen). Review URL: http://codereview.chromium.org/1225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44649 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add an arrow cursor rect for the location image.rohitrao@chromium.org2010-04-152-4/+9
| | | | | | | | BUG=41229 TEST=Mouse over the location image. Should show the arrow cursor, not an ibeam cursor. Review URL: http://codereview.chromium.org/1574028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44648 0039d316-1c4b-4281-b951-d872f2087c98
* Add cbentzel to net WATCHLIST.cbentzel@chromium.org2010-04-151-1/+1
| | | | | | | | | BUG=None TEST=Ran watchlists.py, made sure values were correct. Review URL: http://codereview.chromium.org/1528030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44647 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate to WebNotification::iconURL in ↵antonm@chromium.org2010-04-151-1/+1
| | | | | | | | | | src/webkit/tools/test_shell/notification_presenter.cc http://trac.webkit.org/changeset/57604 removed WebNotification::icon which broke the file above. Review URL: http://codereview.chromium.org/1642012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44646 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the "Configure IME..." menu item on the login screen.yusukes@google.com2010-04-151-0/+2
| | | | | | | | | | | | Note that network and clock buttons don't show this kind of menu item as well. BUG=crosbug.com/2268 BUG=crosbug.com/2619 TEST=manual Review URL: http://codereview.chromium.org/1612021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44643 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 378.0 to 379.0chrome-release@google.com2010-04-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44641 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserTest.PageLanguageDetection, it's crashy.phajdan.jr@chromium.org2010-04-151-1/+2
| | | | | | | | | | TBR=jcivelli TEST=still crashy BUG=40962 Review URL: http://codereview.chromium.org/1591033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44638 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize |current_input_method_| in the constructor.yusukes@google.com2010-04-151-0/+3
| | | | | | | | | | | This patch is necessary for http://codereview.chromium.org/1568033 to work. BUG=none TEST=manual Review URL: http://codereview.chromium.org/1566045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44637 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale comment line.mnaganov@chromium.org2010-04-151-1/+0
| | | | | | | | | | | BUG=41291 TEST=none TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/1660001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44636 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Explicitly add a bunch of missing includes.thestig@chromium.org2010-04-1524-25/+62
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1623014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44635 0039d316-1c4b-4281-b951-d872f2087c98
* Update and enable DevToolsSanityTest.TestProfilerTab.mnaganov@chromium.org2010-04-152-9/+3
| | | | | | | | | | | BUG=41291 TEST=DevToolsSanityTest.TestProfilerTab TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/1604037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44634 0039d316-1c4b-4281-b951-d872f2087c98
* Check for file/ftp directory listings before applying settings.jochen@chromium.org2010-04-151-26/+37
| | | | | | | | | BUG=40765 TEST=go to ftp://ibiblio.org/pub/Linux/distributions/damnsmall/current/ Review URL: http://codereview.chromium.org/1594029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44632 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize a reliability test known crash slightly. bug=40736.whesse@chromium.org2010-04-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1525034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused the Dvorak layout to be broken.satorux@chromium.org2010-04-153-8/+39
| | | | | | | | | TEST=unit_tests and manually confirmed dvorak worked. BUG=crosbug.com/2449 Review URL: http://codereview.chromium.org/1523024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44626 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused function, SetInputMethodActivated.yusukes@google.com2010-04-153-21/+0
| | | | | | | | | BUG=none TEST=ran browser_tests Review URL: http://codereview.chromium.org/1576039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44622 0039d316-1c4b-4281-b951-d872f2087c98
* Add an IME_CANCEL_COMPOSITION event. This is fired iftony@chromium.org2010-04-152-3/+8
| | | | | | | | | | webkit can't handle the composition for some reason. For example, if the text field is disabled, we send this message back to the browser process. Review URL: http://codereview.chromium.org/1539037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44621 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r44611 because it may have broken "unit_tests" on "Vista Tests".wtc@chromium.org2010-04-155-25/+88
| | | | | | | | BUG=27125 TEST=none Review URL: http://codereview.chromium.org/1655008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44615 0039d316-1c4b-4281-b951-d872f2087c98
* Updates the launcher location finding logic to skip chrome_launcher.exe on ↵slightlyoff@chromium.org2010-04-151-2/+6
| | | | | | | | | | | OSes where IE can't run with differing integrities. BUG=41572 TEST=None Review URL: http://codereview.chromium.org/1638013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44613 0039d316-1c4b-4281-b951-d872f2087c98
* Display the SECURITY_WARNING status in the location bar for the wtc@chromium.org2010-04-155-88/+25
| | | | | | | | | | | | | | ERR_CERT_UNABLE_TO_CHECK_REVOCATION certificate error. Do not display an info bar. Remove the unused ToolbarModel::GetIconHoverText function. R=pkasting,jcivelli BUG=27125 TEST=Visit port 452 on the chrometws server. Review URL: http://codereview.chromium.org/1653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44611 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed potential crash on OnUnrecoverableError() inakalin@chromium.org2010-04-152-24/+12
| | | | | | | | | | | | theme_change_processor.cc. Basically, it should do nothing else (e.g., StartObserving()) after it calls OnUnrecoverableError(). BUG=41569,41575 TEST=manual Review URL: http://codereview.chromium.org/1604036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44609 0039d316-1c4b-4281-b951-d872f2087c98
* fix arm warningsfbarchard@chromium.org2010-04-155-162/+163
| | | | | | | | | BUG=19113 TEST=builds on arm Review URL: http://codereview.chromium.org/1553033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44608 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid a crash in ChromeFrame in the BindToStorage call initiated when our ↵ananta@chromium.org2010-04-159-116/+188
| | | | | | | | | | | | | | | | active document is loaded. The crash occurs while dereferencing a NULL delegate which is the case in the pending request object created by the active document to handle the initial load. Fix for this is to maintain a pending state in the request object. We ignore all OnProgress notifications in this state. When Chrome requests data for the top level url this state is cleared. Consolidated the number of bind context information structures into one which contains everything we need in ChromeFrame, i.e. to decide to switch to Chrome, indicating whether the request came from Chrome, etc. Review URL: http://codereview.chromium.org/1654012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44604 0039d316-1c4b-4281-b951-d872f2087c98
* Make MessageLoop::MessageLoop easier to read.thestig@chromium.org2010-04-151-17/+16
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1655007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44595 0039d316-1c4b-4281-b951-d872f2087c98
* Made Pepper 3D plugins' output opaque on Mac OS X by filling thekbr@google.com2010-04-1521-37/+85
| | | | | | | | | | | | | plugin region's alpha channel with 1.0 and then overwriting just the color channels. Core Animation plugins, though they currently always overlay HTML output, remain translucent. BUG=41424 TEST=ran Pepper 3D sample and verified its background is opaque Review URL: http://codereview.chromium.org/1547034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44594 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Handle non-unique profile labels by appending an increasing number tojhawkins@chromium.org2010-04-153-11/+144
| | | | | | | | | | | the label in the PersonalDatabaseManager. BUG=41002 TEST=PersonalDatabaseManager.SetUnique* Review URL: http://codereview.chromium.org/1657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44593 0039d316-1c4b-4281-b951-d872f2087c98
* Make C, MMX and SSE2 all output the same resultsfbarchard@chromium.org2010-04-158-827/+682
| | | | | | | | | BUG=19113,41045 TEST=none. just cleanup and making all platforms produce the same results Review URL: http://codereview.chromium.org/1638008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44591 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Add work around for layout bug that some users are hitting.arv@chromium.org2010-04-152-7/+16
| | | | | | | | | | | | In some rare cases the reported window.innerWidth and the media query reports different widths. This is most likely due to some timing issues. This work around keeps track of what layout mode we are using (wasSmallGrid) and when we get the data as well as on DOMContentLoaded we double check to ensure that the mode is correct and if not we do another layout. So in worst case we do one more layout in the case where the layout was wrong. BUG=25329 TEST=I haven't been able to repro so when testing this I introduced the *wrong* case manually in code. Review URL: http://codereview.chromium.org/1650008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44590 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44570 - Fix chrome os flakyness for test ↵nsylvain@chromium.org2010-04-159-99/+55
| | | | | | | | | | | | | | | | ExtensionApiTest.CaptureVisibleTab. While in the code, add tests for PNG capture, and make code test that the resulting image is the right color. BUG=41380 TEST=ExtensionApiTest.CaptureVisibleTab Review URL: http://codereview.chromium.org/1631015 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/1525035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44587 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete the IOThread globals until all of the ↵eroman@chromium.org2010-04-152-3/+3
| | | | | | | | | | | MessageLoop::DestructionObservers have run (in case they try to access one of these pointers) BUG=39723 Review URL: http://codereview.chromium.org/1638011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44586 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete dragging functions.estade@chromium.org2010-04-154-17/+0
| | | | | | | | | | | This is side 3 of the 3-sided DragImage patch. BUG=11457 TEST=compile Review URL: http://codereview.chromium.org/1513039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44585 0039d316-1c4b-4281-b951-d872f2087c98
* fixed compilation problem with disabled SSEsergeyu@chromium.org2010-04-151-1/+1
| | | | | | | | | BUG=19113 TEST=none Review URL: http://codereview.chromium.org/1559032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44584 0039d316-1c4b-4281-b951-d872f2087c98
* Change prepopulated search engines to reflect new data.mirandac@chromium.org2010-04-151-25/+65
| | | | | | | | | BUG= 41532 TEST= Chrome install for countries in question should offer the new set of search engines. Review URL: http://codereview.chromium.org/1530039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44583 0039d316-1c4b-4281-b951-d872f2087c98
* Fix offscren invalidation in windowless pluginsstuartmorgan@chromium.org2010-04-142-3/+10
| | | | | | | | | | | | | Fixes two related issues: - An invalidate that was entirely off screen, but for a plugin that was partial on-screen, would not trigger a paint when the damaged area was scrolled back into view (all platforms). - When a Mac plugin's container became visible, damaged regions were not repainted (Mac only). BUG=41383 TEST=See bug. Review URL: http://codereview.chromium.org/1629018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44582 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory smash, take 2.pkasting@chromium.org2010-04-148-21/+46
| | | | | | | | | | Fix freed-memory accesses of members of a destroyed object while unwinding the callstack. This avoids introducing a different memory corruption issue at shutdown by using WeakPtr to hold the object that the OS can delete out from under us. It also clarifies and simplifies the shutdown sequence by moving the AutocompleteController::Stop() call into the controller's destructor, and avoiding notifying observers of changes; this actually altogether sidesteps the problematic codepath for which I needed the WeakPtr, but I'm not sure whether the OS still might be able to destroy the object at another time, so I'm leaving the WeakPtr in. BUG=41274 TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash. Review URL: http://codereview.chromium.org/1657002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for LoginPromptTesti.CancelRedundantAuths and related tests on linux views.zelidrag@chromium.org2010-04-141-3/+5
| | | | | | | | | BUG=27585 TEST=run ui_test for linux views build Review URL: http://codereview.chromium.org/1599030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44580 0039d316-1c4b-4281-b951-d872f2087c98