summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-258-6/+143
| | | | | | | | Add more DCHECKs. Same as r5607 except that Thread.StopSoon is fixed. Review URL: http://codereview.chromium.org/11534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5971 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bit of code dupe in a switch.deanm@chromium.org2008-11-251-8/+2
| | | | | | Review URL: http://codereview.chromium.org/12424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5970 0039d316-1c4b-4281-b951-d872f2087c98
* linux greentc@google.com2008-11-251-2/+14
| | | | | | | Review URL: http://codereview.chromium.org/12425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5969 0039d316-1c4b-4281-b951-d872f2087c98
* Add new baseline for hindi-spacing.html, which differs by button size.ericroman@google.com2008-11-253-16/+16
| | | | | | | | | I must have missed this in the r5958, which was a large rebaseline affecting form controls. TBR=tony@chromium.org Review URL: http://codereview.chromium.org/12630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5968 0039d316-1c4b-4281-b951-d872f2087c98
* remove dups from linux test listtc@google.com2008-11-251-15/+2
| | | | | | | Review URL: http://codereview.chromium.org/12629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5967 0039d316-1c4b-4281-b951-d872f2087c98
* Update linux test liststc@google.com2008-11-251-70/+806
| | | | | | | Review URL: http://codereview.chromium.org/12422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5965 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the clipboard owner window. CreateWindow can take ~.5ms, and ↵deanm@chromium.org2008-11-252-13/+26
| | | | | | | | we don't need to do this until the clipboard is actually used (ctrl-c/ctrl-v). Review URL: http://codereview.chromium.org/11398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5963 0039d316-1c4b-4281-b951-d872f2087c98
* Get expectations right. This was a timeout.ojan@google.com2008-11-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/12420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my caret blinking change for now.deanm@chromium.org2008-11-252-3/+6
| | | | | | Review URL: http://codereview.chromium.org/12419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5961 0039d316-1c4b-4281-b951-d872f2087c98
* Use StringPiece in the TLD service. This means we don't have to copy the ↵deanm@chromium.org2008-11-252-138/+103
| | | | | | | | | | TLD data from the resource into a std::string, we can just always refer into the resource data. This saves ~40k or something meaningless. Also use StringPiece to replace StringSegment, and other minor cleanup. Review URL: http://codereview.chromium.org/11310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5960 0039d316-1c4b-4281-b951-d872f2087c98
* It was brought to my attention that defining _HAS_TR1=0 helps with Visual ↵maruel@chromium.org2008-11-252-1/+2
| | | | | | | | | Studio 2008 compilation and causes no adverse effect on Visual Studio 2005. Thanks to Daniel A. White for the tip. Review URL: http://codereview.chromium.org/12607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5959 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some layout-test-specific hacks.ericroman@google.com2008-11-25854-7448/+7660
| | | | | | Review URL: http://codereview.chromium.org/12410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5958 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with plugin installer infobar due to the infobardelegate not being ↵ben@chromium.org2008-11-258-18/+30
| | | | | | | | | | removed from the containing TabContents. http://crbug.com/4620 Review URL: http://codereview.chromium.org/12624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5957 0039d316-1c4b-4281-b951-d872f2087c98
* Don't paint storm in layout test mode.deanm@chromium.org2008-11-252-6/+3
| | | | | | | | Blinking caret frequency sets a repeating timer, before it was 0 which causes the timer to fire constantly. Review URL: http://codereview.chromium.org/12416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5956 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the WebRequest API to consistently use std::string instead ofdarin@chromium.org2008-11-255-27/+25
| | | | | | | | | | | | | | | | | | | std::wstring for HTTP header fields The HTTP specification guarantees that all fields in the header will be ASCII and thus fit fine in a std::string. The GetHttpHeaders/SetHttpHeaders interfaces use std::string values for HTTP headers. This patch fixes GetHttpMethod(), SetHttpMethod(), GetHttpHeaderValue() and SetHttpHeaderValue() and callers to use std::string as well. Patch by James Robinson <jamesr@google.com> R=darin Review URL: http://codereview.chromium.org/12412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5955 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 5929 (r5882) with crash fix and also this change:ben@chromium.org2008-11-2518-273/+338
| | | | | | | | | | | http://codereview.chromium.org/11392/show which fixes the remainder of the UI test issues apparently. http://crbug.com/4620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5954 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists from merge.ojan@google.com2008-11-251-0/+3
| | | | | | Review URL: http://codereview.chromium.org/12623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5953 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the PlatformContext's current transform when returning the cairo ↵estade@chromium.org2008-11-252-20/+23
| | | | | | surface in GdkSkia. Fixes linux test shell widget rendering. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5952 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webkit merge 38575:38600ojan@google.com2008-11-252-5/+5
| | | | | | Review URL: http://codereview.chromium.org/12414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5951 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ISO-8859-9 in the character encoding menu because it's now ↵jungshik@google.com2008-11-254-13/+9
| | | | | | | | | | | | treated as an alias to its superset, windows-1254. BUG=4746 TEST=visit http://www.sabah.com.tr (ISO-8859-9 page) and make sure that 'Turkish' is checked in the encoding menu Review URL: http://codereview.chromium.org/11811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5948 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in RenderThemeGtk.erg@google.com2008-11-251-2/+5
| | | | | | | Review URL: http://codereview.chromium.org/12617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5947 0039d316-1c4b-4281-b951-d872f2087c98
* Find now uses WebKit's TextMatch highlighting for Find-in-page.finnur@google.com2008-11-2412-381/+298
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to discard a bunch of code and plumbing related to maintaining and passing around the tickmark vector. WebKit now owns the drawing of the highlights for inactive matches and we use the selection controller to draw the active highlight. I also simplified the code by eliminating the separate FindNext function, which has been merged into Find. This change also requires minor changes to WebKit upstream (sold seperately, void where prohibited). It simply consists of adding one empty virtual paint function to ScrollbarThemeComposite.h (paintTickmarks) and in ScrollbarThemeComposite::paint call paintTickmarks(). This fixes/makes obsolete a slew of bugs: BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599 ... and a couple of external ones as well. Full list: 1326399 Find highlighting disappears on ThinkPad x60s 1241554 Find doesn't highlight word inside blinky tag 1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode 1070190 Find should begin searching from caret/selection 1023019 Find not highlighting correctly 984786 Find highlight drawing code causes ClearType text to look bad 893737 Find in page should search textareas 868599 Find in page tick marks incorrectly appear on nested scrollbars 298 Find-In-page should highlight elided entries 4389 Find-in-box is not highlighting all the instances of the search word 3908 Find in page highlighting and tickmarks are broken Review URL: http://codereview.chromium.org/11364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some net/ code. Change a number of wstrings to FilePaths.estade@chromium.org2008-11-2415-66/+79
| | | | | | Review URL: http://codereview.chromium.org/12409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5944 0039d316-1c4b-4281-b951-d872f2087c98
* Add a NULL channel check in CreateNPVariantParam as it can be called withananta@chromium.org2008-11-241-9/+15
| | | | | | | | | | | | | a NULL channel during renderer plugin shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=4740 R=jam Bug=4740 Review URL: http://codereview.chromium.org/12609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5943 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save state when the page ID doesn't change.brettw@google.com2008-11-241-2/+9
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=4684 Review URL: http://codereview.chromium.org/12613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5942 0039d316-1c4b-4281-b951-d872f2087c98
* Add Safari bundle targets to the gears-scons build.mpcomplete@chromium.org2008-11-245-13/+156
| | | | | | Review URL: http://codereview.chromium.org/11329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5941 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a potential memory leak with a message creation.klink@chromium.org2008-11-241-4/+3
| | | | | | Review URL: http://codereview.chromium.org/11579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5939 0039d316-1c4b-4281-b951-d872f2087c98
* http_cache: Don't destroy an entry from the transaction destructor ifrvargas@google.com2008-11-242-7/+23
| | | | | | | | | | | | | | | | | | there is a task posted to process the next transaction. Also, fix the check to determine the type of transaction to consider writers that were converted to readers by the time the destructor runs. I'm adding more checks to see if these were all the problems related to bug 3931. B=4731 R=darin Review URL: http://codereview.chromium.org/12608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5938 0039d316-1c4b-4281-b951-d872f2087c98
* Second try ad faster scons builds of test shell.tc@google.com2008-11-243-92/+72
| | | | | | | | | | | | | | This is the same as the previous patch except it doesn't change the WEBCORE_DIR variable. It needs the OBJ_ROOT in the resolution path so .o files end up in Hammer/. I'll fix the include paths in a follow up change. TBR=sgk Review URL: http://codereview.chromium.org/12411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5937 0039d316-1c4b-4281-b951-d872f2087c98
* Add class to encapsulate a CF Mach Message Source and handle it's liftime.jeremy@chromium.org2008-11-243-0/+131
| | | | | | | | | This class handles adding a listener on Mach port to the current CFRunloop and calling a delegate when a message is received on that port. Review URL: http://codereview.chromium.org/11331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5936 0039d316-1c4b-4281-b951-d872f2087c98
* Third commit for yury's change unforking the inspector.ojan@google.com2008-11-24110-0/+0
| | | | | | The patch missed all these deletes somehow. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5935 0039d316-1c4b-4281-b951-d872f2087c98
* Update scons for the unforking of the inspector resource files.ojan@google.com2008-11-241-1/+1
| | | | | | | | I didn't actually build this and see if it works, but I'll at least make sure it passes the trybots. Review URL: http://codereview.chromium.org/11378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5934 0039d316-1c4b-4281-b951-d872f2087c98
* rollbackben@chromium.org2008-11-248-97/+90
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5933 0039d316-1c4b-4281-b951-d872f2087c98
* A bit of RenderThemeGtk::systemFont refactoring and merge with recent changes.mmoss@google.com2008-11-241-39/+53
| | | | | | | Review URL: http://codereview.chromium.org/11400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5932 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "faster scons builds of test shell"tc@google.com2008-11-243-72/+92
| | | | | | | | | | | | It's putting .o files next to .cpp files. I will debug offline then resubmit. TBR=sgk Review URL: http://codereview.chromium.org/12610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5930 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r5882 with a crash fix.ben@chromium.org2008-11-248-90/+97
| | | | | | | http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5929 0039d316-1c4b-4281-b951-d872f2087c98
* Bridge calls to get the root NPObject from a WebPluginContainer.darin@chromium.org2008-11-246-53/+29
| | | | | | | | | | | | | | | | I also did a little cleanup in getPlugins. I found that there was a WebPluginInfo struct declared within the WebCore namespace that was causing us to need '::' in front of WebPluginInfo. I killed the erroneous declaration so that the rest could be cleaned up. I also renamed getPlugins to plugins since I think that is more consistent with how Apple names these kinds of methods. There was some old, unused USE(JSC) code in ScriptController.cpp that I deleted. R=erikkay Review URL: http://codereview.chromium.org/12601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5928 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reenter Webkit, while it waits for outgoing sync calls to complete. Thisananta@chromium.org2008-11-241-0/+4
| | | | | | | | | | | | | | fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits for the PluginDestroyed sync call to unwind. The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario. R=jcampan Bug=4582 Review URL: http://codereview.chromium.org/12402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5927 0039d316-1c4b-4281-b951-d872f2087c98
* Update ICU to r5827 to pick up changes in zh locale (exemplar charset) and ↵jungshik@google.com2008-11-241-1/+1
| | | | | | | | | | | converter name alias (iso-8859-9 => windows-1254) TBR=tony BUG=3863 Review URL: http://codereview.chromium.org/11381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5926 0039d316-1c4b-4281-b951-d872f2087c98
* * Add net_unittests and unit_tests sources that size comparisonssgk@google.com2008-11-242-11/+29
| | | | | | | | | | | | | | | revealed slipped by getting added to the SCons build: net\base\x509_certificate_unittest.cc chrome\browser\greasemonky_master_unittest.cc chrome\browser\greasemonky_slave_unittest.cc chrome\browser\template_url_prepopulate_data_unittest.cc chrome\renderer\render_widget_unittest.cc * Sort file lists. * Move net\*_unittest.cc files that don't have "win" in the base name to the to_be_ported_files lists for Linux and Mac. Review URL: http://codereview.chromium.org/11587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert part of changes made in http://codereview.chromium.org/10687fqian@google.com2008-11-242-8/+41
| | | | | | | | | The document wrapper wasn't kept alive in the life time of the frame. This results issue 4532. I don't how to create a test case yet, but verified that dromaeo test runs fine with this fix. Review URL: http://codereview.chromium.org/11376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5924 0039d316-1c4b-4281-b951-d872f2087c98
* faster scons builds of test shelltc@google.com2008-11-243-92/+72
| | | | | | | | | | | | | | | | | By reducing the number of include paths that are specified as $WEBKIT_DIR/port, we reduce the number of paths that get expanded by the addRepository functions. Instead, we only specify directories from $WEBKIT_DIR/port if we have header files in those directories. The down side is that if we add a header to port, we need to update the include paths. Also, don't specify WebCore includes with OBJ_ROOT as the fallback repository so we save on -I expansion. Remove $WEBKIT_PORT_DIR because it's the same as $PORT_DIR. The change to glue/SConscript is to pick up webkit_version.h since glue is the only place that needs it. Review URL: http://codereview.chromium.org/11598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5923 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5882. It broke LoginPromptTest.TestBasicAuth and .TestTwoAuths.maruel@chromium.org2008-11-248-91/+83
| | | | | | Review URL: http://codereview.chromium.org/11399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5922 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized variable / conditional.deanm@chromium.org2008-11-241-0/+1
| | | | | | | | Properly initialize ResourceLoaderBridge::ResponseInfo content_length. After a long journey, this value is used in WebCore::ProgressTracker::incrementProgress. Review URL: http://codereview.chromium.org/11394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5921 0039d316-1c4b-4281-b951-d872f2087c98
* Progress on form button metrics.deanm@chromium.org2008-11-244-231/+242
| | | | | | | | | | | | | | | | | | | | | | We are very very close to matching Windows metrics for buttons. - Sort RenderThemeGtk.h declarations in the same order as RenderThemeWin.h - Sort RenderThemeGtk.cpp implementations in the same order as declared in the header. - Put all internal static helpers together. - Merge in some comments and code from RenderThemeWin. - Drop incorrect button style methods, when really we want the default behavior instead. - Use 11px Times New Roman for the layout test mode system font. - Switch to Mist as the default layout test theme. This matches Windows much better, with square buttons, etc. - Sort the font list in test_shell_gtk. Review URL: http://codereview.chromium.org/11390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5920 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dead code.deanm@chromium.org2008-11-242-34/+0
| | | | | | | | Remove setButtonPadding, it was a private method that had no callers. Review URL: http://codereview.chromium.org/11391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5919 0039d316-1c4b-4281-b951-d872f2087c98
* Try to bring a bit more structure to RenderThemeWin. This will help as Mac ↵deanm@chromium.org2008-11-232-362/+356
| | | | | | | | | | | | | | | | | | | and Linux try to match it. - Remove trailing whitespace and extra newlines. - Reorder some declarations in the header to better group similar methods. - Drop unimplemented declaration of addIntrinsicMargins. - Implement the empty RenderThemeWin constructor and destructor in the header file. - Reorder all implementations to match declaration order. - Move the enums into the anonymous namespace. - Don't indent in an anonymous namespace. - Move all internal static helpers together. Review URL: http://codereview.chromium.org/11596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5911 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderThemeWin and RenderThemeGtk a bit closer to each other. This is ↵deanm@chromium.org2008-11-224-13/+6
| | | | | | | | | | | | just a baby step in getting RenderThemeGtk to be more like RenderThemeWin. - Remove some cosmetic differences from prototypes. - Remove the unused systemFont(X, X) from GTK. - Make supportsFocus have internal linkage, there is no RenderTheme::supportsFocus. This matches GTK. Review URL: http://codereview.chromium.org/11591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5903 0039d316-1c4b-4281-b951-d872f2087c98
* Update scons binding include path.deanm@chromium.org2008-11-221-1/+0
| | | | | | | | After a recent merge, port/dom no longer exists. The Windows build was updated, but scons was left in a non-building state. Review URL: http://codereview.chromium.org/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5902 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build by updating the include path of the skia files.brettw@google.com2008-11-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5895 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:43:05 +0000