summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* When we're initializing the modal dialog box which asks whether the page has ↵jorlow@chromium.org2010-02-175-54/+40
| | | | | | | | | | | | | | permission to access a "cookie", double check that the value has not since been set. If it has, close the window before it's even shown. This is a stop-gap solution. We should probably come up with something more elegent long term. TEST=Go to a page that starts a database transaction and immediately sets a local storage value. You should get one prompt instead of 2. BUG=36006 Review URL: http://codereview.chromium.org/619009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind memory leak. Adding missing virtual on a destructor.joth@chromium.org2010-02-174-5/+5
| | | | | | | | | | | | ~AccessTokenStoreFactory() was the culprit, the others are for completeness. BUG=none TEST=linux_valgrind try server TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/632001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dock icon to properly pick up pasted-on app icons.avi@chromium.org2010-02-171-1/+6
| | | | | | | | | BUG=http://crbug.com/35791 TEST=paste on a new app icon, download something, make sure icon stays in the dock as is Review URL: http://codereview.chromium.org/628001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39266 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure we don't display several times the translate infobar for a page.jcampan@chromium.org2010-02-177-3/+73
| | | | | | | | | | | | | | We can get several PAGE_DETERMINED notifications for one page. The user might have closed the translate infobar between these multiple notifications. This CL ensures we don't show the infobar again in such cases. BUG=35919 TEST=See bug. Review URL: http://codereview.chromium.org/613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39265 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r38479. The underlying memory leak in WebKit has been fixed.jhawkins@chromium.org2010-02-178-7/+67
| | | | | | | | | | | Send forms seen in the renderer to the AutoFillManager. TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39264 0039d316-1c4b-4281-b951-d872f2087c98
* Calls InfoBarClosed on InfoBarDelegates in unit-tests tojcampan@chromium.org2010-02-172-0/+39
| | | | | | | | | | | ensure the InfoBarDelegates are not leaked. BUG=35614 TEST=No leak in valgrind when running unit-tests. Review URL: http://codereview.chromium.org/600157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39262 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the Update-Client-Auth header to sync. Add a mutex to the ↵chron@google.com2010-02-1723-22/+175
| | | | | | | | | | | auth token in ServerConnectionManager. TEST=manually tested using fiddler2 script. BUG=35321 Review URL: http://codereview.chromium.org/605010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39259 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: prevent the overlay from sliding in and out on fullscreen mode switch.viettrungluu@chromium.org2010-02-176-10/+60
| | | | | | | | | BUG=35959 TEST=Go to various web pages, focus various things, switch in and out of fullscreen mode; overlay should never slide in and then out (it should either be and stay in, if appropriate, or be out and stay out). Review URL: http://codereview.chromium.org/601090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39258 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Prevent chrome from hanging at shutdown after clicking flash player ↵erg@google.com2010-02-172-2/+6
| | | | | | | | | | | | | | settings. When I copied the Windows dialogs, I copied this Windows bug, too. Merge the fix for linux. BUG=34941 TEST=none Review URL: http://codereview.chromium.org/601096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39257 0039d316-1c4b-4281-b951-d872f2087c98
* Added utility to compile webkit with WTF_USE_ACCELERATED_COMPOSITING flag. ↵alokp@chromium.org2010-02-171-0/+11
| | | | | | | | We just need to set GYP_DEFINES=use_accelerated_compositing=1. It is set to 0 by default. Part of the changes is under webkit which I will send in a different CL. Review URL: http://codereview.chromium.org/605006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39256 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix corrupted tab edges when theme changes.erg@google.com2010-02-172-1/+27
| | | | | | | | | | | | | The tab renderer caches composited images, but this means that pieces of the old theme hang around when we switch themes. Drop the cache when we hear a BROWSER_THEME_CHANGED notification. BUG=none TEST=none Review URL: http://codereview.chromium.org/601095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39255 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 54898:54905. Includes image decoder crashing fix.jparent@chromium.org2010-02-172-8/+4
| | | | | | | | | | BUG=35917 TEST=none TBR=rolandsteiner Review URL: http://codereview.chromium.org/620009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39254 0039d316-1c4b-4281-b951-d872f2087c98
* Add comment to unit tests previously disabledhclam@chromium.org2010-02-171-0/+8
| | | | | | | | | | | | | FFmpegGlueTest and friends are crashing on the build bots. Some of them are disabled and need comment in the code to indicate the bug number. BUG=36037 TBR=scherkus, finnur Review URL: http://codereview.chromium.org/619012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39253 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FFmpegGlueTest.Write and friendshclam@chromium.org2010-02-171-4/+4
| | | | | | | | | | | | FFmpegGlueTest.Write starts to crash. Can't fix it shortly so disable it and its friends. BUG=36037 TBR=finnur, scherkus Review URL: http://codereview.chromium.org/624001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39252 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Implement the new AutoFill section of the Options dialog.jhawkins@chromium.org2010-02-177-50/+103
| | | | | | | | | | | | | | * Updated the text of the radio buttons. * Added a button that opens the AutoFill dialog. BUG=33025 TEST=manually Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/579020 Review URL: http://codereview.chromium.org/610003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39251 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: don't unset |model_| when executing a command.estade@chromium.org2010-02-172-16/+5
| | | | | | | | | | | It's valid to reuse the same BookmarkContextMenuModel more than once. BUG=35438 TEST=manual Review URL: http://codereview.chromium.org/609009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39250 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the bookmark manager icons.arv@chromium.org2010-02-172-0/+0
| | | | | | | | | | TBR=glen BUG=34618 TEST=Look and behold. The section image is now showing a star. Review URL: http://codereview.chromium.org/618013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39248 0039d316-1c4b-4281-b951-d872f2087c98
* API to allow strategy class to work on the output buffer of OpenMAXhclam@chromium.org2010-02-1712-147/+1343
| | | | | | | | | | | | | | Added interface of OmxOutputSink to interact with OmxCodec to perform buffer negotiation and buffer read signaling. TEST=media_unittests --gtest_filter=Omx* BUG=32753 BUG=32754 BUG=32870 Review URL: http://codereview.chromium.org/593047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39247 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporating review comments from Amit. The keyboard based back forward ↵ananta@chromium.org2010-02-174-61/+30
| | | | | | | | | | | | | | | test only needs simple HTML files with the meta tag to switch to Chrome. Removed the fulltab_forward_page.html amd fulltab_back_page.html and replaced them with the sub_frame1.html and sub_frame2.html Other changes include to use SetFocusToChrome helper function to give focus to the Chrome renderer window instead of sending a WM_LBUTTONDOWN and to use ComStackObjectWithUninitialize mock class to ensure that things get cleaned up correctly. Review URL: http://codereview.chromium.org/608033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39246 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 54848:54898jparent@chromium.org2010-02-172-1/+18
| | | | | | | | | | TEST=none BUG=36014,36015,36016,36018,36019 TBR=rolandsteiner Review URL: http://codereview.chromium.org/618011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39245 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=http://crbug.com/34161jrg@chromium.org2010-02-172-2/+4
| | | | | | | | | TEST=On Win (debug build only), go to about:ipc. Make sure dialog opens and does not hang. Review URL: http://codereview.chromium.org/600159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39241 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the Mac regression in the startup perf tests by removing themirandac@chromium.org2010-02-172-28/+30
| | | | | | | | | | | | | | HasCustomImage check from GetNSImageNamed. The source of the problem was that HCI was throwing off "nil" for inactive images (which is correct, as they don't appear in a theme's original image pack), and therefore ignoring the already created inactive frames, thus creating them twice. BUG= 34775 TEST= Mac startup regression goes away from perf bots. Review URL: http://codereview.chromium.org/608023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39240 0039d316-1c4b-4281-b951-d872f2087c98
* Minor UI updates on the windows auto-fill UIgeorgey@chromium.org2010-02-171-17/+11
| | | | | | | | TEST=Box around CC info/address appears now when they expanded. Items are collapsed by default BUG=33026 Review URL: http://codereview.chromium.org/613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix removing unnecessary files in export_tarball.pyphajdan.jr@chromium.org2010-02-171-16/+14
| | | | | | | | | TEST=none BUG=29044 Review URL: http://codereview.chromium.org/619007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39238 0039d316-1c4b-4281-b951-d872f2087c98
* Update xp/moz/vm_peak_r.chase@chromium.org2010-02-171-1/+1
| | | | | | | | | | | | r39175's WebKit roll 54810:54839 gives a big drop on vm_peak_r. BUG=none TEST=moz cycler goes green Review URL: http://codereview.chromium.org/619003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39237 0039d316-1c4b-4281-b951-d872f2087c98
* media: remove redundant gyp excludesevan@chromium.org2010-02-172-26/+9
| | | | | | | | | | I moved all of these general patterns to common.gypi. Also rearrange the common.gypi patterns to cover more common Linux patterns. Review URL: http://codereview.chromium.org/608032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39236 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add a link to flash settings from the clear browsing history dialog.erg@google.com2010-02-172-2/+41
| | | | | | | | | BUG=35183 TEST=none Review URL: http://codereview.chromium.org/606070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39235 0039d316-1c4b-4281-b951-d872f2087c98
* Update NaCl in Chromegregoryd@google.com2010-02-171-1/+1
| | | | | | | | This will get the prebuilt nexes into the tree so they can be used by chrome-nacl integration tests. Review URL: http://codereview.chromium.org/600161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39234 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for locaiton arbitrator and browser tests for the access ↵joth@chromium.org2010-02-1714-104/+634
| | | | | | | | | | | | | token store (as it integrates with browser singletons) Fixes a few bugs discovered along the way, and make large-ish redesign of the access token API in order to allow sane use with threading restrictions. BUG=None TEST=unit_tests.exe --gtest_filter=Geol* --gtest_repeat=10000 --gtest_break_on_failure Review URL: http://codereview.chromium.org/600141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39232 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds grippys to the left side of the Browser Actions container to ↵andybons@chromium.org2010-02-175-37/+77
| | | | | | | | | | | | resize the container (they do not work yet), refactors a bunch of code out of toolbar_controller.mm and adds a slight gradient'ed divider between the container and the page/wrench menus buttons. http://imgur.com/OqKGF.png TEST=none BUG=26990 Review URL: http://codereview.chromium.org/606079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39231 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Re-init IPC code when window manager starts.derat@chromium.org2010-02-173-1/+40
| | | | | | | | | | | | | | | | | | Chrome's code to look up the WM's window and notify it about which version of the IPC protocol Chrome supports stopped firing at the correct time, probably due to the login manager change. Additionally, this code wasn't getting re-run if the window manager crashed and was restarted. This change makes us watch for MANAGER ClientMessage events on the root window so that we can reinitialize as needed. BUG=none TEST=checked that panel-dragging works after logging in and after killing chromeos-wm Review URL: http://codereview.chromium.org/610004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39229 0039d316-1c4b-4281-b951-d872f2087c98
* Use better web app icons.xiyuan@chromium.org2010-02-171-2/+8
| | | | | | | | | | | | | | | - Accept "link" element of both "icon" and "shortcut icon" type. see also: http://en.wikipedia.org/wiki/Favicon http://dev.w3.org/html5/spec/Overview.html#rel-icon - Get complete url from icon link's href; BUG=none TEST=Create web app shortcut to "Google Reader" and expect to see crispy clear icon rather than the blur favicon. Review URL: http://codereview.chromium.org/611008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39228 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: move status bubble to fullscreen window (and back) when switching modes.viettrungluu@chromium.org2010-02-173-0/+23
| | | | | | | | | BUG=35962 TEST=Switch to/from fullscreen mode with (or without) the status bubble showing (also in various states of showing -- fading in/out/changing/etc.). Status bubble should appear in new mode, with the appropriate size and in the appropriate place. Review URL: http://codereview.chromium.org/621001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39227 0039d316-1c4b-4281-b951-d872f2087c98
* Removed redundant conditionals from gpu/demos.gyp.alokp@chromium.org2010-02-171-20/+13
| | | | | | Review URL: http://codereview.chromium.org/601085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39226 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp.mmoss@google.com2010-02-175-12/+6
| | | | | | | | | | This properly triggers build targets that depend on "always run" actions. BUG=22044 Review URL: http://codereview.chromium.org/604061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39223 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. tidy up of various comments found whilst learning the codebase.joth@chromium.org2010-02-178-13/+20
| | | | | | | | | | | | Fix a lint warning in render_messages.h (supersedes http://codereview.chromium.org/464072/show) Also implement a couple comments in geolocaiton/ in follow up to http://codereview.chromium.org/604019 BUG=none TEST=none Review URL: http://codereview.chromium.org/600128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39222 0039d316-1c4b-4281-b951-d872f2087c98
* solaris: minor ifdefsevan@chromium.org2010-02-175-2/+10
| | | | | | | | | | | | | base/process_util_posix.cc, base/third_party/nspr/prcpucfg.h, third_party/npapi/bindings/npapi.h: added alternate Solaris OS choice BUG=30101 TEST=compiles Patch by James Choi <jchoi42@pha.jhu.edu>. Review URL: http://codereview.chromium.org/606069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39220 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Mac-like input behavior on all platforms but Mac.jochen@chromium.org2010-02-172-0/+9
| | | | | | | | | BUG=none TEST=e.g. double click a word to select it, hit delete. should only delete the word (not the whitespace before) Review URL: http://codereview.chromium.org/601093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39219 0039d316-1c4b-4281-b951-d872f2087c98
* Improved debugging python GDB helpers.evan@chromium.org2010-02-171-1/+76
| | | | | | | | | | | | | | | | Added printing for WebCore::QualifiedName. Added a new command that will print the path from a WebCore::Node to the root. The command is really only half-baked, but hopefully will provide a good starting point for other new commands. (And it did help me track down an SVG bug.) BUG=none TEST=none Patch from Bryan Yeung <bryeung@chromium.org>. Review URL: http://codereview.chromium.org/598051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39215 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CONTENT_SETTING_ASK for database. Also some cleanup of the dialog ↵jorlow@chromium.org2010-02-1716-81/+363
| | | | | | | | | | | for local storage. BUG=34628 TEST=none Review URL: http://codereview.chromium.org/605028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39214 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 330.0 to 331.0chrome-release@google.com2010-02-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39212 0039d316-1c4b-4281-b951-d872f2087c98
* Disables some WorkerTests on Linux valgrind bots.hbono@chromium.org2010-02-171-0/+17
| | | | | | | | | TBR=dimich BUG=28439 TEST=none Review URL: http://codereview.chromium.org/621002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39209 0039d316-1c4b-4281-b951-d872f2087c98
* We need to support the following accelerators in the ChromeFrame Active ↵ananta@chromium.org2010-02-1711-8/+245
| | | | | | | | | | | | | | | | | | | | | | | | document, to ensure that the following accelerators navigate backwards and forwards in IE history. 1. VK_BACK and Alt + VK_LEFT to navigate back. 2. Shift + VK_BACK and Alt + VK_RIGHT to navigate forward. This CL adds support for this. We load the accelerator table in our Active document and when we receive an accelerator from Chrome, we first call the Windows API TranslateAccelerator to translate any accelerators and then continue with the default handling. Added handlers for navigating back and forward. Test=covered by unit test. Fixes bug http://code.google.com/p/chromium/issues/detail?id=35629 Bug=35629 Review URL: http://codereview.chromium.org/600117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39208 0039d316-1c4b-4281-b951-d872f2087c98
* Translate: Move label parsing logic into common code.jeremy@chromium.org2010-02-175-18/+59
| | | | | | | | | | | | | * Add a string16 & Cocoa version of GetStringF(). * Move logic for parsing translate infobar label into translate_infobars_delegates. * Make views variant of translate infobars use new code. BUG=34466 TEST=Translate infobars should continue to workon Windows. Review URL: http://codereview.chromium.org/597042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39206 0039d316-1c4b-4281-b951-d872f2087c98
* Implement layoutTestController.numberOfPages.hamaji@chromium.org2010-02-175-16/+62
| | | | | | | | | BUG=35215 TEST=layout tests Review URL: http://codereview.chromium.org/594054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39199 0039d316-1c4b-4281-b951-d872f2087c98
* Suppresses the leak in TranslateManagerTest.hbono@chromium.org2010-02-171-0/+24
| | | | | | | | | TBR=jcampan BUG=35614 TEST=none Review URL: http://codereview.chromium.org/616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39198 0039d316-1c4b-4281-b951-d872f2087c98
* Updates many commands to require the client to set the gman@chromium.org2010-02-177-23/+383
| | | | | | | | | | | | result->size to 0 or result->success to false before calling the command. TEST=none BUG=none Review URL: http://codereview.chromium.org/612006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39193 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the issues with Jump, JumpRel, Call, CallRelgman@chromium.org2010-02-172-2/+6
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/614006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39192 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix valgrind error.thakis@chromium.org2010-02-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/616003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39191 0039d316-1c4b-4281-b951-d872f2087c98
* Beginnings of a unit test for downloads that occur in a new window.tommi@chromium.org2010-02-176-130/+429
| | | | | | | | | | | | | | | | | | For now this works for IE regularly (no cf in the picture) and triggers a download in a new window. It is disabled since support for this scenario is not yet ready in CF. I'm adding a couple of things to WebBrowserEventSink: - A way to gracefully close IE. This way we allow IE to quit on its own and don't go the "kill" route unless necessary. This should help with reducing cases where we've killed IE and the next time it is started it presents the user with an "IE crashed" dialog which could cause subsequent unit tests to fail. Another thing this adds is support for the OnQuit event that can be useful to add to unit tests as an expected event. - A new OnFileDownload event. I also updated several tests to expect this event. TEST=Adds a unit test. BUG=none Review URL: http://codereview.chromium.org/569011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39190 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 05:08:26 +0000