summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Suppress DrMemory leak reports under _getptdtimurrrr@chromium.org2011-01-211-0/+5
| | | | | | | | | BUG=http://code.google.com/p/drmemory/issues/detail?id=275 TBR=glider TEST=DrM/FYI should go greener Review URL: http://codereview.chromium.org/6303015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72126 0039d316-1c4b-4281-b951-d872f2087c98
* Update the suppression for a race on bool in HistoryURLProvider; ignore a ↵timurrrr@chromium.org2011-01-212-1/+6
| | | | | | | | | | | function where TSan doesn't understand a shared memory lock TBR=glider BUG=45083,66994 TEST=TSan/interactive_ui tests should become greener Review URL: http://codereview.chromium.org/6354012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72125 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run JingleSessionTest.Connect under DrMemory as well; update DrM ↵timurrrr@chromium.org2011-01-212-0/+11
| | | | | | | | | | | suppressions TBR=glider TEST=DrM/FYI bot should go greener BUG=70225 Review URL: http://codereview.chromium.org/6380009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72124 0039d316-1c4b-4281-b951-d872f2087c98
* When clearing plugin data at shutdown, wait for it to finish.bauerb@chromium.org2011-01-2110-51/+170
| | | | | | | | | | | Also, Add some browser tests for clearing plugin data and enable npapi_test_plugin on 64-bit Linux; apparently it's been fixed. BUG=58235, 18337, 26625 TEST=PluginDataRemoverTest.* Review URL: http://codereview.chromium.org/6308001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72123 0039d316-1c4b-4281-b951-d872f2087c98
* The RSS subscribe.js should not double-decoded the URL passed in.finnur@chromium.org2011-01-214-3/+37
| | | | | | | | | | | | This causes feeds from Twitter searches to break because the hash sign (%23) gets decoded before passed to Twitter. BUG=70226 TEST=ExtensionBrowserTest.ParseFeedInvalidFeed4 Review URL: http://codereview.chromium.org/6332008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72122 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes problem with non-consitent active downloads.altimofeev@chromium.org2011-01-211-1/+0
| | | | | | | | | | | | | | Fix http://src.chromium.org/viewvc/chrome?view=rev&revision=71785 revealed possible flow, when active downloads list contains non-existing downloads. This fix removes redundant method call, which is also dangerous. BUG=none TEST=cancel dangerous download, notice that Chromium is alive. Review URL: http://codereview.chromium.org/6372003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72121 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetScreenMode() to status_area_host.h.yusukes@google.com2011-01-2111-53/+43
| | | | | | | | | | | Add GetScreenMode() to status_area_host.h, and remove IsBrowserMode() and IsScreenLockerMode() APIs. The old APIs seem to be a bit confusing since only 3 combinations out of 2^2 are valid. (I mean, IsBrowserMode() == true and IsScreenLockerMode() == true is invalid.) BUG=chromium-os:8386 TEST=manually, try bot. Review URL: http://codereview.chromium.org/6378008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72120 0039d316-1c4b-4281-b951-d872f2087c98
* Fix my (??) stupid typo in memcheck_analyze which stupid python didn't caught.timurrrr@chromium.org2011-01-211-1/+1
| | | | | | | | | | As a result, memcheck_analyze was waiting for dead Valgrind processes for 3 extra minutes. D'oh. BUG=17453,44545 TEST=trybots, experiments by eugenis@ Review URL: http://codereview.chromium.org/6258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72119 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show queued infobars on tab shutdown.jknotten@chromium.org2011-01-215-17/+199
| | | | | | | | | BUG=69965 TEST=GeolocationBrowserTest.TabDestroyed,GeolocationPermissionContextTests.TabDestroyed Review URL: http://codereview.chromium.org/6340011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72118 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to pull the recent cros change.yusukes@google.com2011-01-211-1/+1
| | | | | | | | | | | http://git.chromium.org/gitweb/?p=cros.git;a=commit;h=34a0e132afad573f7595c1c813ae03d9d5ff6eec BUG=chromium-os:11101 TEST=try Review URL: http://codereview.chromium.org/6364003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72117 0039d316-1c4b-4281-b951-d872f2087c98
* Add opener frame id, url, and target url to CreateWindow message.jochen@chromium.org2011-01-213-2/+37
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6293007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72116 0039d316-1c4b-4281-b951-d872f2087c98
* Generate thumbnails in the browser process.satorux@chromium.org2011-01-2115-22/+348
| | | | | | | | | | | | | | | | | | | | | The feature is now behind --enable-in-browser-thumbnailing flag. The in-browser thumbnailing works as follows: - The scroll offset is sent from the renderer to the browser. - The thumbnail is taken when the page info is sent from the renderer process. - Since thumbnails are generated in the browser, we can avoid the generation when unnecessary (ex. off-the-record mode, or New Tab Page). - The quality of thumbnails is as good as before, as the patch doesn't change timing heuristics. - The drawback is that we cannot take thumbnails from background tabs. New functions are added to ThumbnailGenerator for clipping thumbnails, with tests. BUG=65936 TEST=add unit tests for thumbnail_generator. confirmed that the thumbnails are updated with and without --enable-in-browser-thumbnailing Review URL: http://codereview.chromium.org/6246007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the regression caused by r72061.kochi@chromium.org2011-01-211-4/+8
| | | | | | | | | | | The CL ifdef'ed out for some parts of HTML, but it did not touch the corresponding JS code that modifies the part. BUG=chromium-os:11142 TEST=manually open chrome://settings Review URL: http://codereview.chromium.org/6342013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72114 0039d316-1c4b-4281-b951-d872f2087c98
* Views-implementation of AutocompleteEditView.oshima@google.com2011-01-216-369/+1334
| | | | | | | | | | | | | | | | | | This is based on GTK implementation. Please see the header file for features that are not implemented yet. Textfield changes (files under views/controls/textfield) are being reviewed by Ben in separate CL (http://codereview.chromium.org/6314012/), so you don't have to review them (but you're welcome to do so). * Updated factory method in AutocompleteEditViewGtk to return views-implementation when TextfieldViews is enabled. * Added new option to FillLayout so that it lays out its child inside border. * Added missing GD_PK_Delete to keycode conversion. * Enabled tests in autodomplete_edit_view_browsertests for views-implementation as well. I moved the test body to the class and then called them from each test class to avoid having another test configuration on bots. Let me know if there is better way. BUG=none TEST=Enabled autocomplete_edit_view_browsertest for views-implementation. Review URL: http://codereview.chromium.org/6245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in build fix.brettw@chromium.org2011-01-211-1/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6346011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix base:: namespace for Lock.brettw@chromium.org2011-01-212-3/+3
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6265018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72111 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sanity check in RegKey to prevent usage of checkingamit@chromium.org2011-01-212-67/+34
| | | | | | | | | | | | return value as a bool BUG=none TEST=none Review URL: http://codereview.chromium.org/6346010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to fix the buildbrettw@chromium.org2011-01-211-1/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6360010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72109 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing base::lock usage.brettw@chromium.org2011-01-218-8/+8
| | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6336010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the process is _really_ gone after a __debugbreak(). We've had acevans@chromium.org2011-01-214-1/+12
| | | | | | | | | | | | | few annoying cases where someone has been monitoring Chrome under windbg, which can skip over __debugbreak() and then show them a scary-looking access violation. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6372008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-21297-1114/+1085
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+17
| | | | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72095 Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72105 0039d316-1c4b-4281-b951-d872f2087c98
* Add Throbber control for DOMUI. Use it everywhere in options and in Sync ↵sergeyu@chromium.org2011-01-2112-90/+37
| | | | | | | | | | | setup UI. BUG=69755 TEST=Throbber works properly when settings page is scaled. Review URL: http://codereview.chromium.org/6378006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72104 0039d316-1c4b-4281-b951-d872f2087c98
* Add gpu/ files from the public skia project into the chrome build. This is inthakis@chromium.org2011-01-212-2/+106
| | | | | | | | | | | | | | | | | preparation for experimenting with them to gpu-accelerate various aspects of chrome's drawing. In this initial patch, the files will be built, but not called. Now with dependency on gpu lib for sharedlib build on linux TEST=be sure that page rendering, and <canvas> rendering, look the same as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71998 Review URL: http://codereview.chromium.org/6357006 Patch from Mike Reed <reed@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72103 0039d316-1c4b-4281-b951-d872f2087c98
* Only close the sync socket if it is non-NULL. This fixesnfullagar@google.com2011-01-211-1/+2
| | | | | | | | | | a NaCl page reload / surf-away regression. BUG=NaCl ppapi audio proxy TEST=native_client/tests/ppapi_example_audio Review URL: http://codereview.chromium.org/6300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72099 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for leak in gfx::CanvasSkia::SizeStringIntisherman@chromium.org2011-01-211-0/+11
| | | | | | | | | BUG=70327 TEST=none Review URL: http://codereview.chromium.org/6268009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72095 - Attribute orphaned or anonymous network usage to the Browser ↵thakis@chromium.org2011-01-211-16/+13
| | | | | | | | | | | | | | | resources. BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6341006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+16
| | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK(result) keeps firing in ↵dhollowa@chromium.org2011-01-211-0/+8
| | | | | | | | | | | | | AutocompleteHistoryManager::OnWebDataServiceRequestDone() A NULL |result| should DCHECK, but not crash. This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined. BUG=68783, 69833 TEST=none Review URL: http://codereview.chromium.org/6275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72094 0039d316-1c4b-4281-b951-d872f2087c98
* Added one testcase: testFindInCanDismissInstantnirnimesh@chromium.org2011-01-211-0/+10
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6352003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72093 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Cancel pending queries to the PasswordStore on destruction to avoidjhawkins@chromium.org2011-01-212-12/+24
| | | | | | | | | | | being notified after the object has been destroyed. BUG=69441 TEST=none Review URL: http://codereview.chromium.org/6299014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72092 0039d316-1c4b-4281-b951-d872f2087c98
* ppapi_egl target is currently unused as verified by using:noelallen@google.com2011-01-212-40/+55
| | | | | | | | | | | | grep --include="*.gyp*" -nr -F "ppapi_egl" . However this library causes NaCl to require third_party/mesa which relative to NaCl is large. This CL moves the definition of this static library from ppapi to the lib/gl directory under ppapi so that PPAPI users are not forced to DEPS in mesa. Review URL: http://codereview.chromium.org/6342012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72090 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Show Mac address book checkbox.csilv@chromium.org2011-01-211-1/+1
| | | | | | | | BUG=64800 TEST=Verify that the checkbox for the Mac address book appears in autofill options. Review URL: http://codereview.chromium.org/6278012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse()nirnimesh@chromium.org2011-01-211-2/+2
| | | | | | Review URL: http://codereview.chromium.org/6264007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72088 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on non-existent librarythakis@chromium.org2011-01-211-2/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72087 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of SingleSplitViewExample from the header ↵tfarina@chromium.org2011-01-213-49/+82
| | | | | | | | | | | file to the source file. BUG=None TEST=run out/Debug/views_examples, it should work as before. Review URL: http://codereview.chromium.org/6377004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72086 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: enable languages & spell checker settings for all platforms.csilv@chromium.org2011-01-2115-220/+458
| | | | | | | | BUG=56415,43716 TEST=Verify language & settings panel functionality on dom-ui settings window. Review URL: http://codereview.chromium.org/6296017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72085 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in PluginService if the keys are null. It's still unclear why ↵jam@chromium.org2011-01-211-2/+4
| | | | | | | | | this is happening now as opposed to before. This change just fixes the crash in the meantime. BUG=70317 Review URL: http://codereview.chromium.org/6313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72083 0039d316-1c4b-4281-b951-d872f2087c98
* final fix for windows webkit test_expectations for official buildskerz@chromium.org2011-01-211-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72079 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Roll webkit deps from r76235 to r76307."tony@chromium.org2011-01-211-1/+1
| | | | | | | | | | | | | | | | This reverts commit r72069. The ARM build gave this compiler warning: cc1plus: warnings being treated as errors third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp: In function 'const WTF::AtomicString& WebCore::alternateFamilyName(const WTF::AtomicString&)': third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp:139: error: 'timesNewRoman.unstatic.3258' may be used uninitialized in this function make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/FontCache.o] Error 1 TBR=jorlow Review URL: http://codereview.chromium.org/6248012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72078 0039d316-1c4b-4281-b951-d872f2087c98
* windows test exceptionskerz@chromium.org2011-01-211-0/+28
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72076 0039d316-1c4b-4281-b951-d872f2087c98
* lastchange.py: fix style, unify git codepathevan@chromium.org2011-01-211-41/+15
| | | | | | | | | | | | 1) Change style to match style guide. 2) Use "git svn info" so we can use the same parsing code for both git and svn. TEST=ran manually Review URL: http://codereview.chromium.org/6263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72074 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_utils::GetNameForURL return a string16.evan@chromium.org2011-01-214-8/+8
| | | | | | | | | | | It is returning Unicode so it should be a string16. The callers want a string16 anyway. TEST=compiles Review URL: http://codereview.chromium.org/6306006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72073 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Gracefully a handle a NULL profile in the Autofill editor handler. Thisjhawkins@chromium.org2011-01-211-2/+16
| | | | | | | | | | | | can happen if we try to edit a profile that is in the process of being removed, but for which we haven't been notified that it's removed yet. BUG=69327 TEST=none Review URL: http://codereview.chromium.org/6323012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72071 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Disable AutomatedUITestBase.ShowBookmarkBar under Valgrind as itjhawkins@chromium.org2011-01-211-0/+4
| | | | | | | | | | | | fails flakily. TBR=isherman BUG=70323 TEST=none Review URL: http://codereview.chromium.org/6351012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72070 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps from r76235 to r76307.tony@chromium.org2011-01-211-1/+1
| | | | | | | | TBR=jorlow Review URL: http://codereview.chromium.org/6300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72069 0039d316-1c4b-4281-b951-d872f2087c98
* Force patches that touch sync code to use the sync trybotsrsimha@chromium.org2011-01-211-0/+13
| | | | | | | | | | | | | | | | | | | | | As of today, we have dedicated chromium trybots that can run the sync integration tests, but it requires developers to explicitly send try jobs to these bots via the --bot switch. Now that the sync trybots are stable, it is time to make this process automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that adds the sync trybots in addition to win, mac and linux to the list of preferred trybots. This patch adds such a PRESUBMIT.py file, that includes win_sync, mac_sync and linux_sync to the list of preferred trybots. BUG=70311 TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try" Review URL: http://codereview.chromium.org/6275010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98
* final set of expectations for nowkerz@chromium.org2011-01-211-1/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72065 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: More data files for unit tests.rvargas@google.com2011-01-2124-0/+776
| | | | | | | | | | | BUG=69135 TEST=none TBR=gavinp Review URL: http://codereview.chromium.org/6300009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72063 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS files to autofill, notifications and speech subdirs.tfarina@chromium.org2011-01-213-0/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6380006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72062 0039d316-1c4b-4281-b951-d872f2087c98