summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix crashes stemming from ClientSocketPoolBase::ReleaseSocket().willchan@chromium.org2009-06-183-20/+61
| | | | | | | | | BUG=http://crbug.com/13908 TEST=Go to a page that loads lots of content from the same host, and then triggers a redirect (which will cancel the requests). A good example is http://photo.sora.net/album/theme/index.php. Unittest coverage provided in TCPClientSocketPoolTest.CancelActiveRequestWithPendingRequests. Review URL: http://codereview.chromium.org/131023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18718 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract ExtensionPrefs into their own class.erikkay@google.com2009-06-189-244/+374
| | | | | | | | | Relands http://codereview.chromium.org/126281 which had been reverted due to a leak. The only difference is in extension_prefs.h where extension_data_ is now a scoped_ptr. Review URL: http://codereview.chromium.org/131040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18717 0039d316-1c4b-4281-b951-d872f2087c98
* Set the right mime type on pdf files.maruel@chromium.org2009-06-180-0/+0
| | | | | | | | TEST=none BUG=none TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18716 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up "clear browsing data" dialog. It looks like ass right now. The ↵ben@chromium.org2009-06-189-37/+65
| | | | | | | | | | intent is to be able to debug problems with NativeControls under Gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/131027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18715 0039d316-1c4b-4281-b951-d872f2087c98
* A long standing bug in views!ben@chromium.org2009-06-182-2/+0
| | | | | | | | | | | | | | | | Every time a widget is resized, we call Layout on its view hierarchy TWICE! A while ago, I added code to views::View's default implementation of DidChangeBounds to automatically call Layout. So, after calling SetBounds on a widget, it is not necessary to call Layout. However this is exactly what WidgetWin/WidgetGtk do o_O. It turns out this doesn't matter on windows because size changes in child widgets never affect the sizes of their parents - they're just clipped to their parent's bounds. However, on Gtk it seems like sizing a child causes a size-allocate signal to be sent to the parent widget, which means we end up in infinite resize loops. BUG=none TEST=none Review URL: http://codereview.chromium.org/131026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18714 0039d316-1c4b-4281-b951-d872f2087c98
* Fix scons related svn:ignores for linux.maruel@chromium.org2009-06-180-0/+0
| | | | | | | | | | Cleaned up the stale .scons and SConstruct ignores and added the new ones TEST=none BUG=none TBR=sgk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18713 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup the windows-related svn:ignore on the directories.maruel@chromium.org2009-06-180-0/+0
| | | | | | | | | | | | Removed the stale .sln and .vcproj ignores and added the new ones. This should help the try server tremendously. TEST=none BUG=none TBR=sgk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18711 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a skia valgrind error.craig.schlenter@chromium.org2009-06-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18710 0039d316-1c4b-4281-b951-d872f2087c98
* Only check for first run dialog on official builds (since the dialog is aamanda@chromium.org2009-06-181-0/+4
| | | | | | | | | no-op on Chromium builds) BUG=none TEST=none Review URL: http://codereview.chromium.org/131035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18709 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back Skia to r198. There are just a few layout test pixeldeanm@chromium.org2009-06-181-1/+1
| | | | | | | | | | differences, but the results look like something more broken is going on. Review URL: http://codereview.chromium.org/132020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18708 0039d316-1c4b-4281-b951-d872f2087c98
* Roll up Skia to r220 to pick up MSVC warning fix.deanm@chromium.org2009-06-181-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/132019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18706 0039d316-1c4b-4281-b951-d872f2087c98
* Roll up Skia to revision r219, picking up a spline rendering fix.deanm@chromium.org2009-06-181-1/+1
| | | | | | | | | BUG=14536 Review URL: http://codereview.chromium.org/136002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18705 0039d316-1c4b-4281-b951-d872f2087c98
* Quick spelling fix.avi@google.com2009-06-181-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/132016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18703 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Implement console.dir(live object) while on a breakpoint.pfeldman@chromium.org2009-06-181-4/+41
| | | | | | Review URL: http://codereview.chromium.org/131030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18702 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the addition of -fno-threadsafe-statics. It breaks the build:deanm@chromium.org2009-06-181-1/+0
| | | | | | | | | | | cc1: warning: command line option "-fno-threadsafe-statics" is valid for C++/ObjC++ but not for C From what I can find, GYP has not separation between C and C++ flags :( Review URL: http://codereview.chromium.org/131031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18701 0039d316-1c4b-4281-b951-d872f2087c98
* Add -fno-threadsafe-statics to the Linux build.deanm@chromium.org2009-06-181-0/+1
| | | | | | | | | | | We already depend on our static initializers being thread safe, since MSVC does not implement locking around static initialization. This avoids extra locking (__cxa_guard_acquire / __cxa_guard_release). Review URL: http://codereview.chromium.org/126267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18700 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: the context should be disposed to releas scripts and other ↵yurys@google.com2009-06-182-0/+6
| | | | | | | | resources it may hold. Review URL: http://codereview.chromium.org/132012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18699 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 44773:44798levin@chromium.org2009-06-184-1/+5
| | | | | | | | | | | | | The one change is to add HTMLDataGridElement support due to change http://trac.webkit.org/changeset/44778 TBR=paul@chromium.org BUG=None TEST=The data grid element is new but it is still under development. Review URL: http://codereview.chromium.org/126310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18698 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing null handle check to document wrapper caching code.ager@chromium.org2009-06-181-0/+8
| | | | | | | | | | | If instantiation of the document wrapper fails (for instance in out of memory situations) we get a null handle which will lead to a crash when using ForceSet. BUG=14514 Review URL: http://codereview.chromium.org/133001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18697 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call FileChooser::chooseFile("") if a user selects nothing with a file ↵tkent@chromium.org2009-06-181-3/+2
| | | | | | | | | | | | | | | | chooser dialog. chooseFiles() works well even for an empty vector. BUG=14162,14164 TEST=Open an image upload dialog of Gmail or Google Sites, Click the file upload button, Click the Cancel button in the file chooser dialog. Confirm that the dialog doesn't show "[failed]" message. Review URL: http://codereview.chromium.org/125175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18696 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'cp' not 'copy' to copy in the FirstRun file, since the gyp msvssgk@google.com2009-06-181-1/+1
| | | | | | | | | generator uses Cygwin's bash and not cmd to execute commands. BUG=none TEST=none Review URL: http://codereview.chromium.org/131028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18695 0039d316-1c4b-4281-b951-d872f2087c98
* Remove RenderThemeChromiumSkia.cpp explicitly from the mac build.ajwong@chromium.org2009-06-181-0/+4
| | | | | | | | This file does not build on a CoreGraphics platform, and isn't used by the mac build. The explicit exclusion is needed because the Skia suffix doesn't match any of the platform regex exclusions. Review URL: http://codereview.chromium.org/131024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18694 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.8.1.sgjesse@chromium.org2009-06-181-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18693 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.exe to generation by gyp.sgk@google.com2009-06-181-1/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18692 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the 'app' target name (which builds the actual executable)sgk@google.com2009-06-182-14/+14
| | | | | | | | | to 'chrome'. BUG=none TEST=none Review URL: http://codereview.chromium.org/131011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18689 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18683: "Add more CHECKs to ClientSocketPoolBase."willchan@chromium.org2009-06-181-17/+11
| | | | | | | | Looks like it might have broken block-test.html somehow. Review URL: http://codereview.chromium.org/131020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18688 0039d316-1c4b-4281-b951-d872f2087c98
* Improve chunked encoding parsing.abarth@chromium.org2009-06-182-1/+9
| | | | | | | | | | | | R=abarth BUG=14508 TEST=HttpChunkedDecoderTest.ExcessiveChunkLen Patch contributed by Chris Evans. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18687 0039d316-1c4b-4281-b951-d872f2087c98
* test_support_ui needs to depend on theme_resources to fix this compilensylvain@chromium.org2009-06-181-0/+1
| | | | | | | | | | | | | | | issue for clobber build : Configuration: test_support_ui - Debug|Win32 Compiling... npapi_test_helper.cc c:\b\slave\win\build\src\chrome/browser/tab_contents/navigation_entry.h(15) : fatal error C1083: Cannot open include file: 'grit/theme_resources.h': No such file or directory ui_test.cc Review URL: http://codereview.chromium.org/131019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18686 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp revision in DEPS to change SCons intermediate directories.sgk@google.com2009-06-181-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18685 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile on Jaunty.thestig@chromium.org2009-06-181-0/+1
| | | | | | | | | BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/132011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18684 0039d316-1c4b-4281-b951-d872f2087c98
* Add more CHECKs to ClientSocketPoolBase.willchan@chromium.org2009-06-181-11/+17
| | | | | | | | BUG=http://crbug.com/14395 Review URL: http://codereview.chromium.org/131017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18683 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18661.willchan@chromium.org2009-06-189-370/+244
| | | | | | | | Broke purify and mac valgrind. "Pull Extension-related prefs into its own class. Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none" Review URL: http://codereview.chromium.org/132008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18682 0039d316-1c4b-4281-b951-d872f2087c98
* Use factories for ConnectingSockets.willchan@chromium.org2009-06-182-33/+93
| | | | | | | | | | This breaks the dependency between ClientSocketPoolBase and the specific ConnectingSocket. The derived class of ClientSocketPool passes in a ConnectingSocketFactory to ClientSocketPoolBase. BUG=http://crbug.com/13289 Review URL: http://codereview.chromium.org/125282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18681 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc. Take 2.willchan@chromium.org2009-06-187-24/+102
| | | | | | | | | | Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Review URL: http://codereview.chromium.org/131007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some more images for the new new tab pagearv@google.com2009-06-1825-0/+15
| | | | | | | | | | BUG=None TEST=No visible changes yet Review URL: http://codereview.chromium.org/131010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18677 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move SyncIPC function from Skia to base.agl@chromium.org2009-06-183-43/+69
| | | | | | | | | I'll be needing in some pending WebKit changes. http://codereview.chromium.org/131006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18676 0039d316-1c4b-4281-b951-d872f2087c98
* Enable off-by-default monitor color management on Windows. This is enabled viabrettw@chromium.org2009-06-185-2/+50
| | | | | | | | | a command-line switch. BUG=4938 Review URL: http://codereview.chromium.org/131002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18675 0039d316-1c4b-4281-b951-d872f2087c98
* I think this fixes the issue with init-status-test.htmlgman@google.com2009-06-181-10/+12
| | | | | | | | It worked for me :-) Review URL: http://codereview.chromium.org/126255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18674 0039d316-1c4b-4281-b951-d872f2087c98
* linux: NULL-initialize an array.evan@chromium.org2009-06-181-32/+34
| | | | | | | | | | A guess at fixing a crash seen by users. BUG=14483 Review URL: http://codereview.chromium.org/132001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18673 0039d316-1c4b-4281-b951-d872f2087c98
* Convert cld.gyp to Unix line endings.Patch by chase@chromium.orgsidchat@google.com2009-06-181-105/+105
| | | | | | | | BUG=none TEST=gclient runhooks --force completes successfully. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18672 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add menu item to url bar context menu to launch the search engine editor.mattm@chromium.org2009-06-182-0/+39
| | | | | | | | BUG=13326 Review URL: http://codereview.chromium.org/126307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18671 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the RenderWidgetHostViewGtk to be sized even if it isn't a popup.ben@chromium.org2009-06-181-0/+9
| | | | | | | | | | | browser/views/tab_contents/tab_contents_view_gtk.cc implements sizing in a similar fashion to windows - i.e. when the GtkWidget is resized, it tells the RenderViewHost that it was sized, which causes the RVH to resize the view. A check for if (parent_) in the Gtk RenderWidgetHostView impl was preventing this sizing from occurring. BUG=none TEST=none Review URL: http://codereview.chromium.org/125275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18670 0039d316-1c4b-4281-b951-d872f2087c98
* Add CHECKs to keep the socket counts in sync.willchan@chromium.org2009-06-172-3/+42
| | | | | | | | | A full chromebot run on 189.0 revealed them getting out of sync, so this should reveal where they get out of sync. BUG=http://crbug.com/14395. Review URL: http://codereview.chromium.org/125276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug in SimpleDataSourcehclam@chromium.org2009-06-171-0/+5
| | | | | | | | | SimpleDataSource might be stopped before StartTask is called, so handle this case. Review URL: http://codereview.chromium.org/125278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18668 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Don't try to special case webkit blur when we stop showing right ↵estade@chromium.org2009-06-171-5/+1
| | | | | | | | | | | | | click context menu. After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out. BUG=13554 TEST=right click spellcheck correction works in gmail Review URL: http://codereview.chromium.org/126301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18667 0039d316-1c4b-4281-b951-d872f2087c98
* Pass a gfk::NativeWindow instead of gfx::NativeView for TemplateURLFetcher.mattm@chromium.org2009-06-173-9/+5
| | | | | | | | | | Use cross-platform method to get the NativeWindow. BUG=13326 Review URL: http://codereview.chromium.org/126302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18666 0039d316-1c4b-4281-b951-d872f2087c98
* Bumping o3d_assets to rev 76 which contains a new screenshot for ↵vangelis@google.com2009-06-171-1/+1
| | | | | | | | texture-set-test Review URL: http://codereview.chromium.org/125281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18665 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 44757:44773.levin@chromium.org2009-06-173-4/+12
| | | | | | | | | | | | | | The code change here is to compensate for http://trac.webkit.org/changeset/44758 which changed how to get to theme(). BUG=None TEST=Possible (but unlikely) whitespace changes in the autocomplete popup menu. Review URL: http://codereview.chromium.org/128003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18664 0039d316-1c4b-4281-b951-d872f2087c98
* Add watchlist for the "net" module.darin@chromium.org2009-06-171-0/+4
| | | | | | | | | | BUG=none TEST=none R=nirnimesh Review URL: http://codereview.chromium.org/126212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18663 0039d316-1c4b-4281-b951-d872f2087c98
* Use media*.png for UI controls for <video> in test_shellhclam@chromium.org2009-06-171-0/+4
| | | | | | | | Loading media*.png for <video> and <audio> Review URL: http://codereview.chromium.org/125277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18662 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 22:12:12 +0000