| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Same as issue 12981 with but now with change to test_shell.vsprops. This change makes it actually compile on windows! It also makes it clear that test shell is looking in webkit directories for include files. Apparently this was already the case on linux and mac, but it is new for windows.
Review URL: http://codereview.chromium.org/13678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the test expecation lsits.
BUG=5181
Review URL: http://codereview.chromium.org/13227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13685
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
associated with any object.
Review URL: http://codereview.chromium.org/13676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Same story as before: double click shouldn't select trailing whitespace. Rebaseline of render tree only affects one digit.
update: found another test this affects. now rebaselining 2 tests.
Review URL: http://codereview.chromium.org/13680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- keeps creating importer processes
- the issue is the creation of the first run sentinel file needs to
happen before starting the new process.
BUG=1535947
Review URL: http://codereview.chromium.org/13312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
It appears that I messed up and checked in the wrong render-tree baseline.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
delegate says it can be minimized.
BUG=4083
TEST=none
Review URL: http://codereview.chromium.org/13683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the incorrect baseline for a failing Windows test.
Annotate a test that now fails on Windows and Linux.
Remove a FAIL for a test that we pass.
Review URL: http://codereview.chromium.org/13313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Delete the bogus Windows baseline (the test was already marked as failing).
Add a baseline for Linux since we get it right.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Delete the bogus Windows baseline and mark it as failing. Add a Linux baseline
since we get it right.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The baseline is wrong w.r.t. the comments in the file, but it matches how
every platform actually renders it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enough to trigger the Python timer watchdog. This doesn't happen much, but
can come up in the Purify layout test runs.
BUG=5318
TEST=none
Review URL: http://codereview.chromium.org/13306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Delete the bogus Windows baseline and mark the test as failing there.
Add a Linux baseline.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Mark as failing on Windows and delete the bogus baseline. Add a baseline for
Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This change reverts one file.
Review URL: http://codereview.chromium.org/13308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a test which WebKit currently can't handle to the tests_ignored.txt.
Delete a bogus Windows baseline which is clearly wrong and mark it as
failing on Windows. Add baseline for that test on Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
exist (e.g. if we have no pending/http/ directory).
TBR=ojan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/13310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Bug: 4793: about:credits LIBXSLT bad homepage link
TBR=laforge@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
versions and update tests_fixable.txt correspondingly.
BUG=4391
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/11016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds new image baselines for tests under css2.1/* where either the
fuzzy image matcher accepts the delta, or where the images have been
manually checked.
This also adds render-tree baselines for 8 tests which current fail
because of differences in the arrow or ying-yang glyph between Windows
and Linux. On Linux we are using Lucida Sans for the symbols and it's
not clear what Windows is using, but it's not a free font.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove dead/unnecessary resources/identifiers/code.
The trickiest bit of this to review are the browser.cc changes, where various commands are no longer initialized multiple times.
Review URL: http://codereview.chromium.org/13648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initialization code.
Review URL: http://codereview.chromium.org/13295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
These are the comments from the manual review of the pixel test diffs.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5134
TBR=nsylvain
Review URL: http://codereview.chromium.org/13303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RemovePendingRequest causes a request to be removed
from pending_requests_. Add the removing_pending_request_
member and some DCHECKS to catch that in action.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests all match on render-trees, but they are 1px off when
rendering a ":" in one of the headlines. Since the font metrics are
actually correct, all the glyphs are at the correct place and this just
appears to be a rounding difference from Win32 in FreeType.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of the SaveFileAsWithFilter function (after splitting
it out to a separate function).
Review URL: http://codereview.chromium.org/13637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These images are those where either the fuzzy matcher accepts the image
delta or where I have manually verified the difference.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/13631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
debugger URL.
BUG=5287
Review URL: http://codereview.chromium.org/13298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Image diff verified manually.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Image diff verified manually
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is the set of tests under LayoutTests/css1 where the render-tree matches
exactly and the fuzzy image matcher accepts the image diff.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=ojan
Review URL: http://codereview.chromium.org/13675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
native key code.
Also match windows behavior for setting m_text field of platform event equal to key_code.
update: fixes at least 7 layout tests.
Review URL: http://codereview.chromium.org/12981
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetWin for the popup.
I observed this in Purify and confirmed in the debugger
that the destructor for WidgetWin was never called.
Review URL: http://codereview.chromium.org/13672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cache-control:no-store,
we return the cached entry to the requestor but doom the entry so it's not used
in the future.
B=b/1363355
R=darin
TEST=unit test.
Review URL: http://codereview.chromium.org/13273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
probably be ParseQuery, but I couldn't bring myself to another
ParseQuery method. I'm going to need this for bookmark queries.
BUG=4065
TEST=none
Review URL: http://codereview.chromium.org/13296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These baselines are wrong, but correspond to http://trac.webkit.org/changeset/36855, where CSS variable support was turned off upstream.
Review URL: http://codereview.chromium.org/13669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Three Windows baselines are clearly wrong (involving red boxes with "fail"
written in them etc): remove them. Linux now passes two of the tests falling
back to Mac baselines. However, one of the tests involves text, which we don't
match against the Mac, so we rebaseline that test.
Review URL: http://codereview.chromium.org/13294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Double clicking a word shouldn't select the whitespace following it.
Review URL: http://codereview.chromium.org/13265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6601 0039d316-1c4b-4281-b951-d872f2087c98
|