summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Disable running layout tests worker-constructor.html and ↵jianli@chromium.org2009-07-161-3/+2
| | | | | | | | | | | worker-redirect.html in UI test frameworker in preparation to checkin the fix for WebKit bug 25151 (https://bugs.webkit.org/show_bug.cgi?id=25151). I will reenable the tests once the corresponding V8 change is landed. BUG=none TEST=none Review URL: http://codereview.chromium.org/155544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20827 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test shadow-translucent-fill.html started failing with merge.agl@chromium.org2009-07-161-1/+2
| | | | | | | BUG=16878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20826 0039d316-1c4b-4281-b951-d872f2087c98
* Fix web contents drag corner case.estade@chromium.org2009-07-161-1/+5
| | | | | | | | | | | We heuristically use the last mouse down event the renderer got as the event that 'started' the drag, which is not entirely accurate. Since the context menu grabs input, we were in a situation where the last mouse down was a right click, so it wanted the drag to end by releasing the right mouse button. BUG=16793 TEST=see bug Review URL: http://codereview.chromium.org/155604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20825 0039d316-1c4b-4281-b951-d872f2087c98
* Allow 6 channel to pass thru to driver.fbarchard@chromium.org2009-07-161-2/+11
| | | | | | Review URL: http://codereview.chromium.org/155525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20823 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new cov-analyze options recommended by Coverity.wtc@chromium.org2009-07-161-3/+11
| | | | | | | | | | | | | Basically we remove --enable-single-virtual and replace --all by just the checkers useful to us. This should speed up the analysis. R=huanr BUG=none TEST=none Review URL: http://codereview.chromium.org/155589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20822 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WritableBuffer interface for more useful ptr management.kylep@chromium.org2009-07-1610-70/+95
| | | | | | | | BUG=16011 TEST=DataBuffer unittest Review URL: http://codereview.chromium.org/149573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20821 0039d316-1c4b-4281-b951-d872f2087c98
* Disable LoadState net unittest: it's flakeyagl@chromium.org2009-07-161-1/+1
| | | | | | | BUG=16881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20820 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo pointed out by wtc after I checked in.jshin@chromium.org2009-07-161-1/+1
| | | | | | | | | | | BUG=NONE TEST=NONE TBR=wtc Review URL: http://codereview.chromium.org/149726 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20818 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/155575 for atwilson.dimich@google.com2009-07-151-10/+2
| | | | | | | | BUG=15880 TEST=none Review URL: http://codereview.chromium.org/149722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20817 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect logic in WriteCPUInformation().thestig@chromium.org2009-07-151-3/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20816 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS 45936:45958.japhet@chromium.org2009-07-152-1/+7
| | | | | | | | | | BUG=none TEST=green build TBR=ericroman Review URL: http://codereview.chromium.org/149720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20815 0039d316-1c4b-4281-b951-d872f2087c98
* quick fix for bad checkingman@google.com2009-07-151-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20813 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test rem-dynamic-scaling is crashing on Windows.agl@chromium.org2009-07-151-1/+1
| | | | | | | BUG=16815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20810 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-159-51/+106
| | | | | | | | | | | | | | Relanding with fixes for unit tests. Run through trybot this time... http://crbug.com/13967 Original Review URL: http://codereview.chromium.org/155588 TBR=estade Review URL: http://codereview.chromium.org/155601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20809 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test progress-event-total.html started failing with merge.agl@chromium.org2009-07-151-2/+1
| | | | | | | | | Moving from flaking to failing. BUG=16850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20808 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel icon load requests when we are getting shutdown.estade@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | | Hopefully this will fix the download test flakiness. I was able to reproduce the crash manually by just mass-clicking on the same download link many times (thanks to DotA for improving my APM). With this patch I am no longer able to repro. BUG=14746,14745,15244,15416 TEST=download tests stop flaking out Review URL: http://codereview.chromium.org/149712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20807 0039d316-1c4b-4281-b951-d872f2087c98
* More docs changes.gman@google.com2009-07-1511-56/+307
| | | | | | | | | | | | | | | *) Made enums show up *) Right justified return type *) moved class name to right column in summary area *) pretty print code examples *) changed [inherited] to [inhertied from <class>] *) Changed name in details area to Class.Name or Namespace.Name *) Add subtypes so ParticleEmitter shows up in docs for o3djs.particle *) Grabbed new nixysa so properties show up Review URL: http://codereview.chromium.org/155600 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20806 0039d316-1c4b-4281-b951-d872f2087c98
* test_shell had hard-coded paths to the old LayoutTests locationdpranke@google.com2009-07-151-3/+2
| | | | | | | | | | | | | | test_shell had a javascript function that transformed file:/// URLs to point to the top of the old LayoutTests tree (src/webkit/data/LayoutTests). I have modified it to point to the new one (src/third_party/WebKit/LayoutTests). BUG=https://crbug.com/16865 R=victorw TEST=LayoutTests/fast/loader/local-css-from-local-html.html Review URL: http://codereview.chromium.org/149713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20805 0039d316-1c4b-4281-b951-d872f2087c98
* Removed extraneous call to the now depreacted WebCore::parseURL().japhet@chromium.org2009-07-151-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20804 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux crash death signal message constant sized.thestig@chromium.org2009-07-153-31/+48
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20803 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK Themes: Tint throbbers like we tint all other buttons in the ↵erg@google.com2009-07-158-79/+42
| | | | | | | | | | | | interface." This reverts commit 3dfa509662e99282b5212490bfe19b32da357741 (r20799). TBR=estade Review URL: http://codereview.chromium.org/155598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20802 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move hardcoded paths to GYP variables.agl@chromium.org2009-07-155-11/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the hardcoded paths for the sandbox binary location and the chrome binary location for the sandbox. Instead, you can now set GYP variables for these things. Indeed, you have to set a GYP variable in order to use the sandbox now. GYP variables can be set on the command line, if you run gyp.py directly, with -D key=value. Or you can export GYP_DEFINES="key=value key2=value2". Now, in order to use the sandbox you should set: linux_sandbox_path=/opt/google/chrome/chrome-sandbox linux_sandbox_chrome_path=/opt/google/chrome/chrome (changing the paths as needed, of course). See the comments in build/common.gypi For development see http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment Because developers need to setup a special sandbox binary. http://codereview.chromium.org/149689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20801 0039d316-1c4b-4281-b951-d872f2087c98
* Fix createCheckerMaterial to use same colors as it original used.gman@google.com2009-07-153-6/+6
| | | | | | | | | and increase timeout for Google IO step14ex. Also make old-school-shadows use createCheckerMaterial Review URL: http://codereview.chromium.org/155554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20800 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-158-42/+79
| | | | | | | | http://crbug.com/13967 Review URL: http://codereview.chromium.org/155588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20799 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: evan@chromium.orgmattm@chromium.org2009-07-151-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20798 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in "web content" section in "user data" options.mattm@chromium.org2009-07-153-5/+47
| | | | | | | | | BUG=11507 TEST=open options -> user data. Click the configure fonts button. Font configuration dialog should appear. Review URL: http://codereview.chromium.org/157002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20797 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ResolveMetricsReportingEnabled logic to OptionsUtil, make gtk ↵mattm@chromium.org2009-07-154-29/+90
| | | | | | | | | | | | | | | options use it. Only show the reporting checkbox in Google Chrome builds. Show the restart required message box when changing the reporting setting. BUG=11507 TEST=on Chromium build, option should not show up. On Google Chrome build in should show up, and enable both crash reporting and metrics settings. Review URL: http://codereview.chromium.org/149665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20796 0039d316-1c4b-4281-b951-d872f2087c98
* Refactorings surrounding HostResolver:ericroman@google.com2009-07-1538-1071/+1503
| | | | | | | | | | | | | | | | | | | | | | (1) Extract HostResolver to an interface. The existing concrete implementation is now named HostResolverImpl. This makes it possible to create mocks with more complex behavior (i.e. choose via rules if response will be sync vs async). (2) Transform HostMapper into HostResolverProc. Conceptually HostResolverProc maps a hostname to a socket address, whereas HostMapper mapped a hostname to another hostname (so you were still at the mercy of the system's host resolver). With HostResolverProc you can specify the exact AddressList, making it possible to run tests requiring IPv6 socketaddrs on systems (like WinXP) that don't actually support it. (3) Add a MockHostResolver implementation of HostResolver. This replaces the [ScopedHostMapper + RuleBasedHostMapper + HostResolver] combo. It is less clunky and a bit more expressive. BUG=http://crbug.com/16452 R=willchan TEST=existing Review URL: http://codereview.chromium.org/149511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20795 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the unit-tests pass with toolkit_views on Linux.jcampan@chromium.org2009-07-153-46/+77
| | | | | | | | | | It also make them run the view tests. BUG=None TEST=Run the unit-tests on Linux with toolkit_views=1 Review URL: http://codereview.chromium.org/149649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20794 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the WebKit.gyp file's exclusions of DOM Storage stuff.jorlow@chromium.org2009-07-151-1/+3
| | | | | | | | | | | This adds one exclusion so that I can fix the file list upstream. Then I'll get rid of a bunch of unnecessary exceptions in this file. TEST=none BUG=16254 Review URL: http://codereview.chromium.org/149699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20793 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a typo introduced in r20778. The logic condition is reversed.jhawkins@chromium.org2009-07-151-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20792 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Remove two calls to Update that are unnecessary. When we layout the ↵jhawkins@chromium.org2009-07-151-2/+0
| | | | | | | | | | dragged tab, gtk will emit an expose-event signal for us if the widget changes size. BUG=none TEST=Drag a tab out of the browser. The tab should be sized and shown properly. Review URL: http://codereview.chromium.org/149703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20791 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline to end of download_manager.ccglen@chromium.org2009-07-151-1/+2
| | | | | | | | | BUG=none TEST=none TBR=sverrir git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20790 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Webkit DEPS 45916:45936.japhet@chromium.org2009-07-152-1/+5
| | | | | | | | | BUG=none TEST=green builds Review URL: http://codereview.chromium.org/155587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20789 0039d316-1c4b-4281-b951-d872f2087c98
* Make our HSL shifting match Photoshop's.glen@chromium.org2009-07-155-76/+52
| | | | | | | | | | Also clean up a bunch of PMColor code - skia_utils should operate on SkColors and PMColors should only ever be used by SkBitmaps and ImageOperations. BUG=16687 Review URL: http://codereview.chromium.org/149663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20788 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto-open items from the download shelf on auto-open. This has the ↵glen@chromium.org2009-07-153-23/+34
| | | | | | | | | | | | | delicious side-effect of auto-closing the download shelf after extensions are downloaded and auto installed. While we're here, also add proper colors to the download buttons. BUG=16232 TEST=Install a theme from the web, make sure the download shelf isn't shown after installation. Do the same for a filetype that is set to auto-open. Make sure the shelf stays open for other filetypes. Review URL: http://codereview.chromium.org/149580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20787 0039d316-1c4b-4281-b951-d872f2087c98
* Add more browser tests for Task Manager.phajdan.jr@chromium.org2009-07-1512-43/+162
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/12127 Review URL: http://codereview.chromium.org/155433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20786 0039d316-1c4b-4281-b951-d872f2087c98
* Make more things clickable in the bookmark bar menus:estade@chromium.org2009-07-151-4/+16
| | | | | | | | | | | | | | - folder within a folder - "empty" menu item Note that it can be hard to click on a folder within a folder since hovering over the folder pops up a submenu that grabs focus, so you end up needing to right click twice. It's a little odd but the hackery required to fix it doesn't seem worth it. BUG=15886 TEST=right click on an empty menu item Review URL: http://codereview.chromium.org/155586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20785 0039d316-1c4b-4281-b951-d872f2087c98
* newer gyp (support >1 gyp file via env var)thomasvl@chromium.org2009-07-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149698 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20784 0039d316-1c4b-4281-b951-d872f2087c98
* Retrying this patch. This was already reviewed by mpcomplete and thefinnur@chromium.org2009-07-1520-107/+212
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | only change is a fix for the UI test that broke and a small change to event_bindings.cc (reviewed in-person). ExtensionFunctionDispatcher now notifies ExtensionProcessManager of renderviews created, which in turn notifies the renderer of page actions that it knows about. Remove generic event "page-action-executed" in favor of page action specific event (sent as extension_id/page_action_id). In the bindings, we now setup events for each page action we know about so we can register for specific events, and not receive broadcast events from all page actions. To setup these events I added a GetCurrentPageActions() to extension_process_bindings.cc and a helper function GetCurrentExtensionId(). And, finally, I simplified the page action background page by removing the check to see if we are already subscribed to the feed (since we now support multiple feed readers, it doesn't make sense anymore to always check Google Reader). This check might make a comeback later in a different form. TBR=mpcomplete BUG=13936 TEST=The RSS sample extension should work as before. Review URL: http://codereview.chromium.org/149683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20782 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Only show completed downloads.arv@google.com2009-07-151-0/+5
| | | | | | | | | | | | | BUG=16719 TEST=Download a big file (http://www.thinkbroadband.com/download.html has good files for testing downloads) and make sure that that cancelled and in progress downloads are not shown on the new tab page. Review URL: http://codereview.chromium.org/149685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20780 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use ID generation logic always. Only reassign IDsmunjal@chromium.org2009-07-153-195/+94
| | | | | | | | | | | | | | when checksums differ or if IDs are missing and do that simply by assigning the next maximum id. Add a unit test. BUG=16357 TEST=NONE Review URL: http://codereview.chromium.org/155560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20779 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when positioning the tab strip drop arrow.jhawkins@chromium.org2009-07-153-1/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149695 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in ShownSectionsHandler::HandleGetShownSections andtim@chromium.org2009-07-152-2/+3
| | | | | | | | | | | potential leak of default_favicon_ in DOMUIFavIconSource. BUG=16818 TEST=valgrind ui_tests Review URL: http://codereview.chromium.org/155579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20777 0039d316-1c4b-4281-b951-d872f2087c98
* Adding handling of target and origin in external tab's postMessage + a unit ↵tommi@chromium.org2009-07-153-6/+94
| | | | | | | | | | | test. TEST=run ExternalTabPostMessageTarget test. BUG=none Review URL: http://codereview.chromium.org/155516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20775 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Inactive title bars should follow the bg insensitive color.erg@google.com2009-07-151-6/+13
| | | | | | | | | | This solves the inactive skyline color often being laughably bad. It does show that we may want to draw the line between the skyline and toolbar for best visual effect, though... Review URL: http://codereview.chromium.org/149693 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20774 0039d316-1c4b-4281-b951-d872f2087c98
* Mac pop-up window happier-ness.jrg@chromium.org2009-07-157-2/+78
| | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/15727, http://crbug.com/16063, http://crbug.com/16329 TEST=A few things. Bookmark bar test (16063): - open bookmark bar, then open popup. Popup should not have bmb. - close bookmark bar, then open popup. Popup should not have bmb. - In main window, toggle bmb a few times. Popup should not change. Tab at bottom bug (16329): - Open 'details' popup in gmail (next to 'last acct activity') - make sure no tab strip at the bottom of the window General (15727): - Open a popup. Make sure no toolbar (back/fwd buttons et al) Review URL: http://codereview.chromium.org/155444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20773 0039d316-1c4b-4281-b951-d872f2087c98
* Fix auto-opening file types not auto-opening.avi@chromium.org2009-07-151-3/+6
| | | | | | | | | BUG=http://crbug.com/16085 TEST=As described in bug Review URL: http://codereview.chromium.org/149692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20772 0039d316-1c4b-4281-b951-d872f2087c98
* When work shows up and no delegate is available to dispatch it to, arrange tomark@chromium.org2009-07-152-13/+37
| | | | | | | | | | | | dispatch to the delegate when one becomes available. BUG=16732 TEST=rm ~/Library/Preferences/com.google.Chrome.plist, launch official-branding Google Chrome, dismiss first-run dialog. The application should be usable. Review URL: http://codereview.chromium.org/149687 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20770 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove guard on FocusLocation() in autocomplete field.shess@chromium.org2009-07-152-12/+7
| | | | | | | | | | | | | | | | | Reapplies http://codereview.chromium.org/149492 . That version was accidentally calling this code as part of the class implementation, which caused the code to receive the "done editing" notification, which caused the code to drop the popup... This version stops using FocusLocation() internally, instead messaging field_ directly. http://crbug.com/12246 TEST=Type some stuff in address bar. Popup should popup with suggestions. With cursor still in bar, Command-l should select all. Review URL: http://codereview.chromium.org/155537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20769 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 16:10:14 +0000