| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
code. This is the same as the last change except I renamed
class MessageBox to class MessageBoxFlags to avoid conflicting
with the same name in windows.h.
Review URL: http://codereview.chromium.org/87065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes
The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).
The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605
BUG=6125
BUG=8686
Review URL: http://codereview.chromium.org/86003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular.
Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me.
BUG=10054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/87066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove InsertText() from webview.
Review URL: http://codereview.chromium.org/87002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
time was in milliseconds.
TBR=hclam
Review URL: http://codereview.chromium.org/90009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a temporary solution. We need to find a more sustainable way to
do this.
Review URL: http://codereview.chromium.org/87018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
working. Ugly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, add some more tests to cover this case.
Review URL: http://codereview.chromium.org/87048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r14146.
MessageBox is redefined to MessageBoxW by windows. I need to rename the
class.
Review URL: http://codereview.chromium.org/87064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
code.
This is mostly a find & replace in our code to use the new location
of the enum.
I also deleted some GetDialogButtons methods in child classes
because they were identical to the parent version in DialogDelegate.
This will allow more code to be enabled on linux/mac in the
automation provider.
Review URL: http://codereview.chromium.org/88008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/89008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the last change, but forgot.
Review URL: http://codereview.chromium.org/69042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/87035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10760
TBR=erikkay
Review URL: http://codereview.chromium.org/88059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
zip file packaging.
BUG=10828
Review URL: http://codereview.chromium.org/87055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
wait on UI thread. Instead of using sync messages, the plugin hwnd is initially parented to the RenderWidgetHost's HWND. It's then lazily reparented to an intermediate HWND on the UI thread when it comes time to move it.
BUG=10711
TEST=added regression tests, but testers please confirm plugins on top video sites are placed correctly.
Review URL: http://codereview.chromium.org/67285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/88031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the process terminates, and retrieve what the process printed to the standard output.
That util function is needed for the new in-process test framework.
It is Windows only for now.
BUG=None
TEST=Covered by new unit test.
Review URL: http://codereview.chromium.org/87008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the http scheme, this allows Chromium to be set as a default browser for the Mac.
Review URL: http://codereview.chromium.org/87043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10766
Review URL: http://codereview.chromium.org/88055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically.
BUG=10739
Review URL: http://codereview.chromium.org/88044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
blind fix but it seems like it should work.
Instead of adjusting the window rect by the change in work rect for maximized windows, just size to (work area inflated by SM_CXSIZEFRAME), which is what a maximized window normally does. This makes the new window size independent of the previous window size, which could prevent problems if during a chain of resizes Windows doesn't like one of the desired window sizes and modifies it.
BUG=8873
Review URL: http://codereview.chromium.org/88001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
with this checkin.
Review URL: http://codereview.chromium.org/79085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/88050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also clean up some accelerators.
BUG=10803
Review URL: http://codereview.chromium.org/90008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
displayed correctly in Omnibox
NavSuggest drop-down list.
The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI.
BUG=2674
Review URL: http://codereview.chromium.org/79005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in guchar from gtk.h) and moving it from base/gfx to base.
Review URL: http://codereview.chromium.org/87016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks.
Review URL: http://codereview.chromium.org/88005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the gtk mouse events. Fixes a crash where the hover index would become stale before a leave-notify event.
BUG=10776
Review URL: http://codereview.chromium.org/88037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Turns out it was the test code that was flaky and not a threading bug in our actual code. Under heavy load it was possible for a thread holding onto a reference to get time sliced long enough that the unit test continued executing until it asserted that the object was deleted when in fact it was not.
BUG=10653
Review URL: http://codereview.chromium.org/88010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rate is != 1.0.
This is a non-optimal, but easy to implement interem solution. Correct fix is to actually stop audio
playback, but that requires refactoring of components.
Addede TODO's() where refactor needs to occur.
Review URL: http://codereview.chromium.org/88014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/87014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=10475
Review URL: http://codereview.chromium.org/87033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
response header.
Log an INFO message whenever we receive an auth challenge.
R=eroman
BUG=8771
Review URL: http://codereview.chromium.org/67117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=10475
Review URL: http://codereview.chromium.org/88034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to be deleted.
BUG=7178
Review URL: http://codereview.chromium.org/82003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates DOMWrapperToNodeHelper to preform the actual work (in the .cpp) and DOMWrapperToNode just does the cast.
This function has a lot of callers from the generated bindings, and I am skeptical an extra call instruction will hurt.
25740168 /tmp/chrome.after
25902672 /tmp/chrome.before
Review URL: http://codereview.chromium.org/88029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=10760
Review URL: http://codereview.chromium.org/88030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This increases our score on the DOM Perf benchmarks by about 10%
Review URL: http://codereview.chromium.org/79055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14103 0039d316-1c4b-4281-b951-d872f2087c98
|