summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add JsonSchema-based validation for the tab APIs.aa@chromium.org2009-04-1420-227/+1350
| | | | | | | | | Arv: can you take json_schema.js and json_schema_test.js. Matt: you take the rest. Review URL: http://codereview.chromium.org/66006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13720 0039d316-1c4b-4281-b951-d872f2087c98
* Convert instances of WideToUTF8(l10n_util::GetString( totc@google.com2009-04-146-30/+28
| | | | | | | | | | | | l10n_util::GetStringUTF8 in the gtk code. This saves us some string conversions. BUG=9688 Review URL: http://codereview.chromium.org/73056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13719 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up icon loader/manager in preparation for porting.estade@chromium.org2009-04-149-130/+68
| | | | | | | | Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum. Review URL: http://codereview.chromium.org/73007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13718 0039d316-1c4b-4281-b951-d872f2087c98
* Fix strict aliasing warning in disk_cache_perftest.thestig@chromium.org2009-04-141-4/+2
| | | | | | Review URL: http://codereview.chromium.org/67144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13717 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome_proces_util for linux and enable download ui test.estade@chromium.org2009-04-1421-109/+234
| | | | | | | | | | To get the PID from the socket, we use lsof (fuser doesn't work with unix sockets apparently). The download shelf, save page, and browser ui tests now pass. Review URL: http://codereview.chromium.org/66071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ExtensionContentScriptInject unit test.aa@chromium.org2009-04-143-64/+0
| | | | | | | | This was somehow causing crashes in ExtensionViewTest. Review URL: http://codereview.chromium.org/68012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13715 0039d316-1c4b-4281-b951-d872f2087c98
* Implement context menu handling for the Linux tab strip.jhawkins@chromium.org2009-04-146-9/+152
| | | | | | Review URL: http://codereview.chromium.org/73053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13714 0039d316-1c4b-4281-b951-d872f2087c98
* Second part of the low level audio for Maccpu@chromium.org2009-04-146-68/+147
| | | | | | | | | | | -Fixed leaks (audiomanager singleton, audiostream) -Moved simple_sources to be common for all platforms -Added trivial check for sinesource -Added some logic on the audio callback, not used yet Review URL: http://codereview.chromium.org/67058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13713 0039d316-1c4b-4281-b951-d872f2087c98
* Add non-fatal errors to parsing the expectations file and make lacking a bug ↵ojan@google.com2009-04-142-44/+77
| | | | | | | | | | | | id and the path not existing non-fatal. There are too many false positives in those cases to stop webkit tests from running for those errors. Also add a bit more error checking that the modifiers for a test are valid. Review URL: http://codereview.chromium.org/73049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13712 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line flag that removes randomness from javascript functions, to ↵ace@google.com2009-04-144-1/+11
| | | | | | | | be used during reliability_tests. Review URL: http://codereview.chromium.org/63143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13711 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few more flaky tests. TBR.ojan@google.com2009-04-141-3/+8
| | | | | | Review URL: http://codereview.chromium.org/69008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the usage of GetLastActiveBrowserWindowhuanr@chromium.org2009-04-144-26/+20
| | | | | | | | | | as the function is flakey. BUG=10501 Review URL: http://codereview.chromium.org/67139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13709 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of webkit merge 42403:42440.ericroman@google.com2009-04-149-21/+65
| | | | | | Review URL: http://codereview.chromium.org/73009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13708 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TestTabContents. This makes BrowserWithTestWindow use thebrettw@chromium.org2009-04-1426-674/+172
| | | | | | | | | | | | | | | TestRenderViewHost instead. There are some changes to browser_commands_unittest to support this. Now that we're using proper TabContentes, I had to stub out a FocusManager call since there isn't a proper view hierarchy created. Remove TabContents collection and switching from the NavigationController. I tried to keep the same interface to the NavigationController since I tried that in a previous patch and the change blew up. Remove the TabContents factory. Callers now create a WebContents directly. Review URL: http://codereview.chromium.org/67113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13707 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to match last few runs, mainly marking some flakiness.pam@chromium.org2009-04-141-6/+5
| | | | | | | | | | Also remove some tests that have passed consistently in the last ~30 runs. BUG=none TEST=covered by buildbot Review URL: http://codereview.chromium.org/73050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13706 0039d316-1c4b-4281-b951-d872f2087c98
* Use Michael Moss's nice user agent code on Linux.dkegel@google.com2009-04-141-25/+45
| | | | | | | | | Also imitate some of Firefox's behavior with respect to 32-bit-on-64 bit apps. Review URL: http://codereview.chromium.org/67115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove two lines that were from a different experiment and got checked inpinkerton@chromium.org2009-04-141-3/+0
| | | | | | accidentally. Those lines only have an effect for non-textured windows. Patch from nicothakis@googlemail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13704 0039d316-1c4b-4281-b951-d872f2087c98
* Give each HistoryService instance it's own backend thread.tim@chromium.org2009-04-147-25/+42
| | | | | | | | | | | | | | | | | I had originally planned to push history_thread up to BrowserProcess, but was scared away by the comment in ~Profile that talks about HistoryService calling back into the bookmark bar model, and that it depended on join()ing at that particular time to ensure this doesn't happen after the bookmark bar model has been reset. I didn't use scoped_ptr for the thread because it makes the little dance in CleanUp awkward. TEST=any existing test that exersizes the history service. I added a ProfileManager test that would fail without this change. Review URL: http://codereview.chromium.org/73012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13703 0039d316-1c4b-4281-b951-d872f2087c98
* Delete more unused functions in nss_memio.c.thestig@chromium.org2009-04-141-32/+0
| | | | | | Review URL: http://codereview.chromium.org/67142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13702 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OnBeforePossibleChange() and OnAfterPossibleChange() to fix delete ↵shess@chromium.org2009-04-142-23/+67
| | | | | | | | | | in Mac Omnibox. BUG=10030 Review URL: http://codereview.chromium.org/67136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13700 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extra zoom menu items.thestig@chromium.org2009-04-142-20/+19
| | | | | | Review URL: http://codereview.chromium.org/73023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13699 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for the Find box forwarding scroll messages to the page when it shouldn't.finnur@chromium.org2009-04-143-23/+35
| | | | | | | | TEST=Open Find on a page with scrollbars, type in 'nomatch', scroll to the middle of the page, set the cursor at the end of the Find text field and add '!', '(' and ')' to the search string. Make sure the page doesn't scroll. BUG=10509 Review URL: http://codereview.chromium.org/67135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13696 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-1416-81/+628
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp text size in js message box dialogscpu@google.com2009-04-141-3/+13
| | | | | | | | | | | | | | - Long text peg cpu at 100% for a couple of minutes for the UI thread - Now with extra protection for OnUnload() BUG=8863 TEST=existing ui tests suffice. Review URL: http://codereview.chromium.org/73043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13693 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ResourceBundle::GetLocalizedString to return a string16 insteadtc@google.com2009-04-145-19/+19
| | | | | | | | | | | | of a wstring. This saves us a conversion to wstring on linux when getting utf8 strings. BUG=9911 Review URL: http://codereview.chromium.org/67134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13692 0039d316-1c4b-4281-b951-d872f2087c98
* grit: cut down on chattiness.evan@chromium.org2009-04-142-5/+10
| | | | | | | | | - We don't need to print the copyright every time we run. - Don't print empty lines when there are no warnings. Review URL: http://codereview.chromium.org/67085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13691 0039d316-1c4b-4281-b951-d872f2087c98
* Link to DiamondX plugin.evan@chromium.org2009-04-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/67105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13690 0039d316-1c4b-4281-b951-d872f2087c98
* Update playback extension so that javascript functions return consistent ↵ace@google.com2009-04-141-2/+6
| | | | | | | | (but not constant) values in an attempt to preserve the functionality but improve compatibility of the extension. Review URL: http://codereview.chromium.org/62165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13688 0039d316-1c4b-4281-b951-d872f2087c98
* Add routing_id to the ipc debugging log output.willchan@chromium.org2009-04-142-1/+6
| | | | | | Review URL: http://codereview.chromium.org/66051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13687 0039d316-1c4b-4281-b951-d872f2087c98
* The history tests relies on being about to reset a profile, which means we needthomasvl@chromium.org2009-04-142-0/+18
| | | | | | | | | to load a bunch of resources. For the Mac, this means we build the app first and the unittest looks into the app bundle to pull resources. Review URL: http://codereview.chromium.org/73046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13686 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where scrolling up would draw over the horizontalavi@google.com2009-04-141-1/+10
| | | | | | | | | | | scrollbar on mac. Patch by rohitrao. http://codereview.chromium.org/73042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13685 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Enable the code that sets the max size automatically.rvargas@google.com2009-04-143-10/+69
| | | | | | | | (still limiting the ceiling). Review URL: http://codereview.chromium.org/68007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13684 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reserve space for an auto-hide taskbar that's not always-on-top. ↵pkasting@chromium.org2009-04-144-12/+13
| | | | | | | | | Windows native behavior is to cover these. BUG=9976 Review URL: http://codereview.chromium.org/66055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13683 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't drop invalid scroll requests.agl@chromium.org2009-04-141-20/+18
| | | | | | | | | | | | When performing an anchor jump, WebKit will send a scroll request with an invalid scroll magnitude (greater than the size of the window). We must still process the paint request attached however. BUG=10494 http://codereview.chromium.org/67132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems correctly invalidating/repainting when our updated paint rect ↵pkasting@chromium.org2009-04-147-20/+62
| | | | | | | | for a large area came back while we were repainting a smaller area. Review URL: http://codereview.chromium.org/66013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13681 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notifications.paulg@google.com2009-04-143-27/+0
| | | | | | | | | The old download tab page was the only consumer of these notifications, so they're no longer necessary. Review URL: http://codereview.chromium.org/69003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when the browser opens a popup window in Linux.jhawkins@chromium.org2009-04-141-0/+5
| | | | | | Review URL: http://codereview.chromium.org/73045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13679 0039d316-1c4b-4281-b951-d872f2087c98
* Get the first set of page_cycler_tests working on Mac. This means: MozFile,nirnimesh@chromium.org2009-04-142-30/+41
| | | | | | | | | | | | | DomFile and DhtmlFile corpus sets. Not enabling Intl1File, Intl2File yet coz they crash Chromium. Not enabling PageCyclerReferenceTest yet coz we don't yet have a reference build. Review URL: http://codereview.chromium.org/67127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13677 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a gcc warning about uninitialized variables.tc@google.com2009-04-141-2/+2
| | | | | | | | | | app_modal_dialog_gtk.cc:46:warning: ‘message_type’ may be used uninitialized in this function app_modal_dialog_gtk.cc:46:warning: ‘buttons’ may be used uninitialized in this function Review URL: http://codereview.chromium.org/73040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13676 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for status bubble mac.pinkerton@chromium.org2009-04-143-0/+112
| | | | | | Review URL: http://codereview.chromium.org/67131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13674 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/68009dimich@google.com2009-04-141-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13673 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that the WinSock DLL supports version 2.2.wtc@chromium.org2009-04-141-9/+14
| | | | | | | R=cpu Review URL: http://codereview.chromium.org/67111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13672 0039d316-1c4b-4281-b951-d872f2087c98
* Color/emphasize correct portions of view-source: URLs. Original patch by ↵pkasting@chromium.org2009-04-144-8/+104
| | | | | | | | Shinichiro Hamaji (see http://codereview.chromium.org/62094/show ), r=me. BUG=2349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13671 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status bubble shadow being opaque, which made the bubble appear to be ↵pkasting@chromium.org2009-04-143-43/+38
| | | | | | | | | off by one pixel. This reverts Brett's fix for issue 8651 and instead fixes that issue by ensuring the text bounding box does not overlap the status bubble shadow. This also makes kShadowThickness (renamed for consistency with the browser frame) a class-scoped constant so the browser view can access it, eliminating a magic number. BUG=9928 Review URL: http://codereview.chromium.org/67059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13670 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo. Original patch by Shinichiro Hamaji (see ↵pkasting@chromium.org2009-04-142-10/+10
| | | | | | http://codereview.chromium.org/67123 ), r=me. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13669 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-1410-189/+526
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore the value of GetLastError() when [D]LOG/[D]CHECK etc on ↵tommi@google.com2009-04-142-0/+28
| | | | | | | | | | Windows. Also for log levels higher than INFO, the value of GLE is tagged onto the log message. Review URL: http://codereview.chromium.org/73010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13667 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the internal GetStringF to use string16. This saves atc@google.com2009-04-144-82/+83
| | | | | | | | | | | | | | | conversion from string16 to wstring on the linux side when calling GetStringFUTF8 methods. It actually adds extra conversions when calling GetStringF, but we're going to get rid of all those, right? BUG=9911 Review URL: http://codereview.chromium.org/67112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13666 0039d316-1c4b-4281-b951-d872f2087c98
* Rendering dependencies inherited from version.rules less relative.robertshield@google.com2009-04-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/73016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13665 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the new Omnibox resources to follow convention and use underscores. ↵deanm@chromium.org2009-04-146-0/+5
| | | | | | | | | Add these resources to theme_resources.grd. Review URL: http://codereview.chromium.org/73030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13664 0039d316-1c4b-4281-b951-d872f2087c98