summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* clean up line endingphajdan.jr@chromium.org2009-01-051-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7548 0039d316-1c4b-4281-b951-d872f2087c98
* Update some comments/nits following r7486.ericroman@google.com2009-01-055-20/+19
| | | | | | Review URL: http://codereview.chromium.org/17047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7547 0039d316-1c4b-4281-b951-d872f2087c98
* Windows SCons build fixes.phajdan.jr@chromium.org2009-01-053-1/+9
| | | | | | Review URL: http://codereview.chromium.org/17054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7546 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for http://codereview.chromium.org/16411.sgjesse@chromium.org2009-01-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/17055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7544 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed console messages for messages which was not added through the ↵sgjesse@chromium.org2009-01-051-1/+1
| | | | | | | | console.xxx calls. Review URL: http://codereview.chromium.org/16411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7543 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that constructor functions are created in the context of theager@google.com2009-01-053-15/+20
| | | | | | | | | | | | corresponding DOMWindow. This is important for instance for XMLHttpRequests, so that they are created with the right document. If the XMLHttpRequest function is created in the context of the caller, URI resolution will be broken for the request. Review URL: http://codereview.chromium.org/17053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a bindings stats counter.deanm@chromium.org2009-01-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/17051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix part of linking problems in Windows SCons build.phajdan.jr@chromium.org2009-01-031-0/+4
| | | | | | Review URL: http://codereview.chromium.org/17049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7540 0039d316-1c4b-4281-b951-d872f2087c98
* g++ 4.3.x doesn't seem to like forward declarationsphajdan.jr@chromium.org2009-01-031-1/+3
| | | | | | | | | | with namespace::classname so declare the forward declaration inside the appropriate namespace. Review URL: http://codereview.chromium.org/16508 Patch from Craig Schlenter. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7539 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7537. DirectoryWatcherTest.SubDir was passing on my XP box, but ↵phajdan.jr@chromium.org2009-01-032-23/+15
| | | | | | | | | fails on the buildbot. TBR=maruel Review URL: http://codereview.chromium.org/17048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7538 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable DirectoryWatcherTest.SubDir on Vistaphajdan.jr@chromium.org2009-01-032-15/+23
| | | | | | | | BUG=5072 Review URL: http://codereview.chromium.org/17046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7537 0039d316-1c4b-4281-b951-d872f2087c98
* Try to consistently use arraysize() with strlcpy().deanm@chromium.org2009-01-024-15/+18
| | | | | | | | | For a char*, sizeof() == arraysize(), so there is nothing wrong with the current code. However I think it's important to be clear that the lcpy() functions work in characters and not bytes. The danger would be accidently using sizeof() with wcslcpy, for example copying some code as an example or modifying old code to use a wchar instead of a char. Review URL: http://codereview.chromium.org/17019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7536 0039d316-1c4b-4281-b951-d872f2087c98
* Roll up DEPS to pick up skia canvas ref count leak fix.deanm@chromium.org2009-01-021-1/+1
| | | | | | | | | | This is to pick up the follow change: http://codereview.chromium.org/17043 Review URL: http://codereview.chromium.org/16804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7535 0039d316-1c4b-4281-b951-d872f2087c98
* PSDK v6.1 does not have VC/Include and VC/LIB directories. So, they have to ↵jungshik@google.com2009-01-011-2/+2
| | | | | | | | | | | be removed from essential.vsprops. This should have been a part of r7520 ( http://src.chromium.org/viewvc/chrome?view=rev&revision=7520 ) TBR=nsylvain Review URL: http://codereview.chromium.org/16501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7533 0039d316-1c4b-4281-b951-d872f2087c98
* Update channel_change build files to refer to Platform SDK 6.1jungshik@google.com2008-12-312-4/+4
| | | | | | Review URL: http://codereview.chromium.org/17037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7532 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in unzip code. I was calling the wrong close function.erikkay@google.com2008-12-311-1/+1
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/17039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7531 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic unzip support. This is to be used by extensions.erikkay@google.com2008-12-3113-9/+384
| | | | | | | depends on http://codereview.chromium.org/16605 Review URL: http://codereview.chromium.org/16487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7530 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2008-12-319-22/+20
| | | | | | Review URL: http://codereview.chromium.org/17016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7529 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test case for crbug.com/2074: jungshik@google.com2008-12-312-0/+55
| | | | | | | | | | | | DBCS invalid multi-byte over-consumptionleads to XSS vectors http://codereview.chromium.org/15059/show patch by xiaolu@chromium.org Bug=5271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the 3rd file that went in prematurely in r7501 while reverting r7500.jungshik@google.com2008-12-311-1/+0
| | | | | | | | | | | | This broke Scon build. The other two files were reverted in r7502. TBR=nsylvain Review URL: http://codereview.chromium.org/16502 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7527 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in icu38@7525 which updated the ICU build file to refer to platformsdk ↵jungshik@google.com2008-12-311-1/+1
| | | | | | | | | | 6.1 instead of 6.0 TBR=nsylvain Review URL: http://codereview.chromium.org/16500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7526 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix issue 4669 (http://code.google.com/p/chromium/issues/detail?id=4669)hclam@chromium.org2008-12-311-1/+2
| | | | | | | | | When doing a view source action and then go to other address and back to view source page. Forward addresses become backward addresses. The reason is that every view source page is treated as a standard load because content_state() is always empty. The content state should be filled in SetContentStateIfEmpty() Review URL: http://codereview.chromium.org/16221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7524 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium piece of merge 39501:39520.pamg@google.com2008-12-312-5/+5
| | | | | | | | BUG=none TEST=covered by layout tests Review URL: http://codereview.chromium.org/17035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7523 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tracing on non-windows platforms.dkegel@google.com2008-12-311-9/+0
| | | | | | | | | | This was LGTM by erikkay in code review 16207, and I meant to commit it as part of code review 16467, but dropped it by accident. Review URL: http://codereview.chromium.org/17031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7521 0039d316-1c4b-4281-b951-d872f2087c98
* Update build files to use PSDK 6.1 (platformsdk_win2008_6_1). This is ↵jungshik@google.com2008-12-316-12/+10
| | | | | | | | | | | | | | | | | necessary for dynamic font support. This is a re-run of http://codereview.chromium.org/14908/show (except that chrome_dll.deps file which needs to be updated along with the actual code change) This will be followed by http://codereview.chromium.org/16494 (actual webkit code change) and changes in webkit/build BUG=1303 Review URL: http://codereview.chromium.org/16496 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7520 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit deps to pull in build fix.pamg@google.com2008-12-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7519 0039d316-1c4b-4281-b951-d872f2087c98
* Add newly failing tests for Linux. Started failing with latest WebKit merge.pamg@google.com2008-12-311-0/+6
| | | | | | | | | | TBR=nsylvain BUG=none TEST=covered by layout tests Review URL: http://codereview.chromium.org/16208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the test server to be smarter about when tonsylvain@chromium.org2008-12-301-98/+58
| | | | | | | | | | | | | | handle a command or not. This is to fix this problem: Adding a new command called "slowread" will not work if added after "slow", because the handler for "slow" handles all the commands that STARTS with slow, instead of slow[/?$] Review URL: http://codereview.chromium.org/17009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7515 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 7508.7509 and 7510nsylvain@chromium.org2008-12-3025-1038/+493
| | | | | | Review URL: http://codereview.chromium.org/17030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7514 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of merge 39453:39501.pamg@google.com2008-12-3014-10/+78
| | | | | | | | | | | | Includes new baselines for fast/transforms/identity-matrix-expected.html, which was edited slightly, and fast/backgrounds/opacity-on-document-element.html, which is new and looks correct. BUG=none TEST=none Review URL: http://codereview.chromium.org/17010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7513 0039d316-1c4b-4281-b951-d872f2087c98
* Update to SCons 1.2.0.sgk@google.com2008-12-30174-740/+1564
| | | | | | Review URL: http://codereview.chromium.org/17024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7511 0039d316-1c4b-4281-b951-d872f2087c98
* ack. fix it for real this time.erikkay@google.com2008-12-301-1/+1
| | | | | | | | TBR=pam Review URL: http://codereview.chromium.org/17027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7510 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FTP tests that are hanging on the bot.erikkay@google.com2008-12-301-1/+3
| | | | | | | | TBR=pam Review URL: http://codereview.chromium.org/17026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7509 0039d316-1c4b-4281-b951-d872f2087c98
* Add FTP unit test in preparation for portable FTP implementation.erikkay@google.com2008-12-3026-517/+1109
| | | | | | | | | | | Clean up test server code. Originally from issue 12939, written by Ibrar Ahmed (ibrar.ahmed@gmail.com) Review URL: http://codereview.chromium.org/16490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7508 0039d316-1c4b-4281-b951-d872f2087c98
* Add TRACE_EVENT calls from tcp_client_socket_win.cc into ↵dkegel@google.com2008-12-301-1/+16
| | | | | | | | | | | tcp_client_socket_libevent.cc. This was broken out from a larger cl 16027, it's the part you LGTM'd on Dec 23rd. (Should I have just checked this in without a separate review?) Review URL: http://codereview.chromium.org/16467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7507 0039d316-1c4b-4281-b951-d872f2087c98
* Processes take a long time to start if started via ssh,dkegel@google.com2008-12-301-1/+1
| | | | | | | | | | | | | as they now have to connect to the X server (not sure when we added that, or where, but it's happening). In my case, when running ProcessUtilTest.SpawnChild, it takes 1.7 seconds after the main process starts waiting for the child before the child finishes reading from the X server and exits. So raise timeout from one second to five seconds. Review URL: http://codereview.chromium.org/17022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7506 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style to LF on the SCons *.py files.sgk@google.com2008-12-301-2253/+2253
| | | | | | Review URL: http://codereview.chromium.org/16492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7505 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusting the name of a function to make it more descriptive.avi@google.com2008-12-3010-14/+15
| | | | | | Review URL: http://codereview.chromium.org/16489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7504 0039d316-1c4b-4281-b951-d872f2087c98
* Provide and use auto startup/teardown for tracked objectsjar@google.com2008-12-302-27/+41
| | | | | | | | | | Avoid races with message loop teardown r=nsylvain Review URL: http://codereview.chromium.org/17023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7503 0039d316-1c4b-4281-b951-d872f2087c98
* Revert two files that went in by mistake in r7501jungshik@google.com2008-12-302-9/+1
| | | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/16491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert sdk 6.1 upgrade changes.jungshik@google.com2008-12-3010-43/+53
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/17021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98
* Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0.jungshik@google.com2008-12-307-12/+11
| | | | | | | | | | | SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later. FYI: http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. Review URL: http://codereview.chromium.org/14908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98
* Remove compatibility #defines in string_util.hphajdan.jr@chromium.org2008-12-304-15/+9
| | | | | | Review URL: http://codereview.chromium.org/17014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some bad linux baselines.estade@chromium.org2008-12-304-2/+2
| | | | | | | | These were baselined to not render text shadows. (Now we do render text shadows on linux so the tests have been failing.) Review URL: http://codereview.chromium.org/17012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix zlib bustage with hammer build.erikkay@google.com2008-12-301-0/+1
| | | | | | | TBR=sgk Review URL: http://codereview.chromium.org/17008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7497 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.xji@chromium.org2008-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Related bug: http://code.google.com/p/chromium/issues/detail?id=2779 Related Webkit fix: http://trac.webkit.org/changeset/36874 Test: Steps to repro: 1) open chrome, Hebrew UI 2) make sure the spell checker is on, and is set to Hebrew 3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a Hebrew word that the speller does not know. 4) type some more Without the underlying Webkit fix: the highlight marker is in a wrong location, and keeps moving while typing more words after the unrecognized one. With the underlying Webkit fix: the highlight marker is in a correct and fixed location. Review URL: http://codereview.chromium.org/16606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7496 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up to issue 17007.estade@chromium.org2008-12-303-2/+2
| | | | | | | tbr=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7495 0039d316-1c4b-4281-b951-d872f2087c98
* Add zlib/contrib/minizip to third_party/zliberikkay@google.com2008-12-3019-2/+5559
| | | | | | | | This adds support for reading the .zip archive file format, which we're using in extensions. Review URL: http://codereview.chromium.org/16605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7493 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Add common words for each language, and remove forbidden words'.sidchat@google.com2008-12-292-27/+59
| | | | | | | | | | | Updated the Dic Reader to read additional words from additional-words dictionary file, created as a text file with UTF-8 encoding, with extension dic_delta. Test: Tested with all the 21 languages that are currently supported by the spell checker and for which common/additional words have been obtained. Resulting bdic files generated have those additional words. Issue=2837. Review URL: http://codereview.chromium.org/14856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7492 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot one file in r7490.estade@chromium.org2008-12-291-3/+0
| | | | | | | tbr=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7491 0039d316-1c4b-4281-b951-d872f2087c98