summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes and enhancementssgk@google.com2008-12-029-37/+77
| | | | | | | | | | | | | | | | | | * Configurable CHROME_BUILD_TYPE command line or external environment variable for selecting appropriate release_impl*.scons settings (_checksenabled, _coverage, _dom_stats, _official, _purify). * Configurable CHROMIUM_BUILD command line or external environment variable for selecting appropriate chromium_build*.scons settings (_google_chrome). * Configurable /INCREMENTAL linking via command line or external environment variable ($INCREMENTAL), through appropriate setting of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable. * Full link of release builds by default. * Alphabetize *.scons files in the mac_env.FilterOut() list. * Explicitly set _checksenabled.scons link flags. Review URL: http://codereview.chromium.org/13039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6210 0039d316-1c4b-4281-b951-d872f2087c98
* I wanted env.subst() afterall, env.Dir is apparently incorrect.deanm@chromium.org2008-12-021-2/+1
| | | | | | Review URL: http://codereview.chromium.org/12860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6209 0039d316-1c4b-4281-b951-d872f2087c98
* Minor refactorings:ericroman@google.com2008-12-024-6/+5
| | | | | | | | | | | | - Change scheme from a (const char*) to a (std::string). This is in response to an earlier comment. Background: It used to be a (const char*) to avoid allocating a string object since all the callers initialize it with a string literal. - Change the initial value of nonce_count_ from 1 to 0. This doesn't functionally change anything (we just change to a pre-increment rather than post-increment), but I prefer the the start-at-zero style. Review URL: http://codereview.chromium.org/12846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6208 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: replace some raw strings with GURL.ericroman@google.com2008-12-0210-44/+57
| | | | | | | | Also address a TODO about stripping references from proxy resolve requests. Review URL: http://codereview.chromium.org/13029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6207 0039d316-1c4b-4281-b951-d872f2087c98
* Pre-substitute webkit includes to avoid repeated subsitution. This causes ↵deanm@chromium.org2008-12-021-16/+19
| | | | | | | | my null build to go from 45s to 30s. Review URL: http://codereview.chromium.org/12828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6206 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 6190 to see if it's the cause of the 100+ new regressionsnsylvain@chromium.org2008-12-022-48/+6
| | | | | | | | | on the distributed tests. TBR Review URL: http://codereview.chromium.org/13042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6205 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, no pipe anymore.nsylvain@chromium.org2008-12-021-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6202 0039d316-1c4b-4281-b951-d872f2087c98
* A test was there twice in the tests_fixable.txtnsylvain@chromium.org2008-12-021-4/+1
| | | | | | | TBR:ojan Review URL: http://codereview.chromium.org/13041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6201 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui_tests failures. I wantnsylvain@chromium.org2008-12-0210-317/+71
| | | | | | | | | | to check if this change (6181) was the cause. I'm reverting. TBR:jeremy Review URL: http://codereview.chromium.org/12856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6199 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui tests failure that startednsylvain@chromium.org2008-12-021-1/+1
| | | | | | | | | | approximatively at this revision. I'm reverting to make sure. tbr: wtc Review URL: http://codereview.chromium.org/12855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when hiding the find bar due to a NULL window_delegate_.ben@chromium.org2008-12-021-1/+3
| | | | | | Review URL: http://codereview.chromium.org/12854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SSL info bars to use the new system.ben@chromium.org2008-12-023-128/+56
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/12847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6196 0039d316-1c4b-4281-b951-d872f2087c98
* Update debug fixable list.ojan@google.com2008-12-021-0/+5
| | | | | | Review URL: http://codereview.chromium.org/12852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6194 0039d316-1c4b-4281-b951-d872f2087c98
* Add instrumentation to and tighten SDCH implementationjar@google.com2008-12-023-3/+20
| | | | | | | r=huanr,kmixter,openvcdiff Review URL: http://codereview.chromium.org/12699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6193 0039d316-1c4b-4281-b951-d872f2087c98
* Add a wrapper around beyondcompare/kdiff3 so that it can be plugged intoojan@google.com2008-12-022-9/+127
| | | | | | | | | svn merge's diff3-cmd. Eventually, others can use this for other diff3 tools as well, they'll just need to add the right tweaks to support other tools. Review URL: http://codereview.chromium.org/11520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6192 0039d316-1c4b-4281-b951-d872f2087c98
* Found a bug in the BaseTimer (used by OneShotTimer).mbelshe@google.com2008-12-022-6/+48
| | | | | | | | | | | | | | | | | | | | | If you have a OneShotTimer pending, and you destroy your message loop, the cleanup of the timer will use memory which was already freed by the MessageLoop. When the MessageLoop shuts down, it deletes pending tasks. BaseTimer did not provide a virtual destructor to cleanup its "base". Thus, when the actual OneShotTimer cleaned up, it would use deleted memory. This manifested for me when I had accidentally had cleanup of a oneshottimer occurring through the Singleton, which occurs AtExit, after the messageloop is already gone. Created a unit test for this, which does trip the assert due to heap corruption. Review URL: http://codereview.chromium.org/13023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6190 0039d316-1c4b-4281-b951-d872f2087c98
* Change a DCHECK to CHECK to help debug a crash inwtc@google.com2008-12-021-1/+1
| | | | | | | | | | release builds. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6189 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to include this in the merge change I just landed. TBR to greenify tree.ojan@google.com2008-12-021-1/+11
| | | | | | Review URL: http://codereview.chromium.org/13032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6188 0039d316-1c4b-4281-b951-d872f2087c98
* Don't close tabs on middle-click when the release happens off the tab. ↵pkasting@chromium.org2008-12-011-1/+5
| | | | | | | | Patch by Mohamed Mansour, r=ben. See http://codereview.chromium.org/12816/ . BUG=1062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6184 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webkit merge 38729:38760ojan@google.com2008-12-0110-17/+62
| | | | | | Review URL: http://codereview.chromium.org/13028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6183 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ipc_tests unittest target to xcode project.jeremy@chromium.org2008-12-0110-71/+317
| | | | | | | | * Stub out ipc_channel_posix.cc to allow other code that depends on it to be compiled. * Cleanup some ipc code a bit to compile on gcc. * Remove unused IPC::Channel::ProcessPendingMessages() git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6181 0039d316-1c4b-4281-b951-d872f2087c98
* Baseline 12 layout tests (10 new, 2 changed)ericroman@google.com2008-12-0137-63/+321
| | | | | | | | | | | | | | | The 10 new differed by the usual text/form control differences. The two changed were: * LayoutTests/fast/forms/placeholder-set-attribute.html Baseline changed a while ago (lighter placeholder text color) * LayoutTests/fast/forms/select-initial-position.html Currently looks fine (didn't check for historical difference) Review URL: http://codereview.chromium.org/12837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6180 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in updated WebKit for newer RenderPartObject.cpp.pkasting@chromium.org2008-12-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CloseHandle blunder. I was thinking that the handle would be closed by ↵tommi@chromium.org2008-12-011-0/+1
| | | | | | | | Set, but of course I need to close the handle before the CreateFile call... doh! Review URL: http://codereview.chromium.org/13027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6178 0039d316-1c4b-4281-b951-d872f2087c98
* Added missing DEPS file for media subdirectory. Fixes checkdeps breakage.scherkus@chromium.org2008-12-011-0/+2
| | | | | | Review URL: http://codereview.chromium.org/13026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6177 0039d316-1c4b-4281-b951-d872f2087c98
* Re-point WebCoreObjCExtras to WebKit, remove one from pending dir.dglazkov@google.com2008-12-012-83/+1
| | | | | | Review URL: http://codereview.chromium.org/13024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4898: File extension wrong for saved filesfinnur@google.com2008-12-011-0/+1
| | | | | | | | | | | | When the user specifies a filename without an extension, such as "foo" instead of "foo.gif", we would append "gif" to the filename instead of ".gif" (so the user ends up with a file named "foogif"). I'm not confident this is the only thing wrong with this function. For example if the user specifies "foo." and the filter says "*.gif" shouldn't we add ".gif" to the filename instead of deleting the dot? Also, we seem to be ignoring the default_extension parameter passed in when we figure out what extension to tack on and instead get the file extension from GetFileExtensionFromPath... :s Review URL: http://codereview.chromium.org/12838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6174 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed gcc build break due to nested templates (>> should be > >)scherkus@chromium.org2008-12-011-1/+1
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/12841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6173 0039d316-1c4b-4281-b951-d872f2087c98
* <esc> in the AutocompleteEdit should select all the text when reverting to ↵pkasting@chromium.org2008-12-013-27/+37
| | | | | | | | the permanent text. Only pass it through as an accelerator if we don't end up changing anything. Patch by Mohamed Mansour, r=me. See http://codereview.chromium.org/10800 . BUG=4203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6168 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in media common header file and buffer pure interfaces.scherkus@chromium.org2008-12-013-1/+159
| | | | | | | R=cpu,darin Review URL: http://codereview.chromium.org/12701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6167 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for some trivial issues (remove unneeded constants, int->size_t in a ↵pkasting@chromium.org2008-12-014-8/+5
| | | | | | few cases). Patch by phajdan.jr@gmail.com, r=me. See http://codereview.chromium.org/11586 . git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.open()/window.close() regression by disabling window.close() ↵erg@google.com2008-12-0110-7/+60
| | | | | | | | | | | until a message comes back from the Browser thread saying that it's OK to allow javascript close calls. ISSUE=http://crbug.com/4007 Review URL: http://codereview.chromium.org/12691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6165 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create the default download directory just because we ask for its ↵pkasting@chromium.org2008-12-011-14/+11
| | | | | | | | location. This is a first step toward not creating _any_ directories when we merely ask for their locations. Patch by Marc-André Decoste, r=cpu. See http://codereview.chromium.org/11586 . Bug=4575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6164 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new submenu in the context menu for a text box. This submenu displays ↵sidchat@google.com2008-12-018-41/+215
| | | | | | | | some spell check languages that Chrome supports, derived from the accept languages list and the current spell check language. The spell check language which is currently set is shown to be selected. The user can click on some other spell check language, and it will become effective immediately (this part of the code was addressed in a previous CL, and has been checked in). Review URL: http://codereview.chromium.org/12614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6162 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the X selection clipboard for copying html and text out of a linux ↵tc@google.com2008-12-0110-6/+90
| | | | | | | | | | | | | | test shell. I implemented it in the webview delegate, so when we switch to the multiprocess architecture, we will need to find out if the clipboard callback can be async (the current method would require a sync call from browser to renderer to get the selected text). Review URL: http://codereview.chromium.org/12700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6160 0039d316-1c4b-4281-b951-d872f2087c98
* Add F1 as an accelerator for "Help". Original patch by Alex Mendes da ↵pkasting@chromium.org2008-12-013-0/+7
| | | | | | | | Costa, r=ben, see http://codereview.chromium.org/10796 . BUG=851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6158 0039d316-1c4b-4281-b951-d872f2087c98
* Making sure that the buffer we use with ReadFile/WriteFile is pagetommi@chromium.org2008-12-011-10/+67
| | | | | | | | | | | | | | | aligned. Also restoring file attributes after evicting it from the cache (since the function writes to the file). Depending on hardware, file operations will fail if the buffer isn't aligned when using the FILE_FLAG_NO_BUFFERING flag. For more details: http://msdn.microsoft.com/en-us/library/cc644950(VS.85).aspx Review URL: http://codereview.chromium.org/12833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6157 0039d316-1c4b-4281-b951-d872f2087c98
* Allow for setting platform-specific expecations for layout tests.ojan@google.com2008-12-017-168/+193
| | | | | | | | I don't actually update any test lists, but I did test that all my examples in the documentation actually work. Review URL: http://codereview.chromium.org/12628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6156 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 6149 because it broke the unit tests on windows.nsylvain@chromium.org2008-12-0113-217/+47
| | | | | | Review URL: http://codereview.chromium.org/12834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6155 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up how we feed various outputs into the installer builders. Instead ofmpcomplete@chromium.org2008-12-014-137/+144
| | | | | | | | | | referencing them by name, we put them into toplevel environment variables and reference them by the variable. Also made DirBuilder more flexible in accepting SCons Nodes as inputs. Review URL: http://codereview.chromium.org/12705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6154 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing tab with no selection while the form autofill was showing would crash.jcampan@chromium.org2008-12-011-3/+5
| | | | | | | | BUG=4847 TEST=Open a form, type something so the autofill shows, press tab with no selection. Review URL: http://codereview.chromium.org/13019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6153 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the cpu-count forwarding passing code from the v8 SConscript.evanm@google.com2008-12-011-9/+2
| | | | | | | | | | | Running with n CPUs would cause our parent scons to run with n cpus and then have it spawn a sub-scons that would itself attempt to run with an additional n cpus. Review URL: http://codereview.chromium.org/13010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6152 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/12502 for sverrir:sky@google.com2008-12-011-8/+15
| | | | | | | | | | | Fix selection after deleting cookies. The selection was seemingly random because the model to view mapping changed when deleting items. BUG=3692 TEST=Try deleting items in cookies view and make sure selection doesn't jump around unexpectedly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6150 0039d316-1c4b-4281-b951-d872f2087c98
* browser porting, part 2 - importeragl@chromium.org2008-12-0113-47/+217
| | | | | | | | Review URL: http://codereview.chromium.org/12688 Patch from Pawel Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6149 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/12503dglazkov@google.com2008-12-014-298/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6148 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: When asked for Monaco font, default to Times New Roman.agl@chromium.org2008-12-012-1/+10
| | | | | | | | | | | | Monaco is an Apple specific font which we don't have on either Linux nor Windows. When Windows is asked for it it appears to fallback to Times New Roman. We configure Linux to do the same so that we match on layout-tests which use Monaco. Review URL: http://codereview.chromium.org/11610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6146 0039d316-1c4b-4281-b951-d872f2087c98
* Changes filter used when importing in bookmark manager to includesky@google.com2008-12-011-1/+1
| | | | | | | | | | | | | *.htm. BUG=4388 TEST=Create a file name foo.htm. Go to bookmark manager, choose import, navigate to directory with foo.htm and make sure the the open dialog shows foo.htm. Review URL: http://codereview.chromium.org/12459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6144 0039d316-1c4b-4281-b951-d872f2087c98
* This layout test is flaky in debug.nsylvain@chromium.org2008-12-011-1/+2
| | | | | | Review URL: http://codereview.chromium.org/13017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6143 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 5971 which was reverted in 5974. The unit test wasn't unregistering ↵maruel@chromium.org2008-12-018-6/+146
| | | | | | | | the observer correctly. Review URL: http://codereview.chromium.org/12474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6142 0039d316-1c4b-4281-b951-d872f2087c98
* Added the printing of a warning when we get an Exception while trying to ↵maruel@chromium.org2008-12-011-4/+8
| | | | | | | | | import our google.* python packages so that the user can tell why it happens, and how to fix it. Patch from mad@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6140 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 01:55:23 +0000