| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
forked expected output.
Review URL: http://codereview.chromium.org/10284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This CL replaces the following, which seems to have become inaccessible:
http://codereview.chromium.org/9202/
Review URL: http://codereview.chromium.org/10402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgk
Review URL: http://codereview.chromium.org/9762
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=peterson
Review URL: http://codereview.chromium.org/10287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reviewed by erikkay:
http://codereview.chromium.org/6577/show
ports listen_socket and telnet_server to POSIX
I had to make some changes to get this to work on Mac and to fix a few regressions it caused in Windows, so please take a fresh look at this diff Dan.
Ibrar, please take a look at the changes from your patch to mine (you may need to diff listen_socket_unittest.h with listen_socket_unittest.cc manually since I moved a bunch of code here). Some were bugs that I should have caught in review, some were bugs that only got tickled on the Mac, others were just cleanup. Comments welcome.
Review URL: http://codereview.chromium.org/9260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/4286
Review URL: http://codereview.chromium.org/9759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only set the text field text when the user presses enter or click on an item.
It also prevents the WM_CHAR events to make it to the page after a WM_KEYDOWN has been processed by the menu (that would typically cause forms to proceed when you pressed enter in the form popup).
BUG=4145
TEST=Type something in a form to have the autofill popup showing. Use the down/up arrow to move around. The text should not change in the text field. Press enter, the selection should be set. Try again clicking this time.
Review URL: http://codereview.chromium.org/9621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
should not have.
BUG=4136
TEST=see bug for details, along with 4220. You should also verify that
carpet bombing dialog comes up when it should.
Review URL: http://codereview.chromium.org/10270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9752
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Looked at past 200 runs for all the flaky tests
and for all the tests that the past couple runs have
said don't match their results.
Review URL: http://codereview.chromium.org/10273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- quoted path to chrome exe for Google update to launch
- create Chrome guid key if not present.
BUG=1443250
TBR=huanr
Review URL: http://codereview.chromium.org/10403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I also cleaned up Resource{Request,Response} a tad.
R=eseidel
Review URL: http://codereview.chromium.org/10248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move some truly win32-specific from the 'portable' to the 'platform-specific' category.
Enable some tests that already work.
Fix a couple signedness mismatch errors that showed up while testing the above.
Review URL: http://codereview.chromium.org/9465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(NPN_RequestRead). This would occur whenever Chrome was configured to use a proxy server. The NPN_RequestRead API sends out byte range requests to the server, which then responds with a HTTP Partial Response header (206) followed by a content type which specifies the boundary string which separates individual body parts.
We parse out the boundary string in our plugin implementation and then send out individual body parts to the plugin.
In this case the proxy server would respond to the byte range request and send back the response with a quoted boundary string. This is legit as per MIME specs. We did not handle this case and hence would look for the quoted boundary string in the data which did not exist.
Fix is to trim the leading and trailing quotes in the boundary string.
Added a unit test to handle this case.
Bug=http://code.google.com/p/chromium/issues/detail?id=4076
R=jam
Review URL: http://codereview.chromium.org/10236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3805
Review URL: http://codereview.chromium.org/9463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/2324
Review URL: http://codereview.chromium.org/10265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4264
Review URL: http://codereview.chromium.org/9749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu is invoked from the keyboard.
BUG=4029
TEST=In the bookmark manager bring up the context menu of the
tree/table via the menu key and make sure the menu appears at a
reasonable location.
Review URL: http://codereview.chromium.org/10256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
DraggedTabController.
Review URL: http://codereview.chromium.org/10263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
way it was written previous made it seem like it was supposed to be some sort of lock. It was just to manage acquiring the clipboard (which involves some Windows clipboard lock).
Review URL: http://codereview.chromium.org/9745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
better.
BUG=4271
Review URL: http://codereview.chromium.org/10262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/10401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Delegates should be NULLed more aggressively.
Review URL: http://codereview.chromium.org/10235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EnableSuddenTermination, unforking a bunch of code.
BUG=http://crbug.com/4064
Review URL: http://codereview.chromium.org/9746
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a blocked popup notification.
Review URL: http://codereview.chromium.org/9709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
change to textareas.
See http://codereview.chromium.org/9704
Also remove test expectations from layout_test_results where
they shouldn't have been in the first place and move them back to being next to the layout test. The changes to the other tests are all just copies from layout_test_results, no manual modifications.
Review URL: http://codereview.chromium.org/9725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=4185
Review URL: http://codereview.chromium.org/9484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the expected failures.
Review URL: http://codereview.chromium.org/10253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GlobalInit() wasn't successful.
Review URL: http://codereview.chromium.org/10247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Rebaseline css3/keyframes-rule.html.
Review URL: http://codereview.chromium.org/10251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
'window.top'.
Review URL: http://codereview.chromium.org/9740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
empty (has no root element). This matches the WebKit version function dumpFramesAsText in WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp, see http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp?rev=34719#L306.
This fixes layout test LayoutTests/http/tests/security/cross-origin-xsl-BLOCKED.html as it expects a totally empty iframe.
Review URL: http://codereview.chromium.org/10003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
making "not found" noises or jumping within the page."
This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string.
To fix this issue, this change removes a composition string from a search string to emulate Firefox.
BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page."
Review URL: http://codereview.chromium.org/9634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A change r2266 removed fake scroll bars used to handle WM_MOUSEWHEEL messages. This change prevents Windows from sending WM_HSCROLL messages when tilting a mouse wheel (Windows sends WM_HSCROLL messages only to a window which has scroll bars.) and this causes a regression problem that we cannot use tilt-wheel to scroll horizontally.
To solve this problem, this change implements a WM_MOUSEHWHEEL (0x020E) message handler to dispatch tilt-wheel events to the RenderWidgetHostViewWin::OnWheelEvents() function. Also, It changes scroll direction in creating a WebMouseWheelEvent instance.
Review URL: http://codereview.chromium.org/9319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5091 0039d316-1c4b-4281-b951-d872f2087c98
|