summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use string for Histogram names since these are all ASCII anyway.dsh@google.com2009-02-2448-235/+217
| | | | | | | | Wide-character literals cause problems between platforms. Review URL: http://codereview.chromium.org/28046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10276 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ResourceMessageFilter::OnGetWindowRect and OnGetRootWindowRectevan@chromium.org2009-02-243-4/+39
| | | | | | | | | | | | | | | | | on linux. This fixes a problem typing in the username when authenticating to gmail. The error message was: FATAL:browser/renderer_host/render_view_host.cc(658)] Check failed: false. Can't send sync messages to UI thread without pumping messages in the renderer or else deadlocks can occur if the pagehas windowed plugins! (message type 8219) Review URL: http://codereview.chromium.org/28026 Patch from Craig Schlenter <craig.schlenter@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10275 0039d316-1c4b-4281-b951-d872f2087c98
* Taking out unfinished code. I don't understand what role these functions ↵avi@chromium.org2009-02-241-46/+14
| | | | | | | | play, and I put in quickly-ported Windows code. It crashes, so I'm taking it out until I can properly write it. Review URL: http://codereview.chromium.org/31005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10273 0039d316-1c4b-4281-b951-d872f2087c98
* Maximized popup windows couldn't be restored by double-clicking the ↵pkasting@chromium.org2009-02-241-2/+7
| | | | | | | | titlebar, because we gofed up the coordinate transforms while adding nonclient button handling to WidgetWin. Review URL: http://codereview.chromium.org/27095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10272 0039d316-1c4b-4281-b951-d872f2087c98
* Download request manager refactoring.estade@chromium.org2009-02-2412-210/+286
| | | | | | | | | | Pull out the dialog delegate to a separate file so we can swap it out with other implementations on other platforms. Also, build download_request_manager.cc on POSIX. Review URL: http://codereview.chromium.org/27062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10270 0039d316-1c4b-4281-b951-d872f2087c98
* Implement X509Certificate::Persist. dkegel@google.com2009-02-242-15/+32
| | | | | | | | This lets the browser read gmail on linux. Review URL: http://codereview.chromium.org/27033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10269 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing flakeyness when running session restore ui tests insky@google.com2009-02-244-16/+23
| | | | | | | | | | | | | purify. I believe the ui test isn't waiting for the session restore to complete, so that when the ui test does various asserts the state of the browser is wrong. BUG=6495 TEST=covered by tests Review URL: http://codereview.chromium.org/28051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10268 0039d316-1c4b-4281-b951-d872f2087c98
* rollback r10264 to fix build bustagedarin@chromium.org2009-02-242-30/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10266 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit r10259 after successful try server run.jeremy@chromium.org2009-02-247-24/+93
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10265 0039d316-1c4b-4281-b951-d872f2087c98
* Update build files to pick up newly added files.darin@chromium.org2009-02-242-0/+30
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/28047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10264 0039d316-1c4b-4281-b951-d872f2087c98
* Xcode changes to build third_party/WebKit/WebKit/chromiumdarin@google.com2009-02-242-0/+167
| | | | | | | | R=mark Review URL: http://codereview.chromium.org/28038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10263 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r10259 & subsequent fixes.jeremy@chromium.org2009-02-247-94/+24
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10262 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Win32 unit tests broken by r10259.jeremy@chromium.org2009-02-241-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10261 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows bustage in r10259jeremy@chromium.org2009-02-241-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10260 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Sandboxed WebKit on OS X:jeremy@chromium.org2009-02-247-24/+93
| | | | | | | | | | * Cache Gestalt's value since it opens files. * Do a little cleanup in sys_info while I'm there and add a unit test. * Label some methods as not being threadsafe on OSX/POSIX. Review URL: http://codereview.chromium.org/27088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10259 0039d316-1c4b-4281-b951-d872f2087c98
* Minor includes cleanup.darin@chromium.org2009-02-245-5/+1
| | | | | | | | R=brettw Review URL: http://codereview.chromium.org/27076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10258 0039d316-1c4b-4281-b951-d872f2087c98
* Add some browser/dom_ui files to Mac and Linux. Fix errors exposed by GCC.pinkerton@chromium.org2009-02-245-13/+39
| | | | | | Review URL: http://codereview.chromium.org/27090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10257 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check for empty handle in V8Proxy::GetSourceLineNumber()sgjesse@chromium.org2009-02-241-1/+5
| | | | | | | | | If an exception occours in some of the code used to locate the line number of the source on the top stack frame an empty handle will be returned and using Int32Value on it will cause a crash. As of now I have not been able to find a case where an exception to happens though. BUG=7912 Review URL: http://codereview.chromium.org/28024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10253 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a method to sort the elements of a vector by invoking a method onsky@google.com2009-02-243-35/+127
| | | | | | | | | | | | | | each that returns a string. The strings are then compared using a collator, or operator < if no collator is found. I'm going to use this for sorting bookmarks. BUG=1750 TEST=none yet Review URL: http://codereview.chromium.org/20484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10252 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 10250.ericroman@google.com2009-02-246-138/+3
| | | | | | | Rolling back since the windows module builders are failing ot find v8 project... Review URL: http://codereview.chromium.org/27081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10251 0039d316-1c4b-4281-b951-d872f2087c98
* Add v8 as dependency of net.ericroman@google.com2009-02-246-3/+138
| | | | | | | | | | | This is needed for ProxyResolverV8, which executes proxy auto config scripts. See bug 2764. This CL has changes for {xcode, visualstudio}, but not {scons} yet. Review URL: http://codereview.chromium.org/28049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10250 0039d316-1c4b-4281-b951-d872f2087c98
* Removing WS_POPUP before calling SetParent to avoid stealing the focus ↵tommi@chromium.org2009-02-241-5/+12
| | | | | | | | (flicker) during initialization. Review URL: http://codereview.chromium.org/27066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10249 0039d316-1c4b-4281-b951-d872f2087c98
* Add destruction to AudioManager singleton for windowscpu@google.com2009-02-242-6/+14
| | | | | | | | | -Current unit tests sufice Review URL: http://codereview.chromium.org/28036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10248 0039d316-1c4b-4281-b951-d872f2087c98
* Added master preference to select the appropiate shortcut textcpu@google.com2009-02-243-46/+48
| | | | | | | | | - Simplified ParseDistributionPreferences a bit - Added test for new pref Review URL: http://codereview.chromium.org/27077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10247 0039d316-1c4b-4281-b951-d872f2087c98
* Make download manager treat mixed-case extensions the same as lower-case ↵estade@chromium.org2009-02-244-87/+99
| | | | | | | | | | | | extensions when judging whether a file is executable. Also, store known executable file extensions as narrow strings since they are all ASCII anyway. r=jcampan BUG=7455 Review URL: http://codereview.chromium.org/29003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10246 0039d316-1c4b-4281-b951-d872f2087c98
* Have tld_cleanup generate a .cc file that contains the effectivetc@google.com2009-02-2411-126/+3702
| | | | | | | | | | | | tld data. This makes the build dependencies easier (helpful for grit and gyp) and brings in the effective tld data on mac. BUG=6076 Review URL: http://codereview.chromium.org/31004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10245 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure filter buffer is flushed after it fills its output quotajar@chromium.org2009-02-242-5/+28
| | | | | | | | | | | | | | | In some cases, when the filter returned but the output buffer was full, the ReadFilteredData code was not "bothering" to call the filter again (because there was no more input data to provide). We now maintain state indicating that the output buffer was filled (last time) and use that to ensure we call the filter(s) again when Read is next called. bug=7985 r=huanr Review URL: http://codereview.chromium.org/27073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing include in r10237hclam@chromium.org2009-02-241-0/+1
| | | | | | | | TBR=? Review URL: http://codereview.chromium.org/28059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10243 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build due to r10237hclam@chromium.org2009-02-241-1/+2
| | | | | | | | TBR=? Review URL: http://codereview.chromium.org/28058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10242 0039d316-1c4b-4281-b951-d872f2087c98
* Tenative fix to see if the reliability crashes go away.jam@chromium.org2009-02-241-0/+4
| | | | | | | | BUG=7951 Review URL: http://codereview.chromium.org/28057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10241 0039d316-1c4b-4281-b951-d872f2087c98
* Update French dictionary files.sidchat@google.com2009-02-242-90393/+70191
| | | | | | | Issue=7745 Review URL: http://codereview.chromium.org/28054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10240 0039d316-1c4b-4281-b951-d872f2087c98
* Moved most functionality of video renderer into a base class ↵ralphl@chromium.org2009-02-249-0/+606
| | | | | | | | | (video_renderer_base) and implemented mock filter will full functionality execpt that it never draws anything. Review URL: http://codereview.chromium.org/20343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10239 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-roll use of ongoing logs to gather stability metricsjar@chromium.org2009-02-241-3/+1
| | | | | | | | | | | | | | This was rolled back to try to use only the initial logs to gather statibility stats, because we were having trouble capturing data in ongoing logs. We now resolved the problem (which was actually only on the stability branch), so we'll roll back to using this method and verify it in the dev branch. tbr=mal Review URL: http://codereview.chromium.org/27061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10238 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of data source for media playerhclam@chromium.org2009-02-244-47/+326
| | | | | | | | | | | | | | | | Implementation of DataSourceImpl for the media player pipeline in Chrome. DataSourceImpl delegates resource loading request to Chrome from the media pipeline. It also performs asynchronous file reading of the media file and coordinates the progress update of resource loading. This change completes the implementation of construction, initialization of data source, asynchronous file reading and coordinations of streaming progress updates between different threads. This change does not contains delegation of resource loading to RenderView and registration of a streaming resource client. Review URL: http://codereview.chromium.org/20375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10237 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogContentsDelegate should not subclass views::WindowDelegate, for ↵ben@chromium.org2009-02-247-18/+28
| | | | | | | | | | | portability reasons (views isn't used on Mac or Linux). Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead. TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up. Review URL: http://codereview.chromium.org/27074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10236 0039d316-1c4b-4281-b951-d872f2087c98
* mark a couple more tests as failing:tc@google.com2009-02-241-0/+2
| | | | | | | | | | | these two tests are failing on the windows build bot TBR=eseidel Review URL: http://codereview.chromium.org/27078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break due to misplaced ifdef.mmoss@chromium.org2009-02-241-1/+2
| | | | | | | Review URL: http://codereview.chromium.org/27075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10234 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge! (chrome part)eseidel@chromium.org2009-02-246-13/+46
| | | | | | Review URL: http://codereview.chromium.org/27028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10233 0039d316-1c4b-4281-b951-d872f2087c98
* The find bar should be owned and managed from the BrowserView, not the ↵finnur@google.com2009-02-2435-836/+747
| | | | | | | | | | | | | | | | | | | | | | | | WebContentsView, since it's part of the "chrome". Design Doc: http://dev.chromium.org/developers/design-documents/find-bar Things done: - Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed. - Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view. - Moved find control methods to WebContents. - Added recent find result state to WebContents. - Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered. - Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc. - Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs. - Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab. - view.h: Don't lay out child views again if they have a layout manager, it already updated them. TEST=Find box should work as before. BUG=3245 Review URL: http://codereview.chromium.org/27025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling tests that are failing.kuchhal@chromium.org2009-02-241-11/+13
| | | | | | | | | BUG=7983 Review URL: http://codereview.appspot.com/21058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build break.estade@chromium.org2009-02-241-2/+3
| | | | | | | | tbr=jhawkins Review URL: http://codereview.chromium.org/28052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10229 0039d316-1c4b-4281-b951-d872f2087c98
* Multiple fixes for broken Linux SHARED=1 build. This gets things building, ↵mmoss@chromium.org2009-02-2311-9/+52
| | | | | | | | | but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better). Review URL: http://codereview.chromium.org/27054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared build breakage due to undefined references.mmoss@chromium.org2009-02-231-2/+6
| | | | | | | | | | | | | | | This compiles an empty file so we can generate the libplugin target needed by other targets. This whole file does compile (see r9934), but it doesn't link because of undefined refs to files which aren't compiling yet (e.g. npobject_proxy stuff). But we need some sources to build an empty lib, otherwise scons fails to link in skia (when linking with no source files, the -L flag is left off the linker command, so libs in the build directory can't be found). Review URL: http://codereview.chromium.org/27019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10227 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseDownloadItemModel and its inheritors.estade@chromium.org2009-02-2314-131/+112
| | | | | | | | | * Move BaseDownloadItemModel to download_item_model.h. Previously it was in a windows-specific file in chrome/browser/views/. * Move SavePageModel to download_item_model.{cc,h}. Review URL: http://codereview.chromium.org/28033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10226 0039d316-1c4b-4281-b951-d872f2087c98
* Obey the XDG base directory spec and use ~/.config/chromium on Linux.evan@chromium.org2009-02-232-13/+19
| | | | | | | | | As discussed here: http://groups.google.com/group/chromium-dev/browse_thread/thread/41e9154311779e1a Review URL: http://codereview.chromium.org/27069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10225 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more gcc 4.3 warnings.evan@chromium.org2009-02-232-10/+13
| | | | | | Review URL: http://codereview.chromium.org/28045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10224 0039d316-1c4b-4281-b951-d872f2087c98
* Clear out the vbox before adding a new widget.erg@google.com2009-02-232-13/+28
| | | | | | | | | | | | This prevents the weird issue where gtk tries to pack both views into the box. It isn't optimal, though. This solution leaves the area blank since it clears the old renderer as soon as the new one is created instead of waiting until the new renderer has something to display. Review URL: http://codereview.chromium.org/27057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10223 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin_installer.cc compile on Posix.jhawkins@chromium.org2009-02-234-8/+4
| | | | | | Review URL: http://codereview.chromium.org/31001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10222 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a download regression.estade@chromium.org2009-02-231-5/+10
| | | | | | | | FilePath::Extension() returns ".extension" whereas file_util::GetExtensionFromFilename() returns just "extension" Review URL: http://codereview.chromium.org/27071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10221 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Fullscreen mode UI.""kuchhal@chromium.org2009-02-238-1/+340
| | | | | | | | | This reverts commit 243e461e4a659a6e8008befc2c76a55680860f01. Review URL: http://codereview.appspot.com/21057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10220 0039d316-1c4b-4281-b951-d872f2087c98