| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Wide-character literals cause problems between platforms.
Review URL: http://codereview.chromium.org/28046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on linux. This fixes a problem typing in the username when authenticating
to gmail.
The error message was:
FATAL:browser/renderer_host/render_view_host.cc(658)] Check failed:
false. Can't send sync messages to UI thread without pumping messages
in the renderer or else deadlocks can occur if the pagehas windowed
plugins! (message type 8219)
Review URL: http://codereview.chromium.org/28026
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
play, and I put in quickly-ported Windows code. It crashes, so I'm taking it out until I can properly write it.
Review URL: http://codereview.chromium.org/31005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
titlebar, because we gofed up the coordinate transforms while adding nonclient button handling to WidgetWin.
Review URL: http://codereview.chromium.org/27095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Pull out the dialog delegate to a separate file so we can swap it out with other implementations on other platforms.
Also, build download_request_manager.cc on POSIX.
Review URL: http://codereview.chromium.org/27062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This lets the browser read gmail on linux.
Review URL: http://codereview.chromium.org/27033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
purify. I believe the ui test isn't waiting for the session restore to
complete, so that when the ui test does various asserts the state of
the browser is wrong.
BUG=6495
TEST=covered by tests
Review URL: http://codereview.chromium.org/28051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/28047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mark
Review URL: http://codereview.chromium.org/28038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Cache Gestalt's value since it opens files.
* Do a little cleanup in sys_info while I'm there and add a unit test.
* Label some methods as not being threadsafe on OSX/POSIX.
Review URL: http://codereview.chromium.org/27088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/27076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
If an exception occours in some of the code used to locate the line number of the source on the top stack frame an empty handle will be returned and using Int32Value on it will cause a crash. As of now I have not been able to find a case where an exception to happens though.
BUG=7912
Review URL: http://codereview.chromium.org/28024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
each that returns a string. The strings are then compared using a
collator, or operator < if no collator is found.
I'm going to use this for sorting bookmarks.
BUG=1750
TEST=none yet
Review URL: http://codereview.chromium.org/20484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Rolling back since the windows module builders are failing ot find v8 project...
Review URL: http://codereview.chromium.org/27081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for ProxyResolverV8, which executes proxy auto config scripts.
See bug 2764.
This CL has changes for {xcode, visualstudio}, but not {scons} yet.
Review URL: http://codereview.chromium.org/28049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(flicker) during initialization.
Review URL: http://codereview.chromium.org/27066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
-Current unit tests sufice
Review URL: http://codereview.chromium.org/28036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Simplified ParseDistributionPreferences a bit
- Added test for new pref
Review URL: http://codereview.chromium.org/27077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions when judging whether a file is executable.
Also, store known executable file extensions as narrow strings since they are all ASCII anyway.
r=jcampan
BUG=7455
Review URL: http://codereview.chromium.org/29003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tld data. This makes the build dependencies easier (helpful for
grit and gyp) and brings in the effective tld data on mac.
BUG=6076
Review URL: http://codereview.chromium.org/31004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases, when the filter returned but the output buffer was full,
the ReadFilteredData code was not "bothering" to call the filter again
(because there was no more input data to provide). We now maintain
state indicating that the output buffer was filled (last time) and use
that to ensure we call the filter(s) again when Read is next called.
bug=7985
r=huanr
Review URL: http://codereview.chromium.org/27073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=?
Review URL: http://codereview.chromium.org/28059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=?
Review URL: http://codereview.chromium.org/28058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7951
Review URL: http://codereview.chromium.org/28057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=7745
Review URL: http://codereview.chromium.org/28054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(video_renderer_base) and implemented mock filter will full
functionality execpt that it never draws anything.
Review URL: http://codereview.chromium.org/20343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was rolled back to try to use only the initial logs to gather statibility
stats, because we were having trouble capturing data in ongoing logs.
We now resolved the problem (which was actually only on the stability
branch), so we'll roll back to using this method and verify it in the
dev branch.
tbr=mal
Review URL: http://codereview.chromium.org/27061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of DataSourceImpl for the media player pipeline in Chrome.
DataSourceImpl delegates resource loading request to Chrome from the media
pipeline. It also performs asynchronous file reading of the media file and
coordinates the progress update of resource loading.
This change completes the implementation of construction, initialization of
data source, asynchronous file reading and coordinations of streaming
progress updates between different threads. This change does not contains
delegation of resource loading to RenderView and registration of a streaming
resource client.
Review URL: http://codereview.chromium.org/20375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
portability reasons (views isn't used on Mac or Linux).
Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead.
TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up.
Review URL: http://codereview.chromium.org/27074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
these two tests are failing on the windows build bot
TBR=eseidel
Review URL: http://codereview.chromium.org/27078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsView, since it's part of the "chrome".
Design Doc: http://dev.chromium.org/developers/design-documents/find-bar
Things done:
- Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed.
- Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view.
- Moved find control methods to WebContents.
- Added recent find result state to WebContents.
- Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered.
- Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc.
- Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs.
- Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab.
- view.h: Don't lay out child views again if they have a layout manager, it already updated them.
TEST=Find box should work as before.
BUG=3245
Review URL: http://codereview.chromium.org/27025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7983
Review URL: http://codereview.appspot.com/21058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=jhawkins
Review URL: http://codereview.chromium.org/28052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better).
Review URL: http://codereview.chromium.org/27054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This compiles an empty file so we can generate the libplugin target needed by
other targets. This whole file does compile (see r9934), but it doesn't link
because of undefined refs to files which aren't compiling yet (e.g.
npobject_proxy stuff). But we need some sources to build an empty lib,
otherwise scons fails to link in skia (when linking with no source files, the
-L flag is left off the linker command, so libs in the build directory can't be
found).
Review URL: http://codereview.chromium.org/27019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Move BaseDownloadItemModel to download_item_model.h. Previously it was in a windows-specific file in chrome/browser/views/.
* Move SavePageModel to download_item_model.{cc,h}.
Review URL: http://codereview.chromium.org/28033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
As discussed here:
http://groups.google.com/group/chromium-dev/browse_thread/thread/41e9154311779e1a
Review URL: http://codereview.chromium.org/27069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents the weird issue where gtk tries to pack both views into the box.
It isn't optimal, though. This solution leaves the area blank since it clears
the old renderer as soon as the new one is created instead of waiting until
the new renderer has something to display.
Review URL: http://codereview.chromium.org/27057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/31001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FilePath::Extension() returns ".extension" whereas file_util::GetExtensionFromFilename() returns just "extension"
Review URL: http://codereview.chromium.org/27071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit 243e461e4a659a6e8008befc2c76a55680860f01.
Review URL: http://codereview.appspot.com/21057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10220 0039d316-1c4b-4281-b951-d872f2087c98
|