summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* One more header guard fix to trigger the build.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/4320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2663 0039d316-1c4b-4281-b951-d872f2087c98
* One more simple change to trigger the buildbots.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | | This is just fixing the header guard Review URL: http://codereview.chromium.org/4319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2662 0039d316-1c4b-4281-b951-d872f2087c98
* I'm testing the buildbots, I needed a small change to triggernsylvain@chromium.org2008-09-281-3/+3
| | | | | | | them. Review URL: http://codereview.chromium.org/4318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2661 0039d316-1c4b-4281-b951-d872f2087c98
* Add the auth unit-tests to SConscript and .pbxprojericroman@google.com2008-09-275-4/+19
| | | | | | Review URL: http://codereview.chromium.org/4315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2660 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling test I wrote for Find to catch crash described in issue 1341577.finnur@google.com2008-09-271-2/+5
| | | | | | Review URL: http://codereview.chromium.org/5018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2659 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stab at http authentication (basic + digest) in new http stack.ericroman@google.com2008-09-2724-12/+1747
| | | | | | | | | | | | | | | | | | General design: - class HttpAuth -- utility class for http-auth logic. - class HttpAuth::ChallengeTokenizer -- parsing of www-Authenticate headers. - class HttpAuthHandler -- base class for authentication schemes (inspired by nsIHttpAuthenticator) - class HttpAuthHandlerBasic : HttpAuthHandler -- logic for basic auth. - class HttpAuthHandlerDigest : HttpAuthHandler -- logic for digest auth. - The auth integration in HttpNetworkTransaction mimics that of HttpTransactionWinHttp: + HttpNetworkTransaction::ApplyAuth() -- set the authorization headers. + HttpNetworkTransaction::PopulateAuthChallenge() -- process the challenges. BUG=2346 Review URL: http://codereview.chromium.org/4063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2658 0039d316-1c4b-4281-b951-d872f2087c98
* Stop building mini_installer in Debug configuration. This projects has ↵maruel@google.com2008-09-271-283/+0
| | | | | | | | | issues in Debug and is flaky. Remove the Any Cpu configuration. It's really unnecessary. Review URL: http://codereview.chromium.org/4308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2657 0039d316-1c4b-4281-b951-d872f2087c98
* Move 'sdch' into the Windows-specific LIBS lists until it's integratedsgk@google.com2008-09-273-25/+32
| | | | | | | | | with the Linux and Mac SCons-based builds. Also, indent a set of Windows-specific flags under a Windows-only block. Review URL: http://codereview.chromium.org/4314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2656 0039d316-1c4b-4281-b951-d872f2087c98
* Catch up SCons Windows build with recent file shuffling and other changes:sgk@google.com2008-09-268-57/+59
| | | | | | | | | | | | | * New browser\download\ subdirectory. * New browser\importer\ subdirectory. * New browser\views\old_frames subdirectory. * Add common/notification_registrar.cc. * Remove title_chomper{,_unittest}.cc. * Link against sdch where empirically necessary. * No libevent.lib on Windows, comment out until Linux hits the .dll logic. Review URL: http://codereview.chromium.org/4310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2655 0039d316-1c4b-4281-b951-d872f2087c98
* Don't let a malicious web site open an unbounded number of constrained popups.darin@chromium.org2008-09-261-0/+7
| | | | | | | | | | Patch by abarth@chromium.org R=ben BUG=2632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2654 0039d316-1c4b-4281-b951-d872f2087c98
* Check for cpu items before assuming it will work.mbelshe@google.com2008-09-261-8/+10
| | | | | | Review URL: http://codereview.chromium.org/3804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2653 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac compile by removing the unnecessary setDeviceOffset function.brettw@google.com2008-09-263-13/+0
| | | | | | Review URL: http://codereview.chromium.org/5020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2652 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the third_party/icu38 revision in DEPS to have SCons build libicu,sgk@google.com2008-09-2630-30/+36
| | | | | | | | | | not libicuuc. Add a new $ICU_LIBS construction variable to allow different platforms to link with different sets of ICU libraries. Use it in the LIBS lists of the various construction environments used to build the things that link with it. Review URL: http://codereview.chromium.org/4312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2651 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out a RenderThread interfacecpu@google.com2008-09-266-29/+212
| | | | | | | | | | | - RenderWidget was not unit testable as it was - Adding the first ever RederWidget unit tests It is possible to do more. Taking it step by step. Review URL: http://codereview.chromium.org/4271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2649 0039d316-1c4b-4281-b951-d872f2087c98
* Add scoped_nsautorelease_pool.mm to the Mac SCons Build.sgk@google.com2008-09-261-0/+1
| | | | | | Review URL: http://codereview.chromium.org/5015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2647 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 455: Active match in Find is not selected and links are not focused ↵finnur@google.com2008-09-264-10/+63
| | | | | | | | after you close the Find box. Review URL: http://codereview.chromium.org/4283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2645 0039d316-1c4b-4281-b951-d872f2087c98
* Remove setDeviceOffset which isn't used. Fixed a few style and line wrapping ↵brettw@google.com2008-09-267-79/+32
| | | | | | | | issues. Review URL: http://codereview.chromium.org/5012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2644 0039d316-1c4b-4281-b951-d872f2087c98
* Make the link in the About box clickable (Issue 657)finnur@google.com2008-09-263-14/+39
| | | | | | | | The URL in the About box was added as a last minute string addition. I have now made it clickable. I also converted the TextField for the main label into a regular label, since there is no need to copy anything anylonger. Review URL: http://codereview.chromium.org/5013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2643 0039d316-1c4b-4281-b951-d872f2087c98
* Sync the function names. The unit tests overrode this function to prevent ↵brettw@google.com2008-09-261-1/+1
| | | | | | | | interactions with the UI. Review URL: http://codereview.chromium.org/5011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage from my previous renaming.brettw@google.com2008-09-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/4307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some header guards that are named incorrectly.darin@chromium.org2008-09-263-11/+9
| | | | | | | | R=tony Review URL: http://codereview.chromium.org/4306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2639 0039d316-1c4b-4281-b951-d872f2087c98
* "--clobber" should come before the build directory setup.mmoss@google.com2008-09-261-7/+8
| | | | | | | | | | | Otherwise it deletes the build directory and db file which are needed by the rest of the build, causing the build to fail. Fixes error: scons: *** [Errno 2] No such file or directory: 'src/chrome/src/chrome/Hammer/.sconsign.dblite' Review URL: http://codereview.chromium.org/5010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2638 0039d316-1c4b-4281-b951-d872f2087c98
* Make a copy of the builder for the custom gears emitter for TypeLibrary, so itsgk@google.com2008-09-261-0/+4
| | | | | | | doesn't cause problems for other TypeLibrary users. Review URL: http://codereview.chromium.org/4303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a crash in the info bubble at first runcpu@google.com2008-09-261-3/+6
| | | | | | | | | | | - Null deref in GetDefaultSearchEngineName - This is a stopgap fix Issue = 2573 Review URL: http://codereview.chromium.org/4304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2636 0039d316-1c4b-4281-b951-d872f2087c98
* Add positive and negative test cases for whether wewtc@google.com2008-09-261-10/+86
| | | | | | | | | | | should resend a request when we read nothing or get a read failure. R=darin,eroman BUG=2489 Review URL: http://codereview.chromium.org/4291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2635 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the declarations to have some grouping and logical ordering in ↵brettw@google.com2008-09-2620-1704/+1654
| | | | | | | | | tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file. This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent. Review URL: http://codereview.chromium.org/5005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2634 0039d316-1c4b-4281-b951-d872f2087c98
* Change made based on comment in previous CL (that had already landed).jar@google.com2008-09-261-1/+1
| | | | | | | | | Add extra check on received dictionary status before saving it for use r=kmixter,openvcdiff Review URL: http://codereview.chromium.org/4285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2633 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to sort TableView. Contrary to what we spoke aboutsky@google.com2008-09-269-161/+978
| | | | | | | | | | | | | | | | | | | | | | | the other day I ended up doing the sorting in tableview. This makes it a heck of lot easier than having every model have to deal with it. As part of this I removed the optional non-caching logic from TableView, which was never used. Sadly though, this means there are coordinate transformations. I've only enabled sorting in the keyword editor, I have to make sure all the other places that use TableView can deal with it. For example, task manager can't deal with it currently as it expects the getters to be called only once where as when sorting they may be called multiple times. BUG=2790 TEST=This enables sorting ONLY in the keyword editor. Make sure there aren't any problems in adding/removing/changing entries in the keyword editor after this. Review URL: http://codereview.chromium.org/4276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2631 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in importer where we could set the default search providersky@google.com2008-09-262-14/+50
| | | | | | | | | | | | | | | | | | to one that doesn't support replacement. Also changed uniquing to consider invalid OSDD urls. Need this to pick up Windows Live Search. I also changed the ff importer to return out early on if it couldn't find the value for the search provider. I encountered this do to hitting a NOTREACHED. BUG=1507 TEST=In IE set your default search to Live Search. Import from IE and make sure Chrome sets the default search to Live Search. Also make sure this didn't break keyword importing. Review URL: http://codereview.chromium.org/4281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2630 0039d316-1c4b-4281-b951-d872f2087c98
* Increase min throttle on the new timer performance test.mbelshe@google.com2008-09-261-1/+4
| | | | | | | | | | | | This is an arbitrary timer, but these tests run slower than I expected on the bbots. TBR=ojan Review URL: http://codereview.chromium.org/4301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2629 0039d316-1c4b-4281-b951-d872f2087c98
* Use open-vcdiff for sdch compression on the Macmark@chromium.org2008-09-2628-35066/+35523
| | | | | | Review URL: http://codereview.chromium.org/4096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2628 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for http://b/issue?id=1377375 (crashing bug when opening a ↵ojan@google.com2008-09-261-1/+6
| | | | | | | | | | | | | popup). I wasn't able to repro the bug, but I've spent far too long trying to do so already. This seems like the right fix. Will wait to see that it actually fixes the crash in the wild and then upstream the change to webkit. Review URL: http://codereview.chromium.org/4102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2626 0039d316-1c4b-4281-b951-d872f2087c98
* Change to Hi Res timers on Windows.mbelshe@google.com2008-09-266-51/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two parts of this: 1) TimeTicks:Now() Don't call timeBeginPeriod() in all cases. Use the new SystemMonitor class to watch battery on/off transitions and use the timeBeginPeriod() only when we're using the battery. 2) TimeTicks::UnreliableHiResNow() Change this function from "UnreliableHiResNow()" to "HiResNow()". We still use QPC, but we detect if we're on AMD Athlon XP machines which fail on QPC. For those systems, we fall back to TimeTicks::Now(). Updated tests to detect hardware specifics of timers. Output of the test will contain lines such as these: [ RUN ] TimeTicks.SubMillisecondTimers Min timer is: 1us [ OK ] TimeTicks.SubMillisecondTimers [ RUN ] TimeTicks.TimeGetTimeCaps timeGetTime range is 1 to 1000000ms [ OK ] TimeTicks.TimeGetTimeCaps [ RUN ] TimeTicks.QueryPerformanceFrequency QueryPerformanceFrequency is 2394.18MHz [ OK ] TimeTicks.QueryPerformanceFrequency [ RUN ] TimeTicks.TimerPerformance Time::Now: 0.11us per call TimeTicks::Now: 0.09us per call TimeTicks::HighResNow: 0.26us per call [ OK ] TimeTicks.TimerPerformance Review URL: http://codereview.chromium.org/4092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2625 0039d316-1c4b-4281-b951-d872f2087c98
* Add file_util::GetFileInfo as a means to provide more information about a filedarin@google.com2008-09-264-12/+35
| | | | | | | | | | | path. This CL changes GetFileSize to be implemented in terms of GetFileInfo since under the hood on all platforms the same system call is used. R=mark Review URL: http://codereview.chromium.org/4286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2624 0039d316-1c4b-4281-b951-d872f2087c98
* See if 'charset' is available in HTTP response header and use that to ↵jungshik@google.com2008-09-262-19/+24
| | | | | | | | | | | | | | | | | convert the response to UTF-8 before sending over to JSON deserializer. (previously this issue was tracked internally as issue 1293145) BUG=2806 TEST=In French Chrome, set your default search engine to Voila and begin to type a word with an accented letters and see if 'Search Voila for ' contains the word (it's not a bullet-proof test). In Korean chrome, set the default search engine to Daum and begin to type a Korean word (with Korean IME on, type 'qk'). Review URL: http://codereview.chromium.org/4287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2623 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure there is only one instance of the stats histogram at a given time.rvargas@google.com2008-09-261-3/+7
| | | | | | | | | BUG=2805 Review URL: http://codereview.chromium.org/4292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2620 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that the lifetimes of multiple ScopedHostMapperwtc@google.com2008-09-261-1/+3
| | | | | | | | | | instances are properly nested. R=darin BUG=2635 Review URL: http://codereview.chromium.org/4293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2619 0039d316-1c4b-4281-b951-d872f2087c98
* Repair the SCons test_shell build on Windows:sgk@google.com2008-09-253-12/+12
| | | | | | | | | | | | | * Remove the BUILDING_CHROMIUM__ definition so SCons still builds webkit with the currently-checked-in cairo.h shim instead of the new PLATFORM_SKIA definitions. * Link with the new sdch library. * Remove /WX from the test_shell compilation. * Add the additional platform-specific port source files to the input_files list, don't replace the list with a subset. Review URL: http://codereview.chromium.org/4282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2617 0039d316-1c4b-4281-b951-d872f2087c98
* Add --js-flags to the list of flags accepted by UI tests.patrick@chromium.org2008-09-253-0/+16
| | | | | | Review URL: http://codereview.chromium.org/4290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2616 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the request context is released when a URLFetcher is deleted.rvargas@google.com2008-09-252-222/+322
| | | | | | | | | BUG=b/1340170 TEST=unittest Review URL: http://codereview.chromium.org/4077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2615 0039d316-1c4b-4281-b951-d872f2087c98
* If we read nothing (EOF) after sending a request on awtc@google.com2008-09-253-11/+34
| | | | | | | | | | | | | | | | persistent connection, it also indicates that the server closed the connection before receiving the request, and we should resend the request on a new connection. I refactored the main code of HandleIOError into a new ShouldResendRequest method so that I can reuse it to handle the read-nothing case. R=darin BUG=2489 Review URL: http://codereview.chromium.org/4264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2613 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of stuff out of WebContents. I removed a bunch of render view ↵brettw@google.com2008-09-2518-382/+132
| | | | | | | | | host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise. I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it. Review URL: http://codereview.chromium.org/4088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2612 0039d316-1c4b-4281-b951-d872f2087c98
* Wow, it's been a while since we cleaned EOL.maruel@google.com2008-09-2522-2991/+2991
| | | | | | | | | | | | Ran dos2unix on *.cc, *.h, *.py and SCons*.* Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.cc Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.h Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.py Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\SCons*.* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2611 0039d316-1c4b-4281-b951-d872f2087c98
* Add UTF-8 check for JSON deserializer.jungshik@google.com2008-09-257-14/+90
| | | | | | | | | | | Add tests for IsStringUTF8 Make IsStringUTF8 accept std::string/std::wstring rather than char*/wchar_t* Review URL: http://codereview.chromium.org/4268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2610 0039d316-1c4b-4281-b951-d872f2087c98
* Stop spamming delayed tasks on each input event.darin@chromium.org2008-09-254-28/+61
| | | | | | | | | R=mbelshe BUG=2693 Review URL: http://codereview.chromium.org/4262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2609 0039d316-1c4b-4281-b951-d872f2087c98
* Add more tests and files to the Mac's net_unittests:mark@chromium.org2008-09-254-14/+27
| | | | | | | | | | | - backend_unittest - cookie_policy_unittest - proxy_service_unittest - url_request_test_job - test_completion_callback_unittest Review URL: http://codereview.chromium.org/4094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2608 0039d316-1c4b-4281-b951-d872f2087c98
* "Make Chrome your default browser" should now appear as a checkbox at the ↵finnur@google.com2008-09-2548-137/+162
| | | | | | | | | bottom of the First Run dialogs and be opt-out. Therefore I moved it from the FirstRunCustomizeView view to the FirstRunViewBase. I also moved the override function for GetDialogButtonLabel to the base class (since both dialogs should have the same label for the OK button) and aligned the "Import" label vertically to the "Import" combobox. Review URL: http://codereview.chromium.org/4244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix non-Mac break from r2603mark@chromium.org2008-09-251-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2604 0039d316-1c4b-4281-b951-d872f2087c98
* Provide autorelease pool management on the Mac in all types of message pumps.mark@chromium.org2008-09-2511-12/+101
| | | | | | | Fix a few unit tests to use autorelease pools as needed. Review URL: http://codereview.chromium.org/3805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2603 0039d316-1c4b-4281-b951-d872f2087c98
* As an intermediate step towards having a message pump handling IO through ↵rvargas@google.com2008-09-254-146/+267
| | | | | | | | | | completion ports, this CL creates two types of message pumps for windows: one to handle UI threads and another one to handle IO threads. I'm basically moving stuff around, except by the fact that now UI threads will not process APCs or wait on objects (those things only happen on message loops of TYPE_IO) Review URL: http://codereview.chromium.org/3094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2602 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 01:48:34 +0000