| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames ash's default wallpaper images (which had
"gradient" in their name despite not being gradients) and
removes old references in .gitignore to the now-unused
google_wallpapers dependency.
BUG=248764
Review URL: https://chromiumcodereview.appspot.com/19683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently the USB event handling thread is not safely exiting during shutdown due to the blocking and uninterruptable libusb_handle_event API. This issue is to introducing a way to safely interrupt it.
BUG=223817
Review URL: https://chromiumcodereview.appspot.com/18648010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLFetcher normally does not allow POST requests without a body. Work around
this by adding an empty request body to all POST requests made with
PrivetURLFetcher.
BUG=
Review URL: https://chromiumcodereview.appspot.com/19669006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19631002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DrawGL can be called without OnDraw, so if FallbackTickFired can be
called if DrawGL sets continuous_invalidate_ to false.
Add a DCHECK that FallbackTickFired does not run unnecessarily.
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19567003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=259432
Review URL: https://chromiumcodereview.appspot.com/19478002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Enables the public suffix list domain matching for autofill of
passwords by default on Android.
* Changes the flag to one which can turned on and off.
Flag to enable:
--enable-password-autofill-psl-domain-matching
Flag to disable:
--disable-password-autofill-psl-domain-matching
It can also be changed from chrome://flags.
BUG=176386
Review URL: https://chromiumcodereview.appspot.com/19476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
consequent reload requests. See discussion about didFailProvisionalLoad() and net::ERR_ABORTED at https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/provisional$20load$20failure/chromium-dev/Fal1ZJnTgGQ/OgLGlB3x51IJ. In addition, deleted redundant logging.
BUG=254487, 242527, 241889
TEST=manual tests on Linux ChromeOS build
Review URL: https://chromiumcodereview.appspot.com/19390003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes two things:
1. Should set back to lower case after select any accent key at upper case mode
2. Should not remove the active class from a key without any accent keys
after a long press
BUG=254408
Review URL: https://chromiumcodereview.appspot.com/19277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
action would be picked up by chromeactions. Also updating the name so it now fits within 80 chars (the action never made it into the actions list so changing the name shouldn't affect anything else).
Also updating chromeactions.txt so that the action is picked up.
BUG=248790
Review URL: https://chromiumcodereview.appspot.com/19267025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is useful prep work to allow the omnibox to know whether search
term replacement is in effect regardless of whether the user is in the
process of editing in the omnibox.
There should be no user-visible change.
BUG=
Review URL: https://chromiumcodereview.appspot.com/19239004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and the shelf is auto hidden.
BUG=259027
Test=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/19100006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncSetupHandler is a class used for sync setup, and sometimes needs to
initiate a gaia sign in. Today, it does so via SigninTracker, and keeps
track of the sign in progress while displaying a spinner or a grayed out
"in progress" sign in button. This is unnecessary, since other classes
that initiate sync setup respond only after sign in is complete, instead
of keeping track of an ongoing sign in.
This patch does multiple things:
1) Removes the use of SigninTracker from SyncSetupHandler, and updates
the logic to close the sync setup wizard when control is handed off
to the gaia sign in tab.
2) Updates OneClickSigninHelper to automatically close the gaia sign in
tab before handing back control to SyncSetupHandler, in cases when
the settings page initiates a gaia re-auth.
3) Miscellaneous clean up related to the above behavior changes.
Note: This bug takes care of item #2 in bug 241353.
BUG=241353, 259150, 261317, 261367. 92948
TEST=Initiate sync setup or re-auth via the settings page. The setup dialog must be closed during sign in, and be reopened after sign in.
Review URL: https://chromiumcodereview.appspot.com/18698004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
blocker
BUG=38458
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/19569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll still need to populate enough fields of the struct to be able to restore
the popup.
BUG=38458
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/19167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=mark@chromium.org
Review URL: https://codereview.chromium.org/19556005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
Review URL: https://codereview.chromium.org/19742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=261493
TBR=justinlin
Review URL: https://codereview.chromium.org/19711003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These are needed for threading filter animations.
BUG=181613
Review URL: https://chromiumcodereview.appspot.com/19114002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This restores two changes, which were reverted to allow Blink
r153179 to be cleanly reverted, due to causing NPAPI plugin crashes. The changes required window script objects to be
un-wrapped, and never to be force-deallocated, which was
re-landed as Blink r154201.
r210094 - "Remove WebView contentWindow work-around."
r209353 - "Remove window script object stub teardown hack in
out-of-process NPAPI."
BUG=152006
Review URL: https://chromiumcodereview.appspot.com/19070002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Chrome style is to use the full path of the header file. This
cleanup should let us remove "ppapi" from the header file search path.
Having "ppapi/" be implicit is left over from when these source files
were moved from the NaCl repo into the Chrome repo.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=2500
TEST=build
Review URL: https://codereview.chromium.org/19521002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PrivetRegisterOperation is incorrectly accessing the JSON value in the /info
call response even if it is null. Fix this and add a pseudo-action name "info"
for errors that happen during /info requests in the register flow.
BUG=
Review URL: https://chromiumcodereview.appspot.com/19688002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The yuv data arrays were sized for a 1x1 video frame, but the
frame size was changed to be 10x10, so we were reading off the
end of the arrays and blowing up on ASAN. The tests now pass
ASAN locally again.
R=piman,enne
BUG=260920
Review URL: https://chromiumcodereview.appspot.com/19641002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19604002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes RemoteFileSystemProxy from WebkitFileWriterImpl, as a
preparation of removing RemoteFileSystemProxy. The implementation of
CreateWritableSnapshotFile, which WebkitFileStreamWriterImpl depends, is
extracted from FileSystemProxy to fileapi_worker.
The arguments of WebkitFileStreamWriterImpl are re-sorted based on
WebkitFileStreamReaderImpl.
BUG=253837
TEST=Ran unit_tests and browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*"
Review URL: https://chromiumcodereview.appspot.com/19034005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from r210884.
BUG=260391
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19689006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is part of moving device_status_check and buildbot_report into the buildbot folder.
BUG=258171
Review URL: https://chromiumcodereview.appspot.com/19684002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We changed by-value struct passing in a way that we need
shims for every architecture to communicate with PPAPI.
(See https://codereview.chromium.org/14134011/)
This only affects users of offline translation.
BUG=261295
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19680002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We use stlport on android. This inclusion is unnecessary.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19652007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tray_audio.cc.
BUG=259989
TBR=jamescook
Review URL: https://chromiumcodereview.appspot.com/19645002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/plugins to content/. To do this, I simplified how we disable plugin loading for tests, and also updated the test in content to use the new way.
BUG=237249
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Reset All" button becomes disabled or enabled based on the status
of gesture preferences. If all preferences are set to default, then the
button is disabled. If at least one of them is set by user, the button
is enabled. The button label is updated appropriately, too.
BUG=251858
Review URL: https://chromiumcodereview.appspot.com/19643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Touch & gesture related Ash.* and Event.* moved to public repo
BUG=223859
TEST=None
Review URL: https://chromiumcodereview.appspot.com/19575003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=136262
Review URL: https://chromiumcodereview.appspot.com/19220003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19629002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Represent a SpdySession's state by three variables of type:
AvailabilityState, ReadState (the old State type), and WriteState.
Make some important functions, including the BufferedSpdyWriter
callbacks, do nothing if availability_state_ == STATE_CLOSED.
Rename the current state machine from DoLoop etc. to DoReadLoop.
Refactor the write state machine to be parallel to the read state machine.
Keep track of the number of bytes read without yielding in DoReadLoop
itself. This fixes a slight bug where the counter isn't reset if the loop
yields due to ERR_IO_PENDING being returned.
The new write state machine (DoWriteLoop, etc.) has almost the same
behavior as the old one, except if a write completes asynchronously
the write loop is immediately re-entered instead of via a posted task.
Fix tests to match new write loop behavior.
Use time_func_ consistently.
Add regression test for http://crbug.com/261043 .
BUG=255701,261043
R=rch@chromium.org, rtenneti@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211852
Review URL: https://codereview.chromium.org/18143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The integration test, when run with -a, now detects and reports broken links and orphaned pages.
Broken links either link to an invalid page (404) or have an invalid anchor. Orphaned pages are pages that cannot be navigated to from the home pages just by clicking links.
BUG=147747
Review URL: https://chromiumcodereview.appspot.com/17816005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused Linux x64 sizes to fail for reasons unclear.
> Create top-level separate targets for browser and child dlls
>
> The general idea is that there's top level targets chrome and chrome_child,
> and corresponding content_app and content_app_child that depend on only
> the subtargets that should be included in the appropriate dll.
>
> Pull bluetooth_utils from bluetooth_device into separate common target
> as it's referenced from chrome/common/extensions.
>
> Currently (probably) Windows-only and requires setting chrome_multiple_dll=1
> for gyp.
>
> Links, but Blink is still included in browser.
>
> Single-process mode is currently disabled when chrome_multiple_dll is set.
>
> Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html
> generated by "python tools\win\split_link\graph_dependencies.py deps.html"
>
> Remove the previous hacky-er attempt at this that was named "split dll".
>
> TBR=jam@chromium.org
>
> BUG=237249,256965
>
> Review URL: https://codereview.chromium.org/17619005
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/19572012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I thought to hard-code the "<display-name> (<annotation>)" format,
but it should be translated, since some language (like Japanese)
may prefer full-width parenthesis (U+FF08 and U+FF09)
BUG=None
R=oshima@chromium.org
TEST=ash_unittests still passes
Review URL: https://chromiumcodereview.appspot.com/19507002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way we can verify with DEPS that the content/(common|browser)/ code
is only depending on enums and not linking against Blink symbols.
Some of the code in content/common/ that reaches into WebIDBKey(Path)
still needs to be pulled out into content/child/
BUG=237267
Review URL: https://chromiumcodereview.appspot.com/19442002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, job removing code and wakeup code are separate.
With the wait queue algorithm employed by WakeupSocketIfNecessary, we
have O(N^2 log N) total complexity for shutting down all pending jobs.
So, it can make IO thread busy for long time. To prevent such situation
occurring for bogus web app,
- integrate wakeup code into job removing code so that we can build a
list of wakeup candidates from removing process and check only jobs
in it. Total complexity for shutdown will then be O(N log N)
- have some reasonable limit for the maximum number of WebSocketJob
instances pending in the WebSocketThrottle.
The number of WebSocketJob instances pending in WebSocketThrottle will
be limited up to 1k.
Also, the number of active SocketStream instances should be limited.
When huge number of WebSocket instances are created, it pressures the
browser process. It'll be limited up to 16k.
BUG=259005
Review URL: https://chromiumcodereview.appspot.com/18932005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we manually added "always enable" types from within the DataTypeManager.
Now the notion of types to always enable is pulled into its own construct, CoreTypes
(and it's sibling PriorityCoreTypes). Tests have been updated to exercise this, and
SyncedNotifications has been added as the first Core type.
BUG=245762
Review URL: https://chromiumcodereview.appspot.com/19227004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212232 0039d316-1c4b-4281-b951-d872f2087c98
|