| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
For the most part, this is a straight refactor. I'm sure I broke something.
BUG=monolithic code
TEST=none
Review URL: http://codereview.chromium.org/6392011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each infobar is responsible for drawing a little tab-like bulge that pushes into
the browser frame (or another infobar, if there is more than one).
XIB changes:
* Increase the height of Infobar.xib 9px to account for the bulge
* Slide the image and text over so that the image is now aligned for the bulge
BUG=57106
TEST=Go to http://it.wikipedia.org and get an infobar. Open the Task Manager and force-quit an extension to get a second infobar. Both have the bulge.
Review URL: http://codereview.chromium.org/6250080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR 'cos break is broken.
TBR=zelidrag@chromium.org
BUG=chromium-os:6839
TEST=none.
Review URL: http://codereview.chromium.org/6286054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inputs on
windows).
BUG=gyp44
TEST=gyp(actions_multiple)
Review URL: http://codereview.chromium.org/6250086
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/6312094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
addition to its client role that listens to signals from other chromeos dbus
services. For now, it exposes the functionality of resolving network proxies
for specified urls from chromeos clients.
Implements read-write access APIs for proxy settings, will be used by UI to
check if current user can read or write proxy settings.
BUG=chromium-os:8890,chromium-os:6839
TEST=none
Review URL: http://codereview.chromium.org/5054001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also move yestarday's gdk_ suppression into 'benign' category
BUG=71695,71634
TBR=glider
TEST=TSan/unit should go green
Review URL: http://codereview.chromium.org/6410036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows).
BUG=gyp44
TEST=gyp(actions_multiple)
Review URL: http://codereview.chromium.org/6250086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64922
TEST=none
Review URL: http://codereview.chromium.org/6312070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
properly (no windows below 400 width allowed on Mac).
BUG=66717
TEST=see r72153
Review URL: http://codereview.chromium.org/6286053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for multi-profile.
devtools
kDevToolsSplitLocation
browser
kBrowserWindowPlacement
Also add a method to browser_prefs to delete obsolete preferences from local state, and fix all related tests.
BUG=66717
TEST=all browser, interactive, and ui tests work properly
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72153
Review URL: http://codereview.chromium.org/5915006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/webdriver/python.
NO CODE CHANGE.
TEST=none
BUG=none
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implementation (commented out now due to lack of focus manager). Add some utilities to NativeWidget for obtaining NativeWidget from a NativeView.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6286035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6360019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6334042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts the ShowHtmlDialog() function into a common cross platform header.
BUG=None
TEST=Tested on Mac. Windows and Linux builds pending.
Review URL: http://codereview.chromium.org/6250030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=pepper flash, run it and move the mouse everywhere.
Review URL: http://codereview.chromium.org/6260057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Tooltip generation - moved to UserManager::User.
2. Tracking user picture update - moved to ExistingUserController.
3. Resorted methods in UserController a bit.
4. Moved users param from EUC ctor to Init()
BUG=chromium-os:11268
TEST=Existing, manual.
Review URL: http://codereview.chromium.org/6349047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69683
TEST=ViewTest.HiddenViewWithAccelerator
Review URL: http://codereview.chromium.org/6271010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Pepper Flash
Review URL: http://codereview.chromium.org/6400007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66917
TEST=Open several complex web-pages as describe in bug, close them all without crashing.
Review URL: http://codereview.chromium.org/6410014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While I was removing code that's no longer needed, I also simplified the select element handling.
I also abstracted some styling for inline editable list text fields so that CSS isn't replicated for each list.
BUG=None
TEST=DOMUI Settings lists, especially exceptions, should still work correctly and look right.
Review URL: http://codereview.chromium.org/6334038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callbacks.
- Moved teardown state transitions to use TeardownStateTransitionTask() so they can't be confused with normal playback transitions in FilterStateTransitionTask().
- Fixed code so seek callback is called if an error occurs during a Seek().
BUG=71087
TEST=PipelineImplTest.ErrorDuringSeek
Review URL: http://codereview.chromium.org/6250092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set focus to omni box of the Net Tab Page. In some cases on ChromiumOS a new tab didn't have focus after being opened.
BUG=chromium-os:10898
TEST=make sure that focus is set on omnibox when we create new tab on ChromeOS
Review URL: http://codereview.chromium.org/6410004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=loislo
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6286050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6351003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SavingHistoryDisabledThenEnabled
Also add debugging code in case they are still unstable. However,
the logs seem to indicate a bot/launcher issue.
BUG=57994
TEST=browser_tests
Review URL: http://codereview.chromium.org/6246030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The put() function has been updated to take a PutMode parameter rather
than the addOnly bool. Update calls, and ship the PutMode across IPC.
BUG=64052
TEST=none
Review URL: http://codereview.chromium.org/6250049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6258018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=none
TEST=printing works after code change.
Review URL: http://codereview.chromium.org/6240014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/6250100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63656
TEST=host_content_settings_map_unittest.cc
Review URL: http://codereview.chromium.org/6286045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=
TEST=
Review URL: http://codereview.chromium.org/6334052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to render_widget_host.h, view() can return NULL. This patch checks
the value of view() before dereferencing it.
BUG=crash reports indicate failure at point of dereferencing
TEST=none (don't know how to repro)
Review URL: http://codereview.chromium.org/6250084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:60050, chromium-os:8517
TEST=none
Review URL: http://codereview.chromium.org/6250052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID 14614
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6392022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6286037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix serving of policies after the recent config file format change.
BUG=none
TEST=Run the testserver with Chrome and check that policies are applied to Chrome.
Review URL: http://codereview.chromium.org/6246043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=73126
TEST=confirm that the display names are fixed. Added a test for this.
BUG=chromium-os:11575
Review URL: http://codereview.chromium.org/6312086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30700
TBR=cpu
Review URL: http://codereview.chromium.org/6250103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=
TEST=
Review URL: http://codereview.chromium.org/6410026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by http://src.chromium.org/viewvc/chrome?view=rev&revision=73426.
BUG=chromium-os:11581
TEST=browser_tests passed.
Review URL: http://codereview.chromium.org/6410023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11330
TEST=manual, see issue
Review URL: http://codereview.chromium.org/6347068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=
TEST=
Review URL: http://codereview.chromium.org/6410024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Those tests flakily trigger a libjingle assertion:
Error(common.cc:67): e:\b\build\slave\win\build\src\third_party\libjingle\source\talk\session\tunnel\pseudotcpchannel.cc(281): ASSERT FAILED: stream_ != NULL && stream_thread_->IsCurrent() @ cricket::PseudoTcpChannel::Close
TBR=hclam
BUG=70225
TEST=remoting_unittests
Review URL: http://codereview.chromium.org/6334046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
provider interface.
BUG=63656
TEST=unit_tests:*ContentSettings*.*
Review URL: http://codereview.chromium.org/6250077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- My install won't tolerate NULLs to XQueryTree(), so fix.
- Need to flag the test plug-in as NOT an Xt-based plug-in.
- Enable the test in the .gypi.
BUG=30700
TEST=ui_tests,NPAPI*.*
Review URL: http://codereview.chromium.org/6349042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome frame binary
for every test run. We need to register the path provider prior to attempting the registration.
BUG=none
TEST=chrome frame net tests should run
TBR=amit
Review URL: http://codereview.chromium.org/6312087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are now unused because of the migration to DOMUI options. This is a continuation of cleanup done in http://codereview.chromium.org/6336005/
BUG=chromium-os:8307
TEST=ran on linux and netbook, unit tests passed
Review URL: http://codereview.chromium.org/6307019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11055
TEST=see the bug
Review URL: http://codereview.chromium.org/6368044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73431 0039d316-1c4b-4281-b951-d872f2087c98
|