| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
transaction. The reset is done using the default constructor.
This is less fragile than resetting each member manually, and in fact not all members were being reset (for example, vary_data and ssl_info).
In the case of vary_data this could cause a subtle glitch, since calling HttpVaryData::Init() twice on the same object doesn't fully re-initialize.
The changes outside of http_network_transaction.cc are just a safety net -- it seemed reasonable to make HttpVaryData::Init() support the multiple-init model.
Review URL: http://codereview.chromium.org/50031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- future crash reporter will use this key
BUG=1459941
Review URL: http://codereview.chromium.org/42407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
implementation.
Review URL: http://codereview.chromium.org/45016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
this didn't work, but this fixes it and lets me reopen the tree. TBR.
Review URL: http://codereview.chromium.org/42473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
copied from the old radio button.
Review URL: http://codereview.chromium.org/50080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
over to tests_fixable.txt. I'm tempted to rename tests_fixable.txt,
but I wonder whether it's worth it given that there are a number of
scripts that would need to be updated.
Review URL: http://codereview.chromium.org/48045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
type="range">.
This code will not be called until I land the upstream hooks to RenderThemeChromiumWin.cpp to use it.
BUG=8931
Review URL: http://codereview.chromium.org/42451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the Windows Schannel API, a server requests renegotiation
when DecryptMessage (decrypting received data) returns
SEC_I_RENEGOTIATE. We need to jump to the handshake
sequence, and when handshake completes, come back to reading
data.
I also cleaned up the code. I created the
SetNextStateForRead and FreeSendBuffer functions to share
common code, and made sure our handshake sequence is
completely equivalent to the handshake sequence in the
Platform SDK WebClient.c sample.
R=rvargas
BUG=6893
TEST=Visit these sites, which request SSL renegotiation:
https://secure.skandiabanken.se/Skbsecure/LoginInternet/SKBLoginInternet.aspx
https://secure.skandiabanken.no/SkbSecure/Authentication/Otp/Default.ashx
https://www.myopenid.com/signin_certificate
Review URL: http://codereview.chromium.org/42380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux settings to target_defaults in common.gypi so
gyp-generated SConscript files no longer depend on
build/SConscript.main or the Hammer infrastructure.
* Copy the FilterOut() function from Hammer to the chromium_builders.py
Tool module.
* Add a ChromiumLoadableModule() builder to chromium_builders.py.
* Add dependencies on the 'views' library to the chrome link (target 'app').
* Add missing views/*/*_unittest.cc modules to the 'unit_tests' target.
Exclude all but the one that builds on Linux from the non-Windows builds.
* Crib a list of chrome/views files to exclude from the Linux build
from the old SCons configuration.
* Add a new build/linux/system.gyp file with new 'settings' targets
to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2.
* Add depenedencies in the other targets on the new gtk, nss and
pangoft2 'settings' targets from build/linux/system.gyp.
* Add a pkg_config_wrapper.py script that keeps gyp happy by
simply exiting 0 if the package isn't found.
* DEPS roll for latest gyp changes to support the above.
Review URL: http://codereview.chromium.org/42340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The graphical differences are very minor. Text diff due to font metrics. There are small gaps between the lines in the paths that trace the number outlines. I have debugged our skia paint/path calls, and I think it's a skia bug with anti-aliased paths and rounding. Note that the gaps only appear for certain browser window sizes, e.g. that of the layout test default size, but not the test shell's default size. I believe other tests with the same problem have been previously rebased.
Review URL: http://codereview.chromium.org/42470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which we just clone.
This fix cannot land until we get the latest v8.
Review URL: http://codereview.chromium.org/50056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
its originating page.
BUG=5630
Review URL: http://codereview.chromium.org/50067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
M tests_fixable.txt
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
deletes that suggestion from the DB.
BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.
Review URL: http://codereview.chromium.org/42258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.
When...
DownloadRequestDialogDelegate
... and ...
DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.
This causes a DCHECK in...
DownloadRequestDialogDelegateWin::DeleteDelegate()
... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.
Review URL: http://codereview.chromium.org/50072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we separate data between before and after the cache
is full. Also, reduce the rate at which a particular
client sends data to be only once a week. The effect is
that the histogram data will only have one value per client,
and the same client will not be "voting" on more than one
version (release) at the same time.
Review URL: http://codereview.chromium.org/50063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--bookmark-menu.
BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
works. Also make sure I didn't break anything on the bookmark bar.
Review URL: http://codereview.chromium.org/42460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Split V8XMLHttpRequestCustom into appropriate files.
Review URL: http://codereview.chromium.org/45018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=24687
https://bugs.webkit.org/show_bug.cgi?id=24584
and Evan's fix for janky stroked text:
https://bugs.webkit.org/show_bug.cgi?id=24526
Review URL: http://codereview.chromium.org/42465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This consolidates the shutdown path. We used to have two paths depending
of whether the user hit the X on the window manager or used wrench -> exit.
Now both do the same thing: call BrowserWindowGtk::Close().
Review URL: http://codereview.chromium.org/42372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- less things #ifdef-ed
- replaced Windows-specific functions with portable equivalents
Review URL: http://codereview.chromium.org/50059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as it can take too long to wrong. Removes the tests
LayoutTests/transitions/transition-end-event-container.html
LayoutTests/transitions/transition-end-event-multiple-03.html as I
landed a fix (https://bugs.webkit.org/show_bug.cgi?id=24678) that
should make these less flakey.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- enable one more point of logging
- enable decoding of automation messages in log output
Review URL: http://codereview.chromium.org/50058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
this so easy.
Review URL: http://codereview.chromium.org/42438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to webkit.
We want to pass all key events to webkit. But other widgets shouldn't get key events till after they've been checked against our accelerators. This fixes the problem that pressing ctrl-page{up,down} in the location bar moves the cursor rather than changing tabs.
Review URL: http://codereview.chromium.org/50069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/42459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(including the use of AccessibleBase and AccessibleDocument) in the glue accessibility implementation.Introduces the GlueAccessibilityObject, which serves as a platform-independent wrapper directly around WebKit's AccessibilityObject (also platoform-independent).Updates naming/comments to reflect the independence of IAccessible both in glue and (where appropriate) in the browser-side accessibility.
Review URL: http://codereview.chromium.org/46013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Fix new tab focus
- attach f5 for refresh
Review URL: http://codereview.chromium.org/42422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and CFURL loves to be NULL when it can't parse something. Fixes a crash loading a horrific looking URL on espn.com
Review URL: http://codereview.chromium.org/50064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/50065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Update some layout tests and roll deps.
Review URL: http://codereview.chromium.org/42454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Expectations changed upstream and we need to match.
Review URL: http://codereview.chromium.org/50062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Delay the handling of certain accelerators so we don't try to destroy a widget that GTK is reffing as a result of event handling.
Patch based on another by Dean McNamee.
Review URL: http://codereview.chromium.org/42421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Adding test start/end timestamps to new test log.
Review URL: http://codereview.chromium.org/42420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bundle (catches frameworks and app and anything else added in the future).
Review URL: http://codereview.chromium.org/50053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add --gtest_print_time option to valgrind_test.py and use it always in chrome_test.py, since we probably want to keep an eye out for tests that are too slow for valgrind.
Review URL: http://codereview.chromium.org/50055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12193 0039d316-1c4b-4281-b951-d872f2087c98
|